95113 2012-08-27 12:07:13 -0700 [BlackBerry] Removing unnecessary include of Class BlackBerryPlatformClient 2012-08-28 07:41:15 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 parpatel webkit-unassigned haraken mifenton tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 705491 0 parpatel 2012-08-27 12:07:13 -0700 Refactoring has lead to relocation of many or all methods from Class BlackBerryPlatformClient to other classes.Some files include BlackBerryPlatformClient but does not use its instance thus these includes has to be removed. 705504 1 160772 parpatel 2012-08-27 12:18:03 -0700 Created attachment 160772 Patch 705558 2 160772 eric 2012-08-27 13:10:24 -0700 Comment on attachment 160772 Patch rs=me. 705567 3 160772 webkit.review.bot 2012-08-27 13:13:21 -0700 Comment on attachment 160772 Patch Rejecting attachment 160772 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: cceeded at 1 with fuzz 3. patching file Source/WebCore/platform/network/blackberry/NetworkManager.cpp patching file Source/WebKit/blackberry/Api/BackingStore.cpp patching file Source/WebKit/blackberry/Api/WebPage.cpp Hunk #1 FAILED at 155. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebKit/blackberry/Api/WebPage.cpp.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Eric Seidel']" exit_code: 1 cwd: /mnt/git/webkit-commit-queue/ Full output: http://queues.webkit.org/results/13612374 706280 4 160960 parpatel 2012-08-28 06:27:13 -0700 Created attachment 160960 Patch 706290 5 160960 parpatel 2012-08-28 06:44:15 -0700 Comment on attachment 160960 Patch set flag to commit-queue? after review+ 706291 6 160960 haraken 2012-08-28 06:44:41 -0700 Comment on attachment 160960 Patch ok 706329 7 160960 webkit.review.bot 2012-08-28 07:41:12 -0700 Comment on attachment 160960 Patch Clearing flags on attachment: 160960 Committed r126875: <http://trac.webkit.org/changeset/126875> 706330 8 webkit.review.bot 2012-08-28 07:41:15 -0700 All reviewed patches have been landed. Closing bug. 160772 2012-08-27 12:18:03 -0700 2012-08-28 06:27:09 -0700 Patch bug-95113-20120827152202.patch text/plain 3658 parpatel U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGFhZWI3ODgyOTAxNjFh MTVmYzI3YTE5YTY5MTJmMjJlMTQ4OGM0ZC4uMjljNWFlMGUyY2FiMTczMjYxYzc2NDY3ZWY1Zjcx NGU0MDI5ZWZmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTI3ICBQYXJ0 aCBQYXRlbCAgPHBhcnBhdGVsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFJlbW92 aW5nIHVubmVjZXNzYXJ5IGluY2x1ZGUgb2YgQ2xhc3MgQmxhY2tCZXJyeVBsYXRmb3JtQ2xpZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTExMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAg UmVmYWN0b3JpbmcgaGFzIGxlYWQgdG8gcmVsb2NhdGlvbiBvZiBtYW55IG9yIGFsbCBtZXRob2Rz IGZyb20gQ2xhc3MgCisgICAgICAgIEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudCB0byBvdGhlciBj bGFzc2VzLiBTb21lIGZpbGVzIGluY2x1ZGUgCisgICAgICAgIEJsYWNrQmVycnlQbGF0Zm9ybUNs aWVudCBidXQgZG9lcyBub3QgdXNlIGl0cyBpbnN0YW5jZSB0aHVzIHRoZXNlIAorICAgICAgICBp bmNsdWRlcyBoYXMgdG8gYmUgcmVtb3ZlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgYXMgdGhl cmUgYXJlIG5vIGxvZ2ljYWwgbW9kaWZpY2F0aW9ucyBkb25lLgorCisgICAgICAgICogcGxhdGZv cm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2VyLmNwcDoKKwogMjAxMi0wOC0yNCAg UGFydGggUGF0ZWwgIDxwYXJwYXRlbEByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBD aGFuZ2VzIHJlc3VsdGluZyBmcm9tIG1vdmluZyBuZXR3b3JrIHJlbGF0ZWQgbWV0aG9kcwpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggNDk4MjYyNDA5YTc2NjdlOTAyY2I4NzFlNDdm NGFjODdiMWY2YjZiYi4uNmExZTRjNjllZjdkODI5NDY0ZjBlOTBmZGYzNjNlYmMxM2ZhYzBlMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMDgt MjcgIFBhcnRoIFBhdGVsICA8cGFycGF0ZWxAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJy eV0gUmVtb3ZpbmcgdW5uZWNlc3NhcnkgaW5jbHVkZSBvZiBDbGFzcyBCbGFja0JlcnJ5UGxhdGZv cm1DbGllbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk1MTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg UmVmYWN0b3JpbmcgaGFzIGxlYWQgdG8gcmVsb2NhdGlvbiBvZiBtYW55IG9yIGFsbCBtZXRob2Rz IGZyb20gQ2xhc3MgCisgICAgICAgIEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudCB0byBvdGhlciBj bGFzc2VzLiBTb21lIGZpbGVzIGluY2x1ZGUgCisgICAgICAgIEJsYWNrQmVycnlQbGF0Zm9ybUNs aWVudCBidXQgZG9lcyBub3QgdXNlIGl0cyBpbnN0YW5jZSB0aHVzIHRoZXNlIAorICAgICAgICBp bmNsdWRlcyBoYXMgdG8gYmUgcmVtb3ZlZC4KKworICAgICAgICAqIEFwaS9CYWNraW5nU3RvcmUu Y3BwOgorICAgICAgICAqIEFwaS9XZWJQYWdlLmNwcDoKKwogMjAxMi0wOC0yNCAgUGFydGggUGF0 ZWwgIDxwYXJwYXRlbEByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBDaGFuZ2VzIHJl c3VsdGluZyBmcm9tIG1vdmluZyBuZXR3b3JrIHJlbGF0ZWQgbWV0aG9kcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2Vy LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9OZXR3b3Jr TWFuYWdlci5jcHAKaW5kZXggMTE4YmQ3MTQ0M2Y5MDM2Mjc1ZGNmYjM3Nzk0MDY3NGE2NjY0MGFm OC4uZDY2NDUxNzRjNTlhY2M0ZTk2MDA1YTg0ZjY4YzYwOGZiMWExYTM3ZiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtNYW5hZ2Vy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0 d29ya01hbmFnZXIuY3BwCkBAIC0yOCw3ICsyOCw2IEBACiAjaW5jbHVkZSAiUmVzb3VyY2VIYW5k bGVJbnRlcm5hbC5oIgogI2luY2x1ZGUgIlJlc291cmNlUmVxdWVzdC5oIgogCi0jaW5jbHVkZSA8 QmxhY2tCZXJyeVBsYXRmb3JtQ2xpZW50Lmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3Jt TG9nLmg+CiAjaW5jbHVkZSA8QnVpbGRJbmZvcm1hdGlvbi5oPgogI2luY2x1ZGUgPG5ldHdvcmsv RmlsdGVyU3RyZWFtLmg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBp L0JhY2tpbmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdT dG9yZS5jcHAKaW5kZXggZDNjMmNlOTNhNjI1YjZkY2MxZmIxMzE0NTk4ZGU4ODAxMDY0MWZjYS4u MTg1ZWQ1MWJiYzJiNGU1MmJmN2RjZjJiYzllNzYyMjM5NzVhZDNiYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcApAQCAtMzcsNyArMzcsNiBAQAog I2luY2x1ZGUgIldlYlBhZ2VfcC5oIgogI2luY2x1ZGUgIldlYlNldHRpbmdzLmgiCiAKLSNpbmNs dWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1DbGllbnQuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxh dGZvcm1FeGVjdXRhYmxlTWVzc2FnZS5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUdy YXBoaWNzLmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtSW50UmVjdFJlZ2lvbi5oPgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggYTJiZGJjNzBjZTE5 ODQ4Y2ZiZjNkYmI2YThiNDQxMmQ1N2NjMDUxNC4uMTQxNWFjYjEzY2NkOGNiZmUyN2QwMTYyNzAz MDg1OTlkOWRlZWNmMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3Bw CkBAIC0xNTUsNyArMTU1LDYgQEAKICNpbmNsdWRlICJXZWJQYWdlQ29tcG9zaXRvcl9wLmgiCiAj ZW5kaWYKIAotI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudC5oPgogI2luY2x1ZGUg PEJsYWNrQmVycnlQbGF0Zm9ybURldmljZUluZm8uaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxh dGZvcm1FeGVjdXRhYmxlTWVzc2FnZS5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUlU UG9saWN5Lmg+Cg== 160960 2012-08-28 06:27:13 -0700 2012-08-28 07:41:12 -0700 Patch bug-95113-20120828093114.patch text/plain 3079 parpatel U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Nzg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDMzNDJmZDA4MzVkZTY3 MzU3MmNiNWU5Y2I1NDdhZWFkMjEzNzJmYS4uNThmY2FkODY0MmYyYzQyYTAzODk5M2MzZjI0ZjVl MzY0MTk3NzFmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTI3ICBQYXJ0 aCBQYXRlbCAgPHBhcnBhdGVsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFJlbW92 aW5nIHVubmVjZXNzYXJ5IGluY2x1ZGUgb2YgQ2xhc3MgQmxhY2tCZXJyeVBsYXRmb3JtQ2xpZW50 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTExMwor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9y aW5nIGhhcyBsZWFkIHRvIHJlbG9jYXRpb24gb2YgbWFueSBvciBhbGwgbWV0aG9kcyBmcm9tIENs YXNzCisgICAgICAgIEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudCB0byBvdGhlciBjbGFzc2VzLiBT b21lIGZpbGVzIGluY2x1ZGUKKyAgICAgICAgQmxhY2tCZXJyeVBsYXRmb3JtQ2xpZW50IGJ1dCBk b2VzIG5vdCB1c2UgaXRzIGluc3RhbmNlIHRodXMgdGhlc2UKKyAgICAgICAgaW5jbHVkZXMgaGFz IHRvIGJlIHJlbW92ZWQuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoZXJlIGFyZSBubyBs b2dpY2FsIG1vZGlmaWNhdGlvbnMgZG9uZS4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsv YmxhY2tiZXJyeS9OZXR3b3JrTWFuYWdlci5jcHA6CisKIDIwMTItMDgtMjcgIEtldmluIEZ1bmsg IDxrZXZpbi5mdW5rQGtkYWIuY29tPgogCiAgICAgICAgIEZpeCBjb21waWxhdGlvbiB3aGVuIGJv dGggT1MoV0lOQ0UpIGFuZCBQTEFURk9STShRVCkgYXJlIHRydWUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv Q2hhbmdlTG9nCmluZGV4IDU2ZDllZDU0OTNkYmNjNmMwNzAzZjAzNjAwZmZlZThlM2UwYmNlZjMu LmM5OWFkNjVmNDQzZjIxYmQxYTU2NTc1YzMzM2VkNmUzYzAwYjRmOTggMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTI3ICBQYXJ0aCBQYXRl bCAgPHBhcnBhdGVsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFJlbW92aW5nIHVu bmVjZXNzYXJ5IGluY2x1ZGUgb2YgQ2xhc3MgQmxhY2tCZXJyeVBsYXRmb3JtQ2xpZW50CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTExMworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9yaW5nIGhh cyBsZWFkIHRvIHJlbG9jYXRpb24gb2YgbWFueSBvciBhbGwgbWV0aG9kcyBmcm9tIENsYXNzCisg ICAgICAgIEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudCB0byBvdGhlciBjbGFzc2VzLiBTb21lIGZp bGVzIGluY2x1ZGUKKyAgICAgICAgQmxhY2tCZXJyeVBsYXRmb3JtQ2xpZW50IGJ1dCBkb2VzIG5v dCB1c2UgaXRzIGluc3RhbmNlIHRodXMgdGhlc2UKKyAgICAgICAgaW5jbHVkZXMgaGFzIHRvIGJl IHJlbW92ZWQuCisKKyAgICAgICAgKiBBcGkvQmFja2luZ1N0b3JlLmNwcDoKKwogMjAxMi0wOC0y NyAgTGVvIFlhbmcgIDxsZW95YW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIE5v dCB1c2luZyBhYnNvbHV0ZVZpc2libGVPdmVyU2l6ZSB3aGVuIHJvdGF0aW5nCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFn ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdv cmtNYW5hZ2VyLmNwcAppbmRleCAxMThiZDcxNDQzZjkwMzYyNzVkY2ZiMzc3OTQwNjc0YTY2NjQw YWY4Li5kNjY0NTE3NGM1OWFjYzRlOTYwMDVhODRmNjhjNjA4ZmIxYTFhMzdmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNrYmVycnkvTmV0d29ya01hbmFn ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvYmxhY2tiZXJyeS9O ZXR3b3JrTWFuYWdlci5jcHAKQEAgLTI4LDcgKzI4LDYgQEAKICNpbmNsdWRlICJSZXNvdXJjZUhh bmRsZUludGVybmFsLmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VSZXF1ZXN0LmgiCiAKLSNpbmNsdWRl IDxCbGFja0JlcnJ5UGxhdGZvcm1DbGllbnQuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZv cm1Mb2cuaD4KICNpbmNsdWRlIDxCdWlsZEluZm9ybWF0aW9uLmg+CiAjaW5jbHVkZSA8bmV0d29y ay9GaWx0ZXJTdHJlYW0uaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9B cGkvQmFja2luZ1N0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2lu Z1N0b3JlLmNwcAppbmRleCBkM2MyY2U5M2E2MjViNmRjYzFmYjEzMTQ1OThkZTg4MDEwNjQxZmNh Li4xODVlZDUxYmJjMmI0ZTUyYmY3ZGNmMmJjOWU3NjIyMzk3NWFkM2JiIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L0FwaS9CYWNraW5nU3RvcmUuY3BwCkBAIC0zNyw3ICszNyw2IEBA CiAjaW5jbHVkZSAiV2ViUGFnZV9wLmgiCiAjaW5jbHVkZSAiV2ViU2V0dGluZ3MuaCIKIAotI2lu Y2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudC5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQ bGF0Zm9ybUV4ZWN1dGFibGVNZXNzYWdlLmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3Jt R3JhcGhpY3MuaD4KICNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1JbnRSZWN0UmVnaW9uLmg+ Cg==