95110 2012-08-27 11:58:30 -0700 [Chromium] Fixing infinite recursion in Canvas2DLayerManager 2012-08-27 13:20:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 junov junov cc-bugs jamesr senorblanco webkit.review.bot oldest_to_newest 705477 0 junov 2012-08-27 11:58:30 -0700 [Chromium] Fixing infinite recursion in Canvas2DLayerManager 705485 1 160767 junov 2012-08-27 12:05:12 -0700 Created attachment 160767 Patch 705493 2 160767 senorblanco 2012-08-27 12:08:05 -0700 Comment on attachment 160767 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160767&action=review r=me > Source/WebCore/platform/graphics/chromium/Canvas2DLayerBridge.cpp:128 > m_bytesAllocated -= bytesFreed; Micronit: this could be in the if-clause too. > Source/WebKit/chromium/tests/Canvas2DLayerManagerTest.cpp:62 > m_bytesAllocated -= bytesFreed; As above. 705582 3 160767 webkit.review.bot 2012-08-27 13:20:30 -0700 Comment on attachment 160767 Patch Clearing flags on attachment: 160767 Committed r126787: <http://trac.webkit.org/changeset/126787> 705583 4 webkit.review.bot 2012-08-27 13:20:33 -0700 All reviewed patches have been landed. Closing bug. 160767 2012-08-27 12:05:12 -0700 2012-08-27 13:20:30 -0700 Patch bug-95110-20120827150504.patch text/plain 4225 junov SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjc4MSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTI3ICBKdXN0aW4g Tm92b3NhZCAgPGp1bm92QGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIEZpeGlu ZyBpbmZpbml0ZSByZWN1cnNpb24gaW4gQ2FudmFzMkRMYXllck1hbmFnZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MTEwCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgaW5maW5pdGUgcmVjdXJz aW9uIGJ5IG5vdCByZXBvcnRpbmcgYSBjaGFuZ2UgaW4gbWVtb3J5IGFsbG9jYXRpb24KKyAgICAg ICAgd2hlbiBDYW52YXMyRExheWVyQnJpZGdlOjpmcmVlTWVtb3J5SWZQb3NzaWJsZSBmYWlscyB0 byBmcmVlIG1lbW9yeS4KKyAgICAgICAgQWxzbyBtb2RpZmllZCBDYW52YXMyRExheWVyTWFuYWdl cjo6bGF5ZXJBbGxvY2F0ZWRTdG9yYWdlQ2hhbmdlZCB0bworICAgICAgICBvbmx5IGluaXRpYXRl IGEgbWVtb3J5IGV2aWN0aW9uIHBhc3MgaWYgbWVtb3J5IGNvbnN1bXB0aW9uIGhhcworICAgICAg ICBpbmNyZWFzZWQuCisKKyAgICAgICAgVGVzdDogd2Via2l0X3VuaXRfdGVzdHMgQ2FudmFzMkRM YXllck1hbmFnZXJUZXN0KgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v Q2FudmFzMkRMYXllckJyaWRnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDYW52YXMyRExheWVy QnJpZGdlOjpmcmVlTWVtb3J5SWZQb3NzaWJsZSk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvY2hyb21pdW0vQ2FudmFzMkRMYXllck1hbmFnZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q2FudmFzMkRMYXllck1hbmFnZXI6OmxheWVyQWxsb2NhdGVkU3RvcmFnZUNoYW5nZWQpOgorCiAy MDEyLTA4LTI3ICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUuY29tPgogCiAgICAg ICAgIE1lZGlhU3RyZWFtIEFQSTogRml4IHJldmlldyBjb21tZW50cyBmcm9tIHBhdGNoICM5MzEx OQpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ2FudmFz MkRMYXllckJyaWRnZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvY2hyb21pdW0vQ2FudmFzMkRMYXllckJyaWRnZS5jcHAJKHJldmlzaW9uIDEyNjc3 NikKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0NhbnZhczJE TGF5ZXJCcmlkZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjMsNyArMTIzLDggQEAgc2l6ZV90 IENhbnZhczJETGF5ZXJCcmlkZ2U6OmZyZWVNZW1vcnlJZgogewogICAgIEFTU0VSVChkZWZlcnJl ZENhbnZhcygpKTsKICAgICBzaXplX3QgYnl0ZXNGcmVlZCA9IGRlZmVycmVkQ2FudmFzKCktPmZy ZWVNZW1vcnlJZlBvc3NpYmxlKGJ5dGVzVG9GcmVlKTsKLSAgICBDYW52YXMyRExheWVyTWFuYWdl cjo6Z2V0KCkubGF5ZXJBbGxvY2F0ZWRTdG9yYWdlQ2hhbmdlZCh0aGlzLCAtKChpbnRwdHJfdCli eXRlc0ZyZWVkKSk7CisgICAgaWYgKGJ5dGVzRnJlZWQpCisgICAgICAgIENhbnZhczJETGF5ZXJN YW5hZ2VyOjpnZXQoKS5sYXllckFsbG9jYXRlZFN0b3JhZ2VDaGFuZ2VkKHRoaXMsIC0oKGludHB0 cl90KWJ5dGVzRnJlZWQpKTsKICAgICBtX2J5dGVzQWxsb2NhdGVkIC09IGJ5dGVzRnJlZWQ7CiAg ICAgcmV0dXJuIGJ5dGVzRnJlZWQ7CiB9CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9DYW52YXMyRExheWVyTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vQ2FudmFzMkRMYXllck1h bmFnZXIuY3BwCShyZXZpc2lvbiAxMjY3NzYpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9jaHJvbWl1bS9DYW52YXMyRExheWVyTWFuYWdlci5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTg4LDcgKzg4LDggQEAgdm9pZCBDYW52YXMyRExheWVyTWFuYWdlcjo6bGF5ZXJBbGxvY2F0 ZQogICAgICAgICBBU1NFUlQoKGludHB0cl90KW1fYnl0ZXNBbGxvY2F0ZWQgKyBkZWx0YUJ5dGVz ID49IDApOyAKICAgICAgICAgbV9ieXRlc0FsbG9jYXRlZCA9IChpbnRwdHJfdCltX2J5dGVzQWxs b2NhdGVkICsgZGVsdGFCeXRlczsKICAgICB9Ci0gICAgZnJlZU1lbW9yeUlmTmVjZXNzYXJ5KCk7 CisgICAgaWYgKGRlbHRhQnl0ZXMgPiAwKQorICAgICAgICBmcmVlTWVtb3J5SWZOZWNlc3Nhcnko KTsKIH0KIAogdm9pZCBDYW52YXMyRExheWVyTWFuYWdlcjo6bGF5ZXJUb0JlRGVzdHJveWVkKENh bnZhczJETGF5ZXJCcmlkZ2UqIGxheWVyKQpJbmRleDogU291cmNlL1dlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cJ KHJldmlzaW9uIDEyNjc4MSkKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMjcgIEp1c3RpbiBOb3Zvc2Fk ICA8anVub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtDaHJvbWl1bV0gRml4aW5nIGluZmlu aXRlIHJlY3Vyc2lvbiBpbiBDYW52YXMyRExheWVyTWFuYWdlcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUxMTAKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCcmVha2luZyByZWN1cnNpb24gY3ljbGUgYnkg bm90IHJlcG9ydGluZyBhIGNoYW5nZSBpbiBtZW1vcnkgYWxsb2NhdGlvbgorICAgICAgICB3aGVu IG5vIG1lbW9yeSBpcyBmcmVlZCBpbiBGYWtlQ2FudmFzMkRMYXllcjo6ZnJlZU1lbW9yeUlmUG9z c2libGUuCisKKyAgICAgICAgKiB0ZXN0cy9DYW52YXMyRExheWVyTWFuYWdlclRlc3QuY3BwOgor CiAyMDEyLTA4LTI3ICBKdXN0aW4gTm92b3NhZCAgPGp1bm92QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbQ2hyb21pdW1dIEltcGxlbWVudGluZyBhIGdsb2JhbCBsaW1pdCBvbiBtZW1vcnkgY29u c3VtZWQgYnkgZGVmZXJyZWQgMkQgY2FudmFzZXMKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21p dW0vdGVzdHMvQ2FudmFzMkRMYXllck1hbmFnZXJUZXN0LmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0NhbnZhczJETGF5ZXJNYW5hZ2VyVGVzdC5jcHAJKHJl dmlzaW9uIDEyNjc3NikKKysrIFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvQ2FudmFzMkRM YXllck1hbmFnZXJUZXN0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTcsNyArNTcsOCBAQCBwdWJs aWM6CiAgICAgICAgIG1fZnJlZU1lbW9yeUlmUG9zc2libGVDb3VudCsrOwogICAgICAgICBzaXpl X3QgYnl0ZXNGcmVlZCA9IHNpemUgPCBtX2ZyZWVhYmxlQnl0ZXMgPyBzaXplIDogbV9mcmVlYWJs ZUJ5dGVzOwogICAgICAgICBtX2ZyZWVhYmxlQnl0ZXMgLT0gYnl0ZXNGcmVlZDsKLSAgICAgICAg Q2FudmFzMkRMYXllck1hbmFnZXI6OmdldCgpLmxheWVyQWxsb2NhdGVkU3RvcmFnZUNoYW5nZWQo dGhpcywgLSgoaW50cHRyX3QpYnl0ZXNGcmVlZCkpOworICAgICAgICBpZiAoYnl0ZXNGcmVlZCkK KyAgICAgICAgICAgIENhbnZhczJETGF5ZXJNYW5hZ2VyOjpnZXQoKS5sYXllckFsbG9jYXRlZFN0 b3JhZ2VDaGFuZ2VkKHRoaXMsIC0oKGludHB0cl90KWJ5dGVzRnJlZWQpKTsKICAgICAgICAgbV9i eXRlc0FsbG9jYXRlZCAtPSBieXRlc0ZyZWVkOwogICAgICAgICByZXR1cm4gYnl0ZXNGcmVlZDsK ICAgICB9Cg==