<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>95103</bug_id>
          
          <creation_ts>2012-08-27 10:56:15 -0700</creation_ts>
          <short_desc>GCC warning in JSActivation is causing Mac EWS errors</short_desc>
          <delta_ts>2012-08-28 11:41:34 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Mac</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jon Lee">jonlee</reporter>
          <assigned_to name="Geoffrey Garen">ggaren</assigned_to>
          <cc>mhahnenberg</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>705396</commentid>
    <comment_count>0</comment_count>
    <who name="Jon Lee">jonlee</who>
    <bug_when>2012-08-27 10:56:15 -0700</bug_when>
    <thetext>None of the patches going through Mac EWS are succeeding because of a warning that GCC is treating as an error:

CompileC /Volumes/Data/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/JSActivation.o runtime/JSActivation.cpp normal x86_64 c++ com.apple.compilers.gcc.4_2
    cd /Volumes/Data/WebKit/Source/JavaScriptCore
    setenv LANG en_US.US-ASCII
    /Developer/usr/bin/gcc-4.2 -x c++ -arch x86_64 -fmessage-length=0 -pipe -Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -O3 -Werror -Wmissing-prototypes -Wnon-virtual-dtor -Wsign-compare -Wnewline-eof -DNDEBUG -DHAVE_DTRACE=1 -DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -DHAVE_HEADER_DETECTION_H -fasm-blocks -fstrict-aliasing -mmacosx-version-min=10.7 -gdwarf-2 -fvisibility=hidden -fvisibility-inlines-hidden -fno-threadsafe-statics -I/Volumes/Data/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/JavaScriptCore.hmap -I/Volumes/Data/WebKit/WebKitBuild/Release/include -I/Volumes/Data/WebKit/WebKitBuild/Release/DerivedSources/JavaScriptCore -I. -Iicu -I/Volumes/Data/WebKit/WebKitBuild/Release/usr/local/include -I/Volumes/Data/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/DerivedSources/x86_64 -I/Volumes/Data/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/DerivedSources -Wall -Wextra -Wcast-qual -Wchar-subscripts -Wextra-tokens -Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked -Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -F/Volumes/Data/WebKit/WebKitBuild/Release -include /Volumes/Data/WebKit/WebKitBuild/PrecompiledHeaders/JavaScriptCorePrefix-gvhpdgusmukbdobchmcjrzzcdyvs/JavaScriptCorePrefix.h -c /Volumes/Data/WebKit/Source/JavaScriptCore/runtime/JSActivation.cpp -o /Volumes/Data/WebKit/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/x86_64/JSActivation.o
cc1plus: warnings being treated as errors
/Volumes/Data/WebKit/Source/JavaScriptCore/runtime/JSActivation.cpp: In static member function &apos;static void JSC::JSActivation::visitChildren(JSC::JSCell*, JSC::SlotVisitor&amp;)&apos;:
/Volumes/Data/WebKit/Source/JavaScriptCore/runtime/JSActivation.cpp:74: warning: dereferencing type-punned pointer will break strict-aliasing rules

Mark speculated blame goes to Geoff, so starting there.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>705397</commentid>
    <comment_count>1</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2012-08-27 10:56:27 -0700</bug_when>
    <thetext>&lt;rdar://problem/12180632&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706580</commentid>
    <comment_count>2</comment_count>
    <who name="Geoffrey Garen">ggaren</who>
    <bug_when>2012-08-28 11:41:34 -0700</bug_when>
    <thetext>Committed r126906: &lt;http://trac.webkit.org/changeset/126906&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>