95095 2012-08-27 09:36:40 -0700 Simplify cloning of inline style (below Node.cloneNode) 2012-08-28 06:15:41 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling cmarcelo koivisto macpherson menard webkit.review.bot oldest_to_newest 705325 0 kling 2012-08-27 09:36:40 -0700 We should just use StylePropertySet::copy() instead of cloning everything manually in ElementAttributeData::cloneDataFrom(). 705326 1 160733 kling 2012-08-27 09:37:07 -0700 Created attachment 160733 Patch 705408 2 kling 2012-08-27 11:04:49 -0700 CC'ing Antti who is a pretty cool guy. 705569 3 160733 eric 2012-08-27 13:14:10 -0700 Comment on attachment 160733 Patch Looks reasonable. 706274 4 160733 webkit.review.bot 2012-08-28 06:15:38 -0700 Comment on attachment 160733 Patch Clearing flags on attachment: 160733 Committed r126872: <http://trac.webkit.org/changeset/126872> 706275 5 webkit.review.bot 2012-08-28 06:15:41 -0700 All reviewed patches have been landed. Closing bug. 160733 2012-08-27 09:37:07 -0700 2012-08-28 06:15:37 -0700 Patch bug-95095.diff text/plain 4650 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNjNkYmNmLi5iNzg0ZjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTItMDgtMjcgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCisgICAg ICAgIFNpbXBsaWZ5IGNsb25pbmcgb2YgaW5saW5lIHN0eWxlIChiZWxvdyBOb2RlLmNsb25lTm9k ZSkKKyAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvOTUwOTU+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSnVzdCB1c2UgU3R5bGVQcm9wZXJ0eVNl dDo6Y29weSgpIGluc3RlYWQgb2YgY29weWluZyB0aGUgcHJvcGVydGllcyBhbmQgQ1NTIHBhcnNl ciBtb2RlIG1hbnVhbGx5CisgICAgICAgIHdoZW4gY2xvbmluZyBhbiBlbGVtZW50IHRoYXQgaGFz IGlubGluZSBzdHlsZS4KKworICAgICAgICAqIGNzcy9TdHlsZVByb3BlcnR5U2V0LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlN0eWxlUHJvcGVydHlTZXQ6OlN0eWxlUHJvcGVydHlTZXQpOgorICAg ICAgICAqIGNzcy9TdHlsZVByb3BlcnR5U2V0Lmg6CisgICAgICAgIChTdHlsZVByb3BlcnR5U2V0 KToKKyAgICAgICAgKiBkb20vRWxlbWVudEF0dHJpYnV0ZURhdGEuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6RWxlbWVudEF0dHJpYnV0ZURhdGE6OmNsb25lRGF0YUZyb20pOgorCisyMDEyLTA4LTI3 ICBBbmRyZWFzIEtsaW5nICA8a2xpbmdAd2Via2l0Lm9yZz4KKwogICAgICAgICBSRUdSRVNTSU9O KHIxMjY1MjQpOiBIZWFwLWJ1ZmZlci1vdmVyZmxvdyBpbiBXZWJDb3JlOjpTdHlsZVByb3BlcnR5 U2V0Ojpjb3B5UHJvcGVydGllc0Zyb20KICAgICAgICAgPGh0dHA6Ly93ZWJraXQub3JnL2IvOTUw MDU+CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0LmNw cCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9TdHlsZVByb3BlcnR5U2V0LmNwcAppbmRleCAyNjljZWY2 Li4xOTY4OWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNl dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0eWxlUHJvcGVydHlTZXQuY3BwCkBAIC04 NywxNSArODcsMjIgQEAgU3R5bGVQcm9wZXJ0eVNldDo6U3R5bGVQcm9wZXJ0eVNldChjb25zdCBD U1NQcm9wZXJ0eSogcHJvcGVydGllcywgdW5zaWduZWQgY291bnQKICAgICB9CiB9CiAKLVN0eWxl UHJvcGVydHlTZXQ6OlN0eWxlUHJvcGVydHlTZXQoY29uc3QgU3R5bGVQcm9wZXJ0eVNldCYgbykK K1N0eWxlUHJvcGVydHlTZXQ6OlN0eWxlUHJvcGVydHlTZXQoY29uc3QgU3R5bGVQcm9wZXJ0eVNl dCYgb3RoZXIpCiAgICAgOiBSZWZDb3VudGVkPFN0eWxlUHJvcGVydHlTZXQ+KCkKLSAgICAsIG1f Y3NzUGFyc2VyTW9kZShvLm1fY3NzUGFyc2VyTW9kZSkKKyAgICAsIG1fY3NzUGFyc2VyTW9kZShv dGhlci5tX2Nzc1BhcnNlck1vZGUpCiAgICAgLCBtX293bnNDU1NPTVdyYXBwZXIoZmFsc2UpCiAg ICAgLCBtX2lzTXV0YWJsZSh0cnVlKQogICAgICwgbV9hcnJheVNpemUoMCkKICAgICAsIG1fbXV0 YWJsZVByb3BlcnR5VmVjdG9yKG5ldyBWZWN0b3I8Q1NTUHJvcGVydHk+KQogewotICAgIGNvcHlQ cm9wZXJ0aWVzRnJvbShvKTsKKyAgICBpZiAob3RoZXIuaXNNdXRhYmxlKCkpCisgICAgICAgICpt X211dGFibGVQcm9wZXJ0eVZlY3RvciA9ICpvdGhlci5tX211dGFibGVQcm9wZXJ0eVZlY3RvcjsK KyAgICBlbHNlIHsKKyAgICAgICAgbV9tdXRhYmxlUHJvcGVydHlWZWN0b3ItPmNsZWFyKCk7Cisg ICAgICAgIG1fbXV0YWJsZVByb3BlcnR5VmVjdG9yLT5yZXNlcnZlQ2FwYWNpdHkob3RoZXIubV9h cnJheVNpemUpOworICAgICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgb3RoZXIubV9hcnJh eVNpemU7ICsraSkKKyAgICAgICAgICAgIG1fbXV0YWJsZVByb3BlcnR5VmVjdG9yLT51bmNoZWNr ZWRBcHBlbmQob3RoZXIuYXJyYXkoKVtpXSk7CisgICAgfQogfQogCiBTdHlsZVByb3BlcnR5U2V0 Ojp+U3R5bGVQcm9wZXJ0eVNldCgpCkBAIC0xMTEsMjcgKzExOCw2IEBAIFN0eWxlUHJvcGVydHlT ZXQ6On5TdHlsZVByb3BlcnR5U2V0KCkKICAgICB9CiB9CiAKLXZvaWQgU3R5bGVQcm9wZXJ0eVNl dDo6c2V0Q1NTUGFyc2VyTW9kZShDU1NQYXJzZXJNb2RlIGNzc1BhcnNlck1vZGUpCi17Ci0gICAg QVNTRVJUKGlzTXV0YWJsZSgpKTsKLSAgICBtX2Nzc1BhcnNlck1vZGUgPSBjc3NQYXJzZXJNb2Rl OwotfQotCi12b2lkIFN0eWxlUHJvcGVydHlTZXQ6OmNvcHlQcm9wZXJ0aWVzRnJvbShjb25zdCBT dHlsZVByb3BlcnR5U2V0JiBvdGhlcikKLXsKLSAgICBBU1NFUlQoaXNNdXRhYmxlKCkpOwotCi0g ICAgaWYgKG90aGVyLmlzTXV0YWJsZSgpKSB7Ci0gICAgICAgICptX211dGFibGVQcm9wZXJ0eVZl Y3RvciA9ICpvdGhlci5tX211dGFibGVQcm9wZXJ0eVZlY3RvcjsKLSAgICAgICAgcmV0dXJuOwot ICAgIH0KLQotICAgIG1fbXV0YWJsZVByb3BlcnR5VmVjdG9yLT5jbGVhcigpOwotICAgIG1fbXV0 YWJsZVByb3BlcnR5VmVjdG9yLT5yZXNlcnZlQ2FwYWNpdHkob3RoZXIubV9hcnJheVNpemUpOwot ICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBvdGhlci5tX2FycmF5U2l6ZTsgKytpKQotICAg ICAgICBtX211dGFibGVQcm9wZXJ0eVZlY3Rvci0+dW5jaGVja2VkQXBwZW5kKG90aGVyLmFycmF5 KClbaV0pOwotfQotCiBTdHJpbmcgU3R5bGVQcm9wZXJ0eVNldDo6Z2V0UHJvcGVydHlWYWx1ZShD U1NQcm9wZXJ0eUlEIHByb3BlcnR5SUQpIGNvbnN0CiB7CiAgICAgUmVmUHRyPENTU1ZhbHVlPiB2 YWx1ZSA9IGdldFByb3BlcnR5Q1NTVmFsdWUocHJvcGVydHlJRCk7CmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNldC5oIGIvU291cmNlL1dlYkNvcmUvY3NzL1N0 eWxlUHJvcGVydHlTZXQuaAppbmRleCAzMDdhM2VmLi42YWI3YjhkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9jc3MvU3R5bGVQcm9wZXJ0eVNldC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nz cy9TdHlsZVByb3BlcnR5U2V0LmgKQEAgLTg2LDE2ICs4NiwxMiBAQCBwdWJsaWM6CiAKICAgICB2 b2lkIG1lcmdlQW5kT3ZlcnJpZGVPbkNvbmZsaWN0KGNvbnN0IFN0eWxlUHJvcGVydHlTZXQqKTsK IAotICAgIHZvaWQgc2V0Q1NTUGFyc2VyTW9kZShDU1NQYXJzZXJNb2RlKTsKICAgICBDU1NQYXJz ZXJNb2RlIGNzc1BhcnNlck1vZGUoKSBjb25zdCB7IHJldHVybiBzdGF0aWNfY2FzdDxDU1NQYXJz ZXJNb2RlPihtX2Nzc1BhcnNlck1vZGUpOyB9CiAKICAgICB2b2lkIGFkZFN1YnJlc291cmNlU3R5 bGVVUkxzKExpc3RIYXNoU2V0PEtVUkw+JiwgU3R5bGVTaGVldENvbnRlbnRzKiBjb250ZXh0U3R5 bGVTaGVldCkgY29uc3Q7CiAKICAgICBQYXNzUmVmUHRyPFN0eWxlUHJvcGVydHlTZXQ+IGNvcHko KSBjb25zdDsKIAotICAgIC8vIFVzZWQgYnkgU3R5bGVkRWxlbWVudDo6Y29weU5vbkF0dHJpYnV0 ZVByb3BlcnRpZXMoKS4KLSAgICB2b2lkIGNvcHlQcm9wZXJ0aWVzRnJvbShjb25zdCBTdHlsZVBy b3BlcnR5U2V0Jik7Ci0KICAgICB2b2lkIHJlbW92ZUVxdWl2YWxlbnRQcm9wZXJ0aWVzKGNvbnN0 IFN0eWxlUHJvcGVydHlTZXQqKTsKICAgICB2b2lkIHJlbW92ZUVxdWl2YWxlbnRQcm9wZXJ0aWVz KGNvbnN0IENTU1N0eWxlRGVjbGFyYXRpb24qKTsKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvZG9tL0VsZW1lbnRBdHRyaWJ1dGVEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50QXR0cmlidXRlRGF0YS5jcHAKaW5kZXggNDcxZTUxOS4uZGI1MGNkZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnRBdHRyaWJ1dGVEYXRhLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudEF0dHJpYnV0ZURhdGEuY3BwCkBAIC0zNjMsOSArMzYzLDcgQEAg dm9pZCBFbGVtZW50QXR0cmlidXRlRGF0YTo6Y2xvbmVEYXRhRnJvbShjb25zdCBFbGVtZW50QXR0 cmlidXRlRGF0YSYgc291cmNlRGF0YSwKICAgICB9CiAKICAgICBpZiAodGFyZ2V0RWxlbWVudC5p c1N0eWxlZEVsZW1lbnQoKSAmJiBzb3VyY2VEYXRhLm1faW5saW5lU3R5bGVEZWNsKSB7Ci0gICAg ICAgIFN0eWxlUHJvcGVydHlTZXQqIGlubGluZVN0eWxlID0gZW5zdXJlTXV0YWJsZUlubGluZVN0 eWxlKHN0YXRpY19jYXN0PFN0eWxlZEVsZW1lbnQqPigmdGFyZ2V0RWxlbWVudCkpOwotICAgICAg ICBpbmxpbmVTdHlsZS0+Y29weVByb3BlcnRpZXNGcm9tKCpzb3VyY2VEYXRhLm1faW5saW5lU3R5 bGVEZWNsKTsKLSAgICAgICAgaW5saW5lU3R5bGUtPnNldENTU1BhcnNlck1vZGUoc291cmNlRGF0 YS5tX2lubGluZVN0eWxlRGVjbC0+Y3NzUGFyc2VyTW9kZSgpKTsKKyAgICAgICAgbV9pbmxpbmVT dHlsZURlY2wgPSBzb3VyY2VEYXRhLm1faW5saW5lU3R5bGVEZWNsLT5jb3B5KCk7CiAgICAgICAg IHRhcmdldEVsZW1lbnQuc2V0SXNTdHlsZUF0dHJpYnV0ZVZhbGlkKHNvdXJjZUVsZW1lbnQuaXNT dHlsZUF0dHJpYnV0ZVZhbGlkKCkpOwogICAgIH0KIH0K