95091 2012-08-27 08:40:30 -0700 Web Inspector: persist the state of glue records to parents button of Timeline panel 2012-08-28 00:01:35 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 705295 0 caseq 2012-08-27 08:40:30 -0700 Persist the state of glue records button of the timeline panel. 705314 1 160732 caseq 2012-08-27 09:00:45 -0700 Created attachment 160732 Patch 705482 2 160732 vsevik 2012-08-27 12:01:49 -0700 Comment on attachment 160732 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160732&action=review > Source/WebCore/inspector/front-end/TimelinePanel.js:545 > + this._presentationModel.setGlueRecords(newValue); I am not sure which one is correct, but previously you were setting !newValue to presentation model's glue records flag. 706128 3 caseq 2012-08-28 00:01:35 -0700 Committed r126851: <http://trac.webkit.org/changeset/126851> 160732 2012-08-27 09:00:45 -0700 2012-08-27 12:01:48 -0700 Patch bug-95091-20120827200036.patch text/plain 3845 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NzY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzNkOTA3ZmIyMjMwNzYx MjQ2NWVkYzhkYjM5ZWMwOGQ1OWU0YTlmYi4uNjZlOTQ5YWUwOGRlZWFlMWFiYWFlMTQ3NTdiOTM2 YWI3ZjhiYTEzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTI3ICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogcGVyc2lzdCB0aGUgc3RhdGUgb2YgZ2x1ZSByZWNvcmRzIHRvIHBhcmVudHMgYnV0dG9uIG9m IFRpbWVsaW5lIHBhbmVsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NTA5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZCBhIHNldHRpbmcgZm9yICJHbHVlIHJlY29yZHMiIGJ1dHRvbiBvbiB0aGUgdGlt ZWxpbmUsIHVzZSBpdCB0byBwZXJzaXN0IHRoZSBzdGF0ZSBvZiB0aGUgYnV0dG9uLgorCisgICAg ICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVsLmpzOgorICAgICAgICAoV2Vi SW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5l UGFuZWwucHJvdG90eXBlLl9jcmVhdGVTdGF0dXNCYXJJdGVtcy5nZXQgdGhpcyk6CisgICAgICAg IChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5cGUuX2NyZWF0ZVN0YXR1c0Jhckl0 ZW1zKToKKwogMjAxMi0wOC0yNSAgQW50b25pbyBHb21lcyAgPGFnb21lc0ByaW0uY29tPgogCiAg ICAgICAgIEZvciBjb252ZW5pZW5jZSwgbWFrZSBSZW5kZXJMYXllcjo6ZW5jbG9zaW5nRWxlbWVu dCBhIHB1YmxpYyBtZXRob2QuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggMjUxYzkyZjg0YTJjYWM2ZjkyNzMyZWFhNzA5 Zjk3NzAxNDQwYmZhZC4uMjFlY2NmMTUzNTQ1NzQ2NTU1N2YwODUzM2M5MWI4NzcxNjk4NjBiMyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBh bmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQ YW5lbC5qcwpAQCAtNDYsNiArNDYsOSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbCA9IGZ1 bmN0aW9uKCkKICAgICB0aGlzLl9tb2RlbCA9IG5ldyBXZWJJbnNwZWN0b3IuVGltZWxpbmVNb2Rl bCgpOwogICAgIHRoaXMuX3ByZXNlbnRhdGlvbk1vZGVsID0gbmV3IFdlYkluc3BlY3Rvci5UaW1l bGluZVByZXNlbnRhdGlvbk1vZGVsKCk7CiAKKyAgICB0aGlzLl9vdmVydmlld01vZGVTZXR0aW5n ID0gV2ViSW5zcGVjdG9yLnNldHRpbmdzLmNyZWF0ZVNldHRpbmcoInRpbWVsaW5lT3ZlcnZpZXdN b2RlIiwgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZpZXdQYW5lLk1vZGUuRXZlbnRzKTsKKyAg ICB0aGlzLl9nbHVlUmVjb3Jkc1NldHRpbmcgPSBXZWJJbnNwZWN0b3Iuc2V0dGluZ3MuY3JlYXRl U2V0dGluZygidGltZWxpbmVHbHVlUmVjb3JkcyIsIHRydWUpOworCiAgICAgdGhpcy5fb3ZlcnZp ZXdQYW5lID0gbmV3IFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZSh0aGlzLl9tb2Rl bCk7CiAgICAgdGhpcy5fb3ZlcnZpZXdQYW5lLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVjdG9y LlRpbWVsaW5lT3ZlcnZpZXdQYW5lLkV2ZW50cy5XaW5kb3dDaGFuZ2VkLCB0aGlzLl9zY2hlZHVs ZVJlZnJlc2guYmluZCh0aGlzLCBmYWxzZSkpOwogICAgIHRoaXMuX292ZXJ2aWV3UGFuZS5hZGRF dmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5UaW1lbGluZU92ZXJ2aWV3UGFuZS5FdmVudHMuTW9k ZUNoYW5nZWQsIHRoaXMuX292ZXJ2aWV3TW9kZUNoYW5nZWQsIHRoaXMpOwpAQCAtMTQ1LDggKzE0 OCw2IEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsID0gZnVuY3Rpb24oKQogICAgIHRoaXMu X3ByZXNlbnRhdGlvbk1vZGVsLmFkZEZpbHRlcih0aGlzLl9vdmVydmlld1BhbmUpOwogICAgIHRo aXMuX3ByZXNlbnRhdGlvbk1vZGVsLmFkZEZpbHRlcihuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5l Q2F0ZWdvcnlGaWx0ZXIoKSk7IAogICAgIHRoaXMuX3ByZXNlbnRhdGlvbk1vZGVsLmFkZEZpbHRl cihuZXcgV2ViSW5zcGVjdG9yLlRpbWVsaW5lSXNMb25nRmlsdGVyKHRoaXMpKTsgCi0KLSAgICB0 aGlzLl9vdmVydmlld01vZGVTZXR0aW5nID0gV2ViSW5zcGVjdG9yLnNldHRpbmdzLmNyZWF0ZVNl dHRpbmcoInRpbWVsaW5lT3ZlcnZpZXdNb2RlIiwgV2ViSW5zcGVjdG9yLlRpbWVsaW5lT3ZlcnZp ZXdQYW5lLk1vZGUuRXZlbnRzKTsKIH0KIAogLy8gRGVmaW5lIHJvdyBoZWlnaHQsIHNob3VsZCBi ZSBpbiBzeW5jIHdpdGggc3R5bGVzIGZvciB0aW1lbGluZSBncmFwaHMuCkBAIC0yMzUsOCArMjM2 LDggQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgICAgICB0 aGlzLl9zdGF0dXNCYXJCdXR0b25zLnB1c2godGhpcy5nYXJiYWdlQ29sbGVjdEJ1dHRvbik7CiAK ICAgICAgICAgdGhpcy5fZ2x1ZVBhcmVudEJ1dHRvbiA9IG5ldyBXZWJJbnNwZWN0b3IuU3RhdHVz QmFyQnV0dG9uKFdlYkluc3BlY3Rvci5VSVN0cmluZygiR2x1ZSBhc3luY2hyb25vdXMgZXZlbnRz IHRvIGNhdXNlcyIpLCAiZ2x1ZS1hc3luYy1zdGF0dXMtYmFyLWl0ZW0iKTsKLSAgICAgICAgdGhp cy5fZ2x1ZVBhcmVudEJ1dHRvbi50b2dnbGVkID0gdHJ1ZTsKLSAgICAgICAgdGhpcy5fcHJlc2Vu dGF0aW9uTW9kZWwuc2V0R2x1ZVJlY29yZHModHJ1ZSk7CisgICAgICAgIHRoaXMuX2dsdWVQYXJl bnRCdXR0b24udG9nZ2xlZCA9IHRoaXMuX2dsdWVSZWNvcmRzU2V0dGluZy5nZXQoKTsKKyAgICAg ICAgdGhpcy5fcHJlc2VudGF0aW9uTW9kZWwuc2V0R2x1ZVJlY29yZHModGhpcy5fZ2x1ZVBhcmVu dEJ1dHRvbi50b2dnbGVkKTsKICAgICAgICAgdGhpcy5fZ2x1ZVBhcmVudEJ1dHRvbi5hZGRFdmVu dExpc3RlbmVyKCJjbGljayIsIHRoaXMuX2dsdWVQYXJlbnRCdXR0b25DbGlja2VkLCB0aGlzKTsK ICAgICAgICAgdGhpcy5fc3RhdHVzQmFyQnV0dG9ucy5wdXNoKHRoaXMuX2dsdWVQYXJlbnRCdXR0 b24pOwogCkBAIC01MzksOCArNTQwLDEwIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnBy b3RvdHlwZSA9IHsKIAogICAgIF9nbHVlUGFyZW50QnV0dG9uQ2xpY2tlZDogZnVuY3Rpb24oKQog ICAgIHsKLSAgICAgICAgdGhpcy5fZ2x1ZVBhcmVudEJ1dHRvbi50b2dnbGVkID0gIXRoaXMuX2ds dWVQYXJlbnRCdXR0b24udG9nZ2xlZDsKLSAgICAgICAgdGhpcy5fcHJlc2VudGF0aW9uTW9kZWwu c2V0R2x1ZVJlY29yZHModGhpcy5fZ2x1ZVBhcmVudEJ1dHRvbi50b2dnbGVkKTsKKyAgICAgICAg dmFyIG5ld1ZhbHVlID0gIXRoaXMuX2dsdWVQYXJlbnRCdXR0b24udG9nZ2xlZDsKKyAgICAgICAg dGhpcy5fZ2x1ZVBhcmVudEJ1dHRvbi50b2dnbGVkID0gbmV3VmFsdWU7CisgICAgICAgIHRoaXMu X3ByZXNlbnRhdGlvbk1vZGVsLnNldEdsdWVSZWNvcmRzKG5ld1ZhbHVlKTsKKyAgICAgICAgdGhp cy5fZ2x1ZVJlY29yZHNTZXR0aW5nLnNldChuZXdWYWx1ZSk7CiAgICAgICAgIHRoaXMuX3JlcG9w dWxhdGVSZWNvcmRzKCk7CiAgICAgfSwKIAo=