95086 2012-08-27 07:26:03 -0700 [EFL][WK2] Free Url_Bar on program exit 2012-08-27 13:31:41 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis lucas.de.marchi ryuan.choi webkit.review.bot oldest_to_newest 705254 0 naginenis 2012-08-27 07:26:03 -0700 Url_Bar is leaky here. We must free it on program exit. =1801== 24 bytes in 1 blocks are definitely lost in loss record 240 of 1,375 ==1801== at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==1801== by 0x4020E6: url_bar_add (url_bar.c:91) ==1801== by 0x402CAD: browserCreate (main.c:246) ==1801== by 0x402DD2: main (main.c:286) 705260 1 160715 naginenis 2012-08-27 07:40:46 -0700 Created attachment 160715 Patch 705572 2 160715 eric 2012-08-27 13:16:59 -0700 Comment on attachment 160715 Patch I guess in c you don't have destructors Seems Browser should have a destroy() function that does this for you though... None of this code matters... in fact, you're just slowing down exit. BUt I can imagine it might be useful to clean this up for leak detection. rs=me. 705604 3 160715 webkit.review.bot 2012-08-27 13:31:37 -0700 Comment on attachment 160715 Patch Clearing flags on attachment: 160715 Committed r126788: <http://trac.webkit.org/changeset/126788> 705605 4 webkit.review.bot 2012-08-27 13:31:41 -0700 All reviewed patches have been landed. Closing bug. 160715 2012-08-27 07:40:46 -0700 2012-08-27 13:31:37 -0700 Patch 95086.patch text/plain 1008 naginenis ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MWE3 OTkxLi4xZTgxNWI5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMjcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAg PHN1ZGFyc2FuYS5uYWdpbmVuaUBsaW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF1bV0sy XSBGcmVlIFVybF9CYXIgb24gcHJvZ3JhbSBleGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTA4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIG1lbW9yeSBsZWFrIGJ5IGZyZWVpbmcgdGhlIFVy bF9CYXIgb24gcHJvZ3JhbSBleGl0LgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4u YzoKKyAgICAgICAgKG1haW4pOiBDYWxsIHVybF9iYXJfZGVsKCkgdG8gZnJlZSB0aGUgVXJsX0Jh ci4KKwogMjAxMi0wOC0yNCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4K IAogICAgICAgICBVbmlmeSBOdW1iZXIgdG8gU3RyaW5nSW1wbCBjb252ZXJzaW9uCmRpZmYgLS1n aXQgYS9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZs L21haW4uYwppbmRleCAxY2JmNzg0Li5iMDZkZDk4IDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJv d3Nlci9lZmwvbWFpbi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKQEAgLTI5 MSw2ICsyOTEsNyBAQCBpbnQgbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogCiAgICAgZWNv cmVfbWFpbl9sb29wX2JlZ2luKCk7CiAKKyAgICB1cmxfYmFyX2RlbChicm93c2VyLT51cmxfYmFy KTsKICAgICBlY29yZV9ldmVudF9oYW5kbGVyX2RlbChoYW5kbGUpOwogICAgIGVjb3JlX2V2YXNf ZnJlZShicm93c2VyLT5lZSk7CiAgICAgZnJlZShicm93c2VyKTsK