95065 2012-08-27 02:47:39 -0700 Web Inspector: DOM tree search issue with quotation marks 2012-08-27 04:56:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 705114 0 apavlov 2012-08-27 02:47:39 -0700 What steps will reproduce the problem? 1. Go to URL. 2. Right-click play button, "Inspect Element". Note this line is highlighted: <a href="#play" class="play" onclick="return false;" rel="nofollow">Play</a> 3. Press Ctrl-F 4. Type "play" (with quotation marks) What is the expected result? 5. See "play" being found and highlighted. What happens instead? 5. "play" is not found. 6. play (without quotation marks) is found in the exact same, it's currently hits 16 and 17 (although play is in that line 3 times). Upstreaming http://code.google.com/p/chromium/issues/detail?id=143911 705137 1 160688 apavlov 2012-08-27 03:36:22 -0700 Created attachment 160688 Patch 705159 2 160688 pfeldman 2012-08-27 04:46:30 -0700 Comment on attachment 160688 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160688&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:861 > + if (!exactAttributeMatch && attribute->localName().find(attributeQuery) != notFound) { Why did this change? I wonder if we could support the 'class="foo' or 'width=100%' case here. 705164 3 apavlov 2012-08-27 04:53:51 -0700 (In reply to comment #2) > (From update of attachment 160688 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=160688&action=review > > > Source/WebCore/inspector/InspectorDOMAgent.cpp:861 > > + if (!exactAttributeMatch && attribute->localName().find(attributeQuery) != notFound) { > > Why did this change? I wonder if we could support the 'class="foo' or 'width=100%' case here. Fixed the inadvertent change. I'm not sure how we should handle the double quotes around the property values, and this might turn out to be a source of confusion for our users. Let's see what they ask for next. 705165 4 apavlov 2012-08-27 04:56:17 -0700 Committed r126749: <http://trac.webkit.org/changeset/126749> 160688 2012-08-27 03:36:22 -0700 2012-08-27 04:46:30 -0700 Patch bug-95065-20120827143614.patch text/plain 6441 apavlov U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NzM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjJmMTY2MDM3MDMzNDVl YjNjMzFlNWVhM2E1OGRlYmM2MDA2NjI3Mi4uMDZiMzYxM2JlYmZhOWY2YmMyZjUwZWI2MzE2Y2I0 MDMwODJiMjZlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTI3ICBBbGV4 YW5kZXIgUGF2bG92ICA8YXBhdmxvdkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3Bl Y3RvcjogRE9NIHRyZWUgc2VhcmNoIGlzc3VlIHdpdGggcXVvdGF0aW9uIG1hcmtzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTA2NQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludHJvZHVjZWQgdGhlIGV4 YWN0IG1hdGNoIG1vZGUgZm9yIGF0dHJpYnV0ZXMgKHF1ZXJ5IGVuY2xvc2VkIGluIGRvdWJsZSBx dW90ZXMpIHdoZXJlIG9ubHkgZW50aXJlIGF0dHJpYnV0ZSB2YWx1ZXMKKyAgICAgICAgYXJlIG1h dGNoZWQgYWdhaW5zdCB0aGUgc2VhcmNoIHF1ZXJ5ICh3aXRoIHRoZSBkb3VibGUgcXVvdGVzIHRy aW1tZWQpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50OjpwZXJmb3JtU2VhcmNoKToKKwogMjAx Mi0wOC0yNCAgQWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IEluY29ycmVjdCBwcm9wZXJ0eSBvdmVycmlkZSBjb21wdXRhdGlv biB3aGVuICFpbXBvcnRhbnQgaXMgaW52b2x2ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IDU5MjljNzI5ZmE5MWE1MTAzODkxZTgwYzQ3 NDQ1NjZkN2EzODhhMDIuLjdmZWUwZTg3ZWIxZjI4MmIwMGQwYWUwYTFjNzEwMWI2NDllYjQ0ZTMg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApA QCAtODA5LDEyICs4MDksMjAgQEAgdm9pZCBJbnNwZWN0b3JET01BZ2VudDo6cGVyZm9ybVNlYXJj aChFcnJvclN0cmluZyosIGNvbnN0IFN0cmluZyYgd2hpdGVzcGFjZVRyaW0KICAgICB1bnNpZ25l ZCBxdWVyeUxlbmd0aCA9IHdoaXRlc3BhY2VUcmltbWVkUXVlcnkubGVuZ3RoKCk7CiAgICAgYm9v bCBzdGFydFRhZ0ZvdW5kID0gIXdoaXRlc3BhY2VUcmltbWVkUXVlcnkuZmluZCgnPCcpOwogICAg IGJvb2wgZW5kVGFnRm91bmQgPSB3aGl0ZXNwYWNlVHJpbW1lZFF1ZXJ5LnJldmVyc2VGaW5kKCc+ JykgKyAxID09IHF1ZXJ5TGVuZ3RoOworICAgIGJvb2wgc3RhcnRRdW90ZUZvdW5kID0gIXdoaXRl c3BhY2VUcmltbWVkUXVlcnkuZmluZCgnIicpOworICAgIGJvb2wgZW5kUXVvdGVGb3VuZCA9IHdo aXRlc3BhY2VUcmltbWVkUXVlcnkucmV2ZXJzZUZpbmQoJyInKSArIDEgPT0gcXVlcnlMZW5ndGg7 CisgICAgYm9vbCBleGFjdEF0dHJpYnV0ZU1hdGNoID0gc3RhcnRRdW90ZUZvdW5kICYmIGVuZFF1 b3RlRm91bmQ7CiAKICAgICBTdHJpbmcgdGFnTmFtZVF1ZXJ5ID0gd2hpdGVzcGFjZVRyaW1tZWRR dWVyeTsKKyAgICBTdHJpbmcgYXR0cmlidXRlUXVlcnkgPSB3aGl0ZXNwYWNlVHJpbW1lZFF1ZXJ5 OwogICAgIGlmIChzdGFydFRhZ0ZvdW5kKQogICAgICAgICB0YWdOYW1lUXVlcnkgPSB0YWdOYW1l UXVlcnkucmlnaHQodGFnTmFtZVF1ZXJ5Lmxlbmd0aCgpIC0gMSk7CiAgICAgaWYgKGVuZFRhZ0Zv dW5kKQogICAgICAgICB0YWdOYW1lUXVlcnkgPSB0YWdOYW1lUXVlcnkubGVmdCh0YWdOYW1lUXVl cnkubGVuZ3RoKCkgLSAxKTsKKyAgICBpZiAoc3RhcnRRdW90ZUZvdW5kKQorICAgICAgICBhdHRy aWJ1dGVRdWVyeSA9IGF0dHJpYnV0ZVF1ZXJ5LnJpZ2h0KGF0dHJpYnV0ZVF1ZXJ5Lmxlbmd0aCgp IC0gMSk7CisgICAgaWYgKGVuZFF1b3RlRm91bmQpCisgICAgICAgIGF0dHJpYnV0ZVF1ZXJ5ID0g YXR0cmlidXRlUXVlcnkubGVmdChhdHRyaWJ1dGVRdWVyeS5sZW5ndGgoKSAtIDEpOwogCiAgICAg VmVjdG9yPERvY3VtZW50Kj4gZG9jcyA9IGRvY3VtZW50cygpOwogICAgIExpc3RIYXNoU2V0PE5v ZGUqPiByZXN1bHRDb2xsZWN0b3I7CkBAIC04NTAsMTMgKzg1OCwxNiBAQCB2b2lkIEluc3BlY3Rv ckRPTUFnZW50OjpwZXJmb3JtU2VhcmNoKEVycm9yU3RyaW5nKiwgY29uc3QgU3RyaW5nJiB3aGl0 ZXNwYWNlVHJpbQogICAgICAgICAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBudW1B dHRyczsgKytpKSB7CiAgICAgICAgICAgICAgICAgICAgIC8vIEFkZCBhdHRyaWJ1dGUgcGFpcgog ICAgICAgICAgICAgICAgICAgICBjb25zdCBBdHRyaWJ1dGUqIGF0dHJpYnV0ZSA9IGVsZW1lbnQt PmF0dHJpYnV0ZUl0ZW0oaSk7Ci0gICAgICAgICAgICAgICAgICAgIGlmIChhdHRyaWJ1dGUtPmxv Y2FsTmFtZSgpLmZpbmQod2hpdGVzcGFjZVRyaW1tZWRRdWVyeSkgIT0gbm90Rm91bmQpIHsKKyAg ICAgICAgICAgICAgICAgICAgaWYgKCFleGFjdEF0dHJpYnV0ZU1hdGNoICYmIGF0dHJpYnV0ZS0+ bG9jYWxOYW1lKCkuZmluZChhdHRyaWJ1dGVRdWVyeSkgIT0gbm90Rm91bmQpIHsKICAgICAgICAg ICAgICAgICAgICAgICAgIHJlc3VsdENvbGxlY3Rvci5hZGQobm9kZSk7CiAgICAgICAgICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgICAgICAgICAgfQotICAgICAgICAgICAgICAg ICAgICBpZiAoYXR0cmlidXRlLT52YWx1ZSgpLmZpbmQod2hpdGVzcGFjZVRyaW1tZWRRdWVyeSkg IT0gbm90Rm91bmQpIHsKLSAgICAgICAgICAgICAgICAgICAgICAgIHJlc3VsdENvbGxlY3Rvci5h ZGQobm9kZSk7Ci0gICAgICAgICAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgICAg ICAgICAgc2l6ZV90IGZvdW5kUG9zaXRpb24gPSBhdHRyaWJ1dGUtPnZhbHVlKCkuZmluZChhdHRy aWJ1dGVRdWVyeSk7CisgICAgICAgICAgICAgICAgICAgIGlmIChmb3VuZFBvc2l0aW9uICE9IG5v dEZvdW5kKSB7CisgICAgICAgICAgICAgICAgICAgICAgICBpZiAoIWV4YWN0QXR0cmlidXRlTWF0 Y2ggfHwgKCFmb3VuZFBvc2l0aW9uICYmIGF0dHJpYnV0ZS0+dmFsdWUoKS5sZW5ndGgoKSA9PSBh dHRyaWJ1dGVRdWVyeS5sZW5ndGgoKSkpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICBy ZXN1bHRDb2xsZWN0b3IuYWRkKG5vZGUpOworICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJy ZWFrOworICAgICAgICAgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgICAgICB9CiAg ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIGJyZWFrOwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGIyZGFhYjVk NjY4MDk1NGYwYTJjMzg5YjRjY2RmOThhYmQ0NGVmZTIuLjBiNTgzNDUyNGYyZDIyNDg1NmJhMzMz OWRkOTIwNTc5OWU1NzFkZjggMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysg Yi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0wOC0yNyAgQWxl eGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IERPTSB0cmVlIHNlYXJjaCBpc3N1ZSB3aXRoIHF1b3RhdGlvbiBtYXJrcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUwNjUKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGluc3BlY3Rvci9lbGVt ZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2gtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGluc3Bl Y3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2guaHRtbDoKKwogMjAxMi0wOC0yNCAg QWxleGFuZGVyIFBhdmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJ bnNwZWN0b3I6IEluY29ycmVjdCBwcm9wZXJ0eSBvdmVycmlkZSBjb21wdXRhdGlvbiB3aGVuICFp bXBvcnRhbnQgaXMgaW52b2x2ZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9l bGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2gtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC1leHBlY3RlZC50eHQKaW5k ZXggYmE2MGVkYmM5NjZiOGQ3MjVmZGJlODVhZjQxNTQ4OTc0YzIwZWU1NS4uZWY1YTNmMGU4OWRh NTRiMTQ5MmY5YTRiZGFkNDM3NThjZTFiNjFjOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5z cGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC1leHBlY3RlZC50eHQKKysrIGIv TGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC1leHBl Y3RlZC50eHQKQEAgLTI0LDYgKzI0LDkgQEAgUnVubmluZzogdGVzdEV4YWN0QXR0cmlidXRlTmFt ZQogUnVubmluZzogdGVzdEV4YWN0QXR0cmlidXRlVmFsX3VlCiA8IGkgbiBwIHUgdCAgIHYgYSBs IHUgZSA9ICIgSSBuIHAgdSB0IFYgYSBsICIgPgogCitSdW5uaW5nOiB0ZXN0RXhhY3RBdHRyaWJ1 dGVWYWxfdWVXaXRoUXVvdGVzCis8IGQgaSB2ICAgYSB0IHQgciA9ICIgZiBvIG8gIiA+IDwgLyBk IGkgdiA+CisKIFJ1bm5pbmc6IHRlc3RQYXJ0aWFsQXR0cmlidXRlVmFsX3VlCiA8IGkgbiBwIHUg dCAgIHYgYSBsIHUgZSA9ICIgSSBuIHAgdSB0IFYgYSBsICIgPgogCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9pbnNwZWN0b3IvZWxlbWVudHMvZWxlbWVudHMtcGFuZWwtc2VhcmNoLmh0bWwgYi9M YXlvdXRUZXN0cy9pbnNwZWN0b3IvZWxlbWVudHMvZWxlbWVudHMtcGFuZWwtc2VhcmNoLmh0bWwK aW5kZXggMmI3ZDQ1ZjEyODMzNzljZjFiNTgwNzFmOTM2YjU0YWZlNmJmNGEzOC4uODgwNzM3Nzc4 ZDc2ZTZmMWEzODU0OGI4NmYwM2MwNzY2ZDk3YmI2YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMv aW5zcGVjdG9yL2VsZW1lbnRzL2VsZW1lbnRzLXBhbmVsLXNlYXJjaC5odG1sCisrKyBiL0xheW91 dFRlc3RzL2luc3BlY3Rvci9lbGVtZW50cy9lbGVtZW50cy1wYW5lbC1zZWFyY2guaHRtbApAQCAt MzUsNyArMzUsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKIAogICAgICAgICBmdW5jdGlvbiB0ZXN0UGxh aW5UZXh0KG5leHQpCiAgICAgICAgIHsKLSAgICAgICAgICAgIFdlYkluc3BlY3Rvci5kb21BZ2Vu dC5wZXJmb3JtU2VhcmNoKCJGb28iICsgIkJhciIsIHNlYXJjaENhbGxiYWNrLmJpbmQodGhpcywg bmV4dCkpOworICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRvbUFnZW50LnBlcmZvcm1TZWFyY2go IkZvIiArICJvIiArICJCYXIiLCBzZWFyY2hDYWxsYmFjay5iaW5kKHRoaXMsIG5leHQpKTsKICAg ICAgICAgfSwKIAogICAgICAgICBmdW5jdGlvbiB0ZXN0UGFydGlhbFRleHQobmV4dCkKQEAgLTYz LDYgKzYzLDExIEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRv bUFnZW50LnBlcmZvcm1TZWFyY2goIkluIiArICJwdXRWYSIgKyAibCIsIHNlYXJjaENhbGxiYWNr LmJpbmQodGhpcywgbmV4dCkpOwogICAgICAgICB9LAogCisgICAgICAgIGZ1bmN0aW9uIHRlc3RF eGFjdEF0dHJpYnV0ZVZhbF91ZVdpdGhRdW90ZXMobmV4dCkKKyAgICAgICAgeworICAgICAgICAg ICAgV2ViSW5zcGVjdG9yLmRvbUFnZW50LnBlcmZvcm1TZWFyY2goIlwiZm8iICsgIm9cIiIsIHNl YXJjaENhbGxiYWNrLmJpbmQodGhpcywgbmV4dCkpOworICAgICAgICB9LAorCiAgICAgICAgIGZ1 bmN0aW9uIHRlc3RQYXJ0aWFsQXR0cmlidXRlVmFsX3VlKG5leHQpCiAgICAgICAgIHsKICAgICAg ICAgICAgIFdlYkluc3BlY3Rvci5kb21BZ2VudC5wZXJmb3JtU2VhcmNoKCJuIiArICJwdXRWYSIg KyAibCIsIHNlYXJjaENhbGxiYWNrLmJpbmQodGhpcywgbmV4dCkpOwpAQCAtOTMsNiArOTgsNyBA QCBUZXN0cyB0aGF0IGVsZW1lbnRzIHBhbmVsIHNlYXJjaCBpcyByZXR1cm5pbmcgcHJvcGVyIHJl c3VsdHMuCiA8ZGl2IGF0dHI9ImZvbyI+PC9kaXY+CiA8ZGl2IGlkPSJ0ZXJtaW5hdG9yIj48L2Rp dj4KIDxkaXYgY2xhc3M9ImRpdmNsYXNzIj48c3Bhbj5Gb3VuZCBieSBzZWxlY3Rvcjwvc3Bhbj48 L2Rpdj4KKzxzcGFuIGNsYXNzPSJmb28ga29vIj48L3NwYW4+CiAKIDwvYm9keT4KIDwvaHRtbD4K