95062 2012-08-27 02:15:09 -0700 [Gtk] Several tests launch g_object_ref/unref assertion messages 2012-10-02 10:00:08 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 apinheiro zan jdiggs mario mrobinson pnormand zan oldest_to_newest 705090 0 apinheiro 2012-08-27 02:15:09 -0700 Execute run-webkit-tests with the accessibility tests: Tools/Scripts/run-webkit-tests --gtk accessibility platform/gtk/accessibility If you take a look to the stderr of some of those tests you will find several assertion messages related to g_object_ref/unref. For example from accessibility/aria-hidden-updates-alldescendants.html: g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed g_object_ref: assertion `G_IS_OBJECT (object)' failed g_object_unref: assertion `G_IS_OBJECT (object)' failed Note: this started to happen after the changes made on bug 94200. Not sure if that means that this bug should be titled with a REGRESSION label. 705451 1 zan 2012-08-27 11:40:10 -0700 I've recommended using GRefPtr<AtkObject> as the type definition for the PlatformUIElement. That doesn't really work as it causes compilation errors (conversion of 0 from integer to AccessibilityUIElement becomes impossible and the refactoring to avoid this is IMO not really worth the trouble). To bypass this the m_element member should be checked that it is non-nul before refing/unrefing. 732731 2 166701 zan 2012-10-02 09:45:22 -0700 Created attachment 166701 Patch 732734 3 zan 2012-10-02 09:46:28 -0700 CC-ing a11y folks and reviewers. 732738 4 166701 mrobinson 2012-10-02 09:48:49 -0700 Comment on attachment 166701 Patch Thanks! 732757 5 166701 zan 2012-10-02 10:00:03 -0700 Comment on attachment 166701 Patch Clearing flags on attachment: 166701 Committed r130183: <http://trac.webkit.org/changeset/130183> 732758 6 zan 2012-10-02 10:00:08 -0700 All reviewed patches have been landed. Closing bug. 166701 2012-10-02 09:45:22 -0700 2012-10-02 10:00:03 -0700 Patch bug-95062-20121002094435.patch text/plain 1827 zan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzMDE3NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE3IEBACisyMDEyLTEwLTAyICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5j b20+CisKKyAgICAgICAgW0d0a10gU2V2ZXJhbCB0ZXN0cyBsYXVuY2ggZ19vYmplY3RfcmVmL3Vu cmVmIGFzc2VydGlvbiBtZXNzYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTUwNjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBPbmx5IGluY3JlYXNlIGFuZCBkZWNyZWFzZSByZWZlcmVuY2UgY291bnQg b2YgdGhlIGFjY2Vzc2liaWxpdHkKKyAgICAgICAgVUkgZWxlbWVudCBpZiBpdCBhY3R1YWxseSBl eGlzdHMuCisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9ndGsvQWNjZXNzaWJpbGl0eVVJRWxl bWVudEd0ay5jcHA6CisgICAgICAgIChBY2Nlc3NpYmlsaXR5VUlFbGVtZW50OjpBY2Nlc3NpYmls aXR5VUlFbGVtZW50KToKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6On5BY2Nlc3Np YmlsaXR5VUlFbGVtZW50KToKKwogMjAxMi0xMC0wMiAgUmFwaGFlbCBLdWJvIGRhIENvc3RhICA8 cmFwaGFlbC5rdWJvLmRhLmNvc3RhQGludGVsLmNvbT4KIAogICAgICAgICB3ZWJraXRweTogU3Rv cCBsaXN0ZW5pbmcgb24gcG9ydCA4MDgxIHdoZW4gdXNpbmcgQXBhY2hlLgpJbmRleDogVG9vbHMv RHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50R3Rr LmNwcAkocmV2aXNpb24gMTMwMTc3KQorKysgVG9vbHMvRHVtcFJlbmRlclRyZWUvZ3RrL0FjY2Vz c2liaWxpdHlVSUVsZW1lbnRHdGsuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NiwxOCArNTYsMjEg QEAgc3RhdGljIGlubGluZSBnY2hhciogcmVwbGFjZUNoYXJhY3RlcnNGbwogQWNjZXNzaWJpbGl0 eVVJRWxlbWVudDo6QWNjZXNzaWJpbGl0eVVJRWxlbWVudChQbGF0Zm9ybVVJRWxlbWVudCBlbGVt ZW50KQogICAgIDogbV9lbGVtZW50KGVsZW1lbnQpCiB7Ci0gICAgZ19vYmplY3RfcmVmKG1fZWxl bWVudCk7CisgICAgaWYgKG1fZWxlbWVudCkKKyAgICAgICAgZ19vYmplY3RfcmVmKG1fZWxlbWVu dCk7CiB9CiAKIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OkFjY2Vzc2liaWxpdHlVSUVsZW1lbnQo Y29uc3QgQWNjZXNzaWJpbGl0eVVJRWxlbWVudCYgb3RoZXIpCiAgICAgOiBtX2VsZW1lbnQob3Ro ZXIubV9lbGVtZW50KQogewotICAgIGdfb2JqZWN0X3JlZihtX2VsZW1lbnQpOworICAgIGlmICht X2VsZW1lbnQpCisgICAgICAgIGdfb2JqZWN0X3JlZihtX2VsZW1lbnQpOwogfQogCiBBY2Nlc3Np YmlsaXR5VUlFbGVtZW50Ojp+QWNjZXNzaWJpbGl0eVVJRWxlbWVudCgpCiB7Ci0gICAgZ19vYmpl Y3RfdW5yZWYobV9lbGVtZW50KTsKKyAgICBpZiAobV9lbGVtZW50KQorICAgICAgICBnX29iamVj dF91bnJlZihtX2VsZW1lbnQpOwogfQogCiB2b2lkIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6Omdl dExpbmtlZFVJRWxlbWVudHMoVmVjdG9yPEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ+JiBlbGVtZW50 cykK