95060 2012-08-27 02:13:12 -0700 Regression(r126721): bindings-tests results need to be updated 2012-08-27 02:45:17 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95021 1 cdumez cdumez abarth ggaren haraken japhet oliver webkit.review.bot oldest_to_newest 705088 0 cdumez 2012-08-27 02:13:12 -0700 After r126721 (Bug 95021), bindings-generation-tests started failing: FAIL: (JS) JSTestObj.cpp --- WebCore/bindings/scripts/test/JS/JSTestObj.cpp 2012-08-24 02:14:04.835189616 -0700 +++ /tmp/tmpRz6I1v/JSTestObj.cpp 2012-08-27 01:33:11.159781908 -0700 @@ -2593,10 +2593,8 @@ COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag); ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren()); Base::visitChildren(thisObject, visitor); - if (thisObject->m_cachedAttribute1) - visitor.append(&thisObject->m_cachedAttribute1); - if (thisObject->m_cachedAttribute2) - visitor.append(&thisObject->m_cachedAttribute2); + visitor.append(&thisObject->m_cachedAttribute1); + visitor.append(&thisObject->m_cachedAttribute2); } FAIL: (JS) JSTestSerializedScriptValueInterface.cpp --- WebCore/bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp 2012-07-27 10:21:26.271861874 -0700 +++ /tmp/tmpwwIxP6/JSTestSerializedScriptValueInterface.cpp 2012-08-27 01:33:11.579798199 -0700 @@ -356,10 +356,8 @@ COMPILE_ASSERT(StructureFlags & OverridesVisitChildren, OverridesVisitChildrenWithoutSettingFlag); ASSERT(thisObject->structure()->typeInfo().overridesVisitChildren()); Base::visitChildren(thisObject, visitor); - if (thisObject->m_cachedValue) - visitor.append(&thisObject->m_cachedValue); - if (thisObject->m_cachedReadonlyValue) - visitor.append(&thisObject->m_cachedReadonlyValue); + visitor.append(&thisObject->m_cachedValue); + visitor.append(&thisObject->m_cachedReadonlyValue); } The expected results need to be regenerated. 705092 1 160676 cdumez 2012-08-27 02:15:31 -0700 Created attachment 160676 Patch 705095 2 160676 haraken 2012-08-27 02:16:34 -0700 Comment on attachment 160676 Patch Thanks for the quick fix! 705112 3 160676 webkit.review.bot 2012-08-27 02:45:14 -0700 Comment on attachment 160676 Patch Clearing flags on attachment: 160676 Committed r126738: <http://trac.webkit.org/changeset/126738> 705113 4 webkit.review.bot 2012-08-27 02:45:17 -0700 All reviewed patches have been landed. Closing bug. 160676 2012-08-27 02:15:31 -0700 2012-08-27 02:45:14 -0700 Patch 95060_bindings_tests.patch text/plain 2950 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZTZkYTlhLi40NDI2ZDkwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDgtMjcgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBSZWdyZXNzaW9uKHIxMjY3MjEpOiBiaW5kaW5ncy10ZXN0cyByZXN1 bHRzIG5lZWQgdG8gYmUgdXBkYXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTUwNjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSZWdlbmVyYXRlIGJpbmRpbmdzLXRlc3RzIHJlc3VsdHMgYWZ0ZXIgcjEy NjcyMS4gVGhpcyBjaGFuZ2UKKyAgICAgICAgcmVtb3ZlZCB0aGUgTlVMTCBjaGVja3MgZnJvbSB2 aXNpdENoaWxkcmVuIGZ1bmN0aW9ucy4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVz dC9KUy9KU1Rlc3RPYmouY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNUZXN0T2JqOjp2aXNpdENo aWxkcmVuKToKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0U2VyaWFs aXplZFNjcmlwdFZhbHVlSW50ZXJmYWNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpTVGVzdFNl cmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZTo6dmlzaXRDaGlsZHJlbik6CisKIDIwMTItMDgt MjcgIFNpbW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAg IFtRdF0gUkVHUkVTU0lPTihyMTI2Njk0KTogSXQgYnJva2UgdGhlIGRlYnVnIGJ1aWxkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL3Rlc3QvSlMvSlNUZXN0T2Jq LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmou Y3BwCmluZGV4IDc5MjY2MWYuLmMxNzYxNDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9KU1Rlc3RPYmouY3BwCkBAIC0yNTkzLDEwICsyNTkz LDggQEAgdm9pZCBKU1Rlc3RPYmo6OnZpc2l0Q2hpbGRyZW4oSlNDZWxsKiBjZWxsLCBTbG90Vmlz aXRvciYgdmlzaXRvcikKICAgICBDT01QSUxFX0FTU0VSVChTdHJ1Y3R1cmVGbGFncyAmIE92ZXJy aWRlc1Zpc2l0Q2hpbGRyZW4sIE92ZXJyaWRlc1Zpc2l0Q2hpbGRyZW5XaXRob3V0U2V0dGluZ0Zs YWcpOwogICAgIEFTU0VSVCh0aGlzT2JqZWN0LT5zdHJ1Y3R1cmUoKS0+dHlwZUluZm8oKS5vdmVy cmlkZXNWaXNpdENoaWxkcmVuKCkpOwogICAgIEJhc2U6OnZpc2l0Q2hpbGRyZW4odGhpc09iamVj dCwgdmlzaXRvcik7Ci0gICAgaWYgKHRoaXNPYmplY3QtPm1fY2FjaGVkQXR0cmlidXRlMSkKLSAg ICAgICAgdmlzaXRvci5hcHBlbmQoJnRoaXNPYmplY3QtPm1fY2FjaGVkQXR0cmlidXRlMSk7Ci0g ICAgaWYgKHRoaXNPYmplY3QtPm1fY2FjaGVkQXR0cmlidXRlMikKLSAgICAgICAgdmlzaXRvci5h cHBlbmQoJnRoaXNPYmplY3QtPm1fY2FjaGVkQXR0cmlidXRlMik7CisgICAgdmlzaXRvci5hcHBl bmQoJnRoaXNPYmplY3QtPm1fY2FjaGVkQXR0cmlidXRlMSk7CisgICAgdmlzaXRvci5hcHBlbmQo JnRoaXNPYmplY3QtPm1fY2FjaGVkQXR0cmlidXRlMik7CiB9CiAKIC8vIENvbnN0YW50IGdldHRl cnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9KUy9K U1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UuY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVy ZmFjZS5jcHAKaW5kZXggOGFiNzk2Ny4uZDdmOWEzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pTL0pTVGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUlu dGVyZmFjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy90ZXN0L0pT L0pTVGVzdFNlcmlhbGl6ZWRTY3JpcHRWYWx1ZUludGVyZmFjZS5jcHAKQEAgLTM1NiwxMCArMzU2 LDggQEAgdm9pZCBKU1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2U6OnZpc2l0Q2hp bGRyZW4oSlNDZWxsKiBjZWxsLCBTbG90VmlzaXQKICAgICBDT01QSUxFX0FTU0VSVChTdHJ1Y3R1 cmVGbGFncyAmIE92ZXJyaWRlc1Zpc2l0Q2hpbGRyZW4sIE92ZXJyaWRlc1Zpc2l0Q2hpbGRyZW5X aXRob3V0U2V0dGluZ0ZsYWcpOwogICAgIEFTU0VSVCh0aGlzT2JqZWN0LT5zdHJ1Y3R1cmUoKS0+ dHlwZUluZm8oKS5vdmVycmlkZXNWaXNpdENoaWxkcmVuKCkpOwogICAgIEJhc2U6OnZpc2l0Q2hp bGRyZW4odGhpc09iamVjdCwgdmlzaXRvcik7Ci0gICAgaWYgKHRoaXNPYmplY3QtPm1fY2FjaGVk VmFsdWUpCi0gICAgICAgIHZpc2l0b3IuYXBwZW5kKCZ0aGlzT2JqZWN0LT5tX2NhY2hlZFZhbHVl KTsKLSAgICBpZiAodGhpc09iamVjdC0+bV9jYWNoZWRSZWFkb25seVZhbHVlKQotICAgICAgICB2 aXNpdG9yLmFwcGVuZCgmdGhpc09iamVjdC0+bV9jYWNoZWRSZWFkb25seVZhbHVlKTsKKyAgICB2 aXNpdG9yLmFwcGVuZCgmdGhpc09iamVjdC0+bV9jYWNoZWRWYWx1ZSk7CisgICAgdmlzaXRvci5h cHBlbmQoJnRoaXNPYmplY3QtPm1fY2FjaGVkUmVhZG9ubHlWYWx1ZSk7CiB9CiAKIHN0YXRpYyBp bmxpbmUgYm9vbCBpc09ic2VydmFibGUoSlNUZXN0U2VyaWFsaXplZFNjcmlwdFZhbHVlSW50ZXJm YWNlKiBqc1Rlc3RTZXJpYWxpemVkU2NyaXB0VmFsdWVJbnRlcmZhY2UpCg==