95050 2012-08-26 23:52:17 -0700 WebKit fails to compile with both Qt+Wince support enabled 2012-08-27 12:06:35 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 kevin.funk webkit-unassigned gtk-ews gustavo webkit.review.bot xan.lopez oldest_to_newest 705004 0 kevin.funk 2012-08-26 23:52:17 -0700 The problem is in NativeImagePtr.h, when both OS(WINCE) and PLATFORM(QT) are true. The file is split into declaration + typedef part - the first part assumes Qt platform support, the second one support for WinCE, which leads to a compile error. Patch follows. 705008 1 160652 kevin.funk 2012-08-27 00:00:40 -0700 Created attachment 160652 Patch 705009 2 webkit.review.bot 2012-08-27 00:03:06 -0700 Attachment 160652 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/NativeImagePtr.h:31: Header file should not contain WebCore config.h. Should be: alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 705014 3 160652 gtk-ews 2012-08-27 00:20:40 -0700 Comment on attachment 160652 Patch Attachment 160652 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13601992 705043 4 160663 kevin.funk 2012-08-27 01:34:34 -0700 Created attachment 160663 Patch v2 705488 5 160663 webkit.review.bot 2012-08-27 12:06:32 -0700 Comment on attachment 160663 Patch v2 Clearing flags on attachment: 160663 Committed r126783: <http://trac.webkit.org/changeset/126783> 705489 6 webkit.review.bot 2012-08-27 12:06:35 -0700 All reviewed patches have been landed. Closing bug. 160652 2012-08-27 00:00:40 -0700 2012-08-27 01:34:34 -0700 Patch 0001-Fix-compilation-when-both-OS-WINCE-and-PLATFORM-QT-a.patch text/plain 2017 kevin.funk RnJvbSA2NGRhODU4ODIwNGM3NjU1ODgxOWYwNDYxOWY0YmQ4NzY0ZGQ5N2M0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBGdW5rIDxrZXZpbi5mdW5rQGtkYWIuY29tPgpEYXRl OiBNb24sIDI3IEF1ZyAyMDEyIDA4OjU4OjA1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGNv bXBpbGF0aW9uIHdoZW4gYm90aCBPUyhXSU5DRSkgYW5kIFBMQVRGT1JNKFFUKSBhcmUKIHRydWUK Ci0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICB8 IDEyICsrKysrKysrKysrKwogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTmF0aXZl SW1hZ2VQdHIuaCB8ICA2ICsrKystLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBi L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2MmJlODVlLi5iZDczNDY5IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDgtMjcgIEtldmluIEZ1bmsgIDxrZXZpbi5mdW5r QGtkYWIuY29tPgorCisgICAgICAgIEZpeCBjb21waWxhdGlvbiB3aGVuIGJvdGggT1MoV0lOQ0Up IGFuZCBQTEFURk9STShRVCkgYXJlIHRydWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTk1MDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlIGNvbXBpbGF0aW9uIG9mIE5hdGl2ZUltYWdlUHRyLmggYnJl YWtzIHdoZW4gYm90aCBPUyhXSU5DRSkgYW5kIFBMQVRGT1JNKFFUKSBhcmUgZW5hYmxlZC4KKyAg ICAgICAgVGhpcyBwYXRjaCBmaXhlcyB0aGlzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvTmF0aXZlSW1hZ2VQdHIuaDoKKwogMjAxMi0wOC0yMiAgQWxsYW4gU2FuZGZlbGQgSmVuc2Vu ICA8YWxsYW4uamVuc2VuQG5va2lhLmNvbT4KIAogICAgICAgICBbVG91Y2hBZGp1c3RtZW50XSBB ZGp1c3QgdG8gd29yZCBvciBzZWxlY3Rpb24KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL05hdGl2ZUltYWdlUHRyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9OYXRpdmVJbWFnZVB0ci5oCmluZGV4IDNjYzhkNzQuLmEzZDFmMjEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL05hdGl2ZUltYWdlUHRyLmgK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTmF0aXZlSW1hZ2VQdHIuaApA QCAtMjgsNiArMjgsOCBAQAogI2lmbmRlZiBOYXRpdmVJbWFnZVB0cl9oCiAjZGVmaW5lIE5hdGl2 ZUltYWdlUHRyX2gKIAorI2luY2x1ZGUgImNvbmZpZy5oIgorCiAjaWYgUExBVEZPUk0oV1gpCiBj bGFzcyB3eEJpdG1hcDsKIGNsYXNzIHd4R3JhcGhpY3NCaXRtYXA7CkBAIC01Miw2ICs1NCw4IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogI2lmIFVTRShDRykKIHR5cGVkZWYgQ0dJbWFnZVJlZiBO YXRpdmVJbWFnZVB0cjsKKyNlbGlmIFBMQVRGT1JNKFFUKQordHlwZWRlZiBRSW1hZ2UqIE5hdGl2 ZUltYWdlUHRyOwogI2VsaWYgUExBVEZPUk0oT1BFTlZHKQogY2xhc3MgVGlsZWRJbWFnZU9wZW5W RzsKIHR5cGVkZWYgVGlsZWRJbWFnZU9wZW5WRyogTmF0aXZlSW1hZ2VQdHI7CkBAIC02OSw4ICs3 Myw2IEBAIHR5cGVkZWYgV2ViQ29yZTo6TmF0aXZlSW1hZ2VTa2lhKiBOYXRpdmVJbWFnZVB0cjsK IHR5cGVkZWYgUmVmUHRyPFNoYXJlZEJpdG1hcD4gTmF0aXZlSW1hZ2VQdHI7CiAjZWxpZiBQTEFU Rk9STShCTEFDS0JFUlJZKQogdHlwZWRlZiB2b2lkKiBOYXRpdmVJbWFnZVB0cjsKLSNlbGlmIFBM QVRGT1JNKFFUKQotdHlwZWRlZiBRSW1hZ2UqIE5hdGl2ZUltYWdlUHRyOwogI2VuZGlmCiAKIH0K LS0gCjEuNy4xMS5tc3lzZ2l0LjEKCg== 160663 2012-08-27 01:34:34 -0700 2012-08-27 12:06:32 -0700 Patch v2 0001-Fix-compilation-when-both-OS-WINCE-and-PLATFORM-QT-e.patch text/plain 1858 kevin.funk RnJvbSA1ZmJkNjRjNjY0NGI0ZWQ2ZTFjYzU2MmM3YjkzMmIzYWVlMGRhYzU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLZXZpbiBGdW5rIDxrZXZpbi5mdW5rQGtkYWIuY29tPgpEYXRl OiBNb24sIDI3IEF1ZyAyMDEyIDEwOjMyOjUwICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGNv bXBpbGF0aW9uIHdoZW4gYm90aCBPUyhXSU5DRSkgYW5kIFBMQVRGT1JNKFFUKSBlbmFibGVkCgot LS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgfCAx MiArKysrKysrKysrKysKIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL05hdGl2ZUlt YWdlUHRyLmggfCAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDIg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDYyYmU4NWUuLmJkNzM0NjkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOC0yNyAgS2V2aW4gRnVuayAgPGtldmluLmZ1bmtAa2Rh Yi5jb20+CisKKyAgICAgICAgRml4IGNvbXBpbGF0aW9uIHdoZW4gYm90aCBPUyhXSU5DRSkgYW5k IFBMQVRGT1JNKFFUKSBhcmUgdHJ1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTUwNTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBUaGUgY29tcGlsYXRpb24gb2YgTmF0aXZlSW1hZ2VQdHIuaCBicmVha3Mg d2hlbiBib3RoIE9TKFdJTkNFKSBhbmQgUExBVEZPUk0oUVQpIGFyZSBlbmFibGVkLgorICAgICAg ICBUaGlzIHBhdGNoIGZpeGVzIHRoaXMuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9O YXRpdmVJbWFnZVB0ci5oOgorCiAyMDEyLTA4LTIyICBBbGxhbiBTYW5kZmVsZCBKZW5zZW4gIDxh bGxhbi5qZW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFtUb3VjaEFkanVzdG1lbnRdIEFkanVz dCB0byB3b3JkIG9yIHNlbGVjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvTmF0aXZlSW1hZ2VQdHIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL05hdGl2ZUltYWdlUHRyLmgKaW5kZXggM2NjOGQ3NC4uMWZjM2ZhNiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvTmF0aXZlSW1hZ2VQdHIuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9OYXRpdmVJbWFnZVB0ci5oCkBAIC01 Miw2ICs1Miw4IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogI2lmIFVTRShDRykKIHR5cGVkZWYg Q0dJbWFnZVJlZiBOYXRpdmVJbWFnZVB0cjsKKyNlbGlmIFBMQVRGT1JNKFFUKQordHlwZWRlZiBR SW1hZ2UqIE5hdGl2ZUltYWdlUHRyOwogI2VsaWYgUExBVEZPUk0oT1BFTlZHKQogY2xhc3MgVGls ZWRJbWFnZU9wZW5WRzsKIHR5cGVkZWYgVGlsZWRJbWFnZU9wZW5WRyogTmF0aXZlSW1hZ2VQdHI7 CkBAIC02OSw4ICs3MSw2IEBAIHR5cGVkZWYgV2ViQ29yZTo6TmF0aXZlSW1hZ2VTa2lhKiBOYXRp dmVJbWFnZVB0cjsKIHR5cGVkZWYgUmVmUHRyPFNoYXJlZEJpdG1hcD4gTmF0aXZlSW1hZ2VQdHI7 CiAjZWxpZiBQTEFURk9STShCTEFDS0JFUlJZKQogdHlwZWRlZiB2b2lkKiBOYXRpdmVJbWFnZVB0 cjsKLSNlbGlmIFBMQVRGT1JNKFFUKQotdHlwZWRlZiBRSW1hZ2UqIE5hdGl2ZUltYWdlUHRyOwog I2VuZGlmCiAKIH0KLS0gCjEuNy4xMS5tc3lzZ2l0LjEKCg==