9505 2006-06-19 06:33:06 -0700 moveParagraphContentsToNewBlockIfNecessary creates a new block outside the current position 2006-06-29 22:39:55 -0700 1 1 1 Unclassified WebKit HTML Editing 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 Graham.Dennis Graham.Dennis justin.garcia oldest_to_newest 46272 0 Graham.Dennis 2006-06-19 06:33:06 -0700 When pasting certain HTML from Safari, moveParagraphContents creates an invalid DIV element as the first child of a TABLE element. e.g. <table> <div> <tbody> ... </tbody> </div> </table> Steps to reproduce: Do a select-all on the website http://nowataballpark.org/contact.html then paste the result into any contentEditable div. The result will include a <div> element within the table. Cause: By the time the fixupNodeStyles() phase of pasting begins, the HTML just before the table element looks like: ... <p style="color: rgb(255, 0, 0); text-align: -khtml-center; "/> <table border="1" bgcolor="#FFFFFF"> <tbody style="border-spacing: 2px 2px; color: rgb(255, 0, 0); "> ... When applyStyle() is called on the empty paragraph element, this eventually calls through to moveParagraphContentsToNewBlockIfNecessary with a position of [p, 0) (where p is the paragraph element). When the VisiblePositions are created, because the paragraph element has no visible position, the vp's are all within the table element, and a div element is created inside the table element. I will attach a patch. This patch doesn't come with any layout tests as I haven't managed to get one working. I've tried modifying editing/pasteboard/paste-4039777-fix without any luck. However the above-mentioned steps do replicate the bug. 46273 1 8920 Graham.Dennis 2006-06-19 06:34:48 -0700 Created attachment 8920 patch 46419 2 8931 Graham.Dennis 2006-06-20 05:55:28 -0700 Created attachment 8931 testcase While messing around with trying to make a new testcase for bug 9507, I accidentally made a testcase that replicates this bug. :-) 46703 3 8920 justin.garcia 2006-06-22 13:13:34 -0700 Comment on attachment 8920 patch + // Perform some sanity checks. If the position pos doesn't have any visible positions + // then paragraphStart will be outside the paragraph + if (Range::compareBoundaryPoints(pos, paragraphStart) < 0) + return; +   Looks good.  I think you mean "If there are no VisiblePositions in the same block as pos". I can't reproduce the bug you describe with the testcase you attached.  I run it and the table doesn't have an invalid div child. 46778 4 8978 Graham.Dennis 2006-06-23 06:53:09 -0700 Created attachment 8978 patch 2 Modified patch including testcase and modified the comments. Note that because this testcase uses pasteCommand(), it will only work in Debug builds of WebKit or in DumpRenderTree. I've tested the testcase again for myself and it seems to work. 47790 5 ddkilzer 2006-06-29 21:45:55 -0700 (In reply to comment #4) > Created an attachment (id=8978) [edit] > patch 2 Graham, in the future, it would be helpful to include test results (*-expected.txt, *-expected.checksum and *-expected.png) with the tests when you create a patch. Thanks! 47791 6 ddkilzer 2006-06-29 22:30:22 -0700 Committed revision 15103. Also, please don't include tabs in the source code. :) 47792 7 Graham.Dennis 2006-06-29 22:39:55 -0700 (In reply to comment #6) > Committed revision 15103. > > Also, please don't include tabs in the source code. :) > Oops. I have included results of tests in some of my other patches, but I forgot to do that for this one... And I'll change SEE over to use spaces instead of tabs. Sorry about that... 8920 2006-06-19 06:34:48 -0700 2006-06-23 06:53:09 -0700 patch patch-9505.diff text/plain 1421 Graham.Dennis SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTEw KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDYtMDYt MTkgIEdyYWhhbSBEZW5uaXMgIDxHcmFoYW0uRGVubmlzQGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXQVJOSU5HOiBOTyBURVNUIENB U0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIGVkaXRpbmcvQ29tcG9zaXRlRWRpdENv bW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQ YXJhZ3JhcGhDb250ZW50c1RvTmV3QmxvY2tJZk5lY2Vzc2FyeSk6CisgICAgICAgIEFkZGVkIHNh bml0eSBjaGVja2luZyB0byBwcmV2ZW50IG1vZGlmeWluZyBub2RlcyBvdXRzaWRlIG9mIHdoZXJl IHdlIHNob3VsZCBiZQorCiAyMDA2LTA2LTE4ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBraWx6 ZXIubmV0PgogCiAgICAgICAgIFJldmlld2VkIGJ5IGRhcmluLgpJbmRleDogZWRpdGluZy9Db21w b3NpdGVFZGl0Q29tbWFuZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gZWRpdGluZy9Db21wb3NpdGVFZGl0 Q29tbWFuZC5jcHAJKHJldmlzaW9uIDE0ODEwKQorKysgZWRpdGluZy9Db21wb3NpdGVFZGl0Q29t bWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU2NSw2ICs1NjUsMTEgQEAgdm9pZCBDb21wb3Np dGVFZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFwaAogICAgIFBvc2l0aW9uIHBhcmFncmFwaFN0YXJ0 ID0gdmlzaWJsZVBhcmFncmFwaFN0YXJ0LmRlZXBFcXVpdmFsZW50KCkudXBzdHJlYW0oKTsKICAg ICBQb3NpdGlvbiBlbmQgPSB2aXNpYmxlRW5kLmRlZXBFcXVpdmFsZW50KCkudXBzdHJlYW0oKTsK ICAgICAKKwkvLyBQZXJmb3JtIHNvbWUgc2FuaXR5IGNoZWNrcy4gSWYgdGhlIHBvc2l0aW9uIHBv cyBkb2Vzbid0IGhhdmUgYW55IHZpc2libGUgcG9zaXRpb25zCisJLy8gdGhlbiBwYXJhZ3JhcGhT dGFydCB3aWxsIGJlIG91dHNpZGUgdGhlIHBhcmFncmFwaAorCWlmIChSYW5nZTo6Y29tcGFyZUJv dW5kYXJ5UG9pbnRzKHBvcywgcGFyYWdyYXBoU3RhcnQpIDwgMCkKKwkJcmV0dXJuOworCQogICAg IC8vIFBlcmZvcm0gc29tZSBjaGVja3MgdG8gc2VlIGlmIHdlIG5lZWQgdG8gcGVyZm9ybSB3b3Jr IGluIHRoaXMgZnVuY3Rpb24uCiAgICAgaWYgKHBhcmFncmFwaFN0YXJ0Lm5vZGUoKS0+aXNCbG9j a0Zsb3coKSkgewogICAgICAgICBpZiAoZW5kLm5vZGUoKS0+aXNCbG9ja0Zsb3coKSkgewo= 8931 2006-06-20 05:55:28 -0700 2006-06-20 05:55:28 -0700 testcase testcase-9505.html text/html 1315 Graham.Dennis PGh0bWw+IAo8aGVhZD4KCjxzdHlsZT4KLmVkaXRpbmcgeyAKICAgIGJvcmRlcjogMnB4IHNvbGlk IHJlZDsgCiAgICBmb250LXNpemU6IDI0cHg7IAp9Ci5leHBsYW5hdGlvbiB7IAogICAgYm9yZGVy OiAycHggc29saWQgYmx1ZTsgCiAgICBwYWRkaW5nOiAxMnB4OyAKICAgIGZvbnQtc2l6ZTogMjRw eDsgCiAgICBtYXJnaW4tYm90dG9tOiAyNHB4Owp9Ci5zY2VuYXJpbyB7IG1hcmdpbi1ib3R0b206 IDE2cHg7fQouc2NlbmFyaW86Zmlyc3QtbGluZSB7IGZvbnQtd2VpZ2h0OiBib2xkOyBtYXJnaW4t Ym90dG9tOiAxNnB4O30KLmV4cGVjdGVkLXJlc3VsdHM6Zmlyc3QtbGluZSB7IGZvbnQtd2VpZ2h0 OiBib2xkIH0KPC9zdHlsZT4KPHNjcmlwdCBzcmM9Li4vZWRpdGluZy5qcyBsYW5ndWFnZT0iSmF2 YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0IiA+PC9zY3JpcHQ+Cgo8c2NyaXB0PgpmdW5j dGlvbiBsb2cobWVzc2FnZSkgewogICAgdmFyIGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgiY29uc29sZSIpOwogICAgdmFyIGxpID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgibGki KTsKICAgIHZhciB0ZXh0ID0gZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2FnZSk7CiAgICBs aS5hcHBlbmRDaGlsZCh0ZXh0KTsKICAgIGNvbnNvbGUuYXBwZW5kQ2hpbGQobGkpOwp9CgpmdW5j dGlvbiBlZGl0aW5nVGVzdCgpIHsKICAgIGZvciAoaSA9IDA7IGkgPCAzOyBpKyspCiAgICAgICAg ZXh0ZW5kU2VsZWN0aW9uRm9yd2FyZEJ5TGluZUNvbW1hbmQoKTsKICAgIGNvcHlDb21tYW5kKCk7 CiAgICBwYXN0ZUNvbW1hbmQoKTsKfQoKPC9zY3JpcHQ+Cgo8dGl0bGU+RWRpdGluZyBUZXN0PC90 aXRsZT4gCjwvaGVhZD4gCjxib2R5PgpQcm9ibGVtOiBjb3B5L3Bhc3Rpbmcgc29tZSBIVE1MIGlu Y2x1ZGluZyB0YWJsZXMgY2FuIGdpdmUgcmlzZSB0byBhICZsdDtkaXYmZ3Q7IGVsZW1lbnQgYXMg dGhlIGZpcnN0IGNoaWxkIG9mIHRoZSB0YWJsZSBlbGVtZW50LiBUaGlzIGlzIGludmFsaWQuCjxk aXYgY29udGVudGVkaXRhYmxlIGlkPSJyb290Ij4KPGRpdiBpZD0idGVzdCIgY2xhc3M9ImVkaXRp bmciPgo8ZGl2PgphYmNkZWYKPGRpdiBzdHlsZT0idGV4dC1hbGlnbjogY2VudGVyIiA+Cjx0YWJs ZT48dHI+PHRkPmZvbzwvdGQ+PHRkPmJhcjwvdGQ+PC90cj48L3RhYmxlPgpnaGlqawo8L2Rpdj4K PC9kaXY+CjwvZGl2Pgo8L2Rpdj4KCjxvbCBpZD0iY29uc29sZSIgLz4KCjxzY3JpcHQ+CnJ1bkVk aXRpbmdUZXN0KCk7CmxvZyhyb290LmlubmVySFRNTCk7Cjwvc2NyaXB0PgoKPC9ib2R5Pgo8L2h0 bWw+Cg== 8978 2006-06-23 06:53:09 -0700 2006-06-26 11:47:17 -0700 patch 2 patch-9505-v2.diff text/plain 3884 Graham.Dennis SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDE0OTg2KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMDYtMDYtMjMgIEdyYWhhbSBEZW5uaXMgIDxH cmFoYW0uRGVubmlzQGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKyAgICAgICAgCisgICAgICAgIC0gdGVzdCBmb3IgaHR0cDovL2J1Z3ppbGxhLm9wZW5k YXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05NTA1CisgICAgICAgICBtb3ZlUGFyYWdyYXBoQ29u dGVudHNUb05ld0Jsb2NrSWZOZWNlc3NhcnkgY3JlYXRlcyBhIG5ldyBibG9jayBvdXRzaWRlIHRo ZSBjdXJyZW50IHBvc2l0aW9uCisKKyAgICAgICAgKiBlZGl0aW5nL3Bhc3RlYm9hcmQvcGFzdGUt dGFibGUtMDAyLmh0bWw6IEFkZGVkLgorCiAyMDA2LTA2LTIyICBNaXR6IFBldHRlbCAgPG9wZW5k YXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEh5YXR0LgpJ bmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL3Bhc3RlLXRhYmxlLTAwMi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2FyZC9wYXN0ZS10YWJs ZS0wMDIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvcGFzdGVib2Fy ZC9wYXN0ZS10YWJsZS0wMDIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw2MyBAQAorPGh0 bWw+IAorPGhlYWQ+CisKKzxzdHlsZT4KKy5lZGl0aW5nIHsgCisgICAgYm9yZGVyOiAycHggc29s aWQgcmVkOyAKKyAgICBmb250LXNpemU6IDI0cHg7IAorfQorLmV4cGxhbmF0aW9uIHsgCisgICAg Ym9yZGVyOiAycHggc29saWQgYmx1ZTsgCisgICAgcGFkZGluZzogMTJweDsgCisgICAgZm9udC1z aXplOiAyNHB4OyAKKyAgICBtYXJnaW4tYm90dG9tOiAyNHB4OworfQorLnNjZW5hcmlvIHsgbWFy Z2luLWJvdHRvbTogMTZweDt9Cisuc2NlbmFyaW86Zmlyc3QtbGluZSB7IGZvbnQtd2VpZ2h0OiBi b2xkOyBtYXJnaW4tYm90dG9tOiAxNnB4O30KKy5leHBlY3RlZC1yZXN1bHRzOmZpcnN0LWxpbmUg eyBmb250LXdlaWdodDogYm9sZCB9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9Li4vZWRpdGluZy5q cyBsYW5ndWFnZT0iSmF2YVNjcmlwdCIgdHlwZT0idGV4dC9KYXZhU2NyaXB0IiA+PC9zY3JpcHQ+ CisKKzxzY3JpcHQ+CitmdW5jdGlvbiBsb2cobWVzc2FnZSkgeworICAgIHZhciBjb25zb2xlID0g ZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoImNvbnNvbGUiKTsKKyAgICB2YXIgbGkgPSBkb2N1bWVu dC5jcmVhdGVFbGVtZW50KCJsaSIpOworICAgIHZhciB0ZXh0ID0gZG9jdW1lbnQuY3JlYXRlVGV4 dE5vZGUobWVzc2FnZSk7CisgICAgbGkuYXBwZW5kQ2hpbGQodGV4dCk7CisgICAgY29uc29sZS5h cHBlbmRDaGlsZChsaSk7Cit9CisKK2Z1bmN0aW9uIGVkaXRpbmdUZXN0KCkgeworICAgIGV4ZWNT ZWxlY3RBbGxDb21tYW5kKCk7CisgICAgY29weUNvbW1hbmQoKTsKKyAgICBleGVjRGVsZXRlQ29t bWFuZCgpOworICAgIHBhc3RlQ29tbWFuZCgpOworfQorCis8L3NjcmlwdD4KKworPHRpdGxlPkVk aXRpbmcgVGVzdDwvdGl0bGU+IAorPC9oZWFkPiAKKzxib2R5PgorUHJvYmxlbTogY29weS9wYXN0 aW5nIHNvbWUgSFRNTCBpbmNsdWRpbmcgdGFibGVzIGNhbiBnaXZlIHJpc2UgdG8gYSAmbHQ7ZGl2 Jmd0OyBlbGVtZW50IGFzIHRoZSBmaXJzdCBjaGlsZCBvZiB0aGUgdGFibGUgZWxlbWVudC4gVGhp cyBpcyBpbnZhbGlkLgorPGRpdiBjb250ZW50ZWRpdGFibGUgaWQ9InJvb3QiPgorPGRpdiBpZD0i dGVzdCIgY2xhc3M9ImVkaXRpbmciPgorPGRpdj4KK2FiY2RlZgorPGRpdiBzdHlsZT0idGV4dC1h bGlnbjogY2VudGVyIiA+Cis8dGFibGU+PHRyPjx0ZD5mb288L3RkPjx0ZD5iYXI8L3RkPjwvdHI+ PC90YWJsZT4KK2doaWprCis8L2Rpdj4KKzwvZGl2PgorPC9kaXY+Cis8L2Rpdj4KKworPG9sIGlk PSJjb25zb2xlIiAvPgorCis8c2NyaXB0PgorcnVuRWRpdGluZ1Rlc3QoKTsKK2xvZyhyb290Lmlu bmVySFRNTCk7Cis8L3NjcmlwdD4KKworPC9ib2R5PgorPC9odG1sPgpJbmRleDogV2ViQ29yZS9D aGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE0OTg2 KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAor MjAwNi0wNi0yMyAgR3JhaGFtIERlbm5pcyAgPEdyYWhhbS5EZW5uaXNAZ21haWwuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHA6 Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUwNQorICAgICAgICAg IG1vdmVQYXJhZ3JhcGhDb250ZW50c1RvTmV3QmxvY2tJZk5lY2Vzc2FyeSBjcmVhdGVzIGEgbmV3 IGJsb2NrIG91dHNpZGUgdGhlIGN1cnJlbnQgcG9zaXRpb24KKyAgICAgICAgCisgICAgICAgICog ZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHA6CisgICAgICAgIEFkZGVkIHNhbml0eSBj aGVja2luZyB0byBwcmV2ZW50IG1vZGlmeWluZyBub2RlcyBvdXRzaWRlIG9mIAorICAgICAgICB3 aGVyZSB3ZSBzaG91bGQgYmUKKyAgICAgICAgKFdlYkNvcmU6OkNvbXBvc2l0ZUVkaXRDb21tYW5k Ojptb3ZlUGFyYWdyYXBoQ29udGVudHNUb05ld0Jsb2NrSWZOZWNlc3NhcnkpOgorCiAyMDA2LTA2 LTIyICBNaXR6IFBldHRlbCAgPG9wZW5kYXJ3aW4ub3JnQG1pdHpwZXR0ZWwuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IEh5YXR0LgpJbmRleDogV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVk aXRDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRp dENvbW1hbmQuY3BwCShyZXZpc2lvbiAxNDkyMCkKKysrIFdlYkNvcmUvZWRpdGluZy9Db21wb3Np dGVFZGl0Q29tbWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU1Myw2ICs1NTMsMTEgQEAgdm9p ZCBDb21wb3NpdGVFZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFwaAogICAgIFBvc2l0aW9uIHBhcmFn cmFwaFN0YXJ0ID0gdmlzaWJsZVBhcmFncmFwaFN0YXJ0LmRlZXBFcXVpdmFsZW50KCkudXBzdHJl YW0oKTsKICAgICBQb3NpdGlvbiBlbmQgPSB2aXNpYmxlRW5kLmRlZXBFcXVpdmFsZW50KCkudXBz dHJlYW0oKTsKICAgICAKKwkvLyBQZXJmb3JtIHNvbWUgc2FuaXR5IGNoZWNrcy4gSWYgdGhlcmUg YXJlIG5vIFZpc2libGVQb3NpdGlvbnMgaW4KKwkvLyB0aGUgc2FtZSBibG9jayBhcyBwb3MgdGhl biBwYXJhZ3JhcGhTdGFydCB3aWxsIGJlIG91dHNpZGUgdGhlIHBhcmFncmFwaAorCWlmIChSYW5n ZTo6Y29tcGFyZUJvdW5kYXJ5UG9pbnRzKHBvcywgcGFyYWdyYXBoU3RhcnQpIDwgMCkKKwkJcmV0 dXJuOworCQogICAgIC8vIFBlcmZvcm0gc29tZSBjaGVja3MgdG8gc2VlIGlmIHdlIG5lZWQgdG8g cGVyZm9ybSB3b3JrIGluIHRoaXMgZnVuY3Rpb24uCiAgICAgaWYgKHBhcmFncmFwaFN0YXJ0Lm5v ZGUoKS0+aXNCbG9ja0Zsb3coKSkgewogICAgICAgICBpZiAoZW5kLm5vZGUoKS0+aXNCbG9ja0Zs b3coKSkgewo=