95049 2012-08-26 23:09:40 -0700 [Chromium-Android] Move webkit_unit_tests_apk and TestWebKitAPI_apk into condition block [gtest_target_type == "shared_library"' 2012-08-27 00:04:05 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other Android RESOLVED FIXED P2 Normal --- 1 jnd jnd abarth bulach peter wangxianzhu webkit.review.bot oldest_to_newest 704993 0 jnd 2012-08-26 23:09:40 -0700 Some test targets need to be wrapped in APK on Chromium Android platform only if the setting of gtest_target_type is "shared_library". We should explicitly put such test targets into a condition block ['OS=="android" and gtest_target_type == "shared_library"'] 704994 1 160648 jnd 2012-08-26 23:18:01 -0700 Created attachment 160648 patch v1 704999 2 160648 abarth 2012-08-26 23:45:49 -0700 Comment on attachment 160648 patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=160648&action=review > Source/WebKit/chromium/ChangeLog:9 > + Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library" Ideally, the ChangeLog would include the "why" behind the change. You've explained the why in Comment #0. You might just want to copy it into the ChangeLog. 705007 3 jnd 2012-08-26 23:57:45 -0700 (In reply to comment #2) > (From update of attachment 160648 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=160648&action=review > > > Source/WebKit/chromium/ChangeLog:9 > > + Move webkit_unit_tests_apk and TestWebKitAPI_apk into block of gtest_target_type == "shared_library" > > Ideally, the ChangeLog would include the "why" behind the change. You've explained the why in Comment #0. You might just want to copy it into the ChangeLog. Thank, Adam! Will follow it in the future patchs. 705010 4 160648 webkit.review.bot 2012-08-27 00:04:02 -0700 Comment on attachment 160648 patch v1 Clearing flags on attachment: 160648 Committed r126729: <http://trac.webkit.org/changeset/126729> 705011 5 webkit.review.bot 2012-08-27 00:04:05 -0700 All reviewed patches have been landed. Closing bug. 160648 2012-08-26 23:18:01 -0700 2012-08-27 00:04:01 -0700 patch v1 unit_test_password_form-crash-webkit-side.patch text/plain 1950 jnd SW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjY3MjUpCisrKyBTb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA4LTI2ICBKb2hubnkgRGluZyAgPGpuZEBjaHJvbWl1bS5vcmc+CisKKyAgICAg ICAgW0Nocm9taXVtLUFuZHJvaWRdTW92ZSB3ZWJraXRfdW5pdF90ZXN0c19hcGsgYW5kIFRlc3RX ZWJLaXRBUElfYXBrIGludG8gYQorICAgICAgICBjb25kaXRpb24gYmxvY2s6WydPUz09ImFuZHJv aWQiIGFuZCBndGVzdF90YXJnZXRfdHlwZSA9PSAic2hhcmVkX2xpYnJhcnkiJ10uCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTA0OQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgd2Via2l0X3VuaXRf dGVzdHNfYXBrIGFuZCBUZXN0V2ViS2l0QVBJX2FwayBpbnRvIGJsb2NrIG9mIGd0ZXN0X3Rhcmdl dF90eXBlID09ICJzaGFyZWRfbGlicmFyeSIKKworICAgICAgICAqIEFsbC5neXA6CisKIDIwMTIt MDgtMjQgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CiAKICAgICAgICAg Q2hyb21pdW06IFdlYkFjY2Vzc2liaWxpdHlPYmplY3Qgc2hvdWxkIGV4cG9zZSB1cGRhdGVCYWNr aW5nU3RvcmUKSW5kZXg6IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQWxsLmd5cAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViS2l0L2Nocm9taXVtL0FsbC5neXAJKHJldmlzaW9uIDEyNjcyMykKKysr IFNvdXJjZS9XZWJLaXQvY2hyb21pdW0vQWxsLmd5cAkod29ya2luZyBjb3B5KQpAQCAtNDcsOCAr NDcsMTUgQEAKICAgICAgICAgICAgICdjb25kaXRpb25zJzogWwogICAgICAgICAgICAgICAgIFsn T1M9PSJhbmRyb2lkIicsIHsKICAgICAgICAgICAgICAgICAgICAgJ2RlcGVuZGVuY2llcyc6IFsK LSAgICAgICAgICAgICAgICAgICAgICAgICdXZWJLaXRVbml0VGVzdHMuZ3lwOndlYmtpdF91bml0 X3Rlc3RzX2FwaycsCiAgICAgICAgICAgICAgICAgICAgICAgICAnLi4vLi4vLi4vVG9vbHMvRHVt cFJlbmRlclRyZWUvRHVtcFJlbmRlclRyZWUuZ3lwL0R1bXBSZW5kZXJUcmVlLmd5cDpEdW1wUmVu ZGVyVHJlZV9hcGsnLAorICAgICAgICAgICAgICAgICAgICBdLAorICAgICAgICAgICAgICAgIH1d LAorICAgICAgICAgICAgICAgICMgU3BlY2lhbCB0YXJnZXQgdG8gd3JhcCBhIGd0ZXN0X3Rhcmdl dF90eXBlPT1zaGFyZWRfbGlicmFyeQorICAgICAgICAgICAgICAgICMgd2Via2l0X3VuaXRfdGVz dHMgYW5kIFRlc3RXZWJLaXRBUEkgaW50byBhbiBhbmRyb2lkIGFwayBmb3IKKyAgICAgICAgICAg ICAgICAjIGV4ZWN1dGlvbi4gU2VlIGJhc2UuZ3lwIGZvciBUT0RPKGpyZylzIGFib3V0IHRoaXMg c3RyYXRlZ3kuCisgICAgICAgICAgICAgICAgWydPUz09ImFuZHJvaWQiIGFuZCBndGVzdF90YXJn ZXRfdHlwZSA9PSAic2hhcmVkX2xpYnJhcnkiJywgeworICAgICAgICAgICAgICAgICAgICAnZGVw ZW5kZW5jaWVzJzogWworICAgICAgICAgICAgICAgICAgICAgICAgJ1dlYktpdFVuaXRUZXN0cy5n eXA6d2Via2l0X3VuaXRfdGVzdHNfYXBrJywKICAgICAgICAgICAgICAgICAgICAgICAgICcuLi8u Li8uLi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RXZWJLaXRBUEkuZ3lwL1Rlc3RXZWJLaXRBUEku Z3lwOlRlc3RXZWJLaXRBUElfYXBrJywKICAgICAgICAgICAgICAgICAgICAgXSwKICAgICAgICAg ICAgICAgICB9XSwK