95048 2012-08-26 22:54:29 -0700 Add two missing variable initializers to RenderFlowThread 2012-08-27 09:37:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis abarth abucur eric hyatt mihnea webkit.review.bot oldest_to_newest 704978 0 thakis 2012-08-26 22:54:29 -0700 Add two missing variable initializers to RenderFlowThread 704982 1 160641 thakis 2012-08-26 22:56:47 -0700 Created attachment 160641 Patch 705050 2 abucur 2012-08-27 01:38:35 -0700 Unofficially, LGTM :) (though shouldn't the style check fail if there's no "Tests: ..." line?). Thanks for the patch! 705263 3 160641 jchaffraix 2012-08-27 07:46:29 -0700 Comment on attachment 160641 Patch Good catch, r=me. 705269 4 160641 webkit.review.bot 2012-08-27 07:52:10 -0700 Comment on attachment 160641 Patch Clearing flags on attachment: 160641 Committed r126762: <http://trac.webkit.org/changeset/126762> 705270 5 webkit.review.bot 2012-08-27 07:52:13 -0700 All reviewed patches have been landed. Closing bug. 705327 6 thakis 2012-08-27 09:37:58 -0700 Thanks, Julien / Andrei! (In reply to comment #2) > (though shouldn't the style check fail if there's no "Tests: ..." line?) This line from the changelog probably is enough for the style check: "The report came from the `fast/regions/absolute-pos-elem-in-named-flow.html'--pixel-test` test." 160641 2012-08-26 22:56:47 -0700 2012-08-27 07:52:10 -0700 Patch bug-95048-20120826225639.patch text/plain 3124 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NjMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2U3ZDE4ZTlhNjYzNjk2 MTVkMDM0ZWVkYTVjM2Q3YmFkODZkM2UyZi4uNzNhYjlhYThjZmJmMDdmYTQxYmM4MDdjZjU3MjM0 YTFlYzQ0NTYwOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM0IEBACisyMDEyLTA4LTI2ICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBBZGQgdHdvIG1pc3Npbmcg dmFyaWFibGUgaW5pdGlhbGl6ZXJzIHRvIFJlbmRlckZsb3dUaHJlYWQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk1MDQ4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIG1fZGlzcGF0Y2hSZWdpb25MYXlv dXRVcGRhdGVFdmVudCBjaGFuZ2UgaXMgbmVlZGVkIHRvIGZpeCB0aGlzCisgICAgICAgIHZhbGdy aW5kIHdhcm5pbmc6CisgICAgICAgIENvbmRpdGlvbmFsIGp1bXAgb3IgbW92ZSBkZXBlbmRzIG9u IHVuaW5pdGlhbGlzZWQgdmFsdWUocykKKyAgICAgICAgICBXZWJDb3JlOjpSZW5kZXJGbG93VGhy ZWFkOjpsYXlvdXQoKSAodGhpcmRfcGFydHkvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJGbG93VGhyZWFkLmNwcDoxODkpCisgICAgICAgICAgV2ViQ29yZTo6UmVuZGVyT2Jq ZWN0OjpsYXlvdXRJZk5lZWRlZCgpICh0aGlyZF9wYXJ0eS9XZWJLaXQvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOjY0NykKKyAgICAgICAgICBXZWJDb3JlOjpGbG93VGhy ZWFkQ29udHJvbGxlcjo6bGF5b3V0UmVuZGVyTmFtZWRGbG93VGhyZWFkcygpICh0aGlyZF9wYXJ0 eS9XZWJLaXQvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0Zsb3dUaHJlYWRDb250cm9sbGVyLmNw cDoxMjQpCisgICAgICAgICAgV2ViQ29yZTo6UmVuZGVyVmlldzo6bGF5b3V0KCkgKHRoaXJkX3Bh cnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHA6MTU5KQor ICAgICAgICAgIFdlYkNvcmU6OkZyYW1lVmlldzo6bGF5b3V0KGJvb2wpICh0aGlyZF9wYXJ0eS9X ZWJLaXQvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwOjExNTQpCisgICAgICAgICAg V2ViQ29yZTo6RnJhbWVWaWV3OjpsYXlvdXRUaW1lckZpcmVkKFdlYkNvcmU6OlRpbWVyPFdlYkNv cmU6OkZyYW1lVmlldz4qKSAodGhpcmRfcGFydHkvV2ViS2l0L1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RnJhbWVWaWV3LmNwcDoyMDc0KQorICAgICAgICAgIFdlYkNvcmU6OlRpbWVyPFdlYkNvcmU6OkZy YW1lVmlldz46OmZpcmVkKCkgKHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9UaW1lci5oOjEwMCkKKyAgICAgICAgICBXZWJDb3JlOjpUaHJlYWRUaW1lcnM6OnNoYXJl ZFRpbWVyRmlyZWRJbnRlcm5hbCgpICh0aGlyZF9wYXJ0eS9XZWJLaXQvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vVGhyZWFkVGltZXJzLmNwcDoxMTUpCisgICAgICAgICAgV2ViQ29yZTo6VGhyZWFk VGltZXJzOjpzaGFyZWRUaW1lckZpcmVkKCkgKHRoaXJkX3BhcnR5L1dlYktpdC9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9UaHJlYWRUaW1lcnMuY3BwOjkzKQorICAgICAgICAgIHdlYmtpdF9nbHVl OjpXZWJLaXRQbGF0Zm9ybVN1cHBvcnRJbXBsOjpEb1RpbWVvdXQoKSAoLi93ZWJraXQvZ2x1ZS93 ZWJraXRwbGF0Zm9ybXN1cHBvcnRfaW1wbC5oOjE2MykKKyAgICAgICAgVGhlIHJlcG9ydCBjYW1l IGZyb20gdGhlIGBmYXN0L3JlZ2lvbnMvYWJzb2x1dGUtcG9zLWVsZW0taW4tbmFtZWQtZmxvdy5o dG1sJy0tcGl4ZWwtdGVzdGAgdGVzdC4KKworICAgICAgICBtX2Rpc3BhdGNoUmVnaW9uTGF5b3V0 VXBkYXRlRXZlbnQgd2FzIGFkZGVkIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD04ODc3OAorICAgICAgICBieSBhYnVjdXIsIHJldmlld2VkIGJ5IGFiYXJ0aC4KKwor ICAgICAgICBXaGlsZSBoZXJlLCBhbHNvIGluaXRpYWxpemUgbV9oYXNSZWdpb25zV2l0aFN0eWxp bmcsIGFkZGVkIGluIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD04NTYz MworICAgICAgICBieSBtaWhuZWEsIHJldmlld2VkIGJ5IGh5YXR0LgorCisgICAgICAgICogcmVu ZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyRmxv d1RocmVhZDo6UmVuZGVyRmxvd1RocmVhZCk6CisKIDIwMTItMDgtMjQgIFNoZXJpZmYgQm90ICA8 d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxp bmcgb3V0IHIxMjY2MjAuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRmxvd1RocmVhZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxvd1Ro cmVhZC5jcHAKaW5kZXggNjgyNzU4N2ZjNzYwYTk0N2FlM2RjY2VjZGZiYzM1YzgxODI5MTM0ZS4u ZDMwNTlkZjEzNTA0MTllMGUxZGJjYTJhYjU1MThlNmIxZjQ4ZmY1MSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsb3dUaHJlYWQuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbG93VGhyZWFkLmNwcApAQCAtNTIsNiArNTIsOCBAQCBS ZW5kZXJGbG93VGhyZWFkOjpSZW5kZXJGbG93VGhyZWFkKE5vZGUqIG5vZGUpCiAgICAgLCBtX3Jl Z2lvbnNIYXZlVW5pZm9ybUxvZ2ljYWxXaWR0aCh0cnVlKQogICAgICwgbV9yZWdpb25zSGF2ZVVu aWZvcm1Mb2dpY2FsSGVpZ2h0KHRydWUpCiAgICAgLCBtX292ZXJzZXQodHJ1ZSkKKyAgICAsIG1f aGFzUmVnaW9uc1dpdGhTdHlsaW5nKGZhbHNlKQorICAgICwgbV9kaXNwYXRjaFJlZ2lvbkxheW91 dFVwZGF0ZUV2ZW50KGZhbHNlKQogewogICAgIEFTU0VSVChub2RlLT5kb2N1bWVudCgpLT5jc3NS ZWdpb25zRW5hYmxlZCgpKTsKICAgICBzZXRJc0Fub255bW91cyhmYWxzZSk7Cg==