95029 2012-08-26 01:38:58 -0700 [BlackBerry] cookie database thread is leaking a pthread_attr 2012-08-26 05:00:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joenotcharles joenotcharles manyoso mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 704815 0 joenotcharles 2012-08-26 01:38:58 -0700 CookieDatabaseBackingStore creates a pthread_attr with pthread_attr_init but does not delete it with pthread_attr_destroy. 704821 1 160597 joenotcharles 2012-08-26 02:17:30 -0700 Created attachment 160597 fix 704829 2 160597 rwlbuis 2012-08-26 04:49:18 -0700 Comment on attachment 160597 fix View in context: https://bugs.webkit.org/attachment.cgi?id=160597&action=review LGTM. > Source/WebCore/platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.cpp:68 > + createThread("cookie_database", pthread_attr_default); Should we have a default param value for this so we don't even need to specify? 704830 3 160597 webkit.review.bot 2012-08-26 04:59:58 -0700 Comment on attachment 160597 fix Clearing flags on attachment: 160597 Committed r126703: <http://trac.webkit.org/changeset/126703> 704831 4 webkit.review.bot 2012-08-26 05:00:01 -0700 All reviewed patches have been landed. Closing bug. 160597 2012-08-26 02:17:30 -0700 2012-08-26 04:59:57 -0700 fix 0001-BlackBerry-Stop-leaking-a-pthread_attr-in-CookieData.patch text/plain 2385 joenotcharles RnJvbSBlYWI5MzBmMDBhYWVjYWNhNWY0NDY1OGE2NTc5MDFhM2IyOWIzOGJjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKb2UgTWFzb24gPGptYXNvbkByaW0uY29tPgpEYXRlOiBTdW4s IDI2IEF1ZyAyMDEyIDA0OjQyOjI4IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW0JsYWNrQmVycnld IFN0b3AgbGVha2luZyBhIHB0aHJlYWRfYXR0ciBpbgogQ29va2llRGF0YWJhc2VCYWNraW5nU3Rv cmUKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTAyOQoKUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCgpObyBuZXcgdGVzdHMgKG5vIGJlaGF2aW91ciBjaGFuZ2Up ClJJTSBQUiAxOTg1MTkKCiogcGxhdGZvcm0vYmxhY2tiZXJyeS9Db29raWVEYXRhYmFzZUJhY2tp bmdTdG9yZS9Db29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZS5jcHA6CihXZWJDb3JlOjpDb29raWVE YXRhYmFzZUJhY2tpbmdTdG9yZTo6Q29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUpOiB1c2UgcHRo cmVhZF9hdHRyX2RlZmF1bHQKaW5zdGVhZCBvZiBwdGhyZWFkX2F0dHJfaW5pdAotLS0KIFNvdXJj ZS9XZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysr KysrKysrKysrKwogLi4uL0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlLmNwcCAgICAgICAgICAg ICAgICAgfCAgICA0ICstLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzkzOWI1ZS4uZGU4ZmNkZCAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDEyLTA4LTI2ICBKb2UgTWFzb24gIDxqbWFzb25AcmltLmNvbT4K KworICAgICAgICBbQmxhY2tCZXJyeV0gU3RvcCBsZWFraW5nIGEgcHRocmVhZF9hdHRyIGluIENv b2tpZURhdGFiYXNlQmFja2luZ1N0b3JlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05NTAyOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAobm8gYmVoYXZpb3VyIGNoYW5nZSkKKyAgICAg ICAgUklNIFBSIDE5ODUxOQorCisgICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9Db29raWVE YXRhYmFzZUJhY2tpbmdTdG9yZS9Db29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZS5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpDb29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZTo6Q29va2llRGF0YWJhc2VC YWNraW5nU3RvcmUpOiB1c2UgcHRocmVhZF9hdHRyX2RlZmF1bHQKKyAgICAgICAgaW5zdGVhZCBv ZiBwdGhyZWFkX2F0dHJfaW5pdAorCiAyMDEyLTA4LTIzICBPdHRvIERlcmVrIENoZXVuZyAgPG90 Y2hldW5nQHJpbS5jb20+CiAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v YmxhY2tiZXJyeS9Db29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZS9Db29raWVEYXRhYmFzZUJhY2tp bmdTdG9yZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURh dGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlLmNwcAppbmRleCBj ZWQ1NjAyLi43ZDM4ZDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFj a2JlcnJ5L0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0 b3JlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZURh dGFiYXNlQmFja2luZ1N0b3JlL0Nvb2tpZURhdGFiYXNlQmFja2luZ1N0b3JlLmNwcApAQCAtNjUs OSArNjUsNyBAQCBDb29raWVEYXRhYmFzZUJhY2tpbmdTdG9yZTo6Q29va2llRGF0YWJhc2VCYWNr aW5nU3RvcmUoKQogICAgIG1fZGJUaW1lckNsaWVudCA9IG5ldyBCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6R2VuZXJpY1RpbWVyQ2xpZW50KHRoaXMpOwogICAgIG1fZGJUaW1lci5zZXRDbGllbnQobV9k YlRpbWVyQ2xpZW50KTsKIAotICAgIHB0aHJlYWRfYXR0cl90IHRocmVhZEF0dHJzOwotICAgIHB0 aHJlYWRfYXR0cl9pbml0KCZ0aHJlYWRBdHRycyk7Ci0gICAgY3JlYXRlVGhyZWFkKCJjb29raWVf ZGF0YWJhc2UiLCB0aHJlYWRBdHRycyk7CisgICAgY3JlYXRlVGhyZWFkKCJjb29raWVfZGF0YWJh c2UiLCBwdGhyZWFkX2F0dHJfZGVmYXVsdCk7CiB9CiAKIENvb2tpZURhdGFiYXNlQmFja2luZ1N0 b3JlOjp+Q29va2llRGF0YWJhc2VCYWNraW5nU3RvcmUoKQotLSAKMS43LjUuNAoK