95017 2012-08-25 17:18:13 -0700 Roll out r126056 - patch broke path.getBBox() 2012-08-25 18:16:27 -0700 1 1 1 Unclassified WebKit SVG 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pdr pdr krit webkit.review.bot zimmermann oldest_to_newest 704759 0 pdr 2012-08-25 17:18:13 -0700 I removed the virtual getBBox() code in SVGPathElement.cpp which was incorrect and resulted in a test breaking. In the future I will better rely on ChangeLogs, as Tim Horton's r99460 was clear about why this code was organized this way: the boundingRect() call in SVGPathElement returns the _tight_ bounds so that paths don't use the loose/fast bounding rect from m_objectBoundingBox. This test was already skipped on Chromium for other reasons (see: https://bugs.webkit.org/show_bug.cgi?id=65939) and I failed to catch this regression locally. 704761 1 160582 pdr 2012-08-25 17:25:57 -0700 Created attachment 160582 Roll out r126056 and r126626 704762 2 160582 webkit.review.bot 2012-08-25 18:16:24 -0700 Comment on attachment 160582 Roll out r126056 and r126626 Clearing flags on attachment: 160582 Committed r126693: <http://trac.webkit.org/changeset/126693> 704763 3 webkit.review.bot 2012-08-25 18:16:27 -0700 All reviewed patches have been landed. Closing bug. 160582 2012-08-25 17:25:57 -0700 2012-08-25 18:16:24 -0700 Roll out r126056 and r126626 95017.1.patch text/plain 3791 pdr SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjY5MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA4LTI1ICBQaGlsaXAg Um9nZXJzICA8cGRyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUm9sbCBvdXQgcjEyNjA1NiBhbmQg cjEyNjYyNgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTUwMTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIHBhdGNoIHJvbGxzIG91dCByMTI2MDU2IHdoaWNoIHJlZ3Jlc3NlZCBhIHRlc3QuCisgICAg ICAgIFRoZSBnZXRCQm94KCkgY29kZSByZW1vdmVkIHR1cm5zIG91dCB0byBiZSByZXF1aXJlZCBm b3IgdGlnaHQgYm91bmRpbmcKKyAgICAgICAgYm94ZXMgaW4gU1ZHUGF0aEVsZW1lbnQ6OmdldEJC b3goKS4KKworICAgICAgICBXaGVuIHRoaXMgcmVncmVzc2lvbiBvY2N1cnJlZCB0aGUgcmVsZXZh bnQgdGVzdCB3YXMgc2tpcHBlZCBpbiByMTI2NjI2LiBUaGlzCisgICAgICAgIHBhdGNoIHJldmVy dHMgdGhhdCBza2lwLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4KKworICAgICAgICAqIHN2Zy9T VkdQYXRoRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdQYXRoRWxlbWVudDo6Z2V0 QkJveCk6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBzdmcvU1ZHUGF0aEVsZW1lbnQu aDoKKyAgICAgICAgKFNWR1BhdGhFbGVtZW50KToKKwogMjAxMi0wOC0yNSAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFtWOF0gVjhOb2RlRmlsdGVyQ29uZGl0aW9u IHNob3VsZCB1c2UgU2NvcGVkUGVyc2lzdGVudApJbmRleDogU291cmNlL1dlYkNvcmUvc3ZnL1NW R1BhdGhFbGVtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZHUGF0 aEVsZW1lbnQuY3BwCShyZXZpc2lvbiAxMjY1OTkpCisrKyBTb3VyY2UvV2ViQ29yZS9zdmcvU1ZH UGF0aEVsZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTYsNiArMzU2LDIwIEBAIHZvaWQg U1ZHUGF0aEVsZW1lbnQ6OnBhdGhTZWdMaXN0Q2hhbmdlZCgKICAgICBSZW5kZXJTVkdSZXNvdXJj ZTo6bWFya0ZvckxheW91dEFuZFBhcmVudFJlc291cmNlSW52YWxpZGF0aW9uKHJlbmRlcmVyKTsK IH0KIAorRmxvYXRSZWN0IFNWR1BhdGhFbGVtZW50OjpnZXRCQm94KFN0eWxlVXBkYXRlU3RyYXRl Z3kgc3R5bGVVcGRhdGVTdHJhdGVneSkKK3sKKyAgICBpZiAoc3R5bGVVcGRhdGVTdHJhdGVneSA9 PSBBbGxvd1N0eWxlVXBkYXRlKQorICAgICAgICB0aGlzLT5kb2N1bWVudCgpLT51cGRhdGVMYXlv dXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKKworICAgIFJlbmRlclNWR1BhdGgqIHJlbmRl cmVyID0gc3RhdGljX2Nhc3Q8UmVuZGVyU1ZHUGF0aCo+KHRoaXMtPnJlbmRlcmVyKCkpOworCisg ICAgLy8gRklYTUU6IEV2ZW50dWFsbHkgd2Ugc2hvdWxkIHN1cHBvcnQgZ2V0QkJveCBmb3IgZGV0 YWNoZWQgZWxlbWVudHMuCisgICAgaWYgKCFyZW5kZXJlcikKKyAgICAgICAgcmV0dXJuIEZsb2F0 UmVjdCgpOworCisgICAgcmV0dXJuIHJlbmRlcmVyLT5wYXRoKCkuYm91bmRpbmdSZWN0KCk7Cit9 CisKIFJlbmRlck9iamVjdCogU1ZHUGF0aEVsZW1lbnQ6OmNyZWF0ZVJlbmRlcmVyKFJlbmRlckFy ZW5hKiBhcmVuYSwgUmVuZGVyU3R5bGUqKQogewogICAgIC8vIEJ5IGRlZmF1bHQsIGFueSBzdWJj bGFzcyBpcyBleHBlY3RlZCB0byBkbyBwYXRoLWJhc2VkIGRyYXdpbmcKSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3N2Zy9TVkdQYXRoRWxlbWVudC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L3N2Zy9TVkdQYXRoRWxlbWVudC5oCShyZXZpc2lvbiAxMjY1OTkpCisrKyBTb3VyY2UvV2ViQ29y ZS9zdmcvU1ZHUGF0aEVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtOTUsNiArOTUsOCBAQCBw dWJsaWM6CiAKICAgICB2b2lkIHBhdGhTZWdMaXN0Q2hhbmdlZChTVkdQYXRoU2VnUm9sZSk7CiAK KyAgICB2aXJ0dWFsIEZsb2F0UmVjdCBnZXRCQm94KFN0eWxlVXBkYXRlU3RyYXRlZ3kgPSBBbGxv d1N0eWxlVXBkYXRlKTsKKwogICAgIHN0YXRpYyBjb25zdCBTVkdQcm9wZXJ0eUluZm8qIGRQcm9w ZXJ0eUluZm8oKTsKIAogICAgIGJvb2wgaXNBbmltVmFsT2JzZXJ2ZWQoKSBjb25zdCB7IHJldHVy biBtX2lzQW5pbVZhbE9ic2VydmVkOyB9CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMjY2OTIpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAx Mi0wOC0yNSAgUGhpbGlwIFJvZ2VycyAgPHBkckBnb29nbGUuY29tPgorCisgICAgICAgIFJvbGwg b3V0IHIxMjYwNTYgYW5kIHIxMjY2MjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk1MDE3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgUmVtb3Zpbmcgc2tpcHBlZCB0ZXN0LgorCisgICAgICAgICogcGxhdGZv cm0vbWFjL1NraXBwZWQ6CisKIDIwMTItMDgtMjUgIE1hcmsgTGFtICA8bWFyay5sYW1AYXBwbGUu Y29tPgogCiAgICAgICAgIFNraXBwaW5nIDQgY29tcG9zaXRpbmcvb3ZlcmZsb3cgdGVzdHMgZm9y IGdhcmRlbmluZy4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCShyZXZpc2lvbiAxMjY2 OTIpCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAkod29ya2luZyBjb3B5KQpA QCAtMTAwNSwxMSArMTAwNSw2IEBAIHN2Zy9zdHJva2UvemVyby1sZW5ndGgtYXJjLWxpbmVjYXBz LXJlbmQKIHN2Zy9zdHJva2UvemVyby1sZW5ndGgtcGF0aC1saW5lY2FwLXJlbmRlcmluZy5zdmcK IHN2Zy9zdHJva2UvemVyby1sZW5ndGgtc3VicGF0aHMtbGluZWNhcC1yZW5kZXJpbmcuc3ZnCiAK LSMgU2tpcHBpbmcgZHVlIHRvIHJlZ3Jlc3Npb24gY2F1c2VkIGJ5IHIxMjYwNTYgaW4KLSMgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ0MTkgQ2xlYW51cCBTVkdM b2NhdGFibGUgaW5oZXJpdGFuY2UKLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk0OTY5Ci1zdmcvY3VzdG9tL2dldEJCb3gtcGF0aC5zdmcKLQogIyBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTUwMDkKIGNvbXBvc2l0aW5nL292ZXJmbG93 L292ZXJmbG93LWF1dG8td2l0aC10b3VjaC5odG1sCiBjb21wb3NpdGluZy9vdmVyZmxvdy9vdmVy Zmxvdy1vdmVybGF5LXdpdGgtdG91Y2guaHRtbAo=