95010 2012-08-25 15:18:07 -0700 [V8] V8NodeFilterCondition should use ScopedPersistent 2012-08-25 16:06:05 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 704727 0 abarth 2012-08-25 15:18:07 -0700 [V8] V8NodeFilterCondition should use ScopedPersistent 704728 1 160571 abarth 2012-08-25 15:20:24 -0700 Created attachment 160571 Patch 704730 2 160571 eric 2012-08-25 15:24:32 -0700 Comment on attachment 160571 Patch LGTM. 704745 3 160571 webkit.review.bot 2012-08-25 16:06:02 -0700 Comment on attachment 160571 Patch Clearing flags on attachment: 160571 Committed r126690: <http://trac.webkit.org/changeset/126690> 704746 4 webkit.review.bot 2012-08-25 16:06:05 -0700 All reviewed patches have been landed. Closing bug. 160571 2012-08-25 15:20:24 -0700 2012-08-25 16:06:02 -0700 Patch bug-95010-20120825152017.patch text/plain 4317 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjgwYTFkZDUyM2U1MGQy N2M1MDE3NTFjN2Y2MTI3NjNmYmVkNGRkYy4uZWQ3NDUwMGE3MzAzNmMzOTNjYzQwNzBmMmQ2Nzhj YjRjMTYxZDY0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA4LTI1ICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBWOE5vZGVGaWx0ZXJD b25kaXRpb24gc2hvdWxkIHVzZSBTY29wZWRQZXJzaXN0ZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NTAxMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFY4Tm9kZUZpbHRlckNvbmRpdGlvbiBqdXN0IHJl LWltcGxlbWVudHMgU2NvcGVkUGVyc2lzdGVudCBieSBoYW5kLgorCisgICAgICAgICogYmluZGlu Z3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4Tm9k ZUZpbHRlckNvbmRpdGlvbjo6VjhOb2RlRmlsdGVyQ29uZGl0aW9uKToKKyAgICAgICAgKFdlYkNv cmU6OlY4Tm9kZUZpbHRlckNvbmRpdGlvbjo6flY4Tm9kZUZpbHRlckNvbmRpdGlvbik6CisgICAg ICAgIChXZWJDb3JlOjpWOE5vZGVGaWx0ZXJDb25kaXRpb246OmFjY2VwdE5vZGUpOgorICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4Tm9kZUZpbHRlckNvbmRpdGlvbi5oOgorICAgICAgICAoV2ViQ29y ZSk6CisgICAgICAgIChWOE5vZGVGaWx0ZXJDb25kaXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6 VjhOb2RlRmlsdGVyQ29uZGl0aW9uOjpjcmVhdGUpOgorCiAyMDEyLTA3LTE4ICBSb2JlcnQgSG9n YW4gIDxyb2JlcnRAd2Via2l0Lm9yZz4KIAogICAgICAgICBUYWJsZXMgd2l0aCBqdXN0IGJvcmRl ci1zdHlsZSBzZXQgb24gdGhlIGNlbGxzIGRvIG5vdCBnZXQgYSBncmlkCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uY3BwIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmNwcAppbmRleCBi YzUyYTM4ZjM3NjZiZThiMmE0OGFhODg1Njc4YmY4OGE5YjQxOTU2Li45MzMzOWVjMDBjN2E0NGZj ZDg5NWE5NjYwNDkwOWNhYmY4MGRjZDJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4Tm9kZUZpbHRlckNvbmRpdGlvbi5jcHAKQEAgLTM2LDI2ICszNiwxNyBAQAog I2luY2x1ZGUgIlNjcmlwdENvbnRyb2xsZXIuaCIKICNpbmNsdWRlICJTY3JpcHRTdGF0ZS5oIgog I2luY2x1ZGUgIlY4Tm9kZS5oIgotCiAjaW5jbHVkZSA8d3RmL093bkFycmF5UHRyLmg+CiAKIG5h bWVzcGFjZSBXZWJDb3JlIHsKIAogVjhOb2RlRmlsdGVyQ29uZGl0aW9uOjpWOE5vZGVGaWx0ZXJD b25kaXRpb24odjg6OkhhbmRsZTx2ODo6VmFsdWU+IGZpbHRlcikKLSAgICA6IG1fZmlsdGVyKHY4 OjpQZXJzaXN0ZW50PHY4OjpWYWx1ZT46Ok5ldyhmaWx0ZXIpKQorICAgIDogbV9maWx0ZXIoZmls dGVyKQogewotI2lmbmRlZiBOREVCVUcKLSAgICBWOEdDQ29udHJvbGxlcjo6cmVnaXN0ZXJHbG9i YWxIYW5kbGUoTk9ERV9GSUxURVIsIHRoaXMsIG1fZmlsdGVyKTsKLSNlbmRpZgogfQogCiBWOE5v ZGVGaWx0ZXJDb25kaXRpb246On5WOE5vZGVGaWx0ZXJDb25kaXRpb24oKQogewotI2lmbmRlZiBO REVCVUcKLSAgICBWOEdDQ29udHJvbGxlcjo6dW5yZWdpc3Rlckdsb2JhbEhhbmRsZSh0aGlzLCBt X2ZpbHRlcik7Ci0jZW5kaWYKLSAgICBtX2ZpbHRlci5EaXNwb3NlKCk7Ci0gICAgbV9maWx0ZXIu Q2xlYXIoKTsKIH0KIAogc2hvcnQgVjhOb2RlRmlsdGVyQ29uZGl0aW9uOjphY2NlcHROb2RlKFNj cmlwdFN0YXRlKiBzdGF0ZSwgTm9kZSogbm9kZSkgY29uc3QKQEAgLTY5LDcgKzYwLDcgQEAgc2hv cnQgVjhOb2RlRmlsdGVyQ29uZGl0aW9uOjphY2NlcHROb2RlKFNjcmlwdFN0YXRlKiBzdGF0ZSwg Tm9kZSogbm9kZSkgY29uc3QKIAogICAgIHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPiBjYWxsYmFj azsKICAgICBpZiAobV9maWx0ZXItPklzRnVuY3Rpb24oKSkKLSAgICAgICAgY2FsbGJhY2sgPSB2 ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj46OkNhc3QobV9maWx0ZXIpOworICAgICAgICBjYWxsYmFj ayA9IHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uPjo6Q2FzdChtX2ZpbHRlci5nZXQoKSk7CiAgICAg ZWxzZSB7CiAgICAgICAgIHY4OjpMb2NhbDx2ODo6VmFsdWU+IHZhbHVlID0gbV9maWx0ZXItPlRv T2JqZWN0KCktPkdldCh2ODo6U3RyaW5nOjpOZXcoImFjY2VwdE5vZGUiKSk7CiAgICAgICAgIGlm ICghdmFsdWUtPklzRnVuY3Rpb24oKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhOb2RlRmlsdGVyQ29uZGl0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOE5vZGVGaWx0ZXJDb25kaXRpb24uaAppbmRleCBiODY0ZTVlZGVjOWNkZGUyNjRkMDhk ZmZjZjVmMDA5YTllNzk1MDA2Li43OTVmODM0OTQwMTEyYWI5ODk0Y2I1MjNlY2Y2NzgyMmQzYmVm ZTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5vZGVGaWx0ZXJD b25kaXRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOE5vZGVGaWx0ZXJD b25kaXRpb24uaApAQCAtMzIsMzIgKzMyLDMxIEBACiAjZGVmaW5lIFY4Tm9kZUZpbHRlckNvbmRp dGlvbl9oCiAKICNpbmNsdWRlICJOb2RlRmlsdGVyQ29uZGl0aW9uLmgiCisjaW5jbHVkZSAiU2Nv cGVkUGVyc2lzdGVudC5oIgogI2luY2x1ZGUgPHY4Lmg+CiAjaW5jbHVkZSA8d3RmL1Bhc3NSZWZQ dHIuaD4KIAotLy8gTm9kZUZpbHRlciBpcyBhIEphdmFTY3JpcHQgZnVuY3Rpb24gdGhhdCB0YWtl cyBhIE5vZGUgYXMgcGFyYW1ldGVyIGFuZCByZXR1cm5zIGEgc2hvcnQgKEFDQ0VQVCwgU0tJUCwg UkVKRUNUKSBhcyB0aGUgcmVzdWx0LgogbmFtZXNwYWNlIFdlYkNvcmUgewogCi0gICAgY2xhc3Mg Tm9kZTsKLSAgICBjbGFzcyBTY3JpcHRTdGF0ZTsKK2NsYXNzIE5vZGU7CitjbGFzcyBTY3JpcHRT dGF0ZTsKIAotICAgIC8vIE5vZGVGaWx0ZXJDb25kaXRpb24gaXMgYSB3cmFwcGVyIGFyb3VuZCBh IE5vZGVGaWx0ZXIgSlMgZnVuY3Rpb24uCi0gICAgY2xhc3MgVjhOb2RlRmlsdGVyQ29uZGl0aW9u IDogcHVibGljIE5vZGVGaWx0ZXJDb25kaXRpb24gewotICAgIHB1YmxpYzoKLSAgICAgICAgc3Rh dGljIFBhc3NSZWZQdHI8VjhOb2RlRmlsdGVyQ29uZGl0aW9uPiBjcmVhdGUodjg6OkhhbmRsZTx2 ODo6VmFsdWU+IGZpbHRlcikKLSAgICAgICAgewotICAgICAgICAgICAgcmV0dXJuIGFkb3B0UmVm KG5ldyBWOE5vZGVGaWx0ZXJDb25kaXRpb24oZmlsdGVyKSk7Ci0gICAgICAgIH0KK2NsYXNzIFY4 Tm9kZUZpbHRlckNvbmRpdGlvbiA6IHB1YmxpYyBOb2RlRmlsdGVyQ29uZGl0aW9uIHsKK3B1Ymxp YzoKKyAgICBzdGF0aWMgUGFzc1JlZlB0cjxWOE5vZGVGaWx0ZXJDb25kaXRpb24+IGNyZWF0ZSh2 ODo6SGFuZGxlPHY4OjpWYWx1ZT4gZmlsdGVyKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGFkb3B0 UmVmKG5ldyBWOE5vZGVGaWx0ZXJDb25kaXRpb24oZmlsdGVyKSk7CisgICAgfQogCi0gICAgICAg IHZpcnR1YWwgflY4Tm9kZUZpbHRlckNvbmRpdGlvbigpOworICAgIHZpcnR1YWwgflY4Tm9kZUZp bHRlckNvbmRpdGlvbigpOwogCi0gICAgICAgIHZpcnR1YWwgc2hvcnQgYWNjZXB0Tm9kZShTY3Jp cHRTdGF0ZSosIE5vZGUqKSBjb25zdDsKKyAgICB2aXJ0dWFsIHNob3J0IGFjY2VwdE5vZGUoU2Ny aXB0U3RhdGUqLCBOb2RlKikgY29uc3Q7CiAKLSAgICBwcml2YXRlOgotICAgICAgICBleHBsaWNp dCBWOE5vZGVGaWx0ZXJDb25kaXRpb24odjg6OkhhbmRsZTx2ODo6VmFsdWU+IGZpbHRlcik7Citw cml2YXRlOgorICAgIGV4cGxpY2l0IFY4Tm9kZUZpbHRlckNvbmRpdGlvbih2ODo6SGFuZGxlPHY4 OjpWYWx1ZT4gZmlsdGVyKTsKIAotICAgICAgICBtdXRhYmxlIHY4OjpQZXJzaXN0ZW50PHY4OjpW YWx1ZT4gbV9maWx0ZXI7Ci0gICAgfTsKKyAgICBTY29wZWRQZXJzaXN0ZW50PHY4OjpWYWx1ZT4g bV9maWx0ZXI7Cit9OwogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAK