9501 2006-06-18 23:58:00 -0700 Windows build fails with link error CharsetTable not defined 2006-06-19 20:15:03 -0700 1 1 1 Unclassified WebKit New Bugs 420+ PC Windows XP RESOLVED FIXED P1 Blocker --- 0 bengoodger webkit-unassigned bugs-webkit gavin.sharp oldest_to_newest 46224 0 bengoodger 2006-06-18 23:58:00 -0700 Windows builds fail with a link error: CharsetTable is not defined. WebCore/DerivedSources/CharsetData.cpp exists, but is empty. In the build log there is a report that a script failed whilst running. It seems that the script that generates this file - make-charset-table.pl - is having difficulty. make-charset-table.pl does not properly normalize alias names in subroutine process_iana_charsets. character-sets.txt has some Alias: lines that have escape characters on the end that are not properly chomped, meaning that in more than one case the statement: next if $new_alias eq "None"; does not work. This needs to be moved after the normalization steps and adjusted to: next if $new_alias eq "none"; 46230 1 8918 bengoodger 2006-06-19 00:02:37 -0700 Created attachment 8918 patch move test for equality to "none" to after normalization steps. ChangeLog entry: * platform/make-charset-table.pl: (process_iana_charsets): Move test for equality to alias "None" until after normalization steps to ensure escape characters in the input data don't interfere with processing. Convert nearby tabs to 4 spaces in this function. 46290 2 8918 darin 2006-06-19 11:31:42 -0700 Comment on attachment 8918 patch This looks fine -- but I'm working on a patch that eliminates the character set table entirely! 46298 3 8918 darin 2006-06-19 13:26:51 -0700 Comment on attachment 8918 patch Seems fine to land this, but even better to remove this script entirely! r=me 46333 4 ddkilzer 2006-06-19 20:15:03 -0700 Committed revision 14919. 8918 2006-06-19 00:02:37 -0700 2006-06-19 13:26:51 -0700 patch webcore-20060618.patch text/plain 1849 bengoodger SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbWFrZS1jaGFyc2V0LXRhYmxlLnBsDQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 DQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9tYWtlLWNoYXJzZXQtdGFibGUucGwJKHJldmlzaW9uIDE0 ODk5KQ0KKysrIFdlYkNvcmUvcGxhdGZvcm0vbWFrZS1jaGFyc2V0LXRhYmxlLnBsCSh3b3JraW5n IGNvcHkpDQpAQCAtMTcxLDI3ICsxNzEsMjkgQEANCiAgICAgCiAgICAgd2hpbGUgKDxDSEFSU0VU Uz4pIHsKICAgICAgICAgY2hvbXA7Ci0JaWYgKChteSAkbmV3X2Nhbm9uaWNhbF9uYW1lKSA9IC9O YW1lOiAoW14gXHRdKikuKi8pIHsKKyAgICAgICAgaWYgKChteSAkbmV3X2Nhbm9uaWNhbF9uYW1l KSA9IC9OYW1lOiAoW14gXHRdKikuKi8pIHsKICAgICAgICAgICAgICRuZXdfY2Fub25pY2FsX25h bWUgPSBsYyAkbmV3X2Nhbm9uaWNhbF9uYW1lOwogICAgICAgICAgICAgJG5ld19jYW5vbmljYWxf bmFtZSA9fiB0ci9hLXowLTkvL2NkOwogICAgICAgICAgICAgCiAgICAgICAgICAgICBlcnJvciAi c2F3ICRuZXdfY2Fub25pY2FsX25hbWUgdHdpY2UgaW4gY2hhcmFjdGVyLXNldHMudHh0IiwgaWYg JHNlZW57JG5ld19jYW5vbmljYWxfbmFtZX07CiAgICAgICAgICAgICAkc2VlbnskbmV3X2Nhbm9u aWNhbF9uYW1lfSA9ICRuZXdfY2Fub25pY2FsX25hbWU7CiAgICAgICAgICAgICAKLQkgICAgcHJv Y2Vzc19pYW5hX2NoYXJzZXQgJGNhbm9uaWNhbF9uYW1lLCBAYWxpYXNlczsKKyAgICAgICAgICAg IHByb2Nlc3NfaWFuYV9jaGFyc2V0ICRjYW5vbmljYWxfbmFtZSwgQGFsaWFzZXM7CiAJICAgIAot CSAgICAkY2Fub25pY2FsX25hbWUgPSAkbmV3X2Nhbm9uaWNhbF9uYW1lOwotCSAgICBAYWxpYXNl cyA9ICgpOwotCX0gZWxzaWYgKChteSAkbmV3X2FsaWFzKSA9IC9BbGlhczogKFteIFx0XSopLiov KSB7Ci0gICAgICAgICAgICBuZXh0IGlmICRuZXdfYWxpYXMgZXEgIk5vbmUiOwotICAgICAgICAg ICAgCisJICAgICAgICAgICRjYW5vbmljYWxfbmFtZSA9ICRuZXdfY2Fub25pY2FsX25hbWU7CisJ ICAgICAgICAgIEBhbGlhc2VzID0gKCk7CisgICAgICAgIH0gZWxzaWYgKChteSAkbmV3X2FsaWFz KSA9IC9BbGlhczogKFteIFx0XSopLiovKSB7CiAgICAgICAgICAgICAkbmV3X2FsaWFzID0gbGMg JG5ld19hbGlhczsKICAgICAgICAgICAgICRuZXdfYWxpYXMgPX4gdHIvYS16MC05Ly9jZDsKICAg ICAgICAgICAgIAorICAgICAgICAgICAgIyBkbyB0aGlzIGFmdGVyIG5vcm1hbGl6aW5nIHRoZSBh bGlhcywgc29tZXRpbWVzIGNoYXJhY3Rlci1zZXRzLnR4dAorICAgICAgICAgICAgIyBoYXMgd2Vp cmQgZXNjYXBlIGNoYXJhY3RlcnMsIGUuZy4gXGIgYWZ0ZXIgTm9uZQorICAgICAgICAgICAgbmV4 dCBpZiAkbmV3X2FsaWFzIGVxICJub25lIjsKKwogICAgICAgICAgICAgZXJyb3IgInNhdyAkbmV3 X2FsaWFzIHR3aWNlIGluIGNoYXJhY3Rlci1zZXRzLnR4dCAkc2VlbnskbmV3X2FsaWFzfSwgJGNh bm9uaWNhbF9uYW1lIiwgaWYgJHNlZW57JG5ld19hbGlhc30gJiYgJHNlZW57JG5ld19hbGlhc30g bmUgJGNhbm9uaWNhbF9uYW1lICYmICEkZXhjZXB0aW9uc3skbmV3X2FsaWFzfTsKICAgICAgICAg ICAgIHB1c2ggQGFsaWFzZXMsICRuZXdfYWxpYXMgaWYgISRzZWVueyRuZXdfYWxpYXN9OwogICAg ICAgICAgICAgJHNlZW57JG5ld19hbGlhc30gPSAkY2Fub25pY2FsX25hbWU7ICAgICAgICAgICAg Ci0JfQorICAgICAgICB9CiAgICAgfQogICAgIAogICAgIHByb2Nlc3NfaWFuYV9jaGFyc2V0ICRj YW5vbmljYWxfbmFtZSwgQGFsaWFzZXM7Cg==