95008 2012-08-25 14:44:02 -0700 Even up WTF::String to CString functions 2012-08-29 14:31:12 -0700 1 1 1 Unclassified WebKit Web Template Framework 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 benjamin benjamin jberlin oldest_to_newest 704723 0 benjamin 2012-08-25 14:44:02 -0700 Apply the optimizations of JSC::UString to WTF::String. 704725 1 160570 benjamin 2012-08-25 14:58:25 -0700 Created attachment 160570 Patch 705471 2 160570 benjamin 2012-08-27 11:54:37 -0700 Comment on attachment 160570 Patch Clearing flags on attachment: 160570 Committed r126780: <http://trac.webkit.org/changeset/126780> 705472 3 benjamin 2012-08-27 11:54:39 -0700 All reviewed patches have been landed. Closing bug. 707879 4 jberlin 2012-08-29 14:31:12 -0700 This change caused a crash, see https://bugs.webkit.org/show_bug.cgi?id=95380. If I don't hear from someone soon about it, I might need to roll this out. 160570 2012-08-25 14:58:25 -0700 2012-08-27 11:54:37 -0700 Patch bug-95008-20120825145819.patch text/plain 2271 benjamin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Njg2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDgwODVlZWZhZDM3ZTdhM2Q5MTQxMTAz NmQ2M2QzOWI3NDNhZTkxNWYuLmVjOTdlNTBkNDEyNzI1Y2U1NTYxZTNkMDhjNTc1ZGRmODhjMjkw MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDgtMjUgIEJlbmphbWluIFBvdWxhaW4gIDxi ZW5qYW1pbkB3ZWJraXQub3JnPgorCisgICAgICAgIEV2ZW4gdXAgV1RGOjpTdHJpbmcgdG8gQ1N0 cmluZyBmdW5jdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk1MDA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQXBwbHkgYWR2YW50YWdlcyBmcm9tIFVTdHJpbmcgdG8gV1RGOjpTdHJpbmcuCisKKyAg ICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuY3BwOgorICAgICAgICAoV1RGOjpTdHJpbmc6OmFz Y2lpKTogVGhlcmUgaXMgbm8gbmVlZCB0byBzcGVjaWFsIGNhc2UgdGhlIG51bGwgbGVuZ3RoLCBi b3RoCisgICAgICAgIGZvbGxvd2luZyBicmFuY2hlcyB1c2UgQ1N0cmluZzo6bmV3VW5pbml0aWFs aXplZCgpLCB3aGljaCBjcmVhdGUgZW1wdHkgc3RyaW5nCisgICAgICAgIGZvciBudWxsIGxlbmd0 aC4KKyAgICAgICAgKFdURjo6U3RyaW5nOjpsYXRpbjEpOiBVc2UgY2hhcmFjdGVyczE2KCkgaW5z dGVhZCBvZiBjaGFyYWN0ZXJzKCkgdG8gYXZvaWQKKyAgICAgICAgdGVzdGluZyBpczhCaXQoKSBh IHNlY29uZCB0aW1lLgorCiAyMDEyLTA4LTI0ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBUb3VjaCBQbGF0Zm9ybS5oIHRvIHNvbHZlIGEgYnVpbGQg ZGVwZW5kZW5jeSBpc3N1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJp bmcuY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuY3BwCmluZGV4IDcyYjA0OGQ0 MGEyYmFhZjc1Y2EzMDAyYzVjZDI5MzE5YTgzYzFjYjEuLjExNWU1ZDljYjUzYmIxYTQyMGIzMWZi OTdjMmQ0MDlmYzAyYTQwOTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3Ry aW5nLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5jcHAKQEAgLTEsNiAr MSw2IEBACiAvKgogICogKEMpIDE5OTkgTGFycyBLbm9sbCAoa25vbGxAa2RlLm9yZykKLSAqIENv cHlyaWdodCAoQykgMjAwNCwgMjAwNSwgMjAwNiwgMjAwNywgMjAwOCwgMjAxMCBBcHBsZSBJbmMu IEFsbCByaWdodHMgcmVzZXJ2ZWQuCisgKiBDb3B5cmlnaHQgKEMpIDIwMDQsIDIwMDUsIDIwMDYs IDIwMDcsIDIwMDgsIDIwMTAsIDIwMTIgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgog ICogQ29weXJpZ2h0IChDKSAyMDA3LTIwMDkgVG9yY2ggTW9iaWxlLCBJbmMuCiAgKgogICogVGhp cyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdhcmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9v cgpAQCAtNjA0LDExICs2MDQsNiBAQCBDU3RyaW5nIFN0cmluZzo6YXNjaWkoKSBjb25zdAogCiAg ICAgdW5zaWduZWQgbGVuZ3RoID0gdGhpcy0+bGVuZ3RoKCk7CiAKLSAgICBpZiAoIWxlbmd0aCkg ewotICAgICAgICBjaGFyKiBjaGFyYWN0ZXJCdWZmZXI7Ci0gICAgICAgIHJldHVybiBDU3RyaW5n OjpuZXdVbmluaXRpYWxpemVkKGxlbmd0aCwgY2hhcmFjdGVyQnVmZmVyKTsKLSAgICB9Ci0KICAg ICBpZiAodGhpcy0+aXM4Qml0KCkpIHsKICAgICAgICAgY29uc3QgTENoYXIqIGNoYXJhY3RlcnMg PSB0aGlzLT5jaGFyYWN0ZXJzOCgpOwogCkBAIC02NDksNyArNjQ0LDcgQEAgQ1N0cmluZyBTdHJp bmc6OmxhdGluMSgpIGNvbnN0CiAgICAgaWYgKGlzOEJpdCgpKQogICAgICAgICByZXR1cm4gQ1N0 cmluZyhyZWludGVycHJldF9jYXN0PGNvbnN0IGNoYXIqPih0aGlzLT5jaGFyYWN0ZXJzOCgpKSwg bGVuZ3RoKTsKIAotICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzID0gdGhpcy0+Y2hhcmFjdGVy cygpOworICAgIGNvbnN0IFVDaGFyKiBjaGFyYWN0ZXJzID0gdGhpcy0+Y2hhcmFjdGVyczE2KCk7 CiAKICAgICBjaGFyKiBjaGFyYWN0ZXJCdWZmZXI7CiAgICAgQ1N0cmluZyByZXN1bHQgPSBDU3Ry aW5nOjpuZXdVbmluaXRpYWxpemVkKGxlbmd0aCwgY2hhcmFjdGVyQnVmZmVyKTsK