94997 2012-08-24 20:46:40 -0700 REGRESSION: WebProcessProxy destructor is sometimes called recursively 2012-08-24 21:54:50 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P1 Normal --- 1 ap ap webkit.review.bot oldest_to_newest 704642 0 ap 2012-08-24 20:46:40 -0700 We're seeing sees this crash, which is obviously caused by my recent change to keep a vector of WebProcessProxies in a context: 3 com.apple.WebKit2 0x000000010a26d8b9 WebKit::WebProcessProxy::~WebProcessProxy() + 17 4 com.apple.WebKit2 0x000000010a2e95b5 WTF::Vector<WTF::RefPtr<WebKit::WebProcessProxy>, 0ul>::shrink(unsigned long) + 65 5 com.apple.WebKit2 0x000000010a2e9545 WTF::Vector<WTF::RefPtr<WebKit::WebProcessProxy>, 0ul>::~Vector() + 25 6 com.apple.WebKit2 0x000000010a2e5751 WebKit::WebContext::~WebContext() + 17 7 com.apple.WebKit2 0x000000010a34017b WebKit::WebProcessProxy::~WebProcessProxy() + 313 8 com.apple.WebKit2 0x000000010a26d8b9 WebKit::WebProcessProxy::~WebProcessProxy() + 17 9 com.apple.WebKit2 0x000000010a2e7567 WTF::Vector<WTF::RefPtr<WebKit::WebProcessProxy>, 0ul>::remove(unsigned long) + 41 10 com.apple.WebKit2 0x000000010a26d1dc WebKit::WebProcessProxy::disconnect() + 326 <rdar://problem/12157689> 704643 1 160551 ap 2012-08-24 20:51:33 -0700 Created attachment 160551 proposed fix 704649 2 160551 webkit.review.bot 2012-08-24 21:54:47 -0700 Comment on attachment 160551 proposed fix Clearing flags on attachment: 160551 Committed r126679: <http://trac.webkit.org/changeset/126679> 704650 3 webkit.review.bot 2012-08-24 21:54:50 -0700 All reviewed patches have been landed. Closing bug. 160551 2012-08-24 20:51:33 -0700 2012-08-24 21:54:47 -0700 proposed fix RecursiveDestruction.txt text/plain 1744 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNjY3OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTI0ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x MjE1NzY4OT4gUkVHUkVTU0lPTjogV2ViUHJvY2Vzc1Byb3h5IGRlc3RydWN0b3IgaXMgc29tZXRp bWVzIGNhbGxlZCByZWN1cnNpdmVseQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTQ5OTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJDb250ZXh0LmNwcDogKFdlYktpdDo6V2ViQ29u dGV4dDo6ZGlzY29ubmVjdFByb2Nlc3MpOiBNYWtlIHN1cmUgdGhhdAorICAgICAgICB3ZSBkb24n dCB0cnkgdG8gZGVsZXRlIFdlYlByb2Nlc3NQcm94eSB3aGlsZSB0aGUgdmVjdG9yIHN0aWxsIGNv bnRhaW5zIGl0LiBQcmV2aW91c2x5LAorICAgICAgICB3ZSB1c2VkIFJlZlB0cjo6Y2xlYXIsIHdo aWNoIHplcm9lcyBvdXQgdGhlIHZhbHVlIGJlZm9yZSBkZXN0cnVjdGluZywgYnV0IGRvaW5nIHRo YXQKKyAgICAgICAgaW4gZXZlcnkgUmVmUHRyIGRlc3RydWN0b3Igd291bGQgYmUgYmFkIGZvciBw ZXJmb3JtYW5jZS4KKwogMjAxMi0wOC0yNCAgQmVuamFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFw cGxlLmNvbT4KIAogICAgICAgICBVbmlmeSBOdW1iZXIgdG8gU3RyaW5nSW1wbCBjb252ZXJzaW9u CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkNvbnRleHQuY3BwCShyZXZpc2lvbiAx MjYzOTIpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViQ29udGV4dC5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQ1Nyw3ICs0NTcsMTAgQEAgdm9pZCBXZWJDb250ZXh0OjpkaXNjb25uZWN0 UHJvY2VzcyhXZWJQcgogICAgIG1fcGx1Z2luU2l0ZURhdGFNYW5hZ2VyLT5pbnZhbGlkYXRlKCk7 CiAjZW5kaWYKIAotICAgIC8vIFRoaXMgY2FuIGNhdXNlIHRoZSB3ZWIgY29udGV4dCB0byBiZSBk ZXN0cm95ZWQuCisgICAgLy8gVGhlIHZlY3RvciBtYXkgaGF2ZSB0aGUgbGFzdCByZWZlcmVuY2Ug dG8gcHJvY2VzcyBwcm94eSwgd2hpY2ggaW4gdHVybiBtYXkgaGF2ZSB0aGUgbGFzdCByZWZlcmVu Y2UgdG8gdGhlIGNvbnRleHQuCisgICAgLy8gU2luY2UgdmVjdG9yIGVsZW1lbnRzIGFyZSBkZXN0 cm95ZWQgaW4gcGxhY2UsIHdlIHdvdWxkIHJlY3Vyc2UgaW50byBXZWJQcm9jZXNzUHJveHkgZGVz dHJ1Y3RvcgorICAgIC8vIGlmIGl0IHdlcmUgaW52b2tlZCBmcm9tIFZlY3Rvcjo6cmVtb3ZlKCku IFJlZlB0ciBkZWxheXMgZGVzdHJ1Y3Rpb24gdW50aWwgaXQncyBzYWZlLgorICAgIFJlZlB0cjxX ZWJQcm9jZXNzUHJveHk+IHByb3RlY3QocHJvY2Vzcyk7CiAgICAgbV9wcm9jZXNzZXMucmVtb3Zl KG1fcHJvY2Vzc2VzLmZpbmQocHJvY2VzcykpOwogfQogCg==