94995 2012-08-24 18:22:18 -0700 [chromium] CCThreadImpl / WebCompositorImpl shouldn't compile from webkit when use_libcc_for_compositor=1 2012-08-29 10:58:41 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95211 95214 1 jamesr jamesr abarth dpranke enne fishd webkit.review.bot oldest_to_newest 704597 0 jamesr 2012-08-24 18:22:18 -0700 [chromium] Put CCThreadImpl / WebCompositorImpl in webcore_chromium_compositor_files gyp section 704598 1 160538 jamesr 2012-08-24 18:22:48 -0700 Created attachment 160538 Patch 705387 2 160538 enne 2012-08-27 10:48:18 -0700 Comment on attachment 160538 Patch Should these files be moved too, for consistency? It looks like everything in platform/chromium/support goes into webcore_platform_support_files except for these. 705405 3 jamesr 2012-08-27 11:03:17 -0700 Probably wouldn't hurt but wouldn't help too much either - they're getting nuked pretty soon. 705560 4 160538 enne 2012-08-27 13:12:06 -0700 Comment on attachment 160538 Patch R=me. If they're just going to go away soon, then not moving them sounds reasonable. 705824 5 160538 webkit.review.bot 2012-08-27 16:01:09 -0700 Comment on attachment 160538 Patch Clearing flags on attachment: 160538 Committed r126813: <http://trac.webkit.org/changeset/126813> 705825 6 webkit.review.bot 2012-08-27 16:01:12 -0700 All reviewed patches have been landed. Closing bug. 706440 7 webkit.review.bot 2012-08-28 09:47:35 -0700 Re-opened since this is blocked by 95211 706612 8 jamesr 2012-08-28 12:27:26 -0700 With use_libcc_for_compositor==0, I need to link WebCompositorImpl directly into the 'webkit' target along with the other webcore_platform_support_files. Not sure how cr-linux is green on this. 707121 9 161141 jamesr 2012-08-28 23:17:14 -0700 Created attachment 161141 Patch 707122 10 jamesr 2012-08-28 23:17:44 -0700 More direct - this just excludes those files from the 'webkit' target. Trybots are much happier with this. 707540 11 161141 abarth 2012-08-29 09:47:25 -0700 Comment on attachment 161141 Patch ok 707643 12 jamesr 2012-08-29 10:58:41 -0700 Committed r127020: <http://trac.webkit.org/changeset/127020> 160538 2012-08-24 18:22:48 -0700 2012-08-28 23:17:11 -0700 Patch bug-94995-20120824182243.patch text/plain 2637 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDIyMjAyNjY4MzFhYjk4 ZTVmYzQzNjMyN2M1MTQ4MWE2MDAxZDI2YS4uNWNhODQ0ZjdjNzgxZmZjYWIyZTYyOGIyNDRmNjZm ZjY0YjU4MGY4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA4LTI0ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBQ dXQgQ0NUaHJlYWRJbXBsIC8gV2ViQ29tcG9zaXRvckltcGwgaW4gd2ViY29yZV9jaHJvbWl1bV9j b21wb3NpdG9yX2ZpbGVzIGd5cCBzZWN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NDk5NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZXNlIG5lZWQgdG8gYmUgY29udHJvbGxhYmxlIGJ5IHVzZV9s aWJjY19mb3JfY29tcG9zaXRvcgorCisgICAgICAgICogV2ViQ29yZS5neXBpOgorCiAyMDEyLTA4 LTIzICBKYW1lcyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2No cm9taXVtXSBDb252ZXJ0IFdlYkxheWVyVHJlZVZpZXcgaW50ZXJmYWNlIGludG8gcHVyZSB2aXJ0 dWFsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkgYi9Tb3VyY2UvV2Vi Q29yZS9XZWJDb3JlLmd5cGkKaW5kZXggMDIyYWE4MTU3NDNlMWExMTM3OTI3OGE0M2E0NjNhY2Zj OWY1MDZiZS4uMjljZTAxZmVkOTkzMTFjM2E4MGI1ZWM3NmMxNTkzYzU0ZTQ4MjdhYyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCisrKyBiL1NvdXJjZS9XZWJDb3JlL1dl YkNvcmUuZ3lwaQpAQCAtODI5Niw4ICs4Mjk2LDYgQEAKICAgICAgICAgICAgICc8KFBST0RVQ1Rf RElSKS9EZXJpdmVkU291cmNlcy9XZWJDb3JlL1hQYXRoR3JhbW1hci5oJywKICAgICAgICAgXSwK ICAgICAgICAgJ3dlYmNvcmVfcGxhdGZvcm1fc3VwcG9ydF9maWxlcyc6IFsKLSAgICAgICAgICAg ICdwbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L0NDVGhyZWFkSW1wbC5jcHAnLAotICAgICAgICAg ICAgJ3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvQ0NUaHJlYWRJbXBsLmgnLAogICAgICAgICAg ICAgJ3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvRXh0ZW5zaW9uczNEQ2hyb21pdW0uY3BwJywK ICAgICAgICAgICAgICdwbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L0dyYXBoaWNzQ29udGV4dDNE Q2hyb21pdW0uY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L0dy YXBoaWNzQ29udGV4dDNEUHJpdmF0ZS5jcHAnLApAQCAtODMwNSw4ICs4MzAzLDYgQEAKICAgICAg ICAgICAgICdwbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1BsYXRmb3JtR2VzdHVyZUN1cnZlRmFj dG9yeS5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvUGxhdGZv cm1HZXN0dXJlQ3VydmVGYWN0b3J5LmgnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2Nocm9taXVt L3N1cHBvcnQvV2ViQXVkaW9CdXMuY3BwJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS9jaHJvbWl1 bS9zdXBwb3J0L1dlYkNvbXBvc2l0b3JJbXBsLmNwcCcsCi0gICAgICAgICAgICAncGxhdGZvcm0v Y2hyb21pdW0vc3VwcG9ydC9XZWJDb21wb3NpdG9ySW1wbC5oJywKICAgICAgICAgICAgICdwbGF0 Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYkRhdGEuY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9y bS9jaHJvbWl1bS9zdXBwb3J0L1dlYkZsaW5nQW5pbWF0b3JUb0dlc3R1cmVDdXJ2ZUFkYXB0ZXIu aCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9XZWJIVFRQQm9keS5j cHAnLApAQCAtODMzNiw2ICs4MzMyLDEwIEBACiAgICAgICAgICAgICAncGxhdGZvcm0vY2hyb21p dW0vc3VwcG9ydC9XcmFwcGVkUmVzb3VyY2VSZXNwb25zZS5oJywKICAgICAgICAgXSwKICAgICAg ICAgJ3dlYmNvcmVfY2hyb21pdW1fY29tcG9zaXRvcl9maWxlcyc6IFsKKyAgICAgICAgICAgICdw bGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L0NDVGhyZWFkSW1wbC5jcHAnLAorICAgICAgICAgICAg J3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvQ0NUaHJlYWRJbXBsLmgnLAorICAgICAgICAgICAg J3BsYXRmb3JtL2Nocm9taXVtL3N1cHBvcnQvV2ViQ29tcG9zaXRvckltcGwuY3BwJywKKyAgICAg ICAgICAgICdwbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYkNvbXBvc2l0b3JJbXBsLmgnLAog ICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0JpdG1hcENhbnZhc0xheWVy VGV4dHVyZVVwZGF0ZXIuY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9CaXRtYXBDYW52YXNMYXllclRleHR1cmVVcGRhdGVyLmgnLAogICAgICAgICAgICAgJ3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0JpdG1hcFNrUGljdHVyZUNhbnZhc0xheWVyVGV4dHVy ZVVwZGF0ZXIuY3BwJywK 161141 2012-08-28 23:17:14 -0700 2012-08-29 09:47:25 -0700 Patch bug-94995-20120828231705.patch text/plain 1725 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDBhYjI3OGI1NWI0NjVhYTA5ZDcyYjNlYzA4MTg3MGE1MDE0ODZjZWYuLmRlYTBhMThmYjNhZWFm MTlmYzQ3MTcyMGI4ZWRlODRlZTBlNjUwZmYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTIgQEAKKzIwMTItMDgtMjggIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9t aXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIENDVGhyZWFkSW1wbCAvIFdlYkNvbXBvc2l0 b3JJbXBsIHNob3VsZG4ndCBjb21waWxlIGZyb20gd2Via2l0IHdoZW4gdXNlX2xpYmNjX2Zvcl9j b21wb3NpdG9yPTEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk0OTk1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBXZWJLaXQuZ3lwOgorCiAyMDEyLTA4LTI4ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgRml4IEFTU0VSVCBpbiBmYXN0L2V2ZW50cy90b3VjaC9nZXN0dXJl L2NvbnRleHQtbWVudS1vbi10d28tZmluZ2VyLXRhcC5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktp dC5neXAKaW5kZXggOWNiMGVhNjUwZjQ2ZmNmZDRjNGE4YjVjOTYzNDMyYTRiYmE0ZjVlMy4uNDAz NzFjNDQzYTJkNzNjNjk0OWFjYjMyNmJhYWY1MDNmM2QwYzYxZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v V2ViS2l0Lmd5cApAQCAtODM2LDYgKzgzNiwxMiBAQAogICAgICAgICAgICAgICAgICAgICAnZGVw ZW5kZW5jaWVzJzogWwogICAgICAgICAgICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rp cikvd2Via2l0L2NvbXBvc2l0b3IvY29tcG9zaXRvci5neXA6d2Via2l0X2NvbXBvc2l0b3InLAog ICAgICAgICAgICAgICAgICAgICBdLAorICAgICAgICAgICAgICAgICAgICAnc291cmNlcyEnOiBb CisgICAgICAgICAgICAgICAgICAgICAgICAnLi4vLi4vV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1 bS9zdXBwb3J0L0NDVGhyZWFkSW1wbC5jcHAnLAorICAgICAgICAgICAgICAgICAgICAgICAgJy4u Ly4uL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vc3VwcG9ydC9DQ1RocmVhZEltcGwuaCcsCisg ICAgICAgICAgICAgICAgICAgICAgICAnLi4vLi4vV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9z dXBwb3J0L1dlYkNvbXBvc2l0b3JJbXBsLmNwcCcsCisgICAgICAgICAgICAgICAgICAgICAgICAn Li4vLi4vV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9zdXBwb3J0L1dlYkNvbXBvc2l0b3JJbXBs LmgnLAorICAgICAgICAgICAgICAgICAgICBdLAogICAgICAgICAgICAgICAgIH0sIHsgIyBlbHNl OiB1c2VfbGliY2NfZm9yX2NvbXBvc2l0b3I9PTAKICAgICAgICAgICAgICAgICAgICAgJ3NvdXJj ZXMnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAnPEAod2Via2l0X2NvbXBvc2l0b3JfYmlu ZGluZ3NfZmlsZXMpJywK