9498 2006-06-18 15:34:34 -0700 Remove dead code left in JSHTMLDocument::getOwnPropertySlot() from r14298 (Bug 7838) 2006-06-18 16:50:30 -0700 1 1 1 Unclassified WebKit JavaScriptCore 420+ Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 ddkilzer webkit-unassigned andersca darin ggaren oldest_to_newest 46190 0 ddkilzer 2006-06-18 15:34:34 -0700 While attempting to fix Bug 9179, I noticed that JSHTMLDocument::getOwnPropertySlot() contained some code that could never be reached. The patch I will attach removes it, although I'm not sure if this was the desired result of the original fix for Bug 7838. 46191 1 8910 ddkilzer 2006-06-18 15:37:06 -0700 Created attachment 8910 Patch v1 Removes dead code from JSHTMLDocument::getOwnPropertySlot(). Again, I'm not sure if this was the original intent of the change to this method in for Bug 7838 in r14298. 46194 2 8910 darin 2006-06-18 16:39:49 -0700 Comment on attachment 8910 Patch v1 r=me 46200 3 ddkilzer 2006-06-18 16:50:30 -0700 Committed revision 14908. 8910 2006-06-18 15:37:06 -0700 2006-06-18 16:39:49 -0700 Patch v1 bug-9498-v1.diff text/plain 1483 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAxNDkwNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDUgKzEsMTUgQEAKIDIwMDYtMDYtMTggIERhdmlkIEtpbHplciAgPGRka2lsemVyQGtpbHpl ci5uZXQ+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cDovL2J1Z3ppbGxhLm9wZW5kYXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05NDk4CisgICAg ICAgIFJlbW92ZSBkZWFkIGNvZGUgbGVmdCBpbiBKU0hUTUxEb2N1bWVudDo6Z2V0T3duUHJvcGVy dHlTbG90KCkgZnJvbSByMTQyOTggKEJ1ZyA3ODM4KQorCisgICAgICAgICogYmluZGluZ3MvanMv a2pzX2h0bWwuY3BwOgorICAgICAgICAoS0pTOjpKU0hUTUxEb2N1bWVudDo6Z2V0T3duUHJvcGVy dHlTbG90KTogUmVtb3ZlIGRlYWQgY29kZS4KKworMjAwNi0wNi0xOCAgRGF2aWQgS2lsemVyICA8 ZGRraWx6ZXJAa2lsemVyLm5ldD4KKwogICAgICAgICBSZXZpZXdlZCBieSBnZ2FyZW4uCiAKICAg ICAgICAgKiBtYW51YWwtdGVzdHMvcmVkcmF3LXBhZ2UtY2FjaGUtdmlzaXRlZC1saW5rcy5odG1s OiBDaGFuZ2VkIHRvIHVzZSBET00gbW91c2UgZXZlbnQuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdz L2pzL2tqc19odG1sLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL2pzL2tqc19o dG1sLmNwcAkocmV2aXNpb24gMTQ5MDYpCisrKyBXZWJDb3JlL2JpbmRpbmdzL2pzL2tqc19odG1s LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzIzLDE0ICszMjMsNiBAQCBib29sIEpTSFRNTERvY3Vt ZW50OjpnZXRPd25Qcm9wZXJ0eVNsb3QoCiAgIH0KIAogICByZXR1cm4gZ2V0U3RhdGljVmFsdWVT bG90PEpTSFRNTERvY3VtZW50LCBKU0RvY3VtZW50PihleGVjLCAmSFRNTERvY3VtZW50VGFibGUs IHRoaXMsIHByb3BlcnR5TmFtZSwgc2xvdCk7Ci0KLSAgY29uc3QgSGFzaEVudHJ5KiBlbnRyeSA9 IExvb2t1cDo6ZmluZEVudHJ5KCZIVE1MRG9jdW1lbnRUYWJsZSwgcHJvcGVydHlOYW1lKTsKLSAg aWYgKGVudHJ5KSB7Ci0gICAgc2xvdC5zZXRTdGF0aWNFbnRyeSh0aGlzLCBlbnRyeSwgc3RhdGlj VmFsdWVHZXR0ZXI8SlNIVE1MRG9jdW1lbnQ+KTsKLSAgICByZXR1cm4gdHJ1ZTsKLSAgfQotCi0g IHJldHVybiBKU0RvY3VtZW50OjpnZXRPd25Qcm9wZXJ0eVNsb3QoZXhlYywgcHJvcGVydHlOYW1l LCBzbG90KTsKIH0KIAogdm9pZCBKU0hUTUxEb2N1bWVudDo6cHV0KEV4ZWNTdGF0ZSogZXhlYywg Y29uc3QgSWRlbnRpZmllciAmcHJvcGVydHlOYW1lLCBKU1ZhbHVlICp2YWx1ZSwgaW50IGF0dHIp Cg==