94968 2012-08-24 12:54:33 -0700 Always null check cells before marking 2012-08-26 12:39:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 oliver oliver oldest_to_newest 704364 0 oliver 2012-08-24 12:54:33 -0700 Always null check cells before marking 704368 1 160484 oliver 2012-08-24 12:58:10 -0700 Created attachment 160484 Patch 704411 2 160498 oliver 2012-08-24 14:01:13 -0700 Created attachment 160498 Patch 704414 3 160498 ggaren 2012-08-24 14:13:11 -0700 Comment on attachment 160498 Patch r=me 704416 4 oliver 2012-08-24 14:23:21 -0700 Committed r126624: <http://trac.webkit.org/changeset/126624> 704875 5 oliver 2012-08-26 12:39:40 -0700 <rdar://problem/12176692> 160484 2012-08-24 12:58:10 -0700 2012-08-24 14:01:12 -0700 Patch bug-94968-20120824125805.patch text/plain 3372 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk YjliMjQ0ZmEzN2U2ZTkyZWYyZDE1Mjg0NjY1MjU5YjQ3ZGVhZDI1Li44Nzg2NDkwNTc1M2RiNWY0 OGI3ODBkNWJhNzhhNWNmYTEyNzg4YWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxMi0wOC0yNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFsd2F5cyBudWxsIGNoZWNrIGNlbGxzIGJlZm9yZSBtYXJraW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDk2OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9yaWdpbmFsbHkgd2UgdHJp ZWQgdG8gbWluaW1pc2UgbnVsbCBjaGVja3MgYnkgb25seSBudWxsIGNoZWNraW5nIHZhbHVlcwor ICAgICAgICB0aGF0IHdlIGtuZXcgY291bGQgYmUgbnVsbCwgaG93ZXZlciBnaXZlbiB0aGF0IHdl IGNhbid0IGV2ZXIgZ3VhcmFudGVlCisgICAgICAgIHdoZW4gYSBHQyB3aWxsIGhhcHBlbiwgd2Un cmUgYmV0dGVyIG9mZiBqdXN0IGFsd2F5cyBhc3N1bWluZyB0aGF0IGEgbnVsbAorICAgICAgICBj aGVjayB3aWxsIGJlIG5lY2Vzc2FyeS4gIFRoaXMgcmVzdWx0cyBpbiBhIG11Y2ggbGVzcyBmcmFn aWxlIGNvZGUgYmFzZQorICAgICAgICBhcyB3ZSBjYW4gYWRkIEdDIGFsbG9jYXRpb25zIHRvIG9i amVjdCBpbml0aWFsaXNlcnMgd2l0aG91dCBoYXZpbmcgdG8KKyAgICAgICAgc3Vic2VxdWVudGx5 IHdvcnJ5IGFib3V0IHdoZXRoZXIgdGhlIG9iamVjdCB3ZSBhcmUgaW5pdGlhbGlzaW5nIHdpbGwg bmVlZAorICAgICAgICB0byBhZGQgYSBidW5jaCBvZiBudWxsIGNoZWNrcyBpbiBpdHMgdmlzaXRD aGlsZHJlbiBpbXBsZW1lbnRhdGlvbi4KKworICAgICAgICAqIGhlYXAvTWFya1N0YWNrLmNwcDoK KyAgICAgICAgKEpTQzo6TWFya1N0YWNrOjppbnRlcm5hbEFwcGVuZCk6CisgICAgICAgICogaGVh cC9NYXJrU3RhY2tJbmxpbmVNZXRob2RzLmg6CisgICAgICAgIChKU0M6Ok1hcmtTdGFjazo6YXBw ZW5kKToKKyAgICAgICAgKEpTQzo6TWFya1N0YWNrOjphcHBlbmRVbmJhcnJpZXJlZFBvaW50ZXIp OgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmg6CisgICAgICAgIChKU0M6Ok1hcmtTdGFj azo6aW50ZXJuYWxBcHBlbmQpOgorCiAyMDEyLTA4LTIzICBPbGl2ZXIgSHVudCAgPG9saXZlckBh cHBsZS5jb20+CiAKICAgICAgICAgQXV0b2dlbmVyYXRlIE9wY29kZSBkZWZpbml0aW9ucwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya1N0YWNrLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtTdGFjay5jcHAKaW5kZXggOWQzMDYyMTU0OTlkN2Y4 NjViMjRkMzU3NGUyMWYyOWI4OTI1NWQzYS4uYjMxMzY2NDNiNGVkYjc4ZjFhZjExNTNjNzk1ZWMy MzEwMTRjOTU4ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya1N0 YWNrLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2suY3BwCkBA IC01MjMsNiArNTIzLDggQEAgQUxXQVlTX0lOTElORSB2b2lkIE1hcmtTdGFjazo6aW50ZXJuYWxB cHBlbmQoSlNWYWx1ZSogc2xvdCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgSlNDZWxsKiBjZWxs ID0gdmFsdWUuYXNDZWxsKCk7CisgICAgaWYgKCFjZWxsKQorICAgICAgICByZXR1cm47CiAKICAg ICBpZiAobV9zaG91bGRIYXNoQ29uc3QgJiYgY2VsbC0+aXNTdHJpbmcoKSkgewogICAgICAgICBK U1N0cmluZyogc3RyaW5nID0ganNDYXN0PEpTU3RyaW5nKj4oY2VsbCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2tJbmxpbmVNZXRob2RzLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2tJbmxpbmVNZXRob2RzLmgKaW5kZXggOGI0 MjBkNjM3MGUxNDc2MDRiNzI4ZDA3OTU0ZWExMjgwOTVhNDBlNi4uOWJjZDc1OTIwYmYxNzk3MWFi Y2FjOWU1NGQxZWFiMzYyNDA0MTIxYiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvTWFya1N0YWNrSW5saW5lTWV0aG9kcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL01hcmtTdGFja0lubGluZU1ldGhvZHMuaApAQCAtMzUsOCArMzUsNiBAQCBBTFdBWVNf SU5MSU5FIHZvaWQgTWFya1N0YWNrOjphcHBlbmQoSlNWYWx1ZSogc2xvdCwgc2l6ZV90IGNvdW50 KQogewogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgY291bnQ7ICsraSkgewogICAgICAgICBK U1ZhbHVlJiB2YWx1ZSA9IHNsb3RbaV07Ci0gICAgICAgIGlmICghdmFsdWUpCi0gICAgICAgICAg ICBjb250aW51ZTsKICAgICAgICAgaW50ZXJuYWxBcHBlbmQodmFsdWUpOwogICAgIH0KIH0KQEAg LTQ2LDggKzQ0LDcgQEAgaW5saW5lIHZvaWQgTWFya1N0YWNrOjphcHBlbmRVbmJhcnJpZXJlZFBv aW50ZXIoVCoqIHNsb3QpCiB7CiAgICAgQVNTRVJUKHNsb3QpOwogICAgIEpTQ2VsbCogY2VsbCA9 ICpzbG90OwotICAgIGlmIChjZWxsKQotICAgICAgICBpbnRlcm5hbEFwcGVuZChjZWxsKTsKKyAg ICBpbnRlcm5hbEFwcGVuZChjZWxsKTsKIH0KIAogQUxXQVlTX0lOTElORSB2b2lkIE1hcmtTdGFj azo6YXBwZW5kKEpTVmFsdWUqIHNsb3QpCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcnVudGltZS9TdHJ1Y3R1cmUuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0 cnVjdHVyZS5oCmluZGV4IDJiYjAxMDdiNzc2NTYwODFlYTM4NjY4N2IwZjZmNWM4MmEwNmIzMjEu LmUzYTI1YmI4NzFjNTMyN2YxYTcyNWMyNzhmYWVlMGI2NjJiNDhmNzIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL1N0cnVjdHVyZS5oCkBAIC01NjcsNiArNTY3LDggQEAgbmFtZXNw YWNlIEpTQyB7CiAgICAgQUxXQVlTX0lOTElORSB2b2lkIE1hcmtTdGFjazo6aW50ZXJuYWxBcHBl bmQoSlNDZWxsKiBjZWxsKQogICAgIHsKICAgICAgICAgQVNTRVJUKCFtX2lzQ2hlY2tpbmdGb3JE ZWZhdWx0TWFya1Zpb2xhdGlvbik7CisgICAgICAgIGlmICghY2VsbCkKKyAgICAgICAgICAgIHJl dHVybjsKICNpZiBFTkFCTEUoR0NfVkFMSURBVElPTikKICAgICAgICAgdmFsaWRhdGUoY2VsbCk7 CiAjZW5kaWYK 160498 2012-08-24 14:01:13 -0700 2012-08-24 14:13:10 -0700 Patch bug-94968-20120824140109.patch text/plain 3647 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk YjliMjQ0ZmEzN2U2ZTkyZWYyZDE1Mjg0NjY1MjU5YjQ3ZGVhZDI1Li44Nzg2NDkwNTc1M2RiNWY0 OGI3ODBkNWJhNzhhNWNmYTEyNzg4YWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNiBAQAorMjAxMi0wOC0yNCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFsd2F5cyBudWxsIGNoZWNrIGNlbGxzIGJlZm9yZSBtYXJraW5nCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDk2OAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE9yaWdpbmFsbHkgd2UgdHJp ZWQgdG8gbWluaW1pc2UgbnVsbCBjaGVja3MgYnkgb25seSBudWxsIGNoZWNraW5nIHZhbHVlcwor ICAgICAgICB0aGF0IHdlIGtuZXcgY291bGQgYmUgbnVsbCwgaG93ZXZlciBnaXZlbiB0aGF0IHdl IGNhbid0IGV2ZXIgZ3VhcmFudGVlCisgICAgICAgIHdoZW4gYSBHQyB3aWxsIGhhcHBlbiwgd2Un cmUgYmV0dGVyIG9mZiBqdXN0IGFsd2F5cyBhc3N1bWluZyB0aGF0IGEgbnVsbAorICAgICAgICBj aGVjayB3aWxsIGJlIG5lY2Vzc2FyeS4gIFRoaXMgcmVzdWx0cyBpbiBhIG11Y2ggbGVzcyBmcmFn aWxlIGNvZGUgYmFzZQorICAgICAgICBhcyB3ZSBjYW4gYWRkIEdDIGFsbG9jYXRpb25zIHRvIG9i amVjdCBpbml0aWFsaXNlcnMgd2l0aG91dCBoYXZpbmcgdG8KKyAgICAgICAgc3Vic2VxdWVudGx5 IHdvcnJ5IGFib3V0IHdoZXRoZXIgdGhlIG9iamVjdCB3ZSBhcmUgaW5pdGlhbGlzaW5nIHdpbGwg bmVlZAorICAgICAgICB0byBhZGQgYSBidW5jaCBvZiBudWxsIGNoZWNrcyBpbiBpdHMgdmlzaXRD aGlsZHJlbiBpbXBsZW1lbnRhdGlvbi4KKworICAgICAgICAqIGhlYXAvTWFya1N0YWNrLmNwcDoK KyAgICAgICAgKEpTQzo6TWFya1N0YWNrOjppbnRlcm5hbEFwcGVuZCk6CisgICAgICAgICogaGVh cC9NYXJrU3RhY2tJbmxpbmVNZXRob2RzLmg6CisgICAgICAgIChKU0M6Ok1hcmtTdGFjazo6YXBw ZW5kKToKKyAgICAgICAgKEpTQzo6TWFya1N0YWNrOjphcHBlbmRVbmJhcnJpZXJlZFBvaW50ZXIp OgorICAgICAgICAqIHJ1bnRpbWUvU3RydWN0dXJlLmg6CisgICAgICAgIChKU0M6Ok1hcmtTdGFj azo6aW50ZXJuYWxBcHBlbmQpOgorCiAyMDEyLTA4LTIzICBPbGl2ZXIgSHVudCAgPG9saXZlckBh cHBsZS5jb20+CiAKICAgICAgICAgQXV0b2dlbmVyYXRlIE9wY29kZSBkZWZpbml0aW9ucwpkaWZm IC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya1N0YWNrLmNwcCBiL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9oZWFwL01hcmtTdGFjay5jcHAKaW5kZXggOWQzMDYyMTU0OTlkN2Y4 NjViMjRkMzU3NGUyMWYyOWI4OTI1NWQzYS4uYjMxMzY2NDNiNGVkYjc4ZjFhZjExNTNjNzk1ZWMy MzEwMTRjOTU4ZSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2hlYXAvTWFya1N0 YWNrLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2suY3BwCkBA IC01MjMsNiArNTIzLDggQEAgQUxXQVlTX0lOTElORSB2b2lkIE1hcmtTdGFjazo6aW50ZXJuYWxB cHBlbmQoSlNWYWx1ZSogc2xvdCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgSlNDZWxsKiBjZWxs ID0gdmFsdWUuYXNDZWxsKCk7CisgICAgaWYgKCFjZWxsKQorICAgICAgICByZXR1cm47CiAKICAg ICBpZiAobV9zaG91bGRIYXNoQ29uc3QgJiYgY2VsbC0+aXNTdHJpbmcoKSkgewogICAgICAgICBK U1N0cmluZyogc3RyaW5nID0ganNDYXN0PEpTU3RyaW5nKj4oY2VsbCk7CmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2tJbmxpbmVNZXRob2RzLmggYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvaGVhcC9NYXJrU3RhY2tJbmxpbmVNZXRob2RzLmgKaW5kZXggOGI0 MjBkNjM3MGUxNDc2MDRiNzI4ZDA3OTU0ZWExMjgwOTVhNDBlNi4uMDMxZGZmZjM5YWVjZjFkODQ3 MjJhMzUzOThjYzUzYjg1YjllNGYyMCAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L2hlYXAvTWFya1N0YWNrSW5saW5lTWV0aG9kcy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9oZWFwL01hcmtTdGFja0lubGluZU1ldGhvZHMuaApAQCAtMzUsOCArMzUsNiBAQCBBTFdBWVNf SU5MSU5FIHZvaWQgTWFya1N0YWNrOjphcHBlbmQoSlNWYWx1ZSogc2xvdCwgc2l6ZV90IGNvdW50 KQogewogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgY291bnQ7ICsraSkgewogICAgICAgICBK U1ZhbHVlJiB2YWx1ZSA9IHNsb3RbaV07Ci0gICAgICAgIGlmICghdmFsdWUpCi0gICAgICAgICAg ICBjb250aW51ZTsKICAgICAgICAgaW50ZXJuYWxBcHBlbmQodmFsdWUpOwogICAgIH0KIH0KQEAg LTQ2LDggKzQ0LDcgQEAgaW5saW5lIHZvaWQgTWFya1N0YWNrOjphcHBlbmRVbmJhcnJpZXJlZFBv aW50ZXIoVCoqIHNsb3QpCiB7CiAgICAgQVNTRVJUKHNsb3QpOwogICAgIEpTQ2VsbCogY2VsbCA9 ICpzbG90OwotICAgIGlmIChjZWxsKQotICAgICAgICBpbnRlcm5hbEFwcGVuZChjZWxsKTsKKyAg ICBpbnRlcm5hbEFwcGVuZChjZWxsKTsKIH0KIAogQUxXQVlTX0lOTElORSB2b2lkIE1hcmtTdGFj azo6YXBwZW5kKEpTVmFsdWUqIHNsb3QpCkBAIC03MCw4ICs2Nyw3IEBAIEFMV0FZU19JTkxJTkUg dm9pZCBNYXJrU3RhY2s6OmFwcGVuZChKU0NlbGwqKiBzbG90KQogCiBBTFdBWVNfSU5MSU5FIHZv aWQgTWFya1N0YWNrOjppbnRlcm5hbEFwcGVuZChKU1ZhbHVlIHZhbHVlKQogewotICAgIEFTU0VS VCh2YWx1ZSk7Ci0gICAgaWYgKCF2YWx1ZS5pc0NlbGwoKSkKKyAgICBpZiAoIXZhbHVlIHx8ICF2 YWx1ZS5pc0NlbGwoKSkKICAgICAgICAgcmV0dXJuOwogICAgIGludGVybmFsQXBwZW5kKHZhbHVl LmFzQ2VsbCgpKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L1N0cnVjdHVyZS5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgK aW5kZXggMmJiMDEwN2I3NzY1NjA4MWVhMzg2Njg3YjBmNmY1YzgyYTA2YjMyMS4uZTNhMjViYjg3 MWM1MzI3ZjFhNzI1YzI3OGZhZWUwYjY2MmI0OGY3MiAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvU3RydWN0dXJlLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvU3RydWN0dXJlLmgKQEAgLTU2Nyw2ICs1NjcsOCBAQCBuYW1lc3BhY2UgSlNDIHsK ICAgICBBTFdBWVNfSU5MSU5FIHZvaWQgTWFya1N0YWNrOjppbnRlcm5hbEFwcGVuZChKU0NlbGwq IGNlbGwpCiAgICAgewogICAgICAgICBBU1NFUlQoIW1faXNDaGVja2luZ0ZvckRlZmF1bHRNYXJr VmlvbGF0aW9uKTsKKyAgICAgICAgaWYgKCFjZWxsKQorICAgICAgICAgICAgcmV0dXJuOwogI2lm IEVOQUJMRShHQ19WQUxJREFUSU9OKQogICAgICAgICB2YWxpZGF0ZShjZWxsKTsKICNlbmRpZgo=