94963 2012-08-24 11:40:03 -0700 [BlackBerry] Changes resulting from moving network related methods from platform client to platform settings. 2012-08-24 13:21:37 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 parpatel webkit-unassigned mifenton tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 704284 0 parpatel 2012-08-24 11:40:03 -0700 Changes in response to Network related methods moved from class BlackBerryPlatformClient to BlackBerryPlatformSettings in platform respository since these methods are more appropriate in class BlackBerryPlatformSettings. 704322 1 160471 parpatel 2012-08-24 12:12:15 -0700 Created attachment 160471 Patch 704331 2 160471 parpatel 2012-08-24 12:20:34 -0700 Comment on attachment 160471 Patch setting flag cq? as r+ is done 704388 3 160471 webkit.review.bot 2012-08-24 13:21:34 -0700 Comment on attachment 160471 Patch Clearing flags on attachment: 160471 Committed r126617: <http://trac.webkit.org/changeset/126617> 704389 4 webkit.review.bot 2012-08-24 13:21:37 -0700 All reviewed patches have been landed. Closing bug. 160471 2012-08-24 12:12:15 -0700 2012-08-24 13:21:34 -0700 Patch bug-94963-20120824151609.patch text/plain 6456 parpatel U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NjAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGNjMmJlODY2NTRlNjRh NmYzMzk3NmFlZmY1N2RkZmJjOGFmMWViZC4uNGJjNDQ2YmJmMzQ3ZmViNTI5OWY2Y2RkODRhYTEw ZTVmMjQ1NGYwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTI0ICBQYXJ0 aCBQYXRlbCAgPHBhcnBhdGVsQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIENoYW5n ZXMgcmVzdWx0aW5nIGZyb20gbW92aW5nIG5ldHdvcmsgcmVsYXRlZCBtZXRob2RzCisgICAgICAg IGZyb20gcGxhdGZvcm0gY2xpZW50IHRvIHBsYXRmb3JtIHNldHRpbmdzLgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ5NjMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VzIGluIHJlc3BvbnNlIHRv IE5ldHdvcmsgbWV0aG9kcyBtb3ZlZCBmcm9tCisgICAgICAgIGNsYXNzIEJsYWNrQmVycnlQbGF0 Zm9ybUNsaWVudCB0byBjbGFzcyBCbGFja0JlcnJ5UGxhdGZvcm1TZXR0aW5ncworICAgICAgICBp biBwbGF0Zm9ybSByZXBvc2l0b3J5LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyBhcyB0aGVyZSBh cmUgbm8gbG9naWNhbCBtb2RpZmljYXRpb25zLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TmV0d29ya0pv Yjo6c3RvcmVDcmVkZW50aWFscyk6CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9ibGFja2Jl cnJ5L05ldHdvcmtTdGF0ZU5vdGlmaWVyQmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpOZXR3b3JrU3RhdGVOb3RpZmllcjo6TmV0d29ya1N0YXRlTm90aWZpZXIpOgorCiAyMDEyLTA4 LTI0ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBbTmV3IE11bHRp Y29sdW1uXSBQbHVtYmluZyB0byBwcmVwYXJlIGZvciBjb250ZW50cyBwYWludGluZyBhbmQgaGl0 IHRlc3RpbmcgaW1wbGVtZW50YXRpb24uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRl eCBlNWYzN2YwNmYzM2Y0NGM4NjBlMjBkMzJhMzg4NmEzYmFiMDBjYmQ5Li4xN2Q5MDVlNzdmNWVh MDYwY2MxYTkzYzg3YTQ4Y2NlYzhjMTdmNzlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0wOC0yNCAgUGFydGggUGF0ZWwgIDxwYXJwYXRlbEBy aW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBDaGFuZ2VzIHJlc3VsdGluZyBmcm9tIG1v dmluZyBuZXR3b3JrIHJlbGF0ZWQgbWV0aG9kcworICAgICAgICBmcm9tIHBsYXRmb3JtIGNsaWVu dCB0byBwbGF0Zm9ybSBzZXR0aW5ncy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk0OTYzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgQ2hhbmdlcyBpbiByZXNwb25zZSB0byBOZXR3b3JrIG1ldGhvZHMgbW92 ZWQgZnJvbQorICAgICAgICBjbGFzcyBCbGFja0JlcnJ5UGxhdGZvcm1DbGllbnQgdG8gY2xhc3Mg QmxhY2tCZXJyeVBsYXRmb3JtU2V0dGluZ3MKKyAgICAgICAgaW4gcGxhdGZvcm0gcmVwb3NpdG9y eS4KKworICAgICAgICAqIFdlYktpdFN1cHBvcnQvQWJvdXREYXRhLmNwcDoKKyAgICAgICAgKEJs YWNrQmVycnk6OldlYktpdDo6Y2FjaGVQYWdlKToKKwogMjAxMi0wOC0yNCAgQW5kcmV3IExvICA8 YW5sb0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBBbmltYXRpb24gJiBVSSBsYWcg d2hlbiByZW5kZXJpbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvYmxhY2tiZXJyeS9OZXR3b3JrSm9iLmNwcAppbmRleCBiOGM1OWUxMDA3ZWMyMDI5MmY3 NWVjNjJiNTUwYTZmNWZlYmUxNDU4Li43NDE5ODE0ZWJjZTZlNzFmNTAzNzE3ZTk3YWE1YmZmNjY2 MWNmYTg3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2JsYWNr YmVycnkvTmV0d29ya0pvYi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9ibGFja2JlcnJ5L05ldHdvcmtKb2IuY3BwCkBAIC0zNiw3ICszNiw2IEBACiAjaW5jbHVkZSAi UmVzb3VyY2VIYW5kbGVJbnRlcm5hbC5oIgogI2luY2x1ZGUgIlJlc291cmNlUmVxdWVzdC5oIgog Ci0jaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtQ2xpZW50Lmg+CiAjaW5jbHVkZSA8QmxhY2tC ZXJyeVBsYXRmb3JtTG9nLmg+CiAjaW5jbHVkZSA8QmxhY2tCZXJyeVBsYXRmb3JtU2V0dGluZ3Mu aD4KICNpbmNsdWRlIDxMb2NhbGl6ZVJlc291cmNlLmg+CkBAIC04MDEsNyArODAwLDcgQEAgdm9p ZCBOZXR3b3JrSm9iOjpzdG9yZUNyZWRlbnRpYWxzKCkKICAgICBjaGFsbGVuZ2Uuc2V0U3RvcmVk KHRydWUpOwogCiAgICAgaWYgKGNoYWxsZW5nZS5wcm90ZWN0aW9uU3BhY2UoKS5zZXJ2ZXJUeXBl KCkgPT0gUHJvdGVjdGlvblNwYWNlUHJveHlIVFRQKSB7Ci0gICAgICAgIEJsYWNrQmVycnk6OlBs YXRmb3JtOjpDbGllbnQ6OmdldCgpLT5zZXRQcm94eUNyZWRlbnRpYWwoY2hhbGxlbmdlLnByb3Bv c2VkQ3JlZGVudGlhbCgpLnVzZXIoKS51dGY4KCkuZGF0YSgpLAorICAgICAgICBCbGFja0JlcnJ5 OjpQbGF0Zm9ybTo6U2V0dGluZ3M6Omluc3RhbmNlKCktPnNldFByb3h5Q3JlZGVudGlhbChjaGFs bGVuZ2UucHJvcG9zZWRDcmVkZW50aWFsKCkudXNlcigpLnV0ZjgoKS5kYXRhKCksCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg Y2hhbGxlbmdlLnByb3Bvc2VkQ3JlZGVudGlhbCgpLnBhc3N3b3JkKCkudXRmOCgpLmRhdGEoKSk7 CiAgICAgICAgIG1fZnJhbWUtPnBhZ2UoKS0+Y2hyb21lKCktPmNsaWVudCgpLT5wbGF0Zm9ybVBh Z2VDbGllbnQoKS0+c3luY1Byb3h5Q3JlZGVudGlhbChjaGFsbGVuZ2UucHJvcG9zZWRDcmVkZW50 aWFsKCkpOwogICAgIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvYmxhY2tiZXJyeS9OZXR3b3JrU3RhdGVOb3RpZmllckJsYWNrQmVycnkuY3BwIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtTdGF0ZU5vdGlmaWVy QmxhY2tCZXJyeS5jcHAKaW5kZXggNmMyMzgxZWYzZjY0OGE1YjAxNjI5MTU4ZmFjYTYzMDcwMDZk YzkwNy4uZmZiNzFkYzNkZTg0ZTc4M2UxNzk3OTRkMjFhNjNmOWI4YjNiYzE2YyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9ibGFja2JlcnJ5L05ldHdvcmtTdGF0 ZU5vdGlmaWVyQmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9ibGFja2JlcnJ5L05ldHdvcmtTdGF0ZU5vdGlmaWVyQmxhY2tCZXJyeS5jcHAKQEAgLTI3 LDEyICsyNywxMiBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIk5ldHdvcmtTdGF0 ZU5vdGlmaWVyLmgiCiAKLSNpbmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1DbGllbnQuaD4KKyNp bmNsdWRlIDxCbGFja0JlcnJ5UGxhdGZvcm1TZXR0aW5ncy5oPgogCiBuYW1lc3BhY2UgV2ViQ29y ZSB7CiAKIE5ldHdvcmtTdGF0ZU5vdGlmaWVyOjpOZXR3b3JrU3RhdGVOb3RpZmllcigpCi0gICAg OiBtX2lzT25MaW5lKEJsYWNrQmVycnk6OlBsYXRmb3JtOjpDbGllbnQ6OmdldCgpLT5pc05ldHdv cmtBdmFpbGFibGUoKSkKKyAgICA6IG1faXNPbkxpbmUoQmxhY2tCZXJyeTo6UGxhdGZvcm06OlNl dHRpbmdzOjppbnN0YW5jZSgpLT5pc05ldHdvcmtBdmFpbGFibGUoKSkKICAgICAsIG1fbmV0d29y a1N0YXRlQ2hhbmdlZEZ1bmN0aW9uKDApCiB7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9BYm91dERhdGEuY3BwIGIvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvQWJvdXREYXRhLmNwcAppbmRleCBhNjc3MmNjYjUyODk0 Njk5ZDFkNTNiZjIwNmVlNzA4OTZjZjU0NmE4Li43YjdhMWQ1OWFiODU3ODFjMjllYjkyMTllYjM1 NzJjYjY4NzA5M2U0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9BYm91dERhdGEuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJL aXRTdXBwb3J0L0Fib3V0RGF0YS5jcHAKQEAgLTIxLDYgKzIxLDcgQEAKIAogI2luY2x1ZGUgIkFi b3V0VGVtcGxhdGUuaHRtbC5jcHAiCiAjaW5jbHVkZSAiQ1N0cmluZy5oIgorI2luY2x1ZGUgIkNh Y2hlSGVscGVyLmgiCiAjaW5jbHVkZSAiQ29va2llTWFuYWdlci5oIgogI2luY2x1ZGUgIkpTRE9N V2luZG93LmgiCiAjaW5jbHVkZSAiTWVtb3J5Q2FjaGUuaCIKQEAgLTI4LDcgKzI5LDYgQEAKICNp bmNsdWRlICJTdXJmYWNlUG9vbC5oIgogI2luY2x1ZGUgIldlYktpdFZlcnNpb24uaCIKIAotI2lu Y2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybUNsaWVudC5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQ bGF0Zm9ybUxvZy5oPgogI2luY2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybU1lbW9yeS5oPgogI2lu Y2x1ZGUgPEJsYWNrQmVycnlQbGF0Zm9ybVNldHRpbmdzLmg+CkBAIC00NTgsMjMgKzQ1OCwyMyBA QCBzdGF0aWMgU3RyaW5nIGNhY2hlUGFnZShTdHJpbmcgY2FjaGVDb21tYW5kKQogCiAgICAgcmVz dWx0LmFwcGVuZChTdHJpbmcoIjxodG1sPjxoZWFkPjx0aXRsZT5CbGFja0JlcnJ5IEJyb3dzZXIg RGlzayBDYWNoZTwvdGl0bGU+PC9oZWFkPjxib2R5PiIpKTsKIAotICAgIEJsYWNrQmVycnk6OlBs YXRmb3JtOjpDbGllbnQqIGNsaWVudCA9IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpDbGllbnQ6Omdl dCgpOwotICAgIEFTU0VSVChjbGllbnQpOworICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpTZXR0 aW5ncyogc2V0dGluZ3MgPSBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6U2V0dGluZ3M6Omluc3RhbmNl KCk7CisgICAgQVNTRVJUKHNldHRpbmdzKTsKIAogICAgIGlmIChjYWNoZUNvbW1hbmQuaXNFbXB0 eSgpKQotICAgICAgICByZXN1bHQuYXBwZW5kKFN0cmluZyhjbGllbnQtPmdlbmVyYXRlSHRtbEZy YWdtZW50Rm9yQ2FjaGVLZXlzKCkuZGF0YSgpKSk7CisgICAgICAgIHJlc3VsdC5hcHBlbmQoU3Ry aW5nKEJsYWNrQmVycnk6OlBsYXRmb3JtOjpnZW5lcmF0ZUh0bWxGcmFnbWVudEZvckNhY2hlS2V5 cygpLmRhdGEoKSkpOwogICAgIGVsc2UgaWYgKGNhY2hlQ29tbWFuZC5zdGFydHNXaXRoKCI/cXVl cnk9IiwgZmFsc2UpKSB7CiAgICAgICAgIHN0ZDo6c3RyaW5nIGtleShjYWNoZUNvbW1hbmQuc3Vi c3RyaW5nKDcpLnV0ZjgoKS5kYXRhKCkpOyAvLyA3IGlzIGxlbmd0aCBvZiAicXVlcnk9Ii4KICAg ICAgICAgcmVzdWx0LmFwcGVuZChTdHJpbmcoa2V5LmRhdGEoKSkpOwogICAgICAgICByZXN1bHQu YXBwZW5kKFN0cmluZygiPGhyPiIpKTsKLSAgICAgICAgcmVzdWx0LmFwcGVuZChTdHJpbmcoY2xp ZW50LT5nZW5lcmF0ZUh0bWxGcmFnbWVudEZvckNhY2hlSGVhZGVycyhrZXkpLmRhdGEoKSkpOwor ICAgICAgICByZXN1bHQuYXBwZW5kKFN0cmluZyhCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6Z2VuZXJh dGVIdG1sRnJhZ21lbnRGb3JDYWNoZUhlYWRlcnMoa2V5KS5kYXRhKCkpKTsKICAgICB9CiAjaWYg IWRlZmluZWQoUFVCTElDX0JVSUxEKSB8fCAhUFVCTElDX0JVSUxECiAgICAgZWxzZSBpZiAoZXF1 YWxJZ25vcmluZ0Nhc2UoY2FjaGVDb21tYW5kLCAiL2Rpc2FibGUiKSkgewotICAgICAgICBjbGll bnQtPnNldERpc2tDYWNoZUVuYWJsZWQoZmFsc2UpOworICAgICAgICBzZXR0aW5ncy0+c2V0RGlz a0NhY2hlRW5hYmxlZChmYWxzZSk7CiAgICAgICAgIHJlc3VsdC5hcHBlbmQoIkh0dHAgZGlzayBj YWNoZSBpcyBkaXNhYmxlZC4iKTsKICAgICB9IGVsc2UgaWYgKGVxdWFsSWdub3JpbmdDYXNlKGNh Y2hlQ29tbWFuZCwgIi9lbmFibGUiKSkgewotICAgICAgICBjbGllbnQtPnNldERpc2tDYWNoZUVu YWJsZWQodHJ1ZSk7CisgICAgICAgIHNldHRpbmdzLT5zZXREaXNrQ2FjaGVFbmFibGVkKHRydWUp OwogICAgICAgICByZXN1bHQuYXBwZW5kKCJIdHRwIGRpc2sgY2FjaGUgaXMgZW5hYmxlZC4iKTsK ICAgICB9CiAjZW5kaWYK