94962 2012-08-24 11:32:28 -0700 Don't create a new ResourceRequest if delegate returns the same NSURLRequest we passed it 2012-08-25 00:10:07 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psolanki psolanki benjamin psolanki oldest_to_newest 704276 0 psolanki 2012-08-24 11:32:28 -0700 WebFrameLoaderClient::dispatchWillSendRequest does if (implementations->willSendRequestFunc) request = (NSURLRequest *)CallResourceLoadDelegate(implementations->willSendRequestFunc, webView, @selector(webView:resource:willSendRequest:redirectResponse:fromDataS request in this case is a ResourceRequest& that is passed in. This means we always create a new ResourceRequest. This can be wasteful in cases where the client decides to return us the exact same NSURLRequest without modifying it. 704283 1 psolanki 2012-08-24 11:37:32 -0700 <rdar://problem/12163053> 704357 2 160480 psolanki 2012-08-24 12:48:06 -0700 Created attachment 160480 Patch 704362 3 160482 psolanki 2012-08-24 12:52:19 -0700 Created attachment 160482 Patch 704432 4 160482 ggaren 2012-08-24 14:48:33 -0700 Comment on attachment 160482 Patch r=me! 704641 5 psolanki 2012-08-24 20:42:33 -0700 Committed r126678: <http://trac.webkit.org/changeset/126678> 704661 6 benjamin 2012-08-25 00:10:07 -0700 That's great! 160480 2012-08-24 12:48:06 -0700 2012-08-24 12:52:18 -0700 Patch bug-94962-20120824124802.patch text/plain 2582 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZTE1NmY2MWQy ZTRmZDIxNmFmNWRhNjgzNGExMTg3ZDFlZDczMjZmNy4uNDg1YzQ5YTBiMGQ0OTc4MzEzZTJmZTYy MjMyZTQwNjAwYzE1YmQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTA4LTI0ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBE b24ndCBjcmVhdGUgYSBuZXcgUmVzb3VyY2VSZXF1ZXN0IGlmIGRlbGVnYXRlIHJldHVybnMgdGhl IHNhbWUgTlNVUkxSZXF1ZXN0IHdlIHBhc3NlZCBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ5NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgTlNVUkxSZXF1ZXN0IHJldHVybmVkIGZyb20g dGhlIGRlbGVnYXRlIGNhbGxiYWNrIGlzIHRoZSBzYW1lIGFzIHRoZSBvbmUgd2UgcGFzc2VkIHRv CisgICAgICAgIGl0LCB0aGVuIGF2b2lkIGNyZWF0aW5nIGEgbmV3IFJlc291cmNlUmVxdWVzdCBv YmplY3QuIFRoaXMgcmVkdWNlcyB0aGUgbnVtYmVyIG9mIGNhbGxzIHRvCisgICAgICAgIFJlc291 cmNlUmVxdWVzdDo6ZG9VcGRhdGVSZXNvdXJjZVJlcXVlc3QoKS4KKworICAgICAgICAqIFdlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tOgorICAgICAgICAoV2ViRnJhbWVMb2Fk ZXJDbGllbnQ6OmRpc3BhdGNoV2lsbFNlbmRSZXF1ZXN0KToKKwogMjAxMi0wOC0yMyAgTWFyayBI YWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSBiZWhh dmlvciBvZiBNYXNxdWVyYWRlc0FzVW5kZWZpbmVkIHRvIGJldHRlciBhY2NvbW1vZGF0ZSBERkcg Y2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVMb2FkZXJDbGllbnQubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9X ZWJGcmFtZUxvYWRlckNsaWVudC5tbQppbmRleCBmZDE0YmMwMGEzYjY3ZWM5YTE1MzNiNjNkYjg3 NWYxMjQ2YWZjYzBhLi4wYTBjYTNlOTNmZGU1YjY3ODIwZDE3MDA5ZTg3NWY1NGU5ZTVhNDgyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRl ckNsaWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFt ZUxvYWRlckNsaWVudC5tbQpAQCAtMzQ2LDggKzM0NiwxMiBAQCB2b2lkIFdlYkZyYW1lTG9hZGVy Q2xpZW50OjpkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChEb2N1bWVudExvYWRlciogbG9hZGVyLCB1 bnNpZwogICAgIGlmIChyZWRpcmVjdFJlc3BvbnNlLmlzTnVsbCgpKQogICAgICAgICBzdGF0aWNf Y2FzdDxXZWJEb2N1bWVudExvYWRlck1hYyo+KGxvYWRlciktPmluY3JlYXNlTG9hZENvdW50KGlk ZW50aWZpZXIpOwogCisgICAgTlNVUkxSZXF1ZXN0ICpjdXJyZW50VVJMUmVxdWVzdCA9IHJlcXVl c3QubnNVUkxSZXF1ZXN0KCk7CisgICAgTlNVUkxSZXF1ZXN0ICpuZXdVUkxSZXF1ZXN0ID0gY3Vy cmVudFVSTFJlcXVlc3Q7CiAgICAgaWYgKGltcGxlbWVudGF0aW9ucy0+d2lsbFNlbmRSZXF1ZXN0 RnVuYykKLSAgICAgICAgcmVxdWVzdCA9IChOU1VSTFJlcXVlc3QgKilDYWxsUmVzb3VyY2VMb2Fk RGVsZWdhdGUoaW1wbGVtZW50YXRpb25zLT53aWxsU2VuZFJlcXVlc3RGdW5jLCB3ZWJWaWV3LCBA c2VsZWN0b3Iod2ViVmlldzpyZXNvdXJjZTp3aWxsU2VuZFJlcXVlc3Q6cmVkaXJlY3RSZXNwb25z ZTpmcm9tRGF0YVNvdXJjZTopLCBbd2ViVmlldyBfb2JqZWN0Rm9ySWRlbnRpZmllcjppZGVudGlm aWVyXSwgcmVxdWVzdC5uc1VSTFJlcXVlc3QoKSwgcmVkaXJlY3RSZXNwb25zZS5uc1VSTFJlc3Bv bnNlKCksIGRhdGFTb3VyY2UobG9hZGVyKSk7CisgICAgICAgIG5ld1VSTFJlcXVlc3QgPSAoTlNV UkxSZXF1ZXN0ICopQ2FsbFJlc291cmNlTG9hZERlbGVnYXRlKGltcGxlbWVudGF0aW9ucy0+d2ls bFNlbmRSZXF1ZXN0RnVuYywgd2ViVmlldywgQHNlbGVjdG9yKHdlYlZpZXc6cmVzb3VyY2U6d2ls bFNlbmRSZXF1ZXN0OnJlZGlyZWN0UmVzcG9uc2U6ZnJvbURhdGFTb3VyY2U6KSwgW3dlYlZpZXcg X29iamVjdEZvcklkZW50aWZpZXI6aWRlbnRpZmllcl0sIHJlcXVlc3QubnNVUkxSZXF1ZXN0KCks IHJlZGlyZWN0UmVzcG9uc2UubnNVUkxSZXNwb25zZSgpLCBkYXRhU291cmNlKGxvYWRlcikpOwor ICAgIGlmIChuZXdVUkxSZXF1ZXN0ICE9IGN1cnJlbnRVUkxSZXF1ZXN0KQorICAgICAgICByZXF1 ZXN0ID0gbmV3VVJMUmVxdWVzdDsKIH0KIAogYm9vbCBXZWJGcmFtZUxvYWRlckNsaWVudDo6c2hv dWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UoRG9jdW1lbnRMb2FkZXIqIGxvYWRlciwgdW5zaWduZWQg bG9uZyBpZGVudGlmaWVyKQo= 160482 2012-08-24 12:52:19 -0700 2012-08-24 14:48:33 -0700 Patch bug-94962-20120824125215.patch text/plain 2577 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L21h Yy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L21hYy9DaGFuZ2VMb2cKaW5kZXggZTE1NmY2MWQy ZTRmZDIxNmFmNWRhNjgzNGExMTg3ZDFlZDczMjZmNy4uNDg1YzQ5YTBiMGQ0OTc4MzEzZTJmZTYy MjMyZTQwNjAwYzE1YmQzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEy LTA4LTI0ICBQcmF0aWsgU29sYW5raSAgPHBzb2xhbmtpQGFwcGxlLmNvbT4KKworICAgICAgICBE b24ndCBjcmVhdGUgYSBuZXcgUmVzb3VyY2VSZXF1ZXN0IGlmIGRlbGVnYXRlIHJldHVybnMgdGhl IHNhbWUgTlNVUkxSZXF1ZXN0IHdlIHBhc3NlZCBpdAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ5NjIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBJZiB0aGUgTlNVUkxSZXF1ZXN0IHJldHVybmVkIGZyb20g dGhlIGRlbGVnYXRlIGNhbGxiYWNrIGlzIHRoZSBzYW1lIGFzIHRoZSBvbmUgd2UgcGFzc2VkIHRv CisgICAgICAgIGl0LCB0aGVuIGF2b2lkIGNyZWF0aW5nIGEgbmV3IFJlc291cmNlUmVxdWVzdCBv YmplY3QuIFRoaXMgcmVkdWNlcyB0aGUgbnVtYmVyIG9mIGNhbGxzIHRvCisgICAgICAgIFJlc291 cmNlUmVxdWVzdDo6ZG9VcGRhdGVSZXNvdXJjZVJlcXVlc3QoKS4KKworICAgICAgICAqIFdlYkNv cmVTdXBwb3J0L1dlYkZyYW1lTG9hZGVyQ2xpZW50Lm1tOgorICAgICAgICAoV2ViRnJhbWVMb2Fk ZXJDbGllbnQ6OmRpc3BhdGNoV2lsbFNlbmRSZXF1ZXN0KToKKwogMjAxMi0wOC0yMyAgTWFyayBI YWhuZW5iZXJnICA8bWhhaG5lbmJlcmdAYXBwbGUuY29tPgogCiAgICAgICAgIENoYW5nZSBiZWhh dmlvciBvZiBNYXNxdWVyYWRlc0FzVW5kZWZpbmVkIHRvIGJldHRlciBhY2NvbW1vZGF0ZSBERkcg Y2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2Vi RnJhbWVMb2FkZXJDbGllbnQubW0gYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9X ZWJGcmFtZUxvYWRlckNsaWVudC5tbQppbmRleCBmZDE0YmMwMGEzYjY3ZWM5YTE1MzNiNjNkYjg3 NWYxMjQ2YWZjYzBhLi5hZjVjNGFhODMxN2MxOTEzOTNlNDBiMTFmNjI4NDM5NDQwZDRiMWI1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRl ckNsaWVudC5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJGcmFt ZUxvYWRlckNsaWVudC5tbQpAQCAtMzQ2LDggKzM0NiwxMiBAQCB2b2lkIFdlYkZyYW1lTG9hZGVy Q2xpZW50OjpkaXNwYXRjaFdpbGxTZW5kUmVxdWVzdChEb2N1bWVudExvYWRlciogbG9hZGVyLCB1 bnNpZwogICAgIGlmIChyZWRpcmVjdFJlc3BvbnNlLmlzTnVsbCgpKQogICAgICAgICBzdGF0aWNf Y2FzdDxXZWJEb2N1bWVudExvYWRlck1hYyo+KGxvYWRlciktPmluY3JlYXNlTG9hZENvdW50KGlk ZW50aWZpZXIpOwogCisgICAgTlNVUkxSZXF1ZXN0ICpjdXJyZW50VVJMUmVxdWVzdCA9IHJlcXVl c3QubnNVUkxSZXF1ZXN0KCk7CisgICAgTlNVUkxSZXF1ZXN0ICpuZXdVUkxSZXF1ZXN0ID0gY3Vy cmVudFVSTFJlcXVlc3Q7CiAgICAgaWYgKGltcGxlbWVudGF0aW9ucy0+d2lsbFNlbmRSZXF1ZXN0 RnVuYykKLSAgICAgICAgcmVxdWVzdCA9IChOU1VSTFJlcXVlc3QgKilDYWxsUmVzb3VyY2VMb2Fk RGVsZWdhdGUoaW1wbGVtZW50YXRpb25zLT53aWxsU2VuZFJlcXVlc3RGdW5jLCB3ZWJWaWV3LCBA c2VsZWN0b3Iod2ViVmlldzpyZXNvdXJjZTp3aWxsU2VuZFJlcXVlc3Q6cmVkaXJlY3RSZXNwb25z ZTpmcm9tRGF0YVNvdXJjZTopLCBbd2ViVmlldyBfb2JqZWN0Rm9ySWRlbnRpZmllcjppZGVudGlm aWVyXSwgcmVxdWVzdC5uc1VSTFJlcXVlc3QoKSwgcmVkaXJlY3RSZXNwb25zZS5uc1VSTFJlc3Bv bnNlKCksIGRhdGFTb3VyY2UobG9hZGVyKSk7CisgICAgICAgIG5ld1VSTFJlcXVlc3QgPSAoTlNV UkxSZXF1ZXN0ICopQ2FsbFJlc291cmNlTG9hZERlbGVnYXRlKGltcGxlbWVudGF0aW9ucy0+d2ls bFNlbmRSZXF1ZXN0RnVuYywgd2ViVmlldywgQHNlbGVjdG9yKHdlYlZpZXc6cmVzb3VyY2U6d2ls bFNlbmRSZXF1ZXN0OnJlZGlyZWN0UmVzcG9uc2U6ZnJvbURhdGFTb3VyY2U6KSwgW3dlYlZpZXcg X29iamVjdEZvcklkZW50aWZpZXI6aWRlbnRpZmllcl0sIGN1cnJlbnRVUkxSZXF1ZXN0LCByZWRp cmVjdFJlc3BvbnNlLm5zVVJMUmVzcG9uc2UoKSwgZGF0YVNvdXJjZShsb2FkZXIpKTsKKyAgICBp ZiAobmV3VVJMUmVxdWVzdCAhPSBjdXJyZW50VVJMUmVxdWVzdCkKKyAgICAgICAgcmVxdWVzdCA9 IG5ld1VSTFJlcXVlc3Q7CiB9CiAKIGJvb2wgV2ViRnJhbWVMb2FkZXJDbGllbnQ6OnNob3VsZFVz ZUNyZWRlbnRpYWxTdG9yYWdlKERvY3VtZW50TG9hZGVyKiBsb2FkZXIsIHVuc2lnbmVkIGxvbmcg aWRlbnRpZmllcikK