94950 2012-08-24 10:30:46 -0700 Fix a crash in SourceBufferList.remove(). 2012-08-30 09:51:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 acolwell acolwell eric.carlson feature-media-reviews haraken webkit.review.bot oldest_to_newest 704218 0 acolwell 2012-08-24 10:30:46 -0700 Fix a crash in SourceBufferList.remove(). 704225 1 160448 acolwell 2012-08-24 10:40:36 -0700 Created attachment 160448 Patch 704566 2 haraken 2012-08-24 17:43:17 -0700 Could you add a test for your change? 705588 3 160448 eric 2012-08-27 13:23:13 -0700 Comment on attachment 160448 Patch We'll need a test if possible. (Or an explanation in the ChangeLog why testing is impossible/iimpractical.) 706540 4 acolwell 2012-08-28 11:16:03 -0700 Closing in favor of https://bugs.webkit.org/show_bug.cgi?id=95217 Attempting to create a test for this bug exposed a larger problem with the code. 706670 5 acolwell 2012-08-28 13:18:33 -0700 Reopening. eric.carlson@ asked me to keep the fix for this separate from https://bugs.webkit.org/show_bug.cgi?id=95217 708688 6 161486 acolwell 2012-08-30 09:04:13 -0700 Created attachment 161486 Patch 708740 7 161486 webkit.review.bot 2012-08-30 09:51:55 -0700 Comment on attachment 161486 Patch Clearing flags on attachment: 161486 Committed r127153: <http://trac.webkit.org/changeset/127153> 708741 8 webkit.review.bot 2012-08-30 09:51:58 -0700 All reviewed patches have been landed. Closing bug. 160448 2012-08-24 10:40:36 -0700 2012-08-30 09:04:10 -0700 Patch bug-94950-20120824104031.patch text/plain 1866 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmJjN2I4NWMzNzEyOWQ0 MGRkY2JjMTgwYjg4YWY5YWI4MTMzYjQxNC4uMjg1MzM1NzVkZjQ0MzVlNGI2NWVmODIyOWNhYWQx NjBkMzYwZDBmOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTI0ICBBYXJv biBDb2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBhIGNyYXNo IGluIFNvdXJjZUJ1ZmZlckxpc3QucmVtb3ZlKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIElmIGEgU291cmNlQnVmZmVyTGlzdCBvYmplY3QgZ2V0cyBk ZXN0cm95ZWQgYW5kIG5vIG90aGVyIEphdmFTY3JpcHQgY29kZQorICAgICAgICBoYXMgYSByZWZl cmVuY2UgdG8gdGhlIFNvdXJjZUJ1ZmZlciBvYmplY3RzIGluIHRoZSBsaXN0LCBhIGNyYXNoIG9j Y3Vycy4KKyAgICAgICAgVGhpcyBoYXBwZW5zIGJlY2F1c2UgU291cmNlQnVmZmVyTGlzdDo6cmVt b3ZlKCkgY2FsbHMgY2xlYXIoKSBvbiBhbiAKKyAgICAgICAgb2JqZWN0IHRoYXQgaGFzIGJlZW4g ZGVzdHJveWVkIGFzIGEgcmVzdWx0IG9mIGJlaW5nIHJlbW92ZWQgZnJvbSBtX2xpc3QuCisKKyAg ICAgICAgKiBNb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlckxpc3QuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U291cmNlQnVmZmVyTGlzdDo6cmVtb3ZlKTogQ2FsbCBjbGVhcigpIG9uIGJ1 ZmZlciBiZWZvcmUgaXQKKyAgICAgICAgaXMgcmVtb3ZlZCBmcm9tIG1fbGlzdCBzaW5jZSBtX2xp c3QgY291bGQgYmUgaG9sZGluZyB0aGUgbGFzdCByZWZlcmVuY2UuCisKIDIwMTItMDgtMjQgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjY1NDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlckxpc3QuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXJMaXN0LmNwcAppbmRleCBjZTIxM2Q1MTQw MmE4NGZiZGUwY2M5NzZlZjkwODY5MGUzNTY2MjkwLi42NmFiNzQ4MjAwNWYzMWJmNGRkNDhjOWZi ZjQ1YWFlOWMxMDMzZmYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c291cmNlL1NvdXJjZUJ1ZmZlckxpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzb3VyY2UvU291cmNlQnVmZmVyTGlzdC5jcHAKQEAgLTYzLDEzICs2MywxMyBAQCB2b2lk IFNvdXJjZUJ1ZmZlckxpc3Q6OmFkZChQYXNzUmVmUHRyPFNvdXJjZUJ1ZmZlcj4gYnVmZmVyKQog fQogCiBib29sIFNvdXJjZUJ1ZmZlckxpc3Q6OnJlbW92ZShTb3VyY2VCdWZmZXIqIGJ1ZmZlcikK LXsgICAgCit7CiAgICAgc2l6ZV90IGluZGV4ID0gbV9saXN0LmZpbmQoYnVmZmVyKTsKICAgICBp ZiAoaW5kZXggPT0gbm90Rm91bmQpCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAotICAgIG1fbGlz dC5yZW1vdmUoaW5kZXgpOwogICAgIGJ1ZmZlci0+Y2xlYXIoKTsKKyAgICBtX2xpc3QucmVtb3Zl KGluZGV4KTsKICAgICBjcmVhdGVBbmRGaXJlRXZlbnQoZXZlbnROYW1lcygpLndlYmtpdHJlbW92 ZXNvdXJjZWJ1ZmZlckV2ZW50KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0K 161486 2012-08-30 09:04:13 -0700 2012-08-30 09:51:55 -0700 Patch bug-94950-20120830090402.patch text/plain 5230 acolwell U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3MTQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGY1ODE2MDk5OWI1YzI2 MDhhYTkzMzE2ZDc2MmNmNDMyNzEzNzdmYi4uNjJkZmRjNjFjOWFjNDBkMmIzMDY5ZTU4NDBiM2Zj YzA3MDM1ZWNhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTMwICBBYXJv biBDb2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBhIGNyYXNo IGluIFNvdXJjZUJ1ZmZlckxpc3QucmVtb3ZlKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgU291cmNlQnVmZmVyOjpjbGVhcigpIGNhbGwgYmVm b3JlIHRoZSByZW1vdmFsIG9mIHRoZSBTb3VyY2VCdWZmZXIgZnJvbQorICAgICAgICBTb3VyY2VC dWZmZXJMaXN0OjptX2xpc3QgdG8gYXZvaWQgYSB1c2UgYWZ0ZXIgZnJlZSBpZiBtX2xpc3QgaG9s ZHMgdGhlIGxhc3QKKyAgICAgICAgcmVmZXJlbmNlLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVz dHMvbWVkaWEvbWVkaWEtc291cmNlL3ZpZGVvLW1lZGlhLXNvdXJjZS1zb3VyY2VidWZmZXJsaXN0 LWNyYXNoLmh0bWwKKworICAgICAgICAqIE1vZHVsZXMvbWVkaWFzb3VyY2UvU291cmNlQnVmZmVy TGlzdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VCdWZmZXJMaXN0OjpyZW1vdmUpOgor CiAyMDEyLTA4LTMwICBLZWlzaGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgogCiAgICAg ICAgIFRpY2sgbWFya3MgZG9uJ3QgbWF0Y2ggdGh1bWIgd2hlbiBhcHBseWluZyBwYWRkaW5nIG9y IGJvcmRlciB0byBpbnB1dCB0eXBlPXJhbmdlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9N b2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlckxpc3QuY3BwIGIvU291cmNlL1dlYkNvcmUv TW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZmZXJMaXN0LmNwcAppbmRleCBjNTEzOWNlZWY4 ZjEzY2IzMDE5NTM0YTY4MjkyMDRkNGViMDVmNDA3Li41ODM3MjRiYTE1NTk1ODRiZTUzZjdmZGFj ODlkMzE1MjYwYWM4ODViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlh c291cmNlL1NvdXJjZUJ1ZmZlckxpc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMv bWVkaWFzb3VyY2UvU291cmNlQnVmZmVyTGlzdC5jcHAKQEAgLTcwLDggKzcwLDggQEAgYm9vbCBT b3VyY2VCdWZmZXJMaXN0OjpyZW1vdmUoU291cmNlQnVmZmVyKiBidWZmZXIpCiAgICAgaWYgKGlu ZGV4ID09IG5vdEZvdW5kKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKLSAgICBtX2xpc3QucmVt b3ZlKGluZGV4KTsKICAgICBidWZmZXItPmNsZWFyKCk7CisgICAgbV9saXN0LnJlbW92ZShpbmRl eCk7CiAgICAgY3JlYXRlQW5kRmlyZUV2ZW50KGV2ZW50TmFtZXMoKS53ZWJraXRyZW1vdmVzb3Vy Y2VidWZmZXJFdmVudCk7CiAgICAgcmV0dXJuIHRydWU7CiB9CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggYzMxNGQwNWMwNDJh Zjk0MTQ2YWFkMzBiNjVlYThkMjc2NmM2MGMzYy4uMjBmOTM2Mzk0MTgyMGRmZDdkYzIxMjJmM2Yw NTNlZTkwNDc1NGNiNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xh eW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTMwICBBYXJvbiBD b2x3ZWxsICA8YWNvbHdlbGxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIEZpeCBhIGNyYXNoIGlu IFNvdXJjZUJ1ZmZlckxpc3QucmVtb3ZlKCkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD05NDk1MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgbGF5b3V0IHRlc3QgdG8gdmVyaWZ5IHRoYXQgdGhl IGFwcGxpY2F0aW9uIGRvZXNuJ3QgY3Jhc2ggaWYgYSBTb3VyY2VCdWZmZXJMaXN0IGlzIAorICAg ICAgICBob2xkaW5nIHRoZSBvbmx5IHJlZmVyZW5jZXMgZm9yIGl0cyBTb3VyY2VCdWZmZXIgb2Jq ZWN0cyB3aGVuIGEgTWVkaWFTb3VyY2UgdHJhbnNpdGlvbnMgdG8gImNsb3NlZCIuCisKKyAgICAg ICAgKiBodHRwL3Rlc3RzL21lZGlhL21lZGlhLXNvdXJjZS92aWRlby1tZWRpYS1zb3VyY2Utc291 cmNlYnVmZmVybGlzdC1jcmFzaC1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGh0dHAv dGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL3ZpZGVvLW1lZGlhLXNvdXJjZS1zb3VyY2VidWZmZXJs aXN0LWNyYXNoLmh0bWw6IEFkZGVkLgorCiAyMDEyLTA4LTMwICBLZWlzaGkgSGF0dG9yaSAgPGtl aXNoaUB3ZWJraXQub3JnPgogCiAgICAgICAgIFRpY2sgbWFya3MgZG9uJ3QgbWF0Y2ggdGh1bWIg d2hlbiBhcHBseWluZyBwYWRkaW5nIG9yIGJvcmRlciB0byBpbnB1dCB0eXBlPXJhbmdlCmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21lZGlhL21lZGlhLXNvdXJjZS92aWRlby1t ZWRpYS1zb3VyY2Utc291cmNlYnVmZmVybGlzdC1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRU ZXN0cy9odHRwL3Rlc3RzL21lZGlhL21lZGlhLXNvdXJjZS92aWRlby1tZWRpYS1zb3VyY2Utc291 cmNlYnVmZmVybGlzdC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNzZhMzI3ZDZiYThk YjA1ZTViOWJlYjJiNjE0NjNmOGNjYzU3YWMxNAotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRl c3RzL2h0dHAvdGVzdHMvbWVkaWEvbWVkaWEtc291cmNlL3ZpZGVvLW1lZGlhLXNvdXJjZS1zb3Vy Y2VidWZmZXJsaXN0LWNyYXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDcgQEAKK1ZlcmlmeSB0 aGF0IHdlIGRvbid0IGNyYXNoIG9uIGNsb3NlIGlmIHRoZSBNZWRpYVNvdXJjZS5zb3VyY2VCdWZm ZXJzIGhvbGRzIHRoZSBsYXN0IHJlZmVyZW5jZSB0byBpdHMgU291cmNlQnVmZmVyIG9iamVjdHMu CisKK0NhbGxpbmcgYWRkU291cmNlQnVmZmVyKCkKK1J1bm5pbmcgZ2FyYmFnZSBjb2xsZWN0b3Ig dG8gY2xlYW51cCB0aGUgU291cmNlQnVmZmVyIHJlZmVyZW5jZSByZXR1cm5lZCBieSBhZGRTb3Vy Y2VCdWZmZXIoKQorb25Tb3VyY2VDbG9zZQorRU5EIE9GIFRFU1QKKwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9tZWRpYS9tZWRpYS1zb3VyY2UvdmlkZW8tbWVkaWEtc291cmNl LXNvdXJjZWJ1ZmZlcmxpc3QtY3Jhc2guaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVk aWEvbWVkaWEtc291cmNlL3ZpZGVvLW1lZGlhLXNvdXJjZS1zb3VyY2VidWZmZXJsaXN0LWNyYXNo Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMC4uNGVjYjU2ODhlYTdhZmRkNjc5YTBkYWQ2MjBmODBlZDE5YTI4ZDli NwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbWVkaWEvbWVkaWEt c291cmNlL3ZpZGVvLW1lZGlhLXNvdXJjZS1zb3VyY2VidWZmZXJsaXN0LWNyYXNoLmh0bWwKQEAg LTAsMCArMSw0MSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKyAgICA8aGVhZD4KKyAgICAg ICAgPHNjcmlwdCBzcmM9Ii9tZWRpYS1yZXNvdXJjZXMvdmlkZW8tdGVzdC5qcyI+PC9zY3JpcHQ+ CisgICAgICAgIDxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKyAgICAgICAgICAgIGZ1 bmN0aW9uIG9uU291cmNlT3BlbihlKQorICAgICAgICAgICAgeworICAgICAgICAgICAgICAgIGNv bnNvbGVXcml0ZSgiQ2FsbGluZyBhZGRTb3VyY2VCdWZmZXIoKSIpOworICAgICAgICAgICAgICAg IGUudGFyZ2V0LmFkZFNvdXJjZUJ1ZmZlcigndmlkZW8vd2VibTtjb2RlY3M9InZwOCInKTsKKwor ICAgICAgICAgICAgICAgIGlmICh3aW5kb3cuR0NDb250cm9sbGVyKSB7CisgICAgICAgICAgICAg ICAgICAgIGNvbnNvbGVXcml0ZSgiUnVubmluZyBnYXJiYWdlIGNvbGxlY3RvciB0byBjbGVhbnVw IHRoZSBTb3VyY2VCdWZmZXIgcmVmZXJlbmNlIHJldHVybmVkIGJ5IGFkZFNvdXJjZUJ1ZmZlcigp Iik7CisgICAgICAgICAgICAgICAgICAgIHdpbmRvdy5HQ0NvbnRyb2xsZXIuY29sbGVjdCgpOwor ICAgICAgICAgICAgICAgIH0KKworICAgICAgICAgICAgICAgIGRvY3VtZW50LnF1ZXJ5U2VsZWN0 b3IoJyN2Jykuc3JjID0gIiI7CisgICAgICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9u IG9uU291cmNlQ2xvc2UoZSkKKyAgICAgICAgICAgIHsKKyAgICAgICAgICAgICAgICBjb25zb2xl V3JpdGUoIm9uU291cmNlQ2xvc2UiKTsKKyAgICAgICAgICAgICAgICBlbmRUZXN0KCk7CisgICAg ICAgICAgICB9CisKKyAgICAgICAgICAgIGZ1bmN0aW9uIG1haW4oKQorICAgICAgICAgICAgewor ICAgICAgICAgICAgICAgIHZhciB2aWRlbyA9IGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3IoJyN2Jyk7 CisgICAgICAgICAgICAgICAgdmFyIG1lZGlhU291cmNlID0gbmV3IFdlYktpdE1lZGlhU291cmNl KCk7CisKKyAgICAgICAgICAgICAgICBtZWRpYVNvdXJjZS5hZGRFdmVudExpc3RlbmVyKCd3ZWJr aXRzb3VyY2VvcGVuJywgb25Tb3VyY2VPcGVuKTsKKyAgICAgICAgICAgICAgICBtZWRpYVNvdXJj ZS5hZGRFdmVudExpc3RlbmVyKCd3ZWJraXRzb3VyY2VjbG9zZScsIG9uU291cmNlQ2xvc2UpOwor CisgICAgICAgICAgICAgICAgdmlkZW8uc3JjID0gVVJMLmNyZWF0ZU9iamVjdFVSTChtZWRpYVNv dXJjZSk7CisgICAgICAgICAgICB9CisgICAgICAgIDwvc2NyaXB0PgorICAgIDwvaGVhZD4KKyAg ICA8Ym9keSBvbmxvYWQ9Im1haW4oKSI+CisgICAgICA8dmlkZW8gaWQ9InYiPjwvdmlkZW8+Cisg ICAgICA8cD5WZXJpZnkgdGhhdCB3ZSBkb24ndCBjcmFzaCBvbiBjbG9zZSBpZiB0aGUgTWVkaWFT b3VyY2Uuc291cmNlQnVmZmVycyBob2xkcyB0aGUgbGFzdCByZWZlcmVuY2UgdG8gaXRzIFNvdXJj ZUJ1ZmZlciBvYmplY3RzLjwvcD4KKyAgICA8L2JvZHk+Cis8L2h0bWw+Cg==