94947 2012-08-24 09:44:59 -0700 Web Inspector: do not count weak and shortcut edges when calculating distance to window 2012-08-24 10:10:01 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 yurys loislo apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 704175 0 yurys 2012-08-24 09:44:59 -0700 When calculating distance from an object to Window in heap profiler we should only take into account strong real references. This means that shortcuts and weak edges should be ignored. 704180 1 160439 loislo 2012-08-24 09:48:09 -0700 Created attachment 160439 Patch 704183 2 160439 yurys 2012-08-24 09:58:02 -0700 Comment on attachment 160439 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160439&action=review > Source/WebCore/inspector/front-end/HeapSnapshot.js:958 > + var edgeType = containmentEdges[edgeToNodeIndex - edgeToNodeOffset + edgeTypeOffset]; This looks ugly. Let's iterate over edgeIndexes and add appropriate offsets instead of first adding and then subtracting the offsets. 704189 3 160442 loislo 2012-08-24 10:02:51 -0700 Created attachment 160442 Patch 704193 4 loislo 2012-08-24 10:05:33 -0700 comments addressed 704199 5 loislo 2012-08-24 10:10:01 -0700 Committed r126595: <http://trac.webkit.org/changeset/126595> 160439 2012-08-24 09:48:09 -0700 2012-08-24 10:02:45 -0700 Patch bug-94947-20120824204804.patch text/plain 2592 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQ2YWZkMmU0MDkwMzhk ZGIwYmFkOTE1NzcxNDVlMGIyOGQzNDViYy4uMTA0NTc2ZDdjMjZiNmUzOTA0MmMzZTgwNDJkYzBm NzFjYTE2OTgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTI0ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBkbyBub3QgY291bnQgd2VhayBhbmQgc2hvcnRjdXQgZWRnZXMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDk0NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY2FsY3VsYXRpbmcgZGlzdGFu Y2UgZnJvbSBhbiBvYmplY3QgdG8gV2luZG93IGluIGhlYXAgcHJvZmlsZXIgd2Ugc2hvdWxkIG9u bHkKKyAgICAgICAgdGFrZSBpbnRvIGFjY291bnQgc3Ryb25nIHJlYWwgcmVmZXJlbmNlcy4gVGhp cyBtZWFucyB0aGF0IHNob3J0Y3V0cyBhbmQgd2VhayBlZGdlcyBzaG91bGQgYmUgaWdub3JlZC4K KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUuX2Jmcyk6CisKIDIwMTItMDgt MjQgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAg Q3Jhc2ggaW4gUmVuZGVyVGFibGVDZWxsOjpib3JkZXJUb3AoKSBkdWUgdG8gY3VzdG9tIHNjcm9s bGJhcnMgYWZ0ZXIgcjEyNDE2OApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0hlYXBTbmFwc2hvdC5qcwppbmRleCAwYWQ5M2ZkOWRlN2E2MjkxYzNiNGFiOGQ2ZmU5 ZWYxMzgyZjQ1ZDk0Li4yZDlhNDcyMGJiZTEwNGQ1ZDU2NmQzYzQxMDQ2ODAzNjQ3NzE1ZmY4IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hv dC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hv dC5qcwpAQCAtOTQwLDkgKzk0MCwxMiBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3Rv dHlwZSA9IHsKICAgICAgICAgdmFyIGNvbnRhaW5tZW50RWRnZXMgPSB0aGlzLl9jb250YWlubWVu dEVkZ2VzOwogICAgICAgICB2YXIgZmlyc3RFZGdlSW5kZXhlcyA9IHRoaXMuX2ZpcnN0RWRnZUlu ZGV4ZXM7CiAgICAgICAgIHZhciBlZGdlVG9Ob2RlT2Zmc2V0ID0gdGhpcy5fZWRnZVRvTm9kZU9m ZnNldDsKKyAgICAgICAgdmFyIGVkZ2VUeXBlT2Zmc2V0ID0gdGhpcy5fZWRnZVR5cGVPZmZzZXQ7 CiAgICAgICAgIHZhciBub2RlcyA9IHRoaXMuX25vZGVzOwogICAgICAgICB2YXIgbm9kZUNvdW50 ID0gdGhpcy5ub2RlQ291bnQ7CiAgICAgICAgIHZhciBjb250YWlubWVudEVkZ2VzTGVuZ3RoID0g Y29udGFpbm1lbnRFZGdlcy5sZW5ndGg7CisgICAgICAgIHZhciBlZGdlV2Vha1R5cGUgPSB0aGlz Ll9lZGdlV2Vha1R5cGU7CisgICAgICAgIHZhciBlZGdlU2hvcnRjdXRUeXBlID0gdGhpcy5fZWRn ZVNob3J0Y3V0VHlwZTsKIAogICAgICAgICB2YXIgaW5kZXggPSAwOwogICAgICAgICB3aGlsZSAo aW5kZXggPCBub2Rlc1RvVmlzaXRMZW5ndGgpIHsKQEAgLTk1Miw2ICs5NTUsOSBAQCBXZWJJbnNw ZWN0b3IuSGVhcFNuYXBzaG90LnByb3RvdHlwZSA9IHsKICAgICAgICAgICAgIHZhciBmaXJzdEVk Z2VJbmRleCA9IGZpcnN0RWRnZUluZGV4ZXNbbm9kZU9yZGluYWxdOwogICAgICAgICAgICAgdmFy IGVkZ2VzRW5kID0gZmlyc3RFZGdlSW5kZXhlc1tub2RlT3JkaW5hbCArIDFdOwogICAgICAgICAg ICAgZm9yICh2YXIgZWRnZVRvTm9kZUluZGV4ID0gZmlyc3RFZGdlSW5kZXggKyBlZGdlVG9Ob2Rl T2Zmc2V0OyBlZGdlVG9Ob2RlSW5kZXggPCBlZGdlc0VuZDsgZWRnZVRvTm9kZUluZGV4ICs9IGVk Z2VGaWVsZHNDb3VudCkgeworICAgICAgICAgICAgICAgIHZhciBlZGdlVHlwZSA9IGNvbnRhaW5t ZW50RWRnZXNbZWRnZVRvTm9kZUluZGV4IC0gZWRnZVRvTm9kZU9mZnNldCArIGVkZ2VUeXBlT2Zm c2V0XTsKKyAgICAgICAgICAgICAgICBpZiAoZWRnZVR5cGUgPT0gZWRnZVdlYWtUeXBlIHx8IGVk Z2VUeXBlID09IGVkZ2VTaG9ydGN1dFR5cGUpCisgICAgICAgICAgICAgICAgICAgIGNvbnRpbnVl OwogICAgICAgICAgICAgICAgIHZhciBjaGlsZE5vZGVJbmRleCA9IGNvbnRhaW5tZW50RWRnZXNb ZWRnZVRvTm9kZUluZGV4XTsKICAgICAgICAgICAgICAgICB2YXIgY2hpbGROb2RlT3JkaW5hbCA9 IGNoaWxkTm9kZUluZGV4IC8gbm9kZUZpZWxkQ291bnQ7CiAgICAgICAgICAgICAgICAgaWYgKGRp c3RhbmNlc1tjaGlsZE5vZGVPcmRpbmFsXSkK 160442 2012-08-24 10:02:51 -0700 2012-08-24 10:08:08 -0700 Patch bug-94947-20120824210246.patch text/plain 2845 loislo U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQ2YWZkMmU0MDkwMzhk ZGIwYmFkOTE1NzcxNDVlMGIyOGQzNDViYy4uMTA0NTc2ZDdjMjZiNmUzOTA0MmMzZTgwNDJkYzBm NzFjYTE2OTgxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA4LTI0ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBkbyBub3QgY291bnQgd2VhayBhbmQgc2hvcnRjdXQgZWRnZXMuCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDk0NworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gY2FsY3VsYXRpbmcgZGlzdGFu Y2UgZnJvbSBhbiBvYmplY3QgdG8gV2luZG93IGluIGhlYXAgcHJvZmlsZXIgd2Ugc2hvdWxkIG9u bHkKKyAgICAgICAgdGFrZSBpbnRvIGFjY291bnQgc3Ryb25nIHJlYWwgcmVmZXJlbmNlcy4gVGhp cyBtZWFucyB0aGF0IHNob3J0Y3V0cyBhbmQgd2VhayBlZGdlcyBzaG91bGQgYmUgaWdub3JlZC4K KworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUuX2Jmcyk6CisKIDIwMTItMDgt MjQgIEp1bGllbiBDaGFmZnJhaXggIDxqY2hhZmZyYWl4QHdlYmtpdC5vcmc+CiAKICAgICAgICAg Q3Jhc2ggaW4gUmVuZGVyVGFibGVDZWxsOjpib3JkZXJUb3AoKSBkdWUgdG8gY3VzdG9tIHNjcm9s bGJhcnMgYWZ0ZXIgcjEyNDE2OApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L2Zyb250LWVuZC9IZWFwU25hcHNob3QuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJv bnQtZW5kL0hlYXBTbmFwc2hvdC5qcwppbmRleCAwYWQ5M2ZkOWRlN2E2MjkxYzNiNGFiOGQ2ZmU5 ZWYxMzgyZjQ1ZDk0Li44ZTliOTFkNmM1YjY0NzA1NmM4MTRmMjI2YjlhODI2ZWQ0YTY0MWRiIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hv dC5qcworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0hlYXBTbmFwc2hv dC5qcwpAQCAtOTQwLDkgKzk0MCwxMiBAQCBXZWJJbnNwZWN0b3IuSGVhcFNuYXBzaG90LnByb3Rv dHlwZSA9IHsKICAgICAgICAgdmFyIGNvbnRhaW5tZW50RWRnZXMgPSB0aGlzLl9jb250YWlubWVu dEVkZ2VzOwogICAgICAgICB2YXIgZmlyc3RFZGdlSW5kZXhlcyA9IHRoaXMuX2ZpcnN0RWRnZUlu ZGV4ZXM7CiAgICAgICAgIHZhciBlZGdlVG9Ob2RlT2Zmc2V0ID0gdGhpcy5fZWRnZVRvTm9kZU9m ZnNldDsKKyAgICAgICAgdmFyIGVkZ2VUeXBlT2Zmc2V0ID0gdGhpcy5fZWRnZVR5cGVPZmZzZXQ7 CiAgICAgICAgIHZhciBub2RlcyA9IHRoaXMuX25vZGVzOwogICAgICAgICB2YXIgbm9kZUNvdW50 ID0gdGhpcy5ub2RlQ291bnQ7CiAgICAgICAgIHZhciBjb250YWlubWVudEVkZ2VzTGVuZ3RoID0g Y29udGFpbm1lbnRFZGdlcy5sZW5ndGg7CisgICAgICAgIHZhciBlZGdlV2Vha1R5cGUgPSB0aGlz Ll9lZGdlV2Vha1R5cGU7CisgICAgICAgIHZhciBlZGdlU2hvcnRjdXRUeXBlID0gdGhpcy5fZWRn ZVNob3J0Y3V0VHlwZTsKIAogICAgICAgICB2YXIgaW5kZXggPSAwOwogICAgICAgICB3aGlsZSAo aW5kZXggPCBub2Rlc1RvVmlzaXRMZW5ndGgpIHsKQEAgLTk1MSw4ICs5NTQsMTEgQEAgV2ViSW5z cGVjdG9yLkhlYXBTbmFwc2hvdC5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB2YXIgZGlzdGFu Y2UgPSBkaXN0YW5jZXNbbm9kZU9yZGluYWxdICsgMTsKICAgICAgICAgICAgIHZhciBmaXJzdEVk Z2VJbmRleCA9IGZpcnN0RWRnZUluZGV4ZXNbbm9kZU9yZGluYWxdOwogICAgICAgICAgICAgdmFy IGVkZ2VzRW5kID0gZmlyc3RFZGdlSW5kZXhlc1tub2RlT3JkaW5hbCArIDFdOwotICAgICAgICAg ICAgZm9yICh2YXIgZWRnZVRvTm9kZUluZGV4ID0gZmlyc3RFZGdlSW5kZXggKyBlZGdlVG9Ob2Rl T2Zmc2V0OyBlZGdlVG9Ob2RlSW5kZXggPCBlZGdlc0VuZDsgZWRnZVRvTm9kZUluZGV4ICs9IGVk Z2VGaWVsZHNDb3VudCkgewotICAgICAgICAgICAgICAgIHZhciBjaGlsZE5vZGVJbmRleCA9IGNv bnRhaW5tZW50RWRnZXNbZWRnZVRvTm9kZUluZGV4XTsKKyAgICAgICAgICAgIGZvciAodmFyIGVk Z2VJbmRleCA9IGZpcnN0RWRnZUluZGV4OyBlZGdlSW5kZXggPCBlZGdlc0VuZDsgZWRnZUluZGV4 ICs9IGVkZ2VGaWVsZHNDb3VudCkgeworICAgICAgICAgICAgICAgIHZhciBlZGdlVHlwZSA9IGNv bnRhaW5tZW50RWRnZXNbZWRnZUluZGV4ICsgZWRnZVR5cGVPZmZzZXRdOworICAgICAgICAgICAg ICAgIGlmIChlZGdlVHlwZSA9PSBlZGdlV2Vha1R5cGUgfHwgZWRnZVR5cGUgPT0gZWRnZVNob3J0 Y3V0VHlwZSkKKyAgICAgICAgICAgICAgICAgICAgY29udGludWU7CisgICAgICAgICAgICAgICAg dmFyIGNoaWxkTm9kZUluZGV4ID0gY29udGFpbm1lbnRFZGdlc1tlZGdlSW5kZXggKyBlZGdlVG9O b2RlT2Zmc2V0XTsKICAgICAgICAgICAgICAgICB2YXIgY2hpbGROb2RlT3JkaW5hbCA9IGNoaWxk Tm9kZUluZGV4IC8gbm9kZUZpZWxkQ291bnQ7CiAgICAgICAgICAgICAgICAgaWYgKGRpc3RhbmNl c1tjaGlsZE5vZGVPcmRpbmFsXSkKICAgICAgICAgICAgICAgICAgICAgY29udGludWU7Cg==