94938 2012-08-24 08:11:04 -0700 [BlackBerry] Touch cancel can cause huge and needless invalidations 2012-08-24 08:34:39 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tonikitoo tonikitoo tonikitoo oldest_to_newest 704113 0 tonikitoo 2012-08-24 08:11:04 -0700 PR #198051 In order to remove the possible hover effect on touch_cancel, we always invalidate the node under the fat finger, being the fat finger valid or not. Point is having a valid fat finger node does not mean the original touch position was actually adjust for clicking or that the fat finger is actually valid. We set the fat finger node to be the result of the point-based hit-test regardless if it is a click target or not (in order to make our mouse-move machinery to work). We should can less aggressively invalidate the fat finger node, since it can be rather an expensive call (longer than 1s in the worst scenario). 704125 1 160425 tonikitoo 2012-08-24 08:34:18 -0700 Created attachment 160425 patch https://trac.webkit.org/changeset/126588 160425 2012-08-24 08:34:18 -0700 2012-08-24 08:34:18 -0700 patch 0001-BlackBerry-Touch-cancel-can-cause-huge-and-needless-.patch text/plain 4712 tonikitoo RnJvbSAwNzY3ZjAxZWU5ZjRiYjVkOWEyYjA3OGM5ODMwNjk3MTgxNjc5NWYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiAidG9uaWtpdG9vQHdlYmtpdC5vcmciIDx0b25pa2l0b29Ad2Vi a2l0Lm9yZ0AyNjhmNDVjYy1jZDA5LTA0MTAtYWIzYy1kNTI2OTFiNGRiZmM+CkRhdGU6IEZyaSwg MjQgQXVnIDIwMTIgMTU6MzA6MzkgKzAwMDAKU3ViamVjdDogW1BBVENIXSBbQmxhY2tCZXJyeV0g VG91Y2ggY2FuY2VsIGNhbiBjYXVzZSBodWdlIGFuZCBuZWVkbGVzcwogaW52YWxpZGF0aW9ucyBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ5MzgKIFBSICMxOTgwNTEK ClJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29zLgpQYXRjaCBieSBBbnRvbmlvIEdvbWVzIDxhZ29t ZXNAcmltLmNvbT4KSW50ZXJuYWxseSByZXZpZXdlZCBieSBHZW4gTWFrLgoKSW4gb3JkZXIgdG8g cmVtb3ZlIHRoZSBwb3NzaWJsZSBob3ZlciBlZmZlY3Qgb24gdG91Y2hfY2FuY2VsLCB3ZSBhbHdh eXMKaW52YWxpZGF0ZSB0aGUgbm9kZSB1bmRlciB0aGUgZmF0IGZpbmdlciwgYmVpbmcgdGhlIGZh dCBmaW5nZXIgdmFsaWQgb3Igbm90LgoKUG9pbnQgaXM6IGhhdmluZyBhIHZhbGlkIGZhdCBmaW5n ZXIgbm9kZSBkb2VzIG5vdCBtZWFuIHRoZSBvcmlnaW5hbCB0b3VjaApwb3NpdGlvbiB3YXMgYWN0 dWFsbHkgYWRqdXN0IGZvciBjbGlja2luZyBvciB0aGF0IHRoZSBmYXQgZmluZ2VyIGlzIGFjdHVh bGx5CnZhbGlkLiBXZSBzZXQgdGhlIGZhdCBmaW5nZXIgbm9kZSB0byBiZSB0aGUgcmVzdWx0IG9m IHRoZSBwb2ludC1iYXNlZCBoaXQtdGVzdApyZWdhcmRsZXNzIGlmIGl0IGlzIGEgY2xpY2sgdGFy Z2V0IG9yIG5vdCAoaW4gb3JkZXIgdG8gbWFrZSBvdXIgbW91c2UtbW92ZQptYWNoaW5lcnkgdG8g d29yaykuCgpXZSBzaG91bGQgY2FuIGxlc3MgYWdncmVzc2l2ZWx5IGludmFsaWRhdGUgdGhlIGZh dCBmaW5nZXIgbm9kZSwgc2luY2UgaXQgY2FuCmJlIHJhdGhlciBhbiBleHBlbnNpdmUgY2FsbCAo bG9uZ2VyIHRoYW4gMXMgaW4gdGhlIHdvcnN0IHNjZW5hcmlvKS4KCiogV2ViS2l0U3VwcG9ydC9U b3VjaEV2ZW50SGFuZGxlci5jcHA6CihCbGFja0JlcnJ5OjpXZWJLaXQ6OlRvdWNoRXZlbnRIYW5k bGVyOjp0b3VjaEV2ZW50Q2FuY2VsKToKCmdpdC1zdm4taWQ6IGh0dHA6Ly9zdm4ud2Via2l0Lm9y Zy9yZXBvc2l0b3J5L3dlYmtpdC90cnVua0AxMjY1ODggMjY4ZjQ1Y2MtY2QwOS0wNDEwLWFiM2Mt ZDUyNjkxYjRkYmZjCi0tLQogU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgfCAgIDI0ICsrKysrKysrKysrKysrKysrKysrCiAuLi4vYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNwcCB8ICAgMTggKysrKysrKysrKy0tLS0K IDIgZmlsZXMgY2hhbmdlZCwgMzcgaW5zZXJ0aW9ucygrKSwgNSBkZWxldGlvbnMoLSkKCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZwppbmRleCA1Nzg1MjZlLi42NWEyMDU4IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQv YmxhY2tiZXJyeS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAxMi0wOC0yNCAgQW50b25p byBHb21lcyAgPGFnb21lc0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBUb3VjaCBj YW5jZWwgY2FuIGNhdXNlIGh1Z2UgYW5kIG5lZWRsZXNzIGludmFsaWRhdGlvbnMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0OTM4CisgICAgICAgIFBS ICMxOTgwNTEKKworICAgICAgICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKyAgICAgICAg SW50ZXJuYWxseSByZXZpZXdlZCBieSBHZW4gTWFrLgorCisgICAgICAgIEluIG9yZGVyIHRvIHJl bW92ZSB0aGUgcG9zc2libGUgaG92ZXIgZWZmZWN0IG9uIHRvdWNoX2NhbmNlbCwgd2UgYWx3YXlz CisgICAgICAgIGludmFsaWRhdGUgdGhlIG5vZGUgdW5kZXIgdGhlIGZhdCBmaW5nZXIsIGJlaW5n IHRoZSBmYXQgZmluZ2VyIHZhbGlkIG9yIG5vdC4KKworICAgICAgICBQb2ludCBpczogaGF2aW5n IGEgdmFsaWQgZmF0IGZpbmdlciBub2RlIGRvZXMgbm90IG1lYW4gdGhlIG9yaWdpbmFsIHRvdWNo CisgICAgICAgIHBvc2l0aW9uIHdhcyBhY3R1YWxseSBhZGp1c3QgZm9yIGNsaWNraW5nIG9yIHRo YXQgdGhlIGZhdCBmaW5nZXIgaXMgYWN0dWFsbHkKKyAgICAgICAgdmFsaWQuIFdlIHNldCB0aGUg ZmF0IGZpbmdlciBub2RlIHRvIGJlIHRoZSByZXN1bHQgb2YgdGhlIHBvaW50LWJhc2VkIGhpdC10 ZXN0CisgICAgICAgIHJlZ2FyZGxlc3MgaWYgaXQgaXMgYSBjbGljayB0YXJnZXQgb3Igbm90IChp biBvcmRlciB0byBtYWtlIG91ciBtb3VzZS1tb3ZlCisgICAgICAgIG1hY2hpbmVyeSB0byB3b3Jr KS4KKworICAgICAgICBXZSBzaG91bGQgY2FuIGxlc3MgYWdncmVzc2l2ZWx5IGludmFsaWRhdGUg dGhlIGZhdCBmaW5nZXIgbm9kZSwgc2luY2UgaXQgY2FuCisgICAgICAgIGJlIHJhdGhlciBhbiBl eHBlbnNpdmUgY2FsbCAobG9uZ2VyIHRoYW4gMXMgaW4gdGhlIHdvcnN0IHNjZW5hcmlvKS4KKwor ICAgICAgICAqIFdlYktpdFN1cHBvcnQvVG91Y2hFdmVudEhhbmRsZXIuY3BwOgorICAgICAgICAo QmxhY2tCZXJyeTo6V2ViS2l0OjpUb3VjaEV2ZW50SGFuZGxlcjo6dG91Y2hFdmVudENhbmNlbCk6 CisKIDIwMTItMDgtMjQgIEFydmlkIE5pbHNzb24gIDxhbmlsc3NvbkByaW0uY29tPgogCiAgICAg ICAgIFtCbGFja0JlcnJ5XSBBZGQgV2ViUGFnZSBBUEkgdG8gcmVzZXQgYmxvY2sgem9vbQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvVG91Y2hFdmVu dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvVG91 Y2hFdmVudEhhbmRsZXIuY3BwCmluZGV4IGVlM2E3NWYuLjJmYTM1OTIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L1RvdWNoRXZlbnRIYW5kbGVyLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9Ub3VjaEV2ZW50 SGFuZGxlci5jcHAKQEAgLTEzNSw4ICsxMzUsMTMgQEAgdm9pZCBUb3VjaEV2ZW50SGFuZGxlcjo6 dG91Y2hFdmVudENhbmNlbCgpCiAKICAgICAvLyBJZiB3ZSBjYW5jZWwgYSBzaW5nbGUgdG91Y2gg ZXZlbnQsIHdlIG5lZWQgdG8gYWxzbyBjbGVhbiB1cCBhbnkgaG92ZXIKICAgICAvLyBzdGF0ZSB3 ZSBnZXQgaW50byBieSBzeW50aGV0aWNhbGx5IG1vdmluZyB0aGUgbW91c2UgdG8gdGhlIG1fZmlu Z2VyUG9pbnQuCi0gICAgRWxlbWVudCogZWxlbWVudFVuZGVyRmF0RmluZ2VyID0gbV9sYXN0RmF0 RmluZ2Vyc1Jlc3VsdC5ub2RlQXNFbGVtZW50SWZBcHBsaWNhYmxlKCk7Ci0gICAgaWYgKGVsZW1l bnRVbmRlckZhdEZpbmdlciAmJiBlbGVtZW50VW5kZXJGYXRGaW5nZXItPnJlbmRlcmVyKCkpIHsK KyAgICBFbGVtZW50KiBlbGVtZW50VW5kZXJGYXRGaW5nZXIgPSBtX2xhc3RGYXRGaW5nZXJzUmVz dWx0LnBvc2l0aW9uV2FzQWRqdXN0ZWQoKSA/IG1fbGFzdEZhdEZpbmdlcnNSZXN1bHQubm9kZUFz RWxlbWVudElmQXBwbGljYWJsZSgpIDogMDsKKyAgICBkbyB7CisgICAgICAgIGlmICghZWxlbWVu dFVuZGVyRmF0RmluZ2VyIHx8ICFlbGVtZW50VW5kZXJGYXRGaW5nZXItPnJlbmRlcmVyKCkpCisg ICAgICAgICAgICBicmVhazsKKworICAgICAgICBpZiAoIWVsZW1lbnRVbmRlckZhdEZpbmdlci0+ cmVuZGVyZXIoKS0+c3R5bGUoKS0+YWZmZWN0ZWRCeUhvdmVyUnVsZXMoKSkKKyAgICAgICAgICAg IGJyZWFrOwogCiAgICAgICAgIEhpdFRlc3RSZXF1ZXN0IHJlcXVlc3QoSGl0VGVzdFJlcXVlc3Q6 OkZpbmdlclVwKTsKICAgICAgICAgLy8gVGhlIEhpdFRlc3RSZXN1bHQgcG9pbnQgaXMgbm90IGFj dHVhbGx5IG5lZWRlZC4KQEAgLTE0NywxMSArMTUyLDE0IEBAIHZvaWQgVG91Y2hFdmVudEhhbmRs ZXI6OnRvdWNoRXZlbnRDYW5jZWwoKQogICAgICAgICBBU1NFUlQoZG9jdW1lbnQpOwogICAgICAg ICBkb2N1bWVudC0+cmVuZGVyVmlldygpLT5sYXllcigpLT51cGRhdGVIb3ZlckFjdGl2ZVN0YXRl KHJlcXVlc3QsIHJlc3VsdCk7CiAgICAgICAgIGRvY3VtZW50LT51cGRhdGVTdHlsZUlmTmVlZGVk KCk7CisKICAgICAgICAgLy8gVXBkYXRpbmcgdGhlIGRvY3VtZW50IHN0eWxlIG1heSBkZXN0cm95 IHRoZSByZW5kZXJlci4KLSAgICAgICAgaWYgKGVsZW1lbnRVbmRlckZhdEZpbmdlci0+cmVuZGVy ZXIoKSkKLSAgICAgICAgICAgIGVsZW1lbnRVbmRlckZhdEZpbmdlci0+cmVuZGVyZXIoKS0+cmVw YWludCgpOworICAgICAgICBpZiAoIWVsZW1lbnRVbmRlckZhdEZpbmdlci0+cmVuZGVyZXIoKSkK KyAgICAgICAgICAgIGJyZWFrOworCisgICAgICAgIGVsZW1lbnRVbmRlckZhdEZpbmdlci0+cmVu ZGVyZXIoKS0+cmVwYWludCgpOwogICAgICAgICBBU1NFUlQoIWVsZW1lbnRVbmRlckZhdEZpbmdl ci0+aG92ZXJlZCgpKTsKLSAgICB9CisgICAgfSB3aGlsZSAoMCk7CiAKICAgICBtX2xhc3RGYXRG aW5nZXJzUmVzdWx0LnJlc2V0KCk7CiB9Ci0tIAoxLjcuNS40Cgo=