94913 2012-08-24 01:39:42 -0700 Stylechecker warns about comparison to zero when comparing to 0.5 2012-08-29 13:05:37 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 d-r d-r abarth dpranke eric levin ojan tonyg webkit.review.bot oldest_to_newest 703883 0 d-r 2012-08-24 01:39:42 -0700 Stylechecker comlains about the following line if (fabs(result - value) == 0.5 && (result & 1)) with "Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]" I believe that's a mistake. 707391 1 161208 d-r 2012-08-29 06:14:14 -0700 Created attachment 161208 cpp.py regex fix. 707778 2 161208 webkit.review.bot 2012-08-29 13:05:32 -0700 Comment on attachment 161208 cpp.py regex fix. Clearing flags on attachment: 161208 Committed r127036: <http://trac.webkit.org/changeset/127036> 707779 3 webkit.review.bot 2012-08-29 13:05:37 -0700 All reviewed patches have been landed. Closing bug. 161208 2012-08-29 06:14:14 -0700 2012-08-29 13:05:32 -0700 cpp.py regex fix. bug-94913-20120829161701.patch text/plain 3071 d-r U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2OTk0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWFmNWRkMmI1ZjUwYmU4MzYyMWM4OWFjNTA5N2NiNzk2 ZjBlMmQ5ZC4uYzU5YWNiOWM3YzFhYjU3Nzc5YTQ3NDcxYmEwZmE4NzBlNDIxZjgyYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTA4LTI5ICBEb21pbmlrIFLDtnR0c2NoZXMgIDxkb21pbmlrLnJvdHRzY2hlc0Bp bnRlbC5jb20+CisKKyAgICAgICAgU3R5bGVjaGVja2VyIHdhcm5zIGFib3V0IGNvbXBhcmlzb24g dG8gemVybyB3aGVuIGNvbXBhcmluZyB0byAwLjUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk0OTEzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIHRoZSBweXRob24gZG9jdW1lbnRhdGlv biwgXFcgaXMgdGhlIGNoYXJhY3RlciBncm91cCB3aXRoIGFsbAorICAgICAgICBub24tYWxwaGFu dW1lcmljIGNoYXJhY3RlcnMsIGVxdWl2YWxlbnQgdG8gW15hLXpBLVowLTlfXSwgd2hpY2ggaXMg ZXF1YWwgdG8KKyAgICAgICAgdG8gW15cd10uIFdlIG5lZWQgdG8gZXhjbHVkZSB0aGUgZG90ICIu IiBhcyB3ZWxsLCBzbyB0aGF0IGZsb2F0aW5nIHBvaW50CisgICAgICAgIHZhbHVlcyBkbyBub3Qg dHJpZ2dlciB0aGlzIHdhcm5pbmcuIEFkZGluZyBhIHVuaXQgdGVzdCB0aGF0IHNob3dzIHRoZSBw cm9ibGVtLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAu cHk6CisgICAgICAgIChjaGVja19mb3JfY29tcGFyaXNvbnNfdG9femVybyk6IE1vZGlmeWluZyB0 aGUgcmVnZXggdG8gbm90IGdldCB0cmlnZ2VyZWQgYnkgY29tcGFyaW5nIHRvIGZsb2F0cy4KKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToK KyAgICAgICAgKFdlYktpdFN0eWxlVGVzdC50ZXN0X251bGxfZmFsc2VfemVybyk6IFVuaXQgdGVz dCBleHBvc2luZyB0aGlzIGlzc3VlLgorCiAyMDEyLTA4LTI5ICBLcmlzdMOzZiBLb3N6dHnDsyAg PGtrcmlzdG9mQGluZi51LXN6ZWdlZC5odT4KIAogICAgICAgICBbTlJXVF0gVGhlIG5yd3Qgc2hv dWxkIGNoZWNrIHRoZSBjb250ZW50cyBvZiB0aGUgc2tpcHBlZCBmaWxlcyB3aXRoIC0tbGludC10 ZXN0LWZpbGVzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNr ZXJzL2NwcC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5 CmluZGV4IDQ1YzQ5YWFiNDM2YjE2Yzk0NDM1NDQ5MDhlNTIxNzZiMGMzZDBjOTMuLjFlM2Y4NzY3 ZjVmZjJjYjEzYTEwNmE1N2M4NTI2NzA2ZTI5ZDI2YmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwLnB5CkBAIC0yNDI1LDcgKzI0MjUsNyBAQCBkZWYgY2hl Y2tfZm9yX2NvbXBhcmlzb25zX3RvX3plcm8oY2xlYW5fbGluZXMsIGxpbmVfbnVtYmVyLCBlcnJv cik6CiAgICAgbGluZSA9IGNsZWFuX2xpbmVzLmVsaWRlZFtsaW5lX251bWJlcl0KIAogICAgICMg SW5jbHVkZSBOVUxMIGhlcmUgc28gdGhhdCB1c2VycyBkb24ndCBoYXZlIHRvIGNvbnZlcnQgTlVM TCB0byAwIGZpcnN0IGFuZCB0aGVuIGdldCB0aGlzIGVycm9yLgotICAgIGlmIHNlYXJjaChyJ1s9 IV09XHMqKE5VTEx8MHx0cnVlfGZhbHNlKVxXJywgbGluZSkgb3Igc2VhcmNoKHInXFcoTlVMTHww fHRydWV8ZmFsc2UpXHMqWz0hXT0nLCBsaW5lKToKKyAgICBpZiBzZWFyY2gocidbPSFdPVxzKihO VUxMfDB8dHJ1ZXxmYWxzZSlbXlx3Ll0nLCBsaW5lKSBvciBzZWFyY2gocidbXlx3Ll0oTlVMTHww fHRydWV8ZmFsc2UpXHMqWz0hXT0nLCBsaW5lKToKICAgICAgICAgaWYgbm90IHNlYXJjaCgnTElL RUxZJywgbGluZSkgYW5kIG5vdCBzZWFyY2goJ1VOTElLRUxZJywgbGluZSk6CiAgICAgICAgICAg ICBlcnJvcihsaW5lX251bWJlciwgJ3JlYWRhYmlsaXR5L2NvbXBhcmlzb25fdG9femVybycsIDUs CiAgICAgICAgICAgICAgICAgICAnVGVzdHMgZm9yIHRydWUvZmFsc2UsIG51bGwvbm9uLW51bGws IGFuZCB6ZXJvL25vbi16ZXJvIHNob3VsZCBhbGwgYmUgZG9uZSB3aXRob3V0IGVxdWFsaXR5IGNv bXBhcmlzb25zLicpCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcF91bml0dGVzdC5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hl Y2tlcnMvY3BwX3VuaXR0ZXN0LnB5CmluZGV4IGE1YTk0Yjc5M2E5M2Q4YjVhMjcwYWMyNzJlYWE5 ZDIwOThiYzUxMzcuLmRlOTlmNWVkMWE4MjA2YzBiMDEzYjVlNjlhN2Y3ZDQ2Yjg0Mzg4OGUgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3VuaXR0 ZXN0LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvc3R5bGUvY2hlY2tlcnMvY3BwX3Vu aXR0ZXN0LnB5CkBAIC00Mzc2LDYgKzQzNzYsMTIgQEAgY2xhc3MgV2ViS2l0U3R5bGVUZXN0KENw cFN0eWxlVGVzdEJhc2UpOgogICAgICAgICAgICAgJ2lmIChVTkxJS0VMWShmb28gPT0gMCkpJywK ICAgICAgICAgICAgICcnKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAorICAgICAgICAgICAg J2lmICgoYSAtIGIpID09IDAuNSknLAorICAgICAgICAgICAgJycpCisgICAgICAgIHNlbGYuYXNz ZXJ0X2xpbnQoCisgICAgICAgICAgICAnaWYgKDAuNSA9PSAoYSAtIGIpKScsCisgICAgICAgICAg ICAnJykKKyAgICAgICAgc2VsZi5hc3NlcnRfbGludCgKICAgICAgICAgICAgICdpZiAoTElLRUxZ KGZvbyA9PSBOVUxMKSknLAogICAgICAgICAgICAgJ1VzZSAwIGluc3RlYWQgb2YgTlVMTC4gIFty ZWFkYWJpbGl0eS9udWxsXSBbNV0nKQogICAgICAgICBzZWxmLmFzc2VydF9saW50KAo=