94904 2012-08-23 23:15:16 -0700 Web Inspector: move ResourceViews to "components" module - it is used from the Resources as well. 2012-08-24 02:23:12 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 94911 1 pfeldman pfeldman apavlov bweinstein joepeck keishi loislo ossy pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 703795 0 pfeldman 2012-08-23 23:15:16 -0700 Patch to follow. 703805 1 160339 pfeldman 2012-08-23 23:22:06 -0700 Created attachment 160339 Patch 703807 2 pfeldman 2012-08-23 23:26:21 -0700 Committed r126546: <http://trac.webkit.org/changeset/126546> 703866 3 webkit.review.bot 2012-08-24 00:52:14 -0700 Re-opened since this is blocked by 94911 703874 4 ossy 2012-08-24 01:22:00 -0700 (In reply to comment #3) > Re-opened since this is blocked by 94911 It was rolled out by http://trac.webkit.org/changeset/126546 . Additionally it broke 2 tests on Qt and on Mac: --- /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/network-sidebar-width-expected.txt +++ /Volumes/Data/slave/lion-debug-tests-wk1/build/layout-test-results/http/tests/inspector/network/network-sidebar-width-actual.txt @@ -4,4 +4,5 @@ Bug 65256 Sidebar width: 200 Sidebar width: 242 +Uncaught exception in inspector front-end: TypeError: 'undefined' is not a function (evaluating 'this.canEditSource()') [file:///Volumes/Data/slave/lion-debug-tests-wk1/build/WebKitBuild/Debug/WebCore.framework/Resources/inspector/SourceFrame.js:59] http/tests/inspector/resource-tree/resource-tree-reload.html: +Uncaught exception in inspector front-end: TypeError: 'undefined' is not a function [qrc:/webkit/inspector/SourceFrame.js:59] 703916 5 pfeldman 2012-08-24 02:23:12 -0700 Committed r126563: <http://trac.webkit.org/changeset/126563> 160339 2012-08-23 23:22:06 -0700 2012-08-24 01:22:20 -0700 Patch bug-94904-20120824102201.patch text/plain 5892 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMTQyYmFlNzA5OGVmMzBi NGE3NjM0NjY0YmRjZjMyMDZkNTI5YWE0Yy4uYWRhOWNjNTRjZTQ1N2I4YzZmN2YxMWZlMTI0Nzg0 NTdiMTA0OWZlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTIzICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IG1vdmUgUmVzb3VyY2VWaWV3cyB0byAiY29tcG9uZW50cyIgbW9kdWxlIC0gaXQgaXMgdXNl ZCBmcm9tIHRoZSBSZXNvdXJjZXMgYXMgd2VsbC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk0OTA0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlLmd5cGk6CisgICAgICAgICogaW5zcGVjdG9y L2NvbXBpbGUtZnJvbnQtZW5kLnB5OgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvTmV0 d29ya1BhbmVsLmpzOgorICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmh0 bWw6CisKIDIwMTItMDgtMjMgIEFudG9pbmUgTGFib3VyICA8cGltYW5AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFtjaHJvbWl1bV0gRml4IGxvc3QgY29udGV4dCB3aGVuIHRleHR1cmVzIGFyZSBl dmljdGVkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cGkgYi9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5kZXggMGJhMzM3NzZmNjY2NTc1YTFiOWU4ZTYyNjBjMTA4 YmUxN2I1MDNlYi4uM2FkM2IyZTFlMjNkMmQyNzIzOTdkYzdlZjc4OWM3MWRjMWU3NjJhZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpCisrKyBiL1NvdXJjZS9XZWJDb3Jl L1dlYkNvcmUuZ3lwaQpAQCAtNjMxOSwxMSArNjMxOSwxMyBAQAogICAgICAgICAgICAgJ2luc3Bl Y3Rvci9mcm9udC1lbmQvRmlsZU1hbmFnZXIuanMnLAogICAgICAgICAgICAgJ2luc3BlY3Rvci9m cm9udC1lbmQvRmlsZVN5c3RlbU1vZGVsLmpzJywKICAgICAgICAgICAgICdpbnNwZWN0b3IvZnJv bnQtZW5kL0ZpbGVVdGlscy5qcycsCisgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9G b250Vmlldy5qcycsCiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9Hb1RvTGluZURp YWxvZy5qcycsCiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9IQVJFbnRyeS5qcycs CiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9IYW5kbGVyUmVnaXN0cnkuanMnLAog ICAgICAgICAgICAgJ2luc3BlY3Rvci9mcm9udC1lbmQvSGVhcFNuYXBzaG90V29ya2VyLmpzJywK ICAgICAgICAgICAgICdpbnNwZWN0b3IvZnJvbnQtZW5kL0hlbHBTY3JlZW4uanMnLAorICAgICAg ICAgICAgJ2luc3BlY3Rvci9mcm9udC1lbmQvSW1hZ2VWaWV3LmpzJywKICAgICAgICAgICAgICdp bnNwZWN0b3IvZnJvbnQtZW5kL0luZGV4ZWREQk1vZGVsLmpzJywKICAgICAgICAgICAgICdpbnNw ZWN0b3IvZnJvbnQtZW5kL0luc3BlY3RvckJhY2tlbmQuanMnLAogICAgICAgICAgICAgJ2luc3Bl Y3Rvci9mcm9udC1lbmQvSW5zcGVjdG9yRnJvbnRlbmRBUEkuanMnLApAQCAtNjM1OSw2ICs2MzYx LDcgQEAKICAgICAgICAgICAgICdpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlVHJlZU1vZGVs LmpzJywKICAgICAgICAgICAgICdpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlVHlwZS5qcycs CiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVV0aWxzLmpzJywKKyAg ICAgICAgICAgICdpbnNwZWN0b3IvZnJvbnQtZW5kL1Jlc291cmNlVmlldy5qcycsCiAgICAgICAg ICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9TQVNTU291cmNlTWFwcGluZy5qcycsCiAgICAgICAg ICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9TY3JpcHQuanMnLAogICAgICAgICAgICAgJ2luc3Bl Y3Rvci9mcm9udC1lbmQvU2NyaXB0Rm9ybWF0dGVyLmpzJywKQEAgLTY0NTksOCArNjQ2Miw2IEBA CiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZXNQYW5lbC5qcycsCiAg ICAgICAgIF0sCiAgICAgICAgICd3ZWJpbnNwZWN0b3JfbmV0d29ya19qc19maWxlcyc6IFsKLSAg ICAgICAgICAgICdpbnNwZWN0b3IvZnJvbnQtZW5kL0ZvbnRWaWV3LmpzJywKLSAgICAgICAgICAg ICdpbnNwZWN0b3IvZnJvbnQtZW5kL0ltYWdlVmlldy5qcycsCiAgICAgICAgICAgICAnaW5zcGVj dG9yL2Zyb250LWVuZC9OZXR3b3JrSXRlbVZpZXcuanMnLAogICAgICAgICAgICAgJ2luc3BlY3Rv ci9mcm9udC1lbmQvUmVxdWVzdENvb2tpZXNWaWV3LmpzJywKICAgICAgICAgICAgICdpbnNwZWN0 b3IvZnJvbnQtZW5kL1JlcXVlc3RIZWFkZXJzVmlldy5qcycsCkBAIC02NDcwLDcgKzY0NzEsNiBA QAogICAgICAgICAgICAgJ2luc3BlY3Rvci9mcm9udC1lbmQvUmVxdWVzdFJlc3BvbnNlVmlldy5q cycsCiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9SZXF1ZXN0VGltaW5nVmlldy5q cycsCiAgICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9SZXF1ZXN0Vmlldy5qcycsCi0g ICAgICAgICAgICAnaW5zcGVjdG9yL2Zyb250LWVuZC9SZXNvdXJjZVZpZXcuanMnLAogICAgICAg ICAgICAgJ2luc3BlY3Rvci9mcm9udC1lbmQvUmVzb3VyY2VXZWJTb2NrZXRGcmFtZVZpZXcuanMn LAogICAgICAgICAgICAgJ2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzJywKICAg ICAgICAgXSwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9jb21waWxlLWZy b250LWVuZC5weSBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9jb21waWxlLWZyb250LWVuZC5w eQppbmRleCAzMWVhZGRlNzAyODAzZDkzMjY5MjBkODVkNDA1MzY4ZjM3MWE2MTliLi45ZDM4NGM1 OTYwMjVmYWM0YjcxYThhMDIzZTI5OTM3NTcxNzkwNmU3IDEwMDc1NQotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9pbnNwZWN0b3IvY29tcGlsZS1mcm9udC1lbmQucHkKKysrIGIvU291cmNlL1dlYkNvcmUv aW5zcGVjdG9yL2NvbXBpbGUtZnJvbnQtZW5kLnB5CkBAIC0xNjQsMTAgKzE2NCwxMyBAQCBtb2R1 bGVzID0gWwogICAgICAgICAgICAgIkRPTUJyZWFrcG9pbnRzU2lkZWJhclBhbmUuanMiLAogICAg ICAgICAgICAgIkRPTVByZXNlbnRhdGlvblV0aWxzLmpzIiwKICAgICAgICAgICAgICJFbGVtZW50 c1RyZWVPdXRsaW5lLmpzIiwKKyAgICAgICAgICAgICJGb250Vmlldy5qcyIsCisgICAgICAgICAg ICAiSW1hZ2VWaWV3LmpzIiwKICAgICAgICAgICAgICJOYXRpdmVCcmVha3BvaW50c1NpZGViYXJQ YW5lLmpzIiwKICAgICAgICAgICAgICJKYXZhU2NyaXB0Q29udGV4dE1hbmFnZXIuanMiLAogICAg ICAgICAgICAgIk9iamVjdFBvcG92ZXJIZWxwZXIuanMiLAogICAgICAgICAgICAgIk9iamVjdFBy b3BlcnRpZXNTZWN0aW9uLmpzIiwKKyAgICAgICAgICAgICJSZXNvdXJjZVZpZXcuanMiLAogICAg ICAgICAgICAgIlNvdXJjZUZyYW1lLmpzIiwKICAgICAgICAgXQogICAgIH0sCkBAIC0xODYsOCAr MTg5LDYgQEAgbW9kdWxlcyA9IFsKICAgICAgICAgIm5hbWUiOiAibmV0d29yayIsCiAgICAgICAg ICJkZXBlbmRlbmNpZXMiOiBbImNvbXBvbmVudHMiXSwKICAgICAgICAgInNvdXJjZXMiOiBbCi0g ICAgICAgICAgICAiRm9udFZpZXcuanMiLAotICAgICAgICAgICAgIkltYWdlVmlldy5qcyIsCiAg ICAgICAgICAgICAiTmV0d29ya0l0ZW1WaWV3LmpzIiwKICAgICAgICAgICAgICJSZXF1ZXN0Q29v a2llc1ZpZXcuanMiLAogICAgICAgICAgICAgIlJlcXVlc3RIZWFkZXJzVmlldy5qcyIsCkBAIC0x OTcsNyArMTk4LDYgQEAgbW9kdWxlcyA9IFsKICAgICAgICAgICAgICJSZXF1ZXN0UmVzcG9uc2VW aWV3LmpzIiwKICAgICAgICAgICAgICJSZXF1ZXN0VGltaW5nVmlldy5qcyIsCiAgICAgICAgICAg ICAiUmVxdWVzdFZpZXcuanMiLAotICAgICAgICAgICAgIlJlc291cmNlVmlldy5qcyIsCiAgICAg ICAgICAgICAiUmVzb3VyY2VXZWJTb2NrZXRGcmFtZVZpZXcuanMiLAogICAgICAgICAgICAgIk5l dHdvcmtQYW5lbC5qcyIsCiAgICAgICAgICAgICAiTmV0d29ya1BhbmVsRGVzY3JpcHRvci5qcyIs CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtQ YW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVs LmpzCmluZGV4IGIwYjExZTAxMWZjMjFiYjc1ZjgyMmVkN2Q4ODhkZmVkN2E4ZjU4NTguLjVjMjY3 MThhMTRiZmRhYmYyZjgxNGUwYzk2M2ZlNWFlNmFhN2NmMTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzCisrKyBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvTmV0d29ya1BhbmVsLmpzCkBAIC0yOSw5ICsyOSw2 IEBACiAgKi8KIAogaW1wb3J0U2NyaXB0KCJSZXF1ZXN0Vmlldy5qcyIpOwotaW1wb3J0U2NyaXB0 KCJSZXNvdXJjZVZpZXcuanMiKTsKLWltcG9ydFNjcmlwdCgiRm9udFZpZXcuanMiKTsKLWltcG9y dFNjcmlwdCgiSW1hZ2VWaWV3LmpzIik7CiBpbXBvcnRTY3JpcHQoIk5ldHdvcmtJdGVtVmlldy5q cyIpOwogaW1wb3J0U2NyaXB0KCJSZXF1ZXN0Q29va2llc1ZpZXcuanMiKTsKIGltcG9ydFNjcmlw dCgiUmVxdWVzdEhlYWRlcnNWaWV3LmpzIik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5odG1sIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuaHRtbAppbmRleCAxYjA4Y2ZkOGRiNGMzYWUzODdkNzZh OWZiZjg3NTEyNDBjMzAwYzAzLi5kMTA2YjM5NmU4Yjk0ZjIwMjJmYWEyYWQ3Yzc2N2I2M2U5Yjky ZjBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3Bl Y3Rvci5odG1sCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVj dG9yLmh0bWwKQEAgLTYzLDYgKzYzLDkgQEAgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KICAgICA8c2NyaXB0IHR5cGU9InRl eHQvamF2YXNjcmlwdCIgc3JjPSJDb25zb2xlTW9kZWwuanMiPjwvc2NyaXB0PgogICAgIDxzY3Jp cHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0IiBzcmM9IkNvbnNvbGVNZXNzYWdlLmpzIj48L3Njcmlw dD4KICAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgc3JjPSJDb25zb2xlVmlldy5q cyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iUmVz b3VyY2VWaWV3LmpzIj48L3NjcmlwdD4KKyAgICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlw dCIgc3JjPSJGb250Vmlldy5qcyI+PC9zY3JpcHQ+CisgICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2ph dmFzY3JpcHQiIHNyYz0iSW1hZ2VWaWV3LmpzIj48L3NjcmlwdD4KICAgICA8c2NyaXB0IHR5cGU9 InRleHQvamF2YXNjcmlwdCIgc3JjPSJQYW5lbC5qcyI+PC9zY3JpcHQ+CiAgICAgPHNjcmlwdCB0 eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iSW5zcGVjdG9yVmlldy5qcyI+PC9zY3JpcHQ+CiAg ICAgPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiIHNyYz0iQWR2YW5jZWRTZWFyY2hDb250 cm9sbGVyLmpzIj48L3NjcmlwdD4K