94898 2012-08-23 22:26:40 -0700 [Chromium] REGRESSION(r126534) time-multiple-fields-appearance-pseudo-elements.html failing on Win7 2012-08-27 01:02:47 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 95055 94664 1 dominicc yosin jchaffraix tkent oldest_to_newest 703748 0 dominicc 2012-08-23 22:26:40 -0700 The following test: fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements.html started failing on Win7 at r126534 according to the flakiness dashboard: <http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fforms%2Ftime-multiple-fields%2Ftime-multiple-fields-appearance-pseudo-elements.html> It looks like the image results differ in the seconds field – the expectation is :56, but the actual has :00 seconds. 703761 1 160331 yosin 2012-08-23 22:45:41 -0700 Created attachment 160331 Patch 1 703762 2 160331 yosin 2012-08-23 22:46:10 -0700 Comment on attachment 160331 Patch 1 Could you review this patch? Thanks in advance. 703765 3 dominicc 2012-08-23 22:48:33 -0700 I assume this will need rebaselining? 703766 4 160331 tkent 2012-08-23 22:48:35 -0700 Comment on attachment 160331 Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=160331&action=review > LayoutTests/ChangeLog:2 > +2012-08-23 Yoshifumi Inoue <yosin@chromium.org> > + [Chromium] REGRESSION(r126534) time-multiple-fields-appearance-pseudo-elements.html failing on Win7 Need a blank line before the description line. 703769 5 160332 yosin 2012-08-23 22:49:17 -0700 Created attachment 160332 Patch 2 703771 6 160332 yosin 2012-08-23 22:50:14 -0700 Comment on attachment 160332 Patch 2 Could you review this patch? Thanks in advance. = Changes since the last review = * Update ChangeLong 703780 7 160332 tkent 2012-08-23 23:07:44 -0700 Comment on attachment 160332 Patch 2 ok 703784 8 160332 yosin 2012-08-23 23:09:52 -0700 Comment on attachment 160332 Patch 2 Clearing flags on attachment: 160332 Committed r126545: <http://trac.webkit.org/changeset/126545> 703785 9 yosin 2012-08-23 23:09:56 -0700 All reviewed patches have been landed. Closing bug. 703797 10 tkent 2012-08-23 23:16:22 -0700 (In reply to comment #3) > I assume this will need rebaselining? No. This patch has updated an expectation. 704226 11 jchaffraix 2012-08-24 10:41:20 -0700 This patch still didn't solve the issue and I re-disabled the tests & filed a follow-up bug (bug 94951) about it. 160331 2012-08-23 22:45:41 -0700 2012-08-23 22:49:14 -0700 Patch 1 bug-94898-20120824144537.patch text/plain 2314 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTQyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGRiYTZhYjI0YmNjMjQ2ODlhNzFi NjEzNDZjZTliMGNlMmViOWQ5Zi4uNDU4OTdmOWUzODIwMDc5ODRmOGQ5ZmU2YzFmOTBjYTM1ZmEx MGMxYSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTIzICBZb3NoaWZ1bWkgSW5vdWUg PHlvc2luQGNocm9taXVtLm9yZz4KKyAgICAgICAgW0Nocm9taXVtXSBSRUdSRVNTSU9OKHIxMjY1 MzQpIHRpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVhcmFuY2UtcHNldWRvLWVsZW1lbnRzLmh0bWwg ZmFpbGluZyBvbiBXaW43CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NDg5OAorCisgICAgICAgIFRoaXMgcGF0Y2ggY2hhbmdlcyBwYXJhbWV0ZXJzIHRv IHRlc3QgZXhwZWN0YXRpb24gZ2VuZXJhdG9yIHRvIG1ha2UKKyAgICAgICAgYWN0dWFsIHJlc3Vs dCBhbmQgdGVzdCBleHBlY3RhdGlvbiB0byBiZSBtYXRjaGVkLgorCisgICAgICAgIFJvb3QgY2F1 c2Ugb2YgdGhpcyByZWdyZXNzaW9uIGlzIHRoZSB0ZXN0IGV4cGVjdGF0aW9uIGdlbmVyYXRvciBm b3IKKyAgICAgICAgQ2hyb21pdW0tV2luIGdlbmVyYXRlcyBzZWNvbmQgZmllbGQgd2l0aCB2YWx1 ZSAiNTYiIGluc3RlYWQgb2YgIjAwIi4KKworICAgICAgICBPbiBDaHJvbWl1bS1MaW51eCBhbmQg Q2hyb21pdW0tTWFjLCB0aGUgdGVzdCBleHBlY3RhdGlvbiBnZW5lcmF0b3IKKyAgICAgICAgZG9l c24ndCBnZW5lcmF0ZSBzZWNvbmQgZmllbGQuCisKKyAgICAgICAgKiBmYXN0L2Zvcm1zL3RpbWUt bXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVhcmFuY2UtcHNldWRvLWVs ZW1lbnRzLWV4cGVjdGVkLmh0bWw6IENoYW5nZXMgcGFyYW1ldGVycyB0byBoYXZlIGhvdXIgYW5k IG1pbnV0ZSBvbmx5LgorCiAyMDEyLTA4LTIzICBLd2FuZ1lvbmcgQ2hvaSAgPGt5MC5jaG9pQHNh bXN1bmcuY29tPgogCiAgICAgICAgIFtFRkxdIFNraXAgdGhlIHRlc3RzIHdoaWNoIGhhdmUgd3Jv bmcgcGl4ZWwgZXhwZWN0YXRpb25zIGluIGZhc3QvZm9ybXMvCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRz LWFwcGVhcmFuY2UtcHNldWRvLWVsZW1lbnRzLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9m YXN0L2Zvcm1zL3RpbWUtbXVsdGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVh cmFuY2UtcHNldWRvLWVsZW1lbnRzLWV4cGVjdGVkLmh0bWwKaW5kZXggOWQyZjc4YjljOGMyZThk NTZmOTEzZTM0ZGU4MmJlN2UxZDUyNzBkOS4uN2VlYmZjMjM1ZGI4ZTQyZDYxNTBmOTUyNjRlM2Iz YjQwZTY1OTljNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRp cGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLXBzZXVkby1lbGVtZW50 cy1leHBlY3RlZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBs ZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS1wc2V1ZG8tZWxlbWVudHMt ZXhwZWN0ZWQuaHRtbApAQCAtNCw5ICs0LDkgQEAKIDwvaGVhZD4KIDxib2R5PgogPHVsPgotICAg IDxsaT48c3BhbiB0eXBlPSJ0aW1lIiB2YWx1ZT0iMTI6MzQ6NTYiIGNsYXNzPSJhZnRlciI+PC9z cGFuPjwvbGk+Ci0gICAgPGxpPjxzcGFuIHR5cGU9InRpbWUiIHZhbHVlPSIxMjozNDo1NiIgY2xh c3M9ImJlZm9yZSI+W2JlZm9yZV08L3NwYW4+PC9saT4KLSAgICA8bGk+PHNwYW4gdHlwZT0idGlt ZSIgdmFsdWU9IjEyOjM0OjU2IiBjbGFzcz0iZmlyc3QtbGV0dGVyIj48L3NwYW4+PC9zcGFuPjwv bGk+CisgICAgPGxpPjxzcGFuIHR5cGU9InRpbWUiIHZhbHVlPSIxMjozNCIgY2xhc3M9ImFmdGVy Ij48L3NwYW4+PC9saT4KKyAgICA8bGk+PHNwYW4gdHlwZT0idGltZSIgdmFsdWU9IjEyOjM0IiBj bGFzcz0iYmVmb3JlIj5bYmVmb3JlXTwvc3Bhbj48L2xpPgorICAgIDxsaT48c3BhbiB0eXBlPSJ0 aW1lIiB2YWx1ZT0iMTI6MzQiIGNsYXNzPSJmaXJzdC1sZXR0ZXIiPjwvc3Bhbj48L3NwYW4+PC9s aT4KIDwvdWw+CiA8L2JvZHk+CiA8c2NyaXB0IHNyYz0iLi9yZXNvdXJjZXMvdGltZS1tdWx0aXBs ZS1maWVsZHMtYXBwZWFyYW5jZS5qcyI+PC9zY3JpcHQ+Cg== 160332 2012-08-23 22:49:17 -0700 2012-08-23 23:09:52 -0700 Patch 2 bug-94898-20120824144913.patch text/plain 2316 yosin U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTQyCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGRiYTZhYjI0YmNjMjQ2ODlhNzFi NjEzNDZjZTliMGNlMmViOWQ5Zi4uMzFhNzBmNmI5YTI0NWIwMjFhOTgxM2VkZjBmZTAxZDI4YjNi MzAyMSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA4LTIzICBZb3NoaWZ1bWkgSW5vdWUg PHlvc2luQGNocm9taXVtLm9yZz4KKworICAgICAgICBbQ2hyb21pdW1dIFJFR1JFU1NJT04ocjEy NjUzNCkgdGltZS1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS1wc2V1ZG8tZWxlbWVudHMuaHRt bCBmYWlsaW5nIG9uIFdpbjcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk0ODk4CisKKyAgICAgICAgVGhpcyBwYXRjaCBjaGFuZ2VzIHBhcmFtZXRlcnMg dG8gdGVzdCBleHBlY3RhdGlvbiBnZW5lcmF0b3IgdG8gbWFrZQorICAgICAgICBhY3R1YWwgcmVz dWx0IGFuZCB0ZXN0IGV4cGVjdGF0aW9uIHRvIGJlIG1hdGNoZWQuCisKKyAgICAgICAgUm9vdCBj YXVzZSBvZiB0aGlzIHJlZ3Jlc3Npb24gaXMgdGhlIHRlc3QgZXhwZWN0YXRpb24gZ2VuZXJhdG9y IGZvcgorICAgICAgICBDaHJvbWl1bS1XaW4gZ2VuZXJhdGVzIHNlY29uZCBmaWVsZCB3aXRoIHZh bHVlICI1NiIgaW5zdGVhZCBvZiAiMDAiLgorCisgICAgICAgIE9uIENocm9taXVtLUxpbnV4IGFu ZCBDaHJvbWl1bS1NYWMsIHRoZSB0ZXN0IGV4cGVjdGF0aW9uIGdlbmVyYXRvcgorICAgICAgICBk b2Vzbid0IGdlbmVyYXRlIHNlY29uZCBmaWVsZC4KKworICAgICAgICAqIGZhc3QvZm9ybXMvdGlt ZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMtYXBwZWFyYW5jZS1wc2V1ZG8t ZWxlbWVudHMtZXhwZWN0ZWQuaHRtbDogQ2hhbmdlcyBwYXJhbWV0ZXJzIHRvIGhhdmUgaG91ciBh bmQgbWludXRlIG9ubHkuCisKIDIwMTItMDgtMjMgIEt3YW5nWW9uZyBDaG9pICA8a3kwLmNob2lA c2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gU2tpcCB0aGUgdGVzdHMgd2hpY2ggaGF2ZSB3 cm9uZyBwaXhlbCBleHBlY3RhdGlvbnMgaW4gZmFzdC9mb3Jtcy8KZGlmZiAtLWdpdCBhL0xheW91 dFRlc3RzL2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVs ZHMtYXBwZWFyYW5jZS1wc2V1ZG8tZWxlbWVudHMtZXhwZWN0ZWQuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvZm9ybXMvdGltZS1tdWx0aXBsZS1maWVsZHMvdGltZS1tdWx0aXBsZS1maWVsZHMtYXBw ZWFyYW5jZS1wc2V1ZG8tZWxlbWVudHMtZXhwZWN0ZWQuaHRtbAppbmRleCA5ZDJmNzhiOWM4YzJl OGQ1NmY5MTNlMzRkZTgyYmU3ZTFkNTI3MGQ5Li43ZWViZmMyMzVkYjhlNDJkNjE1MGY5NTI2NGUz YjNiNDBlNjU5OWM1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3RpbWUtbXVs dGlwbGUtZmllbGRzL3RpbWUtbXVsdGlwbGUtZmllbGRzLWFwcGVhcmFuY2UtcHNldWRvLWVsZW1l bnRzLWV4cGVjdGVkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy90aW1lLW11bHRp cGxlLWZpZWxkcy90aW1lLW11bHRpcGxlLWZpZWxkcy1hcHBlYXJhbmNlLXBzZXVkby1lbGVtZW50 cy1leHBlY3RlZC5odG1sCkBAIC00LDkgKzQsOSBAQAogPC9oZWFkPgogPGJvZHk+CiA8dWw+Ci0g ICAgPGxpPjxzcGFuIHR5cGU9InRpbWUiIHZhbHVlPSIxMjozNDo1NiIgY2xhc3M9ImFmdGVyIj48 L3NwYW4+PC9saT4KLSAgICA8bGk+PHNwYW4gdHlwZT0idGltZSIgdmFsdWU9IjEyOjM0OjU2IiBj bGFzcz0iYmVmb3JlIj5bYmVmb3JlXTwvc3Bhbj48L2xpPgotICAgIDxsaT48c3BhbiB0eXBlPSJ0 aW1lIiB2YWx1ZT0iMTI6MzQ6NTYiIGNsYXNzPSJmaXJzdC1sZXR0ZXIiPjwvc3Bhbj48L3NwYW4+ PC9saT4KKyAgICA8bGk+PHNwYW4gdHlwZT0idGltZSIgdmFsdWU9IjEyOjM0IiBjbGFzcz0iYWZ0 ZXIiPjwvc3Bhbj48L2xpPgorICAgIDxsaT48c3BhbiB0eXBlPSJ0aW1lIiB2YWx1ZT0iMTI6MzQi IGNsYXNzPSJiZWZvcmUiPltiZWZvcmVdPC9zcGFuPjwvbGk+CisgICAgPGxpPjxzcGFuIHR5cGU9 InRpbWUiIHZhbHVlPSIxMjozNCIgY2xhc3M9ImZpcnN0LWxldHRlciI+PC9zcGFuPjwvc3Bhbj48 L2xpPgogPC91bD4KIDwvYm9keT4KIDxzY3JpcHQgc3JjPSIuL3Jlc291cmNlcy90aW1lLW11bHRp cGxlLWZpZWxkcy1hcHBlYXJhbmNlLmpzIj48L3NjcmlwdD4K