94887 2012-08-23 18:34:57 -0700 Add OVERRIDE and deinline virtual getters on *PlatformGestureCurve 2012-08-23 21:31:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dpranke enne webkit.review.bot oldest_to_newest 703636 0 jamesr 2012-08-23 18:34:57 -0700 Add OVERRIDE and deinline virtual getters on *PlatformGestureCurve 703638 1 160306 jamesr 2012-08-23 18:35:25 -0700 Created attachment 160306 Patch 703708 2 160306 dpranke 2012-08-23 21:06:59 -0700 Comment on attachment 160306 Patch I pretty much never object to deinlining things, but what was clang complaining about? 703719 3 160306 webkit.review.bot 2012-08-23 21:31:12 -0700 Comment on attachment 160306 Patch Clearing flags on attachment: 160306 Committed r126535: <http://trac.webkit.org/changeset/126535> 703720 4 webkit.review.bot 2012-08-23 21:31:15 -0700 All reviewed patches have been landed. Closing bug. 160306 2012-08-23 18:35:25 -0700 2012-08-23 21:31:11 -0700 Patch bug-94887-20120823183521.patch text/plain 4568 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZlZDBkZWNiNjc3ZTFl OWRiMDUzZDcxMWZhMTQxMjM5ZDlhOWI0NC4uN2ExNzU5ZDU0YzAxMDE2MzI5NTI2ZjVkZDY4ZTE3 MTA1ZmYxYmI2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTA4LTIzICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgQWRkIE9WRVJSSURF IGFuZCBkZWlubGluZSB2aXJ0dWFsIGdldHRlcnMgb24gKlBsYXRmb3JtR2VzdHVyZUN1cnZlCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDg4NworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgbWFrZXMg Y2xhbmcgaGFwcHkuIENsYW5nIG1ha2VzIG1lIGhhcHB5LiBCeSBpbmR1Y3Rpb24sIHRoaXMgbWFr ZXMgbWUgaGFwcHkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Ub3VjaHBhZEZsaW5nUGxhdGZvcm1H ZXN0dXJlQ3VydmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VG91Y2hwYWRGbGluZ1BsYXRmb3Jt R2VzdHVyZUN1cnZlOjpkZWJ1Z05hbWUpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICog cGxhdGZvcm0vVG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlLmg6CisgICAgICAgIChU b3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUpOgorICAgICAgICAqIHBsYXRmb3JtL1do ZWVsRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXaGVl bEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmU6OmRlYnVnTmFtZSk6CisgICAgICAgIChXZWJDb3Jl KToKKyAgICAgICAgKiBwbGF0Zm9ybS9XaGVlbEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUuaDoK KyAgICAgICAgKFdoZWVsRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZSk6CisKIDIwMTItMDgtMjMg IEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGF0 dGVtcHQgdG8gZml4IGJ1aWxkIGZhaWx1cmUgaW4gRGVidWcuCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9Ub3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZl LmNwcAppbmRleCAwOWYxODVhOWYxNDZlNTQxNzhiNWY0NzZlMGNkNDM3NTQ3YWMyZGJkLi5iMmJm YmVhNWUxMzJlZjM5Y2U5NGJkYzhkYWYyNTFhZWYwYTI5YjIxIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9Ub3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RvdWNocGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVD dXJ2ZS5jcHAKQEAgLTEyOSw2ICsxMjksMTEgQEAgVG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVy ZUN1cnZlOjp+VG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlKCkKIHsKIH0KIAorY29u c3QgY2hhciogVG91Y2hwYWRGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjpkZWJ1Z05hbWUoKSBj b25zdAoreworICAgIHJldHVybiAiVG91Y2hwYWRGbGluZyI7Cit9CisKIGJvb2wgVG91Y2hwYWRG bGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlOjphcHBseShkb3VibGUgdGltZSwgUGxhdGZvcm1HZXN0 dXJlQ3VydmVUYXJnZXQqIHRhcmdldCkKIHsKICAgICBmbG9hdCBkaXNwbGFjZW1lbnQ7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Ub3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0 dXJlQ3VydmUuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RvdWNocGFkRmxpbmdQbGF0Zm9y bUdlc3R1cmVDdXJ2ZS5oCmluZGV4IDQ2YjBhYTViNmI5MDM4ZDBhMzIxZDYzMGQ4YzQyZjIyOTNm ZTRkNDYuLmUxYzg1NTc1ZDU3M2NlZmRhNDQ2ODFmZTM0NTgwNDAwMTQ4MWNiZTIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RvdWNocGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVD dXJ2ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1RvdWNocGFkRmxpbmdQbGF0Zm9y bUdlc3R1cmVDdXJ2ZS5oCkBAIC00NCw4ICs0NCw4IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgUGFz c093blB0cjxQbGF0Zm9ybUdlc3R1cmVDdXJ2ZT4gY3JlYXRlKGNvbnN0IEZsb2F0UG9pbnQmIHZl bG9jaXR5LCBmbG9hdCBwMCwgZmxvYXQgcDEsIGZsb2F0IHAyLCBmbG9hdCBwMywgZmxvYXQgcDQs IGZsb2F0IGN1cnZlRHVyYXRpb24sIEludFBvaW50IGN1bXVsYXRpdmVTY3JvbGwgPSBJbnRQb2lu dCgpKTsKICAgICB2aXJ0dWFsIH5Ub3VjaHBhZEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUoKTsK IAotICAgIHZpcnR1YWwgY29uc3QgY2hhciogZGVidWdOYW1lKCkgY29uc3QgeyByZXR1cm4gIlRv dWNocGFkRmxpbmciOyB9Ci0gICAgdmlydHVhbCBib29sIGFwcGx5KGRvdWJsZSBtb25vdG9uaWNU aW1lLCBQbGF0Zm9ybUdlc3R1cmVDdXJ2ZVRhcmdldCopOworICAgIHZpcnR1YWwgY29uc3QgY2hh ciogZGVidWdOYW1lKCkgY29uc3QgT1ZFUlJJREU7CisgICAgdmlydHVhbCBib29sIGFwcGx5KGRv dWJsZSBtb25vdG9uaWNUaW1lLCBQbGF0Zm9ybUdlc3R1cmVDdXJ2ZVRhcmdldCopIE9WRVJSSURF OwogCiBwcml2YXRlOgogICAgIFRvdWNocGFkRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZShjb25z dCBGbG9hdFBvaW50JiB2ZWxvY2l0eSwgZmxvYXQgcDAsIGZsb2F0IHAxLCBmbG9hdCBwMiwgZmxv YXQgcDMsIGZsb2F0IHA0LCBmbG9hdCBjdXJ2ZUR1cmF0aW9uLCBjb25zdCBJbnRQb2ludCYgY3Vt dWxhdGl2ZVNjcm9sbCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9XaGVl bEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v V2hlZWxGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlLmNwcAppbmRleCBjOWYxNzMyODk3OWNiN2M3 MmZmMzlmN2VjYzIxMTEwZjQzM2JjMzk5Li43M2ZmYzM4MWQ4NTFkNjQ0YzYzMGNhMjhkZTY0Y2Y5 OTExMjZlMzBiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9XaGVlbEZsaW5n UGxhdGZvcm1HZXN0dXJlQ3VydmUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1do ZWVsRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZS5jcHAKQEAgLTQ2LDYgKzQ2LDExIEBAIFdoZWVs RmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZTo6fldoZWVsRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2 ZSgpCiB7CiB9CiAKK2NvbnN0IGNoYXIqIFdoZWVsRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZTo6 ZGVidWdOYW1lKCkgY29uc3QKK3sKKyAgICByZXR1cm4gIldoZWVsRmxpbmciOworfQorCiBib29s IFdoZWVsRmxpbmdQbGF0Zm9ybUdlc3R1cmVDdXJ2ZTo6YXBwbHkoZG91YmxlIHRpbWUsIFBsYXRm b3JtR2VzdHVyZUN1cnZlVGFyZ2V0KiB0YXJnZXQpCiB7CiAgICAgLy8gVXNlIGEgUmF5bGVpZ2gg ZGlzdHJpYnV0aW9uIGZvciB0aGUgY3VydmUuIFRoaXMgc2ltdWxhdGVzIGEgdmVsb2NpdHkgcHJv ZmlsZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vV2hlZWxGbGluZ1BsYXRm b3JtR2VzdHVyZUN1cnZlLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9XaGVlbEZsaW5nUGxh dGZvcm1HZXN0dXJlQ3VydmUuaAppbmRleCA0NGQ1NTJhODYzZDQ5YmM0YTBiNzc0M2Y2ZGNkNzg5 ZmZlNDFhYzdmLi45NmNmYWNhMWExZWVkZjJkNjU2YjEzN2VhMDBlN2NmYzY0ZWViMTYyIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9XaGVlbEZsaW5nUGxhdGZvcm1HZXN0dXJl Q3VydmUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9XaGVlbEZsaW5nUGxhdGZvcm1H ZXN0dXJlQ3VydmUuaApAQCAtNDMsOCArNDMsOCBAQCBwdWJsaWM6CiAgICAgc3RhdGljIFBhc3NP d25QdHI8UGxhdGZvcm1HZXN0dXJlQ3VydmU+IGNyZWF0ZShjb25zdCBGbG9hdFBvaW50JiB2ZWxv Y2l0eSk7CiAgICAgdmlydHVhbCB+V2hlZWxGbGluZ1BsYXRmb3JtR2VzdHVyZUN1cnZlKCk7CiAK LSAgICB2aXJ0dWFsIGNvbnN0IGNoYXIqIGRlYnVnTmFtZSgpIGNvbnN0IHsgcmV0dXJuICJXaGVl bEZsaW5nIjsgfQotICAgIHZpcnR1YWwgYm9vbCBhcHBseShkb3VibGUgdGltZSwgUGxhdGZvcm1H ZXN0dXJlQ3VydmVUYXJnZXQqKTsKKyAgICB2aXJ0dWFsIGNvbnN0IGNoYXIqIGRlYnVnTmFtZSgp IGNvbnN0IE9WRVJSSURFOworICAgIHZpcnR1YWwgYm9vbCBhcHBseShkb3VibGUgdGltZSwgUGxh dGZvcm1HZXN0dXJlQ3VydmVUYXJnZXQqKSBPVkVSUklERTsKIAogcHJpdmF0ZToKICAgICBleHBs aWNpdCBXaGVlbEZsaW5nUGxhdGZvcm1HZXN0dXJlQ3VydmUoY29uc3QgRmxvYXRQb2ludCYgdmVs b2NpdHkpOwo=