94883 2012-08-23 17:51:21 -0700 Remove RenderTableSection::removeChild 2012-08-24 09:37:35 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 94843 1 jchaffraix jchaffraix bdakin eric inferno webkit.review.bot oldest_to_newest 703607 0 jchaffraix 2012-08-23 17:51:21 -0700 Table section post-child-removal invalidations all go through RenderTableSection::removeChild. Unfortunately we cannot guarantee that it will be called when moving children around (f.e. table splitting logic). Since we introduced willBeRemovedFromTree, we can remove the function and do only the needed invalidation in the children's. Patch forthcoming. 703629 1 160304 jchaffraix 2012-08-23 18:21:32 -0700 Created attachment 160304 Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child. 704162 2 160304 webkit.review.bot 2012-08-24 09:37:32 -0700 Comment on attachment 160304 Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child. Clearing flags on attachment: 160304 Committed r126590: <http://trac.webkit.org/changeset/126590> 704163 3 webkit.review.bot 2012-08-24 09:37:35 -0700 All reviewed patches have been landed. Closing bug. 160304 2012-08-23 18:21:32 -0700 2012-08-24 09:37:32 -0700 Proposed change: Remove RenderTableSection::removeChild, replaced by willBeRemovedFromTree in child. bug-94883-20120823182129.patch text/plain 5706 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWVlZjQyYmMyZWQ3OGVi MTQzZmRmMDc0ZmUzODFiNjIzZDIwYjU2MC4uNWIxODliNGVmYzYxMTc5ZGQ2YWFmOTBmYzI0YmQy MWQyODc5YmM1NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDEyLTA4LTIzICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBS ZW5kZXJUYWJsZVNlY3Rpb246OnJlbW92ZUNoaWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDg4MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hhbmdlIHJlbW92ZWQgcmVtb3ZlQ2hpbGQsIHJl cGxhY2VkIGJ5IHdpbGxCZVJlbW92ZWQgY2FsbHMgaW4gdGhlIGNoaWxkcmVuCisgICAgICAgIGNs YXNzLiBUaGlzIGlzIGRvbmUgdG8gZW5zdXJlIHRoYXQgcG9zdC1yZW1vdmFsIGludmFsaWRhdGlv bnMgYXJlIHByb3Blcmx5IGRvbmUKKyAgICAgICAgaW4gdGFibGUgcm93cyBhbmQgdGFibGUgY2Vs bHMuCisKKyAgICAgICAgUmVmYWN0b3JpbmcgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cy4KKwor ICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UmVuZGVyVGFibGVTZWN0aW9uOjpyZW1vdmVDaGlsZCk6CisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlclRhYmxlU2VjdGlvbi5oOgorICAgICAgICBSZW1vdmVkIHRoaXMgZnVuY3Rpb24u Li4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyVGFibGVDZWxsOjp3aWxsQmVSZW1vdmVkRnJvbVRyZWUpOgorICAgICAg ICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaDoKKyAgICAgICAgKFJlbmRlclRhYmxlQ2Vs bCk6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRhYmxlUm93LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlclRhYmxlUm93Ojp3aWxsQmVSZW1vdmVkRnJvbVRyZWUpOgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJUYWJsZVJvdy5oOgorICAgICAgICAuLi4gYW5kIG1vdmVkIHRoZSBp bnZhbGlkYXRpb24gaW50byB0aGUgd2lsbEJlUmVtb3ZlZEZyb21UcmVlIGZ1bmN0aW9ucy4KKyAg ICAgICAgVGhlIHdpbGxCZVJlbW92ZWRGcm9tVHJlZSByZXBsYWNlZCB0aGUgd2lsbEJlRGVzdHJv eWVkIGZ1bmN0aW9ucyBpbiB0aGUKKyAgICAgICAgMiBjbGFzc2VzIGFzIHRoZSBpbnZhbGlkYXRp b24gcmVhbGx5IHJlcHJlc2VudGVkIHRyZWUgcmVtb3ZhbCB1cGRhdGVzLAorICAgICAgICBub3Qg ZGVhdGggdXBkYXRlcy4KKwogMjAxMi0wOC0yMyAgRG9taW5pYyBNYXp6b25pICA8ZG1henpvbmlA Z29vZ2xlLmNvbT4KIAogICAgICAgICBBWDogRm9jdXNhYmxlIGVsZW1lbnRzIHdpdGhvdXQgYSBy b2xlIHNob3VsZCBub3QgYmUgaWdub3JlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlclRhYmxlQ2VsbC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyVGFibGVDZWxsLmNwcAppbmRleCAwY2VmYzc1YTgyODA0NzU2NTllNTFhZmUwZDNiM2FmYzY3 NjEwZjNkLi4wNWQwYWQxOWFjYzk3NjA1YjQ0NzRkNjU1YjlkYTQxYmYyNTJjM2RkIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmNwcApAQCAtNTIsMTYgKzUy LDEyIEBAIFJlbmRlclRhYmxlQ2VsbDo6UmVuZGVyVGFibGVDZWxsKE5vZGUqIG5vZGUpCiB7CiB9 CiAKLXZvaWQgUmVuZGVyVGFibGVDZWxsOjp3aWxsQmVEZXN0cm95ZWQoKQordm9pZCBSZW5kZXJU YWJsZUNlbGw6OndpbGxCZVJlbW92ZWRGcm9tVHJlZSgpCiB7Ci0gICAgUmVuZGVyVGFibGVTZWN0 aW9uKiByZWNhbGNTZWN0aW9uID0gcGFyZW50KCkgPyBzZWN0aW9uKCkgOiAwOworICAgIFJlbmRl ckJsb2NrOjp3aWxsQmVSZW1vdmVkRnJvbVRyZWUoKTsKIAotICAgIFJlbmRlckJsb2NrOjp3aWxs QmVEZXN0cm95ZWQoKTsKLQotICAgIGlmIChyZWNhbGNTZWN0aW9uKSB7Ci0gICAgICAgIHJlY2Fs Y1NlY3Rpb24tPnNldE5lZWRzQ2VsbFJlY2FsYygpOwotICAgICAgICByZWNhbGNTZWN0aW9uLT5y ZW1vdmVDYWNoZWRDb2xsYXBzZWRCb3JkZXJzKHRoaXMpOwotICAgIH0KKyAgICBzZWN0aW9uKCkt PnNldE5lZWRzQ2VsbFJlY2FsYygpOworICAgIHNlY3Rpb24oKS0+cmVtb3ZlQ2FjaGVkQ29sbGFw c2VkQm9yZGVycyh0aGlzKTsKIH0KIAogdW5zaWduZWQgUmVuZGVyVGFibGVDZWxsOjpjb2xTcGFu KCkgY29uc3QKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJs ZUNlbGwuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNlbGwuaAppbmRl eCA1ZDViMjc2NGJiODA0OTVlN2EyMWU4MzAwYTYzZDUwZmM0NzkzZjMwLi45YjlhODc4ZmY3MDM3 NzJlMTRmMDdiMWIwNGY3MTQ0NzA4OTExYmIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGFibGVDZWxsLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlclRhYmxlQ2VsbC5oCkBAIC0xNzMsNyArMTczLDcgQEAgcHJpdmF0ZToKIAogICAgIHZp cnR1YWwgYm9vbCBpc1RhYmxlQ2VsbCgpIGNvbnN0IHsgcmV0dXJuIHRydWU7IH0KIAotICAgIHZp cnR1YWwgdm9pZCB3aWxsQmVEZXN0cm95ZWQoKTsKKyAgICB2aXJ0dWFsIHZvaWQgd2lsbEJlUmVt b3ZlZEZyb21UcmVlKCkgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIHZvaWQgY29tcHV0ZUxvZ2lj YWxXaWR0aCgpOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy VGFibGVSb3cuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlUm93LmNw cAppbmRleCA3ZGMwNWZhNTY3ZGI3N2VmZmJiMDU3ZDAwNWIwOTE1NGQ0NmE3ZTMzLi5jOWM5ZDc0 MTliMGM4NmZmN2JkMGJhODFmNDU4ZWQyMWIwZjM5NWFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVSb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUYWJsZVJvdy5jcHAKQEAgLTQ2LDE0ICs0NiwxMSBAQCBSZW5kZXJUYWJs ZVJvdzo6UmVuZGVyVGFibGVSb3coTm9kZSogbm9kZSkKICAgICBzZXRJbmxpbmUoZmFsc2UpOyAg IC8vIG91ciBvYmplY3QgaXMgbm90IElubGluZQogfQogCi12b2lkIFJlbmRlclRhYmxlUm93Ojp3 aWxsQmVEZXN0cm95ZWQoKQordm9pZCBSZW5kZXJUYWJsZVJvdzo6d2lsbEJlUmVtb3ZlZEZyb21U cmVlKCkKIHsKLSAgICBSZW5kZXJUYWJsZVNlY3Rpb24qIHJlY2FsY1NlY3Rpb24gPSBzZWN0aW9u KCk7Ci0gICAgCi0gICAgUmVuZGVyQm94Ojp3aWxsQmVEZXN0cm95ZWQoKTsKLSAgICAKLSAgICBp ZiAocmVjYWxjU2VjdGlvbikKLSAgICAgICAgcmVjYWxjU2VjdGlvbi0+c2V0TmVlZHNDZWxsUmVj YWxjKCk7CisgICAgUmVuZGVyQm94Ojp3aWxsQmVSZW1vdmVkRnJvbVRyZWUoKTsKKworICAgIHNl Y3Rpb24oKS0+c2V0TmVlZHNDZWxsUmVjYWxjKCk7CiB9CiAKIHZvaWQgUmVuZGVyVGFibGVSb3c6 OnVwZGF0ZUJlZm9yZUFuZEFmdGVyQ29udGVudCgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVSb3cuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJUYWJsZVJvdy5oCmluZGV4IGFmYTgzOGMxMjU0NjFiZTVmYzM1NWQwMjY1ZGNkMzFjZWY2 YTJjMzEuLjg3OTU2N2EzMDhiZjk1NTA2MWIzYjQ5OTNhM2FhNzg4NGRlMzA5NmUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVJvdy5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVJvdy5oCkBAIC05MCw3ICs5MCw3IEBAIHBy aXZhdGU6CiAKICAgICB2aXJ0dWFsIGJvb2wgaXNUYWJsZVJvdygpIGNvbnN0IHsgcmV0dXJuIHRy dWU7IH0KIAotICAgIHZpcnR1YWwgdm9pZCB3aWxsQmVEZXN0cm95ZWQoKTsKKyAgICB2aXJ0dWFs IHZvaWQgd2lsbEJlUmVtb3ZlZEZyb21UcmVlKCkgT1ZFUlJJREU7CiAKICAgICB2aXJ0dWFsIHZv aWQgYWRkQ2hpbGQoUmVuZGVyT2JqZWN0KiBjaGlsZCwgUmVuZGVyT2JqZWN0KiBiZWZvcmVDaGls ZCA9IDApOwogICAgIHZpcnR1YWwgdm9pZCBsYXlvdXQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uY3BwIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlclRhYmxlU2VjdGlvbi5jcHAKaW5kZXggYTkwNmEyZWY4MjY5MWE4YmVi OWE2MTE1MTA5NjQwNmQ2MjJkMGJiOC4uNWMwOGU3YTFjZTQwMDQ2ZmNlZGU5MTQ0NTcyMmM5YTJm Y2M1MTllZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxl U2VjdGlvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlU2Vj dGlvbi5jcHAKQEAgLTE4OSwxMiArMTg5LDYgQEAgdm9pZCBSZW5kZXJUYWJsZVNlY3Rpb246OmFk ZENoaWxkKFJlbmRlck9iamVjdCogY2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQKICAg ICB0b1JlbmRlclRhYmxlUm93KGNoaWxkKS0+dXBkYXRlQmVmb3JlQW5kQWZ0ZXJDb250ZW50KCk7 CiB9CiAKLXZvaWQgUmVuZGVyVGFibGVTZWN0aW9uOjpyZW1vdmVDaGlsZChSZW5kZXJPYmplY3Qq IG9sZENoaWxkKQotewotICAgIHNldE5lZWRzQ2VsbFJlY2FsYygpOwotICAgIFJlbmRlckJveDo6 cmVtb3ZlQ2hpbGQob2xkQ2hpbGQpOwotfQotCiB2b2lkIFJlbmRlclRhYmxlU2VjdGlvbjo6ZW5z dXJlUm93cyh1bnNpZ25lZCBudW1Sb3dzKQogewogICAgIGlmIChudW1Sb3dzIDw9IG1fZ3JpZC5z aXplKCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVT ZWN0aW9uLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVTZWN0aW9uLmgK aW5kZXggODliZmYzOWEwOGYyMDBjNTg0NzI1NzVhM2E3NWRhZTg2YTEyYmZhMC4uODdkODUxYmY4 YWI2NDk0OTViYWM0MzZiOWRjZGIxMGY0NDhjM2E4ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlU2VjdGlvbi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJUYWJsZVNlY3Rpb24uaApAQCAtMjEwLDggKzIxMCw2IEBAIHByaXZhdGU6 CiAKICAgICB2aXJ0dWFsIHZvaWQgbGF5b3V0KCk7CiAKLSAgICB2aXJ0dWFsIHZvaWQgcmVtb3Zl Q2hpbGQoUmVuZGVyT2JqZWN0KiBvbGRDaGlsZCk7Ci0KICAgICB2aXJ0dWFsIHZvaWQgcGFpbnRD ZWxsKFJlbmRlclRhYmxlQ2VsbCosIFBhaW50SW5mbyYsIGNvbnN0IExheW91dFBvaW50Jik7CiAg ICAgdmlydHVhbCB2b2lkIHBhaW50T2JqZWN0KFBhaW50SW5mbyYsIGNvbnN0IExheW91dFBvaW50 Jik7CiAK