94873 2012-08-23 16:56:04 -0700 [V8] V8AbstractEventListener re-implements ScopedPersistent by hand 2012-08-23 18:02:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 703545 0 abarth 2012-08-23 16:56:04 -0700 [V8] V8AbstractEventListener re-implements ScopedPersistent by hand 703549 1 160282 abarth 2012-08-23 16:57:24 -0700 Created attachment 160282 Patch 703553 2 160282 eric 2012-08-23 17:03:42 -0700 Comment on attachment 160282 Patch LGTM. 703620 3 160282 webkit.review.bot 2012-08-23 18:02:06 -0700 Comment on attachment 160282 Patch Clearing flags on attachment: 160282 Committed r126521: <http://trac.webkit.org/changeset/126521> 703621 4 webkit.review.bot 2012-08-23 18:02:09 -0700 All reviewed patches have been landed. Closing bug. 160282 2012-08-23 16:57:24 -0700 2012-08-23 18:02:06 -0700 Patch bug-94873-20120823165721.patch text/plain 7066 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNlMDA0MzFkOWMzZTQw ZDUxYTY1ZDRhMDhjMzU5NWY5ZDhjYmNmMS4uY2Q0ZDZhMjYxYzlhNDI0NDViNTQyNDYyYWM1NjU2 NDQ5ZTBlZDA4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDEyLTA4LTIzICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKKyAgICAgICAgW1Y4XSBWOEFic3RyYWN0RXZl bnRMaXN0ZW5lciByZS1pbXBsZW1lbnRzIFNjb3BlZFBlcnNpc3RlbnQgYnkgaGFuZAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ4NzMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSYXRoZXIgdGhhbiBjYWxs aW5nIE5ldy9EaXNwb3NlIG1hbnVhbGx5LCB0aGlzIHBhdGNoIGNoYW5nZXMKKyAgICAgICAgVjhB YnN0cmFjdEV2ZW50TGlzdGVuZXIgdG8gdXNlIFNjb3BlZFBlcnNpc3RlbnQuCisKKyAgICAgICAg KiBiaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJD b3JlOjpWOEFic3RyYWN0RXZlbnRMaXN0ZW5lcjo6d2Vha0V2ZW50TGlzdGVuZXJDYWxsYmFjayk6 CisgICAgICAgIChXZWJDb3JlOjpWOEFic3RyYWN0RXZlbnRMaXN0ZW5lcjo6flY4QWJzdHJhY3RF dmVudExpc3RlbmVyKToKKyAgICAgICAgKFdlYkNvcmU6OlY4QWJzdHJhY3RFdmVudExpc3RlbmVy OjpzZXRMaXN0ZW5lck9iamVjdCk6CisgICAgICAgIChXZWJDb3JlOjpWOEFic3RyYWN0RXZlbnRM aXN0ZW5lcjo6Z2V0UmVjZWl2ZXJPYmplY3QpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4QWJz dHJhY3RFdmVudExpc3RlbmVyLmg6CisgICAgICAgIChXZWJDb3JlOjpWOEFic3RyYWN0RXZlbnRM aXN0ZW5lcjo6Z2V0TGlzdGVuZXJPYmplY3QpOgorICAgICAgICAoV2ViQ29yZTo6VjhBYnN0cmFj dEV2ZW50TGlzdGVuZXI6OmdldEV4aXN0aW5nTGlzdGVuZXJPYmplY3QpOgorICAgICAgICAoV2Vi Q29yZTo6VjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6OmV4aXN0aW5nTGlzdGVuZXJPYmplY3RQZXJz aXN0ZW50SGFuZGxlKToKKyAgICAgICAgKFdlYkNvcmU6OlY4QWJzdHJhY3RFdmVudExpc3RlbmVy OjpoYXNFeGlzdGluZ0xpc3RlbmVyT2JqZWN0KToKKyAgICAgICAgKFY4QWJzdHJhY3RFdmVudExp c3RlbmVyKToKKworMjAxMi0wOC0yMyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgor CiAgICAgICAgIFtWOF0gU2NyaXB0VmFsdWUgc2hvdWxkIHVzZSBTY29wZWRQcmVzaXN0ZW50IHJh dGhlciB0aGFuIGNhbGxpbmcgTmV3L0Rpc3Bvc2UgZGlyZWN0bHkKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0ODY0CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmNwcAppbmRleCAw NGYzOTkxNjMwMTM0OGJkOGFmZTcyYTU4N2M0N2FlZTlhOWYwMDQ2Li4wZDIxMTUyNzYwNmNjOGJl YzE3YjViZGNkYWYzNTQ5NDcwZmYwMGI3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuY3BwCkBAIC00NywxMCArNDcsMTAg QEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdGF0aWMgdm9pZCB3ZWFrRXZlbnRMaXN0ZW5l ckNhbGxiYWNrKHY4OjpQZXJzaXN0ZW50PHY4OjpWYWx1ZT4sIHZvaWQqIHBhcmFtZXRlcikKK3Zv aWQgVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6OndlYWtFdmVudExpc3RlbmVyQ2FsbGJhY2sodjg6 OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiwgdm9pZCogcGFyYW1ldGVyKQogewogICAgIFY4QWJzdHJh Y3RFdmVudExpc3RlbmVyKiBsaXN0ZW5lciA9IHN0YXRpY19jYXN0PFY4QWJzdHJhY3RFdmVudExp c3RlbmVyKj4ocGFyYW1ldGVyKTsKLSAgICBsaXN0ZW5lci0+ZGlzcG9zZUxpc3RlbmVyT2JqZWN0 KCk7CisgICAgbGlzdGVuZXItPm1fbGlzdGVuZXIuY2xlYXIoKTsKIH0KIAogVjhBYnN0cmFjdEV2 ZW50TGlzdGVuZXI6OlY4QWJzdHJhY3RFdmVudExpc3RlbmVyKGJvb2wgaXNBdHRyaWJ1dGUsIGNv bnN0IFdvcmxkQ29udGV4dEhhbmRsZSYgd29ybGRDb250ZXh0KQpAQCAtNjUsMTIgKzY1LDEwIEBA IFY4QWJzdHJhY3RFdmVudExpc3RlbmVyOjpWOEFic3RyYWN0RXZlbnRMaXN0ZW5lcihib29sIGlz QXR0cmlidXRlLCBjb25zdCBXb3JsZENvCiAKIFY4QWJzdHJhY3RFdmVudExpc3RlbmVyOjp+VjhB YnN0cmFjdEV2ZW50TGlzdGVuZXIoKQogewotICAgIGlmICghbV9saXN0ZW5lci5Jc0VtcHR5KCkp IHsKKyAgICBpZiAoIW1fbGlzdGVuZXIuZ2V0KCkuSXNFbXB0eSgpKSB7CiAgICAgICAgIHY4OjpI YW5kbGVTY29wZSBzY29wZTsKLSAgICAgICAgdjg6OkxvY2FsPHY4OjpPYmplY3Q+IGxpc3RlbmVy ID0gdjg6OkxvY2FsPHY4OjpPYmplY3Q+OjpOZXcobV9saXN0ZW5lcik7Ci0gICAgICAgIFY4RXZl bnRMaXN0ZW5lckxpc3Q6OmNsZWFyV3JhcHBlcihsaXN0ZW5lciwgbV9pc0F0dHJpYnV0ZSk7Cisg ICAgICAgIFY4RXZlbnRMaXN0ZW5lckxpc3Q6OmNsZWFyV3JhcHBlcih2ODo6TG9jYWw8djg6Ok9i amVjdD46Ok5ldyhtX2xpc3RlbmVyLmdldCgpKSwgbV9pc0F0dHJpYnV0ZSk7CiAgICAgfQotICAg IGRpc3Bvc2VMaXN0ZW5lck9iamVjdCgpOwogI2lmIEVOQUJMRShJTlNQRUNUT1IpCiAgICAgVGhy ZWFkTG9jYWxJbnNwZWN0b3JDb3VudGVyczo6Y3VycmVudCgpLmRlY3JlbWVudENvdW50ZXIoVGhy ZWFkTG9jYWxJbnNwZWN0b3JDb3VudGVyczo6SlNFdmVudExpc3RlbmVyQ291bnRlcik7CiAjZW5k aWYKQEAgLTEwNCwyNSArMTAyLDEwIEBAIHZvaWQgVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6Omhh bmRsZUV2ZW50KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEV2ZW50CiAgICAgaW52 b2tlRXZlbnRIYW5kbGVyKGNvbnRleHQsIGV2ZW50LCBqc0V2ZW50KTsKIH0KIAotdm9pZCBWOEFi c3RyYWN0RXZlbnRMaXN0ZW5lcjo6ZGlzcG9zZUxpc3RlbmVyT2JqZWN0KCkKLXsKLSAgICBpZiAo IW1fbGlzdGVuZXIuSXNFbXB0eSgpKSB7Ci0jaWZuZGVmIE5ERUJVRwotICAgICAgICBWOEdDQ29u dHJvbGxlcjo6dW5yZWdpc3Rlckdsb2JhbEhhbmRsZSh0aGlzLCBtX2xpc3RlbmVyKTsKLSNlbmRp ZgotICAgICAgICBtX2xpc3RlbmVyLkRpc3Bvc2UoKTsKLSAgICAgICAgbV9saXN0ZW5lci5DbGVh cigpOwotICAgIH0KLX0KLQogdm9pZCBWOEFic3RyYWN0RXZlbnRMaXN0ZW5lcjo6c2V0TGlzdGVu ZXJPYmplY3Qodjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBsaXN0ZW5lcikKIHsKLSAgICBkaXNwb3Nl TGlzdGVuZXJPYmplY3QoKTsKLSAgICBtX2xpc3RlbmVyID0gdjg6OlBlcnNpc3RlbnQ8djg6Ok9i amVjdD46Ok5ldyhsaXN0ZW5lcik7Ci0jaWZuZGVmIE5ERUJVRwotICAgIFY4R0NDb250cm9sbGVy OjpyZWdpc3Rlckdsb2JhbEhhbmRsZShFVkVOVF9MSVNURU5FUiwgdGhpcywgbV9saXN0ZW5lcik7 Ci0jZW5kaWYKLSAgICBtX2xpc3RlbmVyLk1ha2VXZWFrKHRoaXMsICZ3ZWFrRXZlbnRMaXN0ZW5l ckNhbGxiYWNrKTsKKyAgICBtX2xpc3RlbmVyLnNldChsaXN0ZW5lcik7CisgICAgbV9saXN0ZW5l ci5nZXQoKS5NYWtlV2Vhayh0aGlzLCAmVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6OndlYWtFdmVu dExpc3RlbmVyQ2FsbGJhY2spOwogfQogCiB2b2lkIFY4QWJzdHJhY3RFdmVudExpc3RlbmVyOjpp bnZva2VFdmVudEhhbmRsZXIoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgRXZlbnQq IGV2ZW50LCB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4ganNFdmVudCkKQEAgLTIwMSw4ICsxODQsOCBA QCBib29sIFY4QWJzdHJhY3RFdmVudExpc3RlbmVyOjpzaG91bGRQcmV2ZW50RGVmYXVsdCh2ODo6 TG9jYWw8djg6OlZhbHVlPiByZXR1cm5WYQogCiB2ODo6TG9jYWw8djg6Ok9iamVjdD4gVjhBYnN0 cmFjdEV2ZW50TGlzdGVuZXI6OmdldFJlY2VpdmVyT2JqZWN0KEV2ZW50KiBldmVudCkKIHsKLSAg ICBpZiAoIW1fbGlzdGVuZXIuSXNFbXB0eSgpICYmICFtX2xpc3RlbmVyLT5Jc0Z1bmN0aW9uKCkp Ci0gICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD46Ok5ldyhtX2xpc3RlbmVyKTsK KyAgICBpZiAoIW1fbGlzdGVuZXIuZ2V0KCkuSXNFbXB0eSgpICYmICFtX2xpc3RlbmVyLmdldCgp LT5Jc0Z1bmN0aW9uKCkpCisgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6Ok9iamVjdD46Ok5l dyhtX2xpc3RlbmVyLmdldCgpKTsKIAogICAgIEV2ZW50VGFyZ2V0KiB0YXJnZXQgPSBldmVudC0+ Y3VycmVudFRhcmdldCgpOwogICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2YWx1ZSA9IFY4RE9N V3JhcHBlcjo6Y29udmVydEV2ZW50VGFyZ2V0VG9WOE9iamVjdCh0YXJnZXQpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuaCBi L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmgKaW5k ZXggNjcyYmE2ZGJhYjU1NDcyYWUwOGMyMjRkYTUwNWE2YmNlYTIxZDU1OS4uZWVkMmE1OTFkNjNk MzIwZDMzMjBlOWFhODI0OGU1YTY4NjQ3NjE0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5oCkBAIC0zMiw4ICszMiw4IEBA CiAjZGVmaW5lIFY4QWJzdHJhY3RFdmVudExpc3RlbmVyX2gKIAogI2luY2x1ZGUgIkV2ZW50TGlz dGVuZXIuaCIKKyNpbmNsdWRlICJTY29wZWRQZXJzaXN0ZW50LmgiCiAjaW5jbHVkZSAiV29ybGRD b250ZXh0SGFuZGxlLmgiCi0KICNpbmNsdWRlIDx2OC5oPgogI2luY2x1ZGUgPHd0Zi9QYXNzUmVm UHRyLmg+CiAjaW5jbHVkZSA8d3RmL1JlZkNvdW50ZWQuaD4KQEAgLTgwLDI5ICs4MCwyNiBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBnZXRMaXN0 ZW5lck9iamVjdChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgICAgICB7CiAg ICAgICAgICAgICBwcmVwYXJlTGlzdGVuZXJPYmplY3QoY29udGV4dCk7Ci0gICAgICAgICAgICBy ZXR1cm4gdjg6OkxvY2FsPHY4OjpPYmplY3Q+OjpOZXcobV9saXN0ZW5lcik7CisgICAgICAgICAg ICByZXR1cm4gdjg6OkxvY2FsPHY4OjpPYmplY3Q+OjpOZXcobV9saXN0ZW5lci5nZXQoKSk7CiAg ICAgICAgIH0KIAogICAgICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gZ2V0RXhpc3RpbmdMaXN0 ZW5lck9iamVjdCgpCiAgICAgICAgIHsKLSAgICAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8djg6 Ok9iamVjdD46Ok5ldyhtX2xpc3RlbmVyKTsKKyAgICAgICAgICAgIHJldHVybiB2ODo6TG9jYWw8 djg6Ok9iamVjdD46Ok5ldyhtX2xpc3RlbmVyLmdldCgpKTsKICAgICAgICAgfQogCiAgICAgICAg IC8vIFByb3ZpZGVzIGFjY2VzcyB0byB0aGUgdW5kZXJseWluZyBoYW5kbGUgZm9yIEdDLiBSZXR1 cm5lZAogICAgICAgICAvLyB2YWx1ZSBpcyBhIHdlYWsgaGFuZGxlIGFuZCBzbyBub3QgZ3VhcmFu dGVlZCB0byBzdGF5IGFsaXZlLgogICAgICAgICB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiBl eGlzdGluZ0xpc3RlbmVyT2JqZWN0UGVyc2lzdGVudEhhbmRsZSgpCiAgICAgICAgIHsKLSAgICAg ICAgICAgIHJldHVybiBtX2xpc3RlbmVyOworICAgICAgICAgICAgcmV0dXJuIG1fbGlzdGVuZXIu Z2V0KCk7CiAgICAgICAgIH0KIAogICAgICAgICBib29sIGhhc0V4aXN0aW5nTGlzdGVuZXJPYmpl Y3QoKQogICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4gIW1fbGlzdGVuZXIuSXNFbXB0eSgp OworICAgICAgICAgICAgcmV0dXJuICFtX2xpc3RlbmVyLmdldCgpLklzRW1wdHkoKTsKICAgICAg ICAgfQogCi0gICAgICAgIC8vIERpc3Bvc2UgbGlzdGVuZXIgb2JqZWN0IGFuZCBjbGVhciB0aGUg aGFuZGxlLgotICAgICAgICB2b2lkIGRpc3Bvc2VMaXN0ZW5lck9iamVjdCgpOwotCiAgICAgICAg IGNvbnN0IFdvcmxkQ29udGV4dEhhbmRsZSYgd29ybGRDb250ZXh0KCkgY29uc3QgeyByZXR1cm4g bV93b3JsZENvbnRleHQ7IH0KIAogICAgIHByb3RlY3RlZDoKQEAgLTExOCw2ICsxMTUsOCBAQCBu YW1lc3BhY2UgV2ViQ29yZSB7CiAgICAgICAgIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBnZXRSZWNl aXZlck9iamVjdChFdmVudCopOwogCiAgICAgcHJpdmF0ZToKKyAgICAgICAgc3RhdGljIHZvaWQg d2Vha0V2ZW50TGlzdGVuZXJDYWxsYmFjayh2ODo6UGVyc2lzdGVudDx2ODo6VmFsdWU+LCB2b2lk KiBwYXJhbWV0ZXIpOworCiAgICAgICAgIC8vIEltcGxlbWVudGF0aW9uIG9mIEV2ZW50TGlzdGVu ZXIgZnVuY3Rpb24uCiAgICAgICAgIHZpcnR1YWwgYm9vbCB2aXJ0dWFsaXNBdHRyaWJ1dGUoKSBj b25zdCB7IHJldHVybiBtX2lzQXR0cmlidXRlOyB9CiAKQEAgLTEyNSw3ICsxMjQsNyBAQCBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgdmlydHVhbCBib29sIHNob3VsZFByZXZlbnREZWZh dWx0KHY4OjpMb2NhbDx2ODo6VmFsdWU+IHJldHVyblZhbHVlKTsKIAotICAgICAgICB2ODo6UGVy c2lzdGVudDx2ODo6T2JqZWN0PiBtX2xpc3RlbmVyOworICAgICAgICBTY29wZWRQZXJzaXN0ZW50 PHY4OjpPYmplY3Q+IG1fbGlzdGVuZXI7CiAKICAgICAgICAgLy8gSW5kaWNhdGVzIGlmIHRoaXMg aXMgYW4gSFRNTCB0eXBlIGxpc3RlbmVyLgogICAgICAgICBib29sIG1faXNBdHRyaWJ1dGU7Cg==