94869 2012-08-23 15:40:42 -0700 REGRESSION (r124815): PDF in frame does not display any more 2012-08-23 15:50:13 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Mac All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson ap oldest_to_newest 703475 0 beidson 2012-08-23 15:40:42 -0700 REGRESSION (r124815): PDF in frame does not display any more. BuiltinPDFView needs to notify the plugincontroller that it initialized. In radar as <rdar://problem/12063306> 703477 1 160267 beidson 2012-08-23 15:42:17 -0700 Created attachment 160267 Patch 703479 2 160267 ap 2012-08-23 15:44:43 -0700 Comment on attachment 160267 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160267&action=review No test?.. <:-| > Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345 > + controller()->didInitializePlugin(); I'm wondering if this should be made async to match regular code path. Probably not. 703481 3 beidson 2012-08-23 15:47:40 -0700 (In reply to comment #2) > (From update of attachment 160267 [details]) > > > Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345 > > + controller()->didInitializePlugin(); > > I'm wondering if this should be made async to match regular code path. Probably not. Probably not indeed. The regular synchronous code path for netscape plugins already has to do this, for example. Thanks for the review! 703485 4 beidson 2012-08-23 15:49:21 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 160267 [details] [details]) > > > > > Source/WebKit2/WebProcess/Plugins/PDF/BuiltInPDFView.mm:345 > > > + controller()->didInitializePlugin(); > > > > I'm wondering if this should be made async to match regular code path. Probably not. > And also, the async design is largely centered around out-of-process plugins. We'll need BuiltinPDFView to be out of process first. :) 703488 5 beidson 2012-08-23 15:50:13 -0700 http://trac.webkit.org/changeset/126490 160267 2012-08-23 15:42:17 -0700 2012-08-23 15:44:43 -0700 Patch patch.txt text/plain 1340 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBhOGQ4YjMyLi5iNWRmYzIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTItMDgtMjMgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFJFR1JFU1NJT04gKHIxMjQ4MTUpOiBQREYgaW4gZnJhbWUgZG9lcyBub3QgZGlzcGxheSBh bnkgbW9yZQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTIwNjMzMDY+IGFuZCBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ4NjkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvUGx1Z2lucy9QREYvQnVp bHRJblBERlZpZXcubW06CisgICAgICAgIChXZWJLaXQ6OkJ1aWx0SW5QREZWaWV3Ojppbml0aWFs aXplKTogVGVsbCB0aGUgY29udHJvbGxlciB0aGF0IGluaXRpYWxpemF0aW9uIHdhcyBzdWNjZXNz ZnVsLgorCiAyMDEyLTA4LTIzICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBp bnRlbC5jb20+CiAKICAgICAgICAgW0VGTF1bV0syXSBGcmVlIGV3ayBjb250ZXh0IGRhdGEgb24g cHJvZ3JhbSBleGl0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVn aW5zL1BERi9CdWlsdEluUERGVmlldy5tbSBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvUGx1 Z2lucy9QREYvQnVpbHRJblBERlZpZXcubW0KaW5kZXggNjFkYjU1My4uZmU3ZjI1OCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9CdWlsdEluUERGVmll dy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL0J1aWx0SW5Q REZWaWV3Lm1tCkBAIC0zNDIsNiArMzQyLDcgQEAgYm9vbCBCdWlsdEluUERGVmlldzo6aW5pdGlh bGl6ZShjb25zdCBQYXJhbWV0ZXJzJiBwYXJhbWV0ZXJzKQogICAgIGlmICghcGFyYW1ldGVycy5z aG91bGRVc2VNYW51YWxMb2FkZXIgJiYgIXBhcmFtZXRlcnMudXJsLmlzRW1wdHkoKSkKICAgICAg ICAgY29udHJvbGxlcigpLT5sb2FkVVJMKHBkZkRvY3VtZW50UmVxdWVzdElELCAiR0VUIiwgcGFy YW1ldGVycy51cmwuc3RyaW5nKCksIFN0cmluZygpLCBIVFRQSGVhZGVyTWFwKCksIFZlY3Rvcjx1 aW50OF90PigpLCBmYWxzZSk7CiAKKyAgICBjb250cm9sbGVyKCktPmRpZEluaXRpYWxpemVQbHVn aW4oKTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KIAo=