94863 2012-08-23 15:06:32 -0700 [BlackBerry] Add WebPage API to reset block zoom 2012-08-24 06:21:04 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson anilsson manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 703438 0 anilsson 2012-08-23 15:06:32 -0700 This is an alternative to blockZoomAnimationFinished() when you don't want to perform a rerendering of the whole web page at the end of block zoom. 703444 1 160260 anilsson 2012-08-23 15:13:45 -0700 Created attachment 160260 Patch 703445 2 anilsson 2012-08-23 15:14:08 -0700 Internal PR 187478 703447 3 anilsson 2012-08-23 15:15:10 -0700 This patch doesn't really make sense without the rest of PR 187478 as context, but I hope the commit message provides the required background. 703449 4 anilsson 2012-08-23 15:17:15 -0700 The problem is basically that the block zoom algorithm needs to compare the current scale with the final scale of block zoom, and if they're almost the same, it should reset instead. However, the current scale that should be used is the scale multiplied by any incremental zoom factor, and the latter is not implemented (or pushed down to WebKit layer) yet. 704043 5 160260 webkit.review.bot 2012-08-24 06:21:01 -0700 Comment on attachment 160260 Patch Clearing flags on attachment: 160260 Committed r126578: <http://trac.webkit.org/changeset/126578> 704044 6 webkit.review.bot 2012-08-24 06:21:04 -0700 All reviewed patches have been landed. Closing bug. 160260 2012-08-23 15:13:45 -0700 2012-08-24 06:21:00 -0700 Patch bug-94863-20120824001340.patch text/plain 2433 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MTgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA2Y2E5NDdkZjZiMTEwZTc0YThiMjZhZGZjODYyYzEzNWM2ODBjOGU0Li41YjBkYmMxM2Qw NDc0MGI1NGFlMGJiZDM5N2I3MmQ0ZjFjMzkyZmYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyNiBAQAorMjAxMi0wOC0yMyAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEFkZCBXZWJQYWdlIEFQSSB0byBy ZXNldCBibG9jayB6b29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NDg2MworCisgICAgICAgIFBSIDE4NzQ3OAorICAgICAgICBUaGlzIGlzIGFuIGFs dGVybmF0aXZlIHRvIFdlYlBhZ2U6OmJsb2NrWm9vbUFuaW1hdGlvbkZpbmlzaGVkKCkgd2hlbgor ICAgICAgICBpdCdzIGRlc2lyYWJsZSB0byBhdm9pZCByZXJlbmRlcmluZyBvZiB0aGUgd2hvbGUg d2ViIHBhZ2UgYXQgdGhlIGVuZAorICAgICAgICBvZiBibG9jayB6b29tLiBUaGlzIGlzIHRoZSBj YXNlIHdoZW4gdGhlIHBsYW5uZWQgImluY3JlbWVudGFsIHpvb20KKyAgICAgICAgZmFjdG9yIiBp cyB1c2VkIGluc3RlYWQgb2Ygem9vbUFib3V0UG9pbnQgYW5kIGl0J3MgcmVsYXRpdmVzLgorCisg ICAgICAgIElkZWFsbHksIHRoZSBibG9jayB6b29tIGFsZ29yaXRobSB3b3VsZCBiZSBjbGV2ZXIg ZW5vdWdoIG5vdCB0byBuZWVkCisgICAgICAgIGEgcmVzZXQgb3IgYW55IGZvcm0gb2YgY2FsbGJh Y2sgd2hlbiB0aGUgYW5pbWF0aW9uIGZpbmlzaGVzLCBidXQgdGhhdAorICAgICAgICByZXF1aXJl cyB0aGUgaW1wbGVtZW50YXRpb24gb2Ygc2FpZCBpbmNyZW1lbnRhbCB6b29tIGZhY3Rvciwgd2hp Y2ggaXMKKyAgICAgICAgbm90IGRvbmUgeWV0LgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tC ZXJyeTo6V2ViS2l0OjpXZWJQYWdlOjpyZXNldEJsb2NrWm9vbSk6CisgICAgICAgIChXZWJLaXQp OgorICAgICAgICAqIEFwaS9XZWJQYWdlLmg6CisKIDIwMTItMDgtMjEgIEphY2t5IEppYW5nICA8 emhhamlhbmdAcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gYWJvdXQ6bWVtb3J5IGFu ZCBhYm91dDptZW1vcnktbGl2ZSBzaG91bGQgc2hvdyBudW1iZXJzIGZvciB0aGUgY2hyb21lIHBy b2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5j cHAgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCmluZGV4IDI4NDM1 MmU2YjE5ZjA2ODE4Yzk0NzU0NmM2YjgwNWNkOWI4MWUxYTguLjhjMjJmMDg0NWZhZGVmZGZhMTI4 YjE5ZjJjNzI2OGFiMzgwMjc4YjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9BcGkvV2ViUGFnZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmNwcApAQCAtMzE2MCw2ICszMTYwLDExIEBAIHZvaWQgV2ViUGFnZTo6YmxvY2tab29tQW5p bWF0aW9uRmluaXNoZWQoKQogICAgIGQtPnpvb21CbG9jaygpOwogfQogCit2b2lkIFdlYlBhZ2U6 OnJlc2V0QmxvY2tab29tKCkKK3sKKyAgICBkLT5yZXNldEJsb2NrWm9vbSgpOworfQorCiB2b2lk IFdlYlBhZ2VQcml2YXRlOjpyZXNldEJsb2NrWm9vbSgpCiB7CiAgICAgbV9jdXJyZW50QmxvY2ta b29tTm9kZSA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dl YlBhZ2UuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5oCmluZGV4IDE2 MGRiNWJjMGNkNTQyZGZiMThjYzE4YzY1MTc2NjczN2JkZTI0NTAuLmZlN2UwZWU5MTk0MGNhMzRm YWVmODY4MGM0ODUyYmZjNzM0YjQyNTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9BcGkvV2ViUGFnZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2Vi UGFnZS5oCkBAIC0xODgsNiArMTg4LDcgQEAgcHVibGljOgogICAgIHZvaWQgem9vbVRvSW5pdGlh bFNjYWxlKCk7CiAgICAgYm9vbCBibG9ja1pvb20oaW50IHgsIGludCB5KTsKICAgICB2b2lkIGJs b2NrWm9vbUFuaW1hdGlvbkZpbmlzaGVkKCk7CisgICAgdm9pZCByZXNldEJsb2NrWm9vbSgpOwog ICAgIGJvb2wgaXNBdEluaXRpYWxab29tKCkgY29uc3Q7CiAgICAgYm9vbCBpc01heFpvb21lZCgp IGNvbnN0OwogICAgIGJvb2wgaXNNaW5ab29tZWQoKSBjb25zdDsK