94849 2012-08-23 14:14:57 -0700 [GTK] Compiling with --disable-blob fails with undefined symbol 2015-01-02 20:23:11 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Mac (Intel) OS X 10.6 RESOLVED INVALID P2 Minor --- 0 philip.chimento webkit-unassigned pnormand webkit.review.bot xan.lopez oldest_to_newest 703349 0 160238 philip.chimento 2012-08-23 14:14:57 -0700 Created attachment 160238 Patch that fixes the problem Configuring with --disable-blob causes make to fail with an undefined symbol. Here is a patch (based on WebKitGTK 1.8.3) that fixes it. (This would seem to imply that bug #44867 has been fixed somewhere along the line.) 703355 1 webkit.review.bot 2012-08-23 14:18:00 -0700 Attachment 160238 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 704047 2 pnormand 2012-08-24 06:24:35 -0700 *** This bug has been marked as a duplicate of bug 94919 *** 704108 3 xan.lopez 2012-08-24 08:04:59 -0700 This is not really the same issue than bug 94919, but I don't think that's the right patch either. Basically the method should be a non-op when the feature is disabled, so move the #ifdefs into it I'd say. 704112 4 160238 xan.lopez 2012-08-24 08:11:02 -0700 Comment on attachment 160238 Patch that fixes the problem r- per previous comment. Basically I think this should take into account the ENABLE features in WebKit (see how the bindings are generated), but the compat. method should always be present to not break API (and thus, the WebKitDOMBlob type should always be present too). I believe this is how we do the other stuff. 704664 5 philip.chimento 2012-08-25 00:35:56 -0700 So you're saying that rather than simply moving the #ifdef's inside the function body, I should make sure a stub WebKitDOMBlob type is defined? Or simply remove the #ifdef's from WebKitDOMBlob? 704674 6 xan.lopez 2012-08-25 03:09:28 -0700 (In reply to comment #5) > So you're saying that rather than simply moving the #ifdef's inside the function body, I should make sure a stub WebKitDOMBlob type is defined? Or simply remove the #ifdef's from WebKitDOMBlob? I'm saying that I think the right fix is to change the WebKitDOMBlob creation so that it respects the ENABLE(BLOB) flags, like other GObject DOM types do (see for instance WebKitDOMTimeRanges). We cannot remove the methods themselves randomly, otherwise we'd break API. If we do that I think the code in WebKitDOMCustom would probably just remain as is, being a no-op. 704681 7 160562 philip.chimento 2012-08-25 04:50:13 -0700 Created attachment 160562 Sample patch So, you're saying all it should take is a Conditional=BLOB in Blob.idl, like the attached patch (WARNING- not tested, don't commit.) Does that mean I should remove the #if !ENABLE(BLOB) around slice() and webkitSlice() in the IDL file? Is this the way I should be tackling the related bugs I filed, #94851 and #94853? 1058500 8 philip.chimento 2015-01-02 20:23:11 -0800 I don't believe this is a problem anymore. 160238 2012-08-23 14:14:57 -0700 2012-08-25 04:50:13 -0700 Patch that fixes the problem webkit-1.8-enable-blob.patch text/plain 665 philip.chimento Q29tcGlsaW5nIHdpdGggLS1kaXNhYmxlLWJsb2IgaXMgYnJva2VuOyB0aGlzIGZpeGVzIGl0LgoK LS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvZ29iamVjdC9XZWJLaXRET01DdXN0b20uY3Bw CTIwMTItMDEtMDYgMTk6MjQ6MTEuMDAwMDAwMDAwICswMTAwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2dvYmplY3QvV2ViS2l0RG9tQ3VzdG9tLmNwcAkyMDEyLTAxLTA2IDE5OjI0OjE3 LjAwMDAwMDAwMCArMDEwMApAQCAtNDIsMTIgKzQyLDE0IEBACiAgICAgcmV0dXJuIGNvcmUoaW5w dXQpLT5sYXN0Q2hhbmdlV2FzVXNlckVkaXQoKTsKIH0KIAorI2lmZGVmIEVOQUJMRV9CTE9CCiAv KiBDb21wYXRpYmlsaXR5ICovCiBXZWJLaXRET01CbG9iKgogd2Via2l0X2RvbV9ibG9iX3NsaWNl KFdlYktpdERPTUJsb2IqIHNlbGYsIGdpbnQ2NCBzdGFydCwgZ2ludDY0IGVuZCwgY29uc3QgZ2No YXIqIGNvbnRlbnRfdHlwZSkKIHsKICAgICByZXR1cm4gd2Via2l0X2RvbV9ibG9iX3dlYmtpdF9z bGljZShzZWxmLCBzdGFydCwgZW5kLCBjb250ZW50X3R5cGUpOwogfQorI2VuZGlmIEVOQUJMRV9C TE9CCiAKIHZvaWQKIHdlYmtpdF9kb21faHRtbF9mb3JtX2VsZW1lbnRfZGlzcGF0Y2hfZm9ybV9j aGFuZ2UoV2ViS2l0RE9NSFRNTEZvcm1FbGVtZW50KiBzZWxmKQo= 160562 2012-08-25 04:50:13 -0700 2012-08-25 04:50:13 -0700 Sample patch 0001-Fix-compiling-with-disable-blob.patch text/plain 677 philip.chimento RnJvbSAyZjFkNDVmNGNjZTk4NWI5Nzg5ZjgwN2RlYjEwODk5ZTc0YWE2ZDI4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXAgQ2hpbWVudG8gPHBoaWxpcC5jaGltZW50b0BnbWFp bC5jb20+CkRhdGU6IFNhdCwgMjUgQXVnIDIwMTIgMTM6NDQ6MzkgKzAyMDAKU3ViamVjdDogW1BB VENIXSBGaXggY29tcGlsaW5nIHdpdGggLS1kaXNhYmxlLWJsb2IKCi0tLQogU291cmNlL1dlYkNv cmUvZmlsZWFwaS9CbG9iLmlkbCB8ICAgIDEgKwogMSBmaWxlcyBjaGFuZ2VkLCAxIGluc2VydGlv bnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZmlsZWFw aS9CbG9iLmlkbCBiL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5pZGwKaW5kZXggYjQ0ZWI0 My4uYzdhNmYzNWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5pZGwK KysrIGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9CbG9iLmlkbApAQCAtMzEsNiArMzEsNyBAQAog bW9kdWxlIGh0bWwgewogCiAgICAgaW50ZXJmYWNlIFsKKyAgICAgICAgQ29uZGl0aW9uYWw9QkxP QiwKICAgICAgICAgSlNHZW5lcmF0ZUlzUmVhY2hhYmxlPUltcGwsCiAgICAgICAgIEN1c3RvbVRv SlNPYmplY3QsCiAgICAgICAgIEpTTm9TdGF0aWNUYWJsZXMsCi0tIAoxLjcuMy4yCgo=