94842 2012-08-23 13:44:34 -0700 Remove RenderTable::removeChild 2012-08-24 12:30:25 -0700 1 1 1 Unclassified WebKit Tables 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 94843 1 jchaffraix jchaffraix bdakin eric hyatt inferno webkit.review.bot oldest_to_newest 703320 0 jchaffraix 2012-08-23 13:44:34 -0700 Table post-child-removal invalidations all go through RenderTable::removeChild. This is a blunt hammer as we have different type of children and not all have the same invalidation. Since we introduced willBeRemovedFromTree, we can remove the function and do only the needed invalidation in the children's function. This will show that some of our code is now unneeded that I intent to remove follow-up patches. 703332 1 160234 jchaffraix 2012-08-23 13:59:02 -0700 Created attachment 160234 Proposed change: Added the proper willBeRemovedFromTree and moved the removeChild code there. 703497 2 160234 webkit.review.bot 2012-08-23 16:01:57 -0700 Comment on attachment 160234 Proposed change: Added the proper willBeRemovedFromTree and moved the removeChild code there. Clearing flags on attachment: 160234 Committed r126495: <http://trac.webkit.org/changeset/126495> 703498 3 webkit.review.bot 2012-08-23 16:02:00 -0700 All reviewed patches have been landed. Closing bug. 704338 4 inferno 2012-08-24 12:30:25 -0700 ASSERTION FAILED: index != notFound third_party/WebKit/Source/WebCore/rendering/RenderTable.cpp(203) : void WebCore::RenderTable::removeCaption(const WebCore::RenderTableCaption *) https://cluster-fuzz.appspot.com/testcase?key=98951173 Testcase:: <style>.caption { display: table-caption </style> >><div id=tCF86>><rp>><theader id=tCF98></theader><div class=caption>><setvar id=tCF108>><script> var docElement = document.body ? document.body : document.documentElement; docElement.contentEditable = "true"; function initCF() { setTimeout("CFcrash()", 408); } document.addEventListener("DOMContentLoaded", initCF, false); function selectRangeBetween(r, sNode, eNode) { window.getSelection().removeAllRanges(); r.setEnd(eNode, eNode.childNodes.length); window.getSelection().addRange(r); } function editFuzz() { try { r = document.createRange(); selectRangeBetween(r, tCF86, tCF108); } catch(e) {} try { document.execCommand("InsertText", false, "the mesage ") } catch(e) {} } function CFcrash() { try { tCF98.style.display = "table-caption" } catch(e) {} setTimeout("editFuzz()", 1922); }</script>> 160234 2012-08-23 13:59:02 -0700 2012-08-23 16:01:57 -0700 Proposed change: Added the proper willBeRemovedFromTree and moved the removeChild code there. bug-94842-20120823135859.patch text/plain 7099 jchaffraix U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NDQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWFlMzExY2YwNWJlNDZj YzFiM2NhMjU2MTFlYjNlNWMwNjQzNTJjNy4uZTAwYzM5NTQ1OTk3YmVmYzFiYTY1OWIyZTMyNTBi YTMzNDEwODY1NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTA4LTIzICBKdWxp ZW4gQ2hhZmZyYWl4ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIFJlbW92ZSBS ZW5kZXJUYWJsZTo6cmVtb3ZlQ2hpbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTk0ODQyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgVGhpcyBjaGFuZ2UgcmVtb3ZlZCByZW1vdmVDaGlsZCwgcmVwbGFjZWQg Ynkgd2lsbEJlUmVtb3ZlZEZyb21UcmVlIGNhbGxzLiBUaGUgdXBzaWRlIGlzIHRoYXQKKyAgICAg ICAgdGhlIGludmFsaWRhdGlvbnMgYXJlIG5vdyBndWFyYW50ZWVkIHRvIHJ1biBpZiB3ZSBzcGxp dCBhIHRhYmxlICh3aGljaCBpcyBub3QgZ3VhcmFudGVlZCB3aGVuCisgICAgICAgIHVzaW5nIHJl bW92ZUNoaWxkKS4gVGhpcyBjaGFuZ2UgYWxzbyBzaG93cyB0aGF0IG91ciBjb2RlIG1heSBiZSBk b2luZyB0b28gbXVjaCB3b3JrIGluIHNvbWUKKyAgICAgICAgb2YgdGhlIGNoaWxkJ3MgcmVtb3Zh bCwgaW4gd2hpY2ggY2FzZSB0aGUgY29kZSB3YXMgbWFya2VkIGFzIG5lZWRlZC4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl clRhYmxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlOjpyZW1vdmVDYXB0aW9u KToKKyAgICAgICAgSGVscGVyIGZ1bmN0aW9uIHVzZWQgdG8gcmVtb3ZlIHRoZSBjYXB0aW9uIGZy b20gb3VyIFZlY3Rvci4gVGhlIGludmFsaWRhdGlvbiBhcmUgdmVyeSBsaWtlbHkKKyAgICAgICAg dW5uZWVkZWQgc28gYWRkZWQgYSBjb21tZW50IGFib3V0IHRoYXQuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyVGFibGUuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGVDYXB0 aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ2FwdGlvbjo6d2lsbEJlUmVt b3ZlZEZyb21UcmVlKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRhYmxlQ2FwdGlvbjo6dGFi bGUpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJUYWJsZUNhcHRpb24uaDoKKyAgICAgICAg KiByZW5kZXJpbmcvUmVuZGVyVGFibGVDb2wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVy VGFibGVDb2w6OndpbGxCZVJlbW92ZWRGcm9tVHJlZSk6CisgICAgICAgICogcmVuZGVyaW5nL1Jl bmRlclRhYmxlQ29sLmg6CisgICAgICAgIEFkZGVkIHRoZSBmb2xsb3dpbmcgZnVuY3Rpb25zIHRv IGRvIHRoZSBpbnZhbGlkYXRpb24uCisKIDIwMTItMDgtMjMgIEpvaG4gR3JpZ2dzICA8amdyaWdn c0ByaW0uY29tPgogCiAgICAgICAgICAgICAgICAgUmVwbGFjZSBhY2Nlc3Mgb3QgSFRNTE1lZGlh RWxlbWVudCBmcm9tIE1lZGlhUGxheWVyUHJpdmF0ZUJsYWNrQmVycnkgd2l0aCBtZXRob2RzIGlu IE1lZGlhUGxheWVyQ2xpZW50IC0gdXBkYXRlZCB3aXRoIG5vdGVzIGZyb20gaW5pdGlhbCByZXZp ZXdzLiAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTg0MjkxCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwIGIvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcAppbmRleCA3NzQyOGM0OTlkMWY1ZmQz OWVmMzljZGI5ZDdkYjk4NzhmMzliZTQ2Li5iNWMzMDgzNzNkZjM2ZDZiMjg3NmM5YWM1MzllN2Vk MDBkOTZlNGM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFi bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKQEAg LTE5NywxNiArMTk3LDE3IEBAIHZvaWQgUmVuZGVyVGFibGU6OmFkZENoaWxkKFJlbmRlck9iamVj dCogY2hpbGQsIFJlbmRlck9iamVjdCogYmVmb3JlQ2hpbGQpCiAgICAgc2VjdGlvbi0+YWRkQ2hp bGQoY2hpbGQpOwogfQogCi12b2lkIFJlbmRlclRhYmxlOjpyZW1vdmVDaGlsZChSZW5kZXJPYmpl Y3QqIG9sZENoaWxkKQordm9pZCBSZW5kZXJUYWJsZTo6cmVtb3ZlQ2FwdGlvbihjb25zdCBSZW5k ZXJUYWJsZUNhcHRpb24qIG9sZENhcHRpb24pCiB7Ci0gICAgUmVuZGVyQm94OjpyZW1vdmVDaGls ZChvbGRDaGlsZCk7Ci0gCi0gICAgc2l6ZV90IGluZGV4ID0gbV9jYXB0aW9ucy5maW5kKG9sZENo aWxkKTsKLSAgICBpZiAoaW5kZXggIT0gbm90Rm91bmQpIHsKLSAgICAgICAgbV9jYXB0aW9ucy5y ZW1vdmUoaW5kZXgpOwotICAgICAgICBpZiAobm9kZSgpKQotICAgICAgICAgICAgbm9kZSgpLT5z ZXROZWVkc1N0eWxlUmVjYWxjKCk7Ci0gICAgfQorICAgIHNpemVfdCBpbmRleCA9IG1fY2FwdGlv bnMuZmluZChvbGRDYXB0aW9uKTsKKyAgICBBU1NFUlQoaW5kZXggIT0gbm90Rm91bmQpOworICAg IG1fY2FwdGlvbnMucmVtb3ZlKGluZGV4KTsKKworICAgIC8vIEZJWE1FOiBUaGUgcmVzdCBvZiB0 aGlzIGZ1bmN0aW9uIGlzIHByb2JhYmx5IG5vdCBuZWVkZWQgc2luY2Ugd2UgaGF2ZSAKKyAgICAv LyBpbXBsZW1lbnRlZCBwcm9wZXIgbXVsdGlwbGUgY2FwdGlvbnMgc3VwcG9ydCAoc2VlIGJ1ZyA1 ODI0OSkuCisgICAgaWYgKG5vZGUoKSkKKyAgICAgICAgbm9kZSgpLT5zZXROZWVkc1N0eWxlUmVj YWxjKCk7CisKICAgICBzZXROZWVkc1NlY3Rpb25SZWNhbGMoKTsKIH0KIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmggYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvUmVuZGVyVGFibGUuaAppbmRleCBlNGM3MGY0N2ZjOWQ1MWYzYWY0MzViNDFiOTll NDVhOTIwZTVmNGMwLi5iYmFmZGI3MTZmY2UxYjQ2ZTc0ZGI0ZjhmOTJiODY3ZTIxMzk4ZWRjIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuaApAQCAtMjMxLDYgKzIzMSw4IEBA IHB1YmxpYzoKICAgICBjb25zdCBCb3JkZXJWYWx1ZSYgdGFibGVTdGFydEJvcmRlckFkam9pbmlu Z0NlbGwoY29uc3QgUmVuZGVyVGFibGVDZWxsKikgY29uc3Q7CiAgICAgY29uc3QgQm9yZGVyVmFs dWUmIHRhYmxlRW5kQm9yZGVyQWRqb2luaW5nQ2VsbChjb25zdCBSZW5kZXJUYWJsZUNlbGwqKSBj b25zdDsKIAorICAgIHZvaWQgcmVtb3ZlQ2FwdGlvbihjb25zdCBSZW5kZXJUYWJsZUNhcHRpb24q KTsKKwogcHJvdGVjdGVkOgogICAgIHZpcnR1YWwgdm9pZCBzdHlsZURpZENoYW5nZShTdHlsZURp ZmZlcmVuY2UsIGNvbnN0IFJlbmRlclN0eWxlKiBvbGRTdHlsZSk7CiAKQEAgLTI0MSw4ICsyNDMs NiBAQCBwcml2YXRlOgogCiAgICAgdmlydHVhbCBib29sIGF2b2lkc0Zsb2F0cygpIGNvbnN0IHsg cmV0dXJuIHRydWU7IH0KIAotICAgIHZpcnR1YWwgdm9pZCByZW1vdmVDaGlsZChSZW5kZXJPYmpl Y3QqIG9sZENoaWxkKTsKLQogICAgIHZpcnR1YWwgdm9pZCBwYWludChQYWludEluZm8mLCBjb25z dCBMYXlvdXRQb2ludCYpOwogICAgIHZpcnR1YWwgdm9pZCBwYWludE9iamVjdChQYWludEluZm8m LCBjb25zdCBMYXlvdXRQb2ludCYpOwogICAgIHZpcnR1YWwgdm9pZCBwYWludEJveERlY29yYXRp b25zKFBhaW50SW5mbyYsIGNvbnN0IExheW91dFBvaW50Jik7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDYXB0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3JlbmRlcmluZy9SZW5kZXJUYWJsZUNhcHRpb24uY3BwCmluZGV4IGI4NDg5MWM3ZjhiZTk0YWVh MWI5MWI1MWY5NWY2ODYzMWNjNWQ3YWUuLjk3ODVmMzcyZDU3ZDgxYTZlNDlmZThjYmZlOTQzZmQ4 Y2ZiODUwMTMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJs ZUNhcHRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNh cHRpb24uY3BwCkBAIC0yMCw2ICsyMCw4IEBACiAjaW5jbHVkZSAiY29uZmlnLmgiCiAjaW5jbHVk ZSAiUmVuZGVyVGFibGVDYXB0aW9uLmgiCiAKKyNpbmNsdWRlICJSZW5kZXJUYWJsZS5oIgorCiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKIFJlbmRlclRhYmxlQ2FwdGlvbjo6UmVuZGVyVGFibGVDYXB0 aW9uKE5vZGUqIG5vZGUpCkBAIC0zNyw0ICszOSwxNiBAQCBMYXlvdXRVbml0IFJlbmRlclRhYmxl Q2FwdGlvbjo6Y29udGFpbmluZ0Jsb2NrTG9naWNhbFdpZHRoRm9yQ29udGVudCgpIGNvbnN0CiAg ICAgcmV0dXJuIGNiLT5sb2dpY2FsV2lkdGgoKTsKIH0KIAordm9pZCBSZW5kZXJUYWJsZUNhcHRp b246OndpbGxCZVJlbW92ZWRGcm9tVHJlZSgpCit7CisgICAgUmVuZGVyQmxvY2s6OndpbGxCZVJl bW92ZWRGcm9tVHJlZSgpOworCisgICAgdGFibGUoKS0+cmVtb3ZlQ2FwdGlvbih0aGlzKTsKK30K KworUmVuZGVyVGFibGUqIFJlbmRlclRhYmxlQ2FwdGlvbjo6dGFibGUoKSBjb25zdAoreworICAg IHJldHVybiB0b1JlbmRlclRhYmxlKHBhcmVudCgpKTsKK30KKwogfQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2FwdGlvbi5oIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ2FwdGlvbi5oCmluZGV4IDIzMDc5YzBlOTYyMGE4NWQy MzA3Mjg4NTAwNjJlZDE5ODQzYjVhMGUuLmI1MDVlYmUxMDI3MDY5ZWE5OTNjMzUzZGMxNjg5OGM0 YjVlMjliZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJs ZUNhcHRpb24uaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDYXB0 aW9uLmgKQEAgLTI0LDYgKzI0LDggQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFzcyBS ZW5kZXJUYWJsZTsKKwogY2xhc3MgUmVuZGVyVGFibGVDYXB0aW9uIDogcHVibGljIFJlbmRlckJs b2NrIHsKIHB1YmxpYzoKICAgICBleHBsaWNpdCBSZW5kZXJUYWJsZUNhcHRpb24oTm9kZSopOwpA QCAtMzIsNiArMzQsMTAgQEAgcHVibGljOgogICAgIAogcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJv b2wgaXNUYWJsZUNhcHRpb24oKSBjb25zdCBPVkVSUklERSB7IHJldHVybiB0cnVlOyB9CisKKyAg ICB2aXJ0dWFsIHZvaWQgd2lsbEJlUmVtb3ZlZEZyb21UcmVlKCkgT1ZFUlJJREU7CisKKyAgICBS ZW5kZXJUYWJsZSogdGFibGUoKSBjb25zdDsKIH07CiAKIGlubGluZSBSZW5kZXJUYWJsZUNhcHRp b24qIHRvUmVuZGVyVGFibGVDYXB0aW9uKFJlbmRlck9iamVjdCogb2JqZWN0KQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ29sLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNvbC5jcHAKaW5kZXggOTdjZDhjYzNlZDA5NTY4 ZjY4OTE2MGE1MGRlODY5NDM3MDBjZGUyOS4uN2M1ZTllZDEwY2Y1NTA5ZWZiMDExZDg4Y2JlYTBk MGUwM2EwMzZjNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRh YmxlQ29sLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGVDb2wu Y3BwCkBAIC02OSw2ICs2OSwxNiBAQCB2b2lkIFJlbmRlclRhYmxlQ29sOjp1cGRhdGVGcm9tRWxl bWVudCgpCiAgICAgICAgIHNldE5lZWRzTGF5b3V0QW5kUHJlZldpZHRoc1JlY2FsYygpOwogfQog Cit2b2lkIFJlbmRlclRhYmxlQ29sOjp3aWxsQmVSZW1vdmVkRnJvbVRyZWUoKQoreworICAgIFJl bmRlckJveDo6d2lsbEJlUmVtb3ZlZEZyb21UcmVlKCk7CisKKyAgICAvLyBXZSBkb24ndCByZWFs bHkgbmVlZCB0byByZWNvbXB1dGUgb3VyIHNlY3Rpb25zLCBidXQgd2UgbmVlZCB0byB1cGRhdGUg b3VyCisgICAgLy8gY29sdW1uIGNvdW50IGFuZCB3aGV0aGVyIHdlIGhhdmUgYSBjb2x1bW4uIEN1 cnJlbnRseSwgd2Ugb25seSBoYXZlIG9uZQorICAgIC8vIHNpemUtZml0LWFsbCBmbGFnIGJ1dCB3 ZSBtYXkgaGF2ZSB0byBjb25zaWRlciBzcGxpdHRpbmcgaXQuCisgICAgdGFibGUoKS0+c2V0TmVl ZHNTZWN0aW9uUmVjYWxjKCk7Cit9CisKIGJvb2wgUmVuZGVyVGFibGVDb2w6OmlzQ2hpbGRBbGxv d2VkKFJlbmRlck9iamVjdCogY2hpbGQsIFJlbmRlclN0eWxlKiBzdHlsZSkgY29uc3QKIHsKICAg ICAvLyBXZSBjYW5ub3QgdXNlIGlzVGFibGVDb2x1bW4gaGVyZSBhcyBzdHlsZSgpIG1heSByZXR1 cm4gMC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZUNv bC5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlQ29sLmgKaW5kZXggNjJm MzI4OGU4ZDY2Mzg3NDBmNjllZjYxZGY2ODdhYmJlYmMyNDIxYy4uODg3YWZkNmM4NWEwYzVhODY1 ZmEzYjE1MzZiMWUwZmM0MDM0M2UzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclRhYmxlQ29sLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRhYmxlQ29sLmgKQEAgLTc1LDYgKzc1LDggQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIGJvb2wg aXNSZW5kZXJUYWJsZUNvbCgpIGNvbnN0IE9WRVJSSURFIHsgcmV0dXJuIHRydWU7IH0KICAgICB2 aXJ0dWFsIHZvaWQgdXBkYXRlRnJvbUVsZW1lbnQoKTsKIAorICAgIHZpcnR1YWwgdm9pZCB3aWxs QmVSZW1vdmVkRnJvbVRyZWUoKSBPVkVSUklERTsKKwogICAgIHZpcnR1YWwgYm9vbCBpc0NoaWxk QWxsb3dlZChSZW5kZXJPYmplY3QqLCBSZW5kZXJTdHlsZSopIGNvbnN0OwogICAgIHZpcnR1YWwg Ym9vbCBjYW5IYXZlQ2hpbGRyZW4oKSBjb25zdDsKICAgICB2aXJ0dWFsIGJvb2wgcmVxdWlyZXNM YXllcigpIGNvbnN0IHsgcmV0dXJuIGZhbHNlOyB9Cg==