94826 2012-08-23 10:13:15 -0700 Web Inspector: dblclick on Timeline overview no longer selects entire timeline range 2012-08-23 10:45:47 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 caseq caseq apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 703106 0 caseq 2012-08-23 10:13:15 -0700 0. Open WebInspector, switch to Timeline 1. Record a timeline 2. Double click on overview pane EXPECTED: Overview selection window is set to entire timeline range ACTUAL: A minimal interval is selected, as would be upon a single click This was apparently regressed by r123313 703107 1 160191 caseq 2012-08-23 10:15:32 -0700 Created attachment 160191 Patch 703126 2 160191 vsevik 2012-08-23 10:30:21 -0700 Comment on attachment 160191 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160191&action=review > Source/WebCore/inspector/front-end/UIUtils.js:69 > + function onMouseOut() WebInspector._mouseOutWhileDragging = function()... ? > Source/WebCore/inspector/front-end/UIUtils.js:71 > + targetDocument.removeEventListener("mouseout", onMouseOut, true); I would extract removeEventListener and delete statement. 703138 3 caseq 2012-08-23 10:45:47 -0700 Committed r126445: <http://trac.webkit.org/changeset/126445> 160191 2012-08-23 10:15:32 -0700 2012-08-23 10:30:20 -0700 Patch bug-94826-20120823211528.patch text/plain 3524 caseq U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2NhOWM1ODk5MjFlMDE2 NGE2ZGFhYWVlNDFlNjQ3NjIyNjVjNWUyNy4uMzU4OGMzNjhmYjJkMTc5NTFkMmEzNDFkNTgwMjgw YTZmNGQwMWEyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA4LTIzICBBbmRy ZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogZGJsY2xpY2sgb24gVGltZWxpbmUgb3ZlcnZpZXcgbm8gbG9uZ2VyIHNlbGVjdHMgZW50aXJl IHRpbWVsaW5lIHJhbmdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NDgyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIE9ubHkgaW5zdGFsbCBhIGdsYXNzIHBhbmUgZm9yIGRyYWctbi1kcm9wIHVwb24gZmly c3QgbW91c2VvdXQgZXZlbnQgLS0gb3RoZXJ3aXNlLCBnbGFzcyBwYW5lCisgICAgICAgIHdpbGwg aW50ZXJmZXJlIHdpdGggZG91YmxlIGNsaWNrcy4KKworICAgICAgICAqIGluc3BlY3Rvci9mcm9u dC1lbmQvVUlVdGlscy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdTdGFy dC5vbk1vdXNlT3V0KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdTdGFydCk6 CisgICAgICAgIChXZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnRW5kKToKKwogMjAxMi0wOC0yMiAg UGF0cmljayBHYW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBCdWlsZCBm aXggZm9yIFdpbkNFIGFmdGVyIHIxMjYzNTkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL1VJVXRpbHMuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1VJVXRpbHMuanMKaW5kZXggYzFlMDc1ODRlZjc3YWRlMzJjN2M4Mjc3MzVlY2Vh YmQyNzA3MDBjZC4uOWRlOGRiYWJiY2M3YWNiMWI2MDFiY2RiM2U4ZTdkZTM1ZjExOTQ4ZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9VSVV0aWxzLmpzCisr KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVUlVdGlscy5qcwpAQCAtNjAs MTggKzYwLDI3IEBAIFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdTdGFydCA9IGZ1bmN0aW9uKGVs ZW1lbnREcmFnU3RhcnQsIGVsZW1lbnREcmFnLCBlbGVtZW50CiAgICAgaWYgKGVsZW1lbnREcmFn U3RhcnQgJiYgIWVsZW1lbnREcmFnU3RhcnQoZXZlbnQpKQogICAgICAgICByZXR1cm47CiAKLSAg ICAvLyBJbnN0YWxsIGdsYXNzIHBhbmUKLSAgICBpZiAoV2ViSW5zcGVjdG9yLl9lbGVtZW50RHJh Z2dpbmdHbGFzc1BhbmUpCisgICAgaWYgKFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdnaW5nR2xh c3NQYW5lKSB7CiAgICAgICAgIFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdnaW5nR2xhc3NQYW5l LmRpc3Bvc2UoKTsKKyAgICAgICAgZGVsZXRlIFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdnaW5n R2xhc3NQYW5lOworICAgIH0KIAotICAgIFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdnaW5nR2xh c3NQYW5lID0gbmV3IFdlYkluc3BlY3Rvci5HbGFzc1BhbmUoKTsKKyAgICAvLyBJbnN0YWxsIGds YXNzIHBhbmUgb25seSB1cG9uIG1vdXNlb3V0CisgICAgZnVuY3Rpb24gb25Nb3VzZU91dCgpCisg ICAgeworICAgICAgICB0YXJnZXREb2N1bWVudC5yZW1vdmVFdmVudExpc3RlbmVyKCJtb3VzZW91 dCIsIG9uTW91c2VPdXQsIHRydWUpOworICAgICAgICBkZWxldGUgV2ViSW5zcGVjdG9yLl9kb2N1 bWVudE1vdXNlT3V0RXZlbnRMaXN0ZW5lcjsKKyAgICAgICAgV2ViSW5zcGVjdG9yLl9lbGVtZW50 RHJhZ2dpbmdHbGFzc1BhbmUgPSBuZXcgV2ViSW5zcGVjdG9yLkdsYXNzUGFuZSgpOworICAgIH0K IAogICAgIFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdnaW5nRXZlbnRMaXN0ZW5lciA9IGVsZW1l bnREcmFnOwogICAgIFdlYkluc3BlY3Rvci5fZWxlbWVudEVuZERyYWdnaW5nRXZlbnRMaXN0ZW5l ciA9IGVsZW1lbnREcmFnRW5kOworICAgIFdlYkluc3BlY3Rvci5fZG9jdW1lbnRNb3VzZU91dEV2 ZW50TGlzdGVuZXIgPSBvbk1vdXNlT3V0OwogCiAgICAgdmFyIHRhcmdldERvY3VtZW50ID0gZXZl bnQudGFyZ2V0Lm93bmVyRG9jdW1lbnQ7CiAgICAgdGFyZ2V0RG9jdW1lbnQuYWRkRXZlbnRMaXN0 ZW5lcigibW91c2Vtb3ZlIiwgV2ViSW5zcGVjdG9yLl9lbGVtZW50RHJhZ2dpbmdFdmVudExpc3Rl bmVyLCB0cnVlKTsKICAgICB0YXJnZXREb2N1bWVudC5hZGRFdmVudExpc3RlbmVyKCJtb3VzZXVw IiwgV2ViSW5zcGVjdG9yLl9lbGVtZW50RHJhZ0VuZCwgdHJ1ZSk7CisgICAgdGFyZ2V0RG9jdW1l bnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2VvdXQiLCBXZWJJbnNwZWN0b3IuX2RvY3VtZW50TW91 c2VPdXRFdmVudExpc3RlbmVyLCB0cnVlKTsKIAogICAgIHRhcmdldERvY3VtZW50LmJvZHkuc3R5 bGUuY3Vyc29yID0gY3Vyc29yOwogCkBAIC04Myw2ICs5Miw4IEBAIFdlYkluc3BlY3Rvci5fZWxl bWVudERyYWdFbmQgPSBmdW5jdGlvbihldmVudCkKICAgICB2YXIgdGFyZ2V0RG9jdW1lbnQgPSBl dmVudC50YXJnZXQub3duZXJEb2N1bWVudDsKICAgICB0YXJnZXREb2N1bWVudC5yZW1vdmVFdmVu dExpc3RlbmVyKCJtb3VzZW1vdmUiLCBXZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnZ2luZ0V2ZW50 TGlzdGVuZXIsIHRydWUpOwogICAgIHRhcmdldERvY3VtZW50LnJlbW92ZUV2ZW50TGlzdGVuZXIo Im1vdXNldXAiLCBXZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnRW5kLCB0cnVlKTsKKyAgICBpZiAo V2ViSW5zcGVjdG9yLl9kb2N1bWVudE1vdXNlT3V0RXZlbnRMaXN0ZW5lcikKKyAgICAgICAgdGFy Z2V0RG9jdW1lbnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigibW91c2VvdXQiLCBXZWJJbnNwZWN0b3Iu X2RvY3VtZW50TW91c2VPdXRFdmVudExpc3RlbmVyLCB0cnVlKTsKIAogICAgIHRhcmdldERvY3Vt ZW50LmJvZHkuc3R5bGUucmVtb3ZlUHJvcGVydHkoImN1cnNvciIpOwogCkBAIC05NCw2ICsxMDUs NyBAQCBXZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnRW5kID0gZnVuY3Rpb24oZXZlbnQpCiAgICAg ZGVsZXRlIFdlYkluc3BlY3Rvci5fZWxlbWVudERyYWdnaW5nR2xhc3NQYW5lOwogICAgIGRlbGV0 ZSBXZWJJbnNwZWN0b3IuX2VsZW1lbnREcmFnZ2luZ0V2ZW50TGlzdGVuZXI7CiAgICAgZGVsZXRl IFdlYkluc3BlY3Rvci5fZWxlbWVudEVuZERyYWdnaW5nRXZlbnRMaXN0ZW5lcjsKKyAgICBkZWxl dGUgV2ViSW5zcGVjdG9yLl9kb2N1bWVudE1vdXNlT3V0RXZlbnRMaXN0ZW5lcjsKIAogICAgIGV2 ZW50LnByZXZlbnREZWZhdWx0KCk7CiAgICAgaWYgKGVsZW1lbnREcmFnRW5kKQo=