94811 2012-08-23 07:27:26 -0700 Remove redundant check for negative values when using WebCore::Color::alpha() 2012-08-23 11:28:04 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bruno.abinader bruno.abinader eric igor.oliveira kling noam webkit.review.bot oldest_to_newest 702964 0 bruno.abinader 2012-08-23 07:27:26 -0700 Though alpha() returns a signed value (int), its value is stored on an unsigned typedef (RGBA32) and is safeguarded by alphaChannel() that its value never goes beyond 255, so no integer overflow, thus we can safely remove redundant check for negative values while using it. 702968 1 160158 bruno.abinader 2012-08-23 07:32:35 -0700 Created attachment 160158 Patch Proposed patch. 703152 2 160158 eric 2012-08-23 11:00:23 -0700 Comment on attachment 160158 Patch OK. 703181 3 160158 webkit.review.bot 2012-08-23 11:28:00 -0700 Comment on attachment 160158 Patch Clearing flags on attachment: 160158 Committed r126452: <http://trac.webkit.org/changeset/126452> 703182 4 webkit.review.bot 2012-08-23 11:28:04 -0700 All reviewed patches have been landed. Closing bug. 160158 2012-08-23 07:32:35 -0700 2012-08-23 11:28:00 -0700 Patch bug-94811-20120823103231.patch text/plain 5381 bruno.abinader U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MzUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzk1YzA0MmMxN2EwMzdk ZjIyM2IwNTlkZjU4YmUxZDJlZWU1MTNhOC4uMjdlNTAzMTdkM2EyNGQ4ODhkOTYyZmE5NGI1ZWI5 OWY4NTc4YjUzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA4LTIzICBCcnVu byBkZSBPbGl2ZWlyYSBBYmluYWRlciAgPGJydW5vLmFiaW5hZGVyQGJhc3lza29tLmNvbT4KKwor ICAgICAgICBSZW1vdmUgcmVkdW5kYW50IGNoZWNrIGZvciBuZWdhdGl2ZSB2YWx1ZXMgd2hlbiB1 c2luZyBXZWJDb3JlOjpDb2xvcjo6YWxwaGEoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTQ4MTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaG91Z2ggYWxwaGEoKSByZXR1cm5zIGEgc2lnbmVkIHZhbHVl IChpbnQpLCBpdHMgdmFsdWUgaXMgc3RvcmVkIG9uIGFuIHVuc2lnbmVkCisgICAgICAgIHR5cGVk ZWYgKFJHQkEzMikgYW5kIGlzIHNhZmVndWFyZGVkIGJ5IGFscGhhQ2hhbm5lbCgpIHRoYXQgaXRz IHZhbHVlIG5ldmVyIGdvZXMKKyAgICAgICAgYmV5b25kIDI1NSwgc28gbm8gaW50ZWdlciBvdmVy ZmxvdywgdGh1cyB3ZSBjYW4gc2FmZWx5IHJlbW92ZSByZWR1bmRhbnQgY2hlY2sKKyAgICAgICAg Zm9yIG5lZ2F0aXZlIHZhbHVlcyB3aGlsZSB1c2luZyBpdC4KKworICAgICAgICBUaGlzIGNoYW5n ZSBkb2VzIG5vdCBhZmZlY3QgYmVoYXZpb3IsIHNvIG5vIG5ldyB0ZXN0cyBuZWVkZWQuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9JbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJ bWFnZTo6ZmlsbFdpdGhTb2xpZENvbG9yKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQm94 TW9kZWxPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9kZWxPYmplY3Q6 OnBhaW50RmlsbExheWVyRXh0ZW5kZWQpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94TW9k ZWxPYmplY3Q6OmJveFNoYWRvd1Nob3VsZEJlQXBwbGllZFRvQmFja2dyb3VuZCk6IFVzaW5nIGhh c0FscGhhKCkgZm9yIHJlYWRpYmlsaXR5LgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclZpZXc6OnBhaW50Qm94RGVjb3JhdGlvbnMp OgorICAgICAgICAqIHJlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oOgorCiAyMDEyLTA4LTIy ICBBbGV4YW5kcmUgRWxpYXMgIDxhZWxpYXNAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21p dW1dIEFkZCBzb2Z0d2FyZSBiaXRtYXAgcmVzb3VyY2VzIHRvIENDUmVzb3VyY2VQcm92aWRlcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2UuY3BwCmluZGV4IDJiMTlmMTM0 OWZlYjAwNzNlY2JjNWQwYzc2OGUzZjhmMmE2MmZmZmUuLjY1NWI2ZDE0ZmE2YjYwZTlhOThiMGZm NDBkNWUxNmQzOWQ5MmY4ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL0ltYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9J bWFnZS5jcHAKQEAgLTgwLDcgKzgwLDcgQEAgYm9vbCBJbWFnZTo6c2V0RGF0YShQYXNzUmVmUHRy PFNoYXJlZEJ1ZmZlcj4gZGF0YSwgYm9vbCBhbGxEYXRhUmVjZWl2ZWQpCiAKIHZvaWQgSW1hZ2U6 OmZpbGxXaXRoU29saWRDb2xvcihHcmFwaGljc0NvbnRleHQqIGN0eHQsIGNvbnN0IEZsb2F0UmVj dCYgZHN0UmVjdCwgY29uc3QgQ29sb3ImIGNvbG9yLCBDb2xvclNwYWNlIHN0eWxlQ29sb3JTcGFj ZSwgQ29tcG9zaXRlT3BlcmF0b3Igb3ApCiB7Ci0gICAgaWYgKGNvbG9yLmFscGhhKCkgPD0gMCkK KyAgICBpZiAoIWNvbG9yLmFscGhhKCkpCiAgICAgICAgIHJldHVybjsKICAgICAKICAgICBDb21w b3NpdGVPcGVyYXRvciBwcmV2aW91c09wZXJhdG9yID0gY3R4dC0+Y29tcG9zaXRlT3BlcmF0aW9u KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxP YmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveE1vZGVsT2JqZWN0 LmNwcAppbmRleCBjYWYzMjdiMTNjODQyNzNiZTc5MzU2MjU0NDM0MGY4OTMzYmY3NzU4Li43OGYz ODBkMzMwMTBmZTMyYzdmZWViMGU4MTllYzBjZTRkN2E2NTNiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94TW9kZWxPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3hNb2RlbE9iamVjdC5jcHAKQEAgLTc0NSwxNCArNzQ1 LDE0IEBAIHZvaWQgUmVuZGVyQm94TW9kZWxPYmplY3Q6OnBhaW50RmlsbExheWVyRXh0ZW5kZWQo Y29uc3QgUGFpbnRJbmZvJiBwYWludEluZm8sIGNvCiAgICAgLy8gd2hpbGUgcmVuZGVyaW5nLikK ICAgICBpZiAoZm9yY2VCYWNrZ3JvdW5kVG9XaGl0ZSkgewogICAgICAgICAvLyBOb3RlIHRoYXQg d2UgY2FuJ3QgcmV1c2UgdGhpcyB2YXJpYWJsZSBiZWxvdyBiZWNhdXNlIHRoZSBiZ0NvbG9yIG1p Z2h0IGJlIGNoYW5nZWQKLSAgICAgICAgYm9vbCBzaG91bGRQYWludEJhY2tncm91bmRDb2xvciA9 ICFiZ0xheWVyLT5uZXh0KCkgJiYgYmdDb2xvci5pc1ZhbGlkKCkgJiYgYmdDb2xvci5hbHBoYSgp ID4gMDsKKyAgICAgICAgYm9vbCBzaG91bGRQYWludEJhY2tncm91bmRDb2xvciA9ICFiZ0xheWVy LT5uZXh0KCkgJiYgYmdDb2xvci5pc1ZhbGlkKCkgJiYgYmdDb2xvci5hbHBoYSgpOwogICAgICAg ICBpZiAoc2hvdWxkUGFpbnRCYWNrZ3JvdW5kSW1hZ2UgfHwgc2hvdWxkUGFpbnRCYWNrZ3JvdW5k Q29sb3IpIHsKICAgICAgICAgICAgIGJnQ29sb3IgPSBDb2xvcjo6d2hpdGU7CiAgICAgICAgICAg ICBzaG91bGRQYWludEJhY2tncm91bmRJbWFnZSA9IGZhbHNlOwogICAgICAgICB9CiAgICAgfQog Ci0gICAgYm9vbCBjb2xvclZpc2libGUgPSBiZ0NvbG9yLmlzVmFsaWQoKSAmJiBiZ0NvbG9yLmFs cGhhKCkgPiAwOworICAgIGJvb2wgY29sb3JWaXNpYmxlID0gYmdDb2xvci5pc1ZhbGlkKCkgJiYg YmdDb2xvci5hbHBoYSgpOwogICAgIAogICAgIC8vIEZhc3QgcGF0aCBmb3IgZHJhd2luZyBzaW1w bGUgY29sb3IgYmFja2dyb3VuZHMuCiAgICAgaWYgKCFpc1Jvb3QgJiYgIWNsaXBwZWRXaXRoTG9j YWxTY3JvbGxpbmcgJiYgIXNob3VsZFBhaW50QmFja2dyb3VuZEltYWdlICYmIGlzQm9yZGVyRmls bCAmJiAhYmdMYXllci0+bmV4dCgpKSB7CkBAIC0yNDIwLDcgKzI0MjAsNyBAQCBib29sIFJlbmRl ckJveE1vZGVsT2JqZWN0Ojpib3hTaGFkb3dTaG91bGRCZUFwcGxpZWRUb0JhY2tncm91bmQoQmFj a2dyb3VuZEJsZWVkQQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBDb2xvciBiYWNrZ3Jv dW5kQ29sb3IgPSBzdHlsZSgpLT52aXNpdGVkRGVwZW5kZW50Q29sb3IoQ1NTUHJvcGVydHlCYWNr Z3JvdW5kQ29sb3IpOwotICAgIGlmICghYmFja2dyb3VuZENvbG9yLmlzVmFsaWQoKSB8fCBiYWNr Z3JvdW5kQ29sb3IuYWxwaGEoKSA8IDI1NSkKKyAgICBpZiAoIWJhY2tncm91bmRDb2xvci5pc1Zh bGlkKCkgfHwgYmFja2dyb3VuZENvbG9yLmhhc0FscGhhKCkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKIAogICAgIGNvbnN0IEZpbGxMYXllciogbGFzdEJhY2tncm91bmRMYXllciA9IHN0eWxlKCkt PmJhY2tncm91bmRMYXllcnMoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJWaWV3LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNw cAppbmRleCBlYzJkMWI4NDI0NDQxZWJlNzhmYzQ0N2U1NzNkYjBhMWU5ZWNmZDJlLi42OThiMjNi MzczOWYzOGNlNTgwMTQ3NmU5MmZiYmMzYTQyMjBkMGZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlclZpZXcuY3BwCkBAIC0zMTQsNyArMzE0LDcgQEAgdm9pZCBSZW5kZXJWaWV3Ojpw YWludEJveERlY29yYXRpb25zKFBhaW50SW5mbyYgcGFpbnRJbmZvLCBjb25zdCBMYXlvdXRQb2lu dCYpCiAgICAgICAgIGZyYW1lVmlldygpLT5zZXRDYW5ub3RCbGl0VG9XaW5kb3coKTsgLy8gVGhl IHBhcmVudCBtdXN0IHNob3cgYmVoaW5kIHRoZSBjaGlsZC4KICAgICBlbHNlIHsKICAgICAgICAg Q29sb3IgYmFzZUNvbG9yID0gZnJhbWVWaWV3KCktPmJhc2VCYWNrZ3JvdW5kQ29sb3IoKTsKLSAg ICAgICAgaWYgKGJhc2VDb2xvci5hbHBoYSgpID4gMCkgeworICAgICAgICBpZiAoYmFzZUNvbG9y LmFscGhhKCkpIHsKICAgICAgICAgICAgIENvbXBvc2l0ZU9wZXJhdG9yIHByZXZpb3VzT3BlcmF0 b3IgPSBwYWludEluZm8uY29udGV4dC0+Y29tcG9zaXRlT3BlcmF0aW9uKCk7CiAgICAgICAgICAg ICBwYWludEluZm8uY29udGV4dC0+c2V0Q29tcG9zaXRlT3BlcmF0aW9uKENvbXBvc2l0ZUNvcHkp OwogICAgICAgICAgICAgcGFpbnRJbmZvLmNvbnRleHQtPmZpbGxSZWN0KHBhaW50SW5mby5yZWN0 LCBiYXNlQ29sb3IsIHN0eWxlKCktPmNvbG9yU3BhY2UoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuaCBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCmluZGV4IDA5MjVmODBiN2M0YmZiZWYwY2Y1OGEy Y2Q1MzBlZWRlNzdlNzNhNDcuLmU4MWE3YWQ2NTkwZmQwYjNiMDI2NjhkODRjZGU3N2Y5ZjFkYjFh NzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHls ZS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9SZW5kZXJTdHlsZS5oCkBA IC00MzYsNyArNDM2LDcgQEAgcHVibGljOgogICAgIGJvb2wgaGFzQmFja2dyb3VuZCgpIGNvbnN0 CiAgICAgewogICAgICAgICBDb2xvciBjb2xvciA9IHZpc2l0ZWREZXBlbmRlbnRDb2xvcihDU1NQ cm9wZXJ0eUJhY2tncm91bmRDb2xvcik7Ci0gICAgICAgIGlmIChjb2xvci5pc1ZhbGlkKCkgJiYg Y29sb3IuYWxwaGEoKSA+IDApCisgICAgICAgIGlmIChjb2xvci5pc1ZhbGlkKCkgJiYgY29sb3Iu YWxwaGEoKSkKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICByZXR1cm4gaGFzQmFj a2dyb3VuZEltYWdlKCk7CiAgICAgfQo=