94808 2012-08-23 06:59:43 -0700 [EFL][WK2] Free ewk context data on program exit. 2012-08-23 19:33:51 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 94697 1 kangil.han cdumez cdumez enmi.lee gyuyoung.kim kenneth lucas.de.marchi naginenis tonikitoo webkit.review.bot oldest_to_newest 702948 0 kangil.han 2012-08-23 06:59:43 -0700 Current implementation doesn't delete ewk context data. This patch fixed it by adding Ewk_Context to Ewk_View_Private_Data and deleting it explicitly when private data is deleted. 702951 1 160153 kangil.han 2012-08-23 07:06:41 -0700 Created attachment 160153 patch 702965 2 160153 ryuan.choi 2012-08-23 07:30:29 -0700 Comment on attachment 160153 patch View in context: https://bugs.webkit.org/attachment.cgi?id=160153&action=review > Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:118 > + ewk_context_free(context); I think that it is wrong because we can remove two ewk_views which use default context. 702972 3 160153 cdumez 2012-08-23 07:39:44 -0700 Comment on attachment 160153 patch View in context: https://bugs.webkit.org/attachment.cgi?id=160153&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:118 >> + ewk_context_free(context); > > I think that it is wrong because we can remove two ewk_views which use default context. Yes. eunmi already has a patch to make Ewk_Context ref counted and solve this problem. 702974 4 cdumez 2012-08-23 07:42:10 -0700 Please see Bug 89186. 702980 5 160153 cdumez 2012-08-23 07:49:27 -0700 Comment on attachment 160153 patch View in context: https://bugs.webkit.org/attachment.cgi?id=160153&action=review >>> Source/WebKit2/UIProcess/API/efl/ewk_view.cpp:118 >>> + ewk_context_free(context); >> >> I think that it is wrong because we can remove two ewk_views which use default context. > > Yes. eunmi already has a patch to make Ewk_Context ref counted and solve this problem. Also, Ewk_Context is currently a static variable returned by ewk_context_default_get() so you cannot free it like this. 702998 6 cdumez 2012-08-23 08:09:01 -0700 This is not really a leak. We use singleton pattern so the variable lives as long as the program. The memory will get freed by the OS on exit. 703053 7 160179 cdumez 2012-08-23 09:03:43 -0700 Created attachment 160179 Patch New proposal. 703055 8 160179 ryuan.choi 2012-08-23 09:09:15 -0700 Comment on attachment 160179 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160179&action=review > Source/WebKit2/UIProcess/API/efl/ewk_context.cpp:214 > - static Ewk_Context* defaultContext = createDefaultEwkContext(); > + if (!defaultContext) > + defaultContext = new Ewk_Context(adoptWK(WKContextCreate())); > > return defaultContext; > } > > +void ewk_context_default_free() > +{ > + delete defaultContext; > + defaultContext = 0; Are there any issue if we just change like below ? (might be DEFINE_STATIC_LOCAL) Ewk_Context* ewk_context_default_get() { - static Ewk_Context* defaultContext = createDefaultEwkContext(); + static Ewk_Context defaultContext(WKContextCreate()); - return defaultContext; + return &defaultContext; } 703084 9 160185 cdumez 2012-08-23 09:41:23 -0700 Created attachment 160185 Patch Take ryuan's feedback into consideration. Note that I cannot use DEFINE_STATIC_LOCAL because of the way it is defined (it calls "new" internally). 703086 10 160186 cdumez 2012-08-23 09:46:01 -0700 Created attachment 160186 Patch 703156 11 160186 webkit.review.bot 2012-08-23 11:02:12 -0700 Comment on attachment 160186 Patch Clearing flags on attachment: 160186 Committed r126448: <http://trac.webkit.org/changeset/126448> 703157 12 webkit.review.bot 2012-08-23 11:02:16 -0700 All reviewed patches have been landed. Closing bug. 703625 13 kangil.han 2012-08-23 18:13:59 -0700 I feel really really bad why chris landed this patch without asking my opinion. He had to review my patch and let me finish this! 703656 14 gyuyoung.kim 2012-08-23 19:07:13 -0700 (In reply to comment #13) > I feel really really bad why chris landed this patch without asking my opinion. He had to review my patch and let me finish this! Was there any discussion ? I don't barely see other contributor landed a patch without asking original patch owner. 703658 15 gyuyoung.kim 2012-08-23 19:11:34 -0700 (In reply to comment #14) > Was there any discussion ? I don't barely see other contributor landed a patch without asking original patch owner. Oops, typo. s/don't barely/barely/g 703670 16 kangil.han 2012-08-23 19:33:51 -0700 (In reply to comment #15) > (In reply to comment #14) > > > Was there any discussion ? I don't barely see other contributor landed a patch without asking original patch owner. > > Oops, typo. s/don't barely/barely/g Nope, chris never asked me about landing his code on my bug. Source code diff might be small, but the process on detection was really hard stuff. That's why I am so angry at him! 160153 2012-08-23 07:06:41 -0700 2012-08-23 09:03:43 -0700 patch patch.txt text/plain 3460 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyOGQ4ZmY1Li40MjI5ZTRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDgtMjMgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtFRkxdW1dLMl0gRnJlZSBld2sgY29udGV4dCBkYXRhIG9uIHByb2dyYW0gZXhpdC4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0ODA4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudCBp bXBsZW1lbnRhdGlvbiBkb2Vzbid0IGRlbGV0ZSBld2sgY29udGV4dCBkYXRhIG9uIHRlcm1pbmF0 aW9uLgorICAgICAgICBUaGVyZWZvcmUsIHRoaXMgcGF0Y2ggZml4ZWQgaXQgYnkgYWRkaW5nIEV3 a19Db250ZXh0IHRvIEV3a19WaWV3X1ByaXZhdGVfRGF0YSBhbmQgZGVsZXRpbmcgaXQgZXhwbGlj aXRseSB3aGVuIHByaXZhdGUgZGF0YSBpcyBkZWxldGVkLgorCisgICAgICAgICogVUlQcm9jZXNz L0FQSS9lZmwvZXdrX2NvbnRleHQuY3BwOgorICAgICAgICAoZXdrX2NvbnRleHRfZnJlZSk6Cisg ICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRleHRfcHJpdmF0ZS5oOgorICAgICAg ICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3LmNwcDoKKyAgICAgICAgKF9Fd2tfVmlld19Q cml2YXRlX0RhdGEpOgorICAgICAgICAoX0V3a19WaWV3X1ByaXZhdGVfRGF0YTo6fl9Fd2tfVmll d19Qcml2YXRlX0RhdGEpOgorICAgICAgICAoX2V3a192aWV3X2luaXRpYWxpemUpOgorCiAyMDEy LTA4LTE3ICBFbnJpY2EgQ2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk aW5nIGJhY2sgdGhlIGZpcnN0IHN0YXRlbWVudCBvZiBXZWJQcm9jZXNzTWFpbiBhY2NpZGVudGFs bHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250 ZXh0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0LmNw cAppbmRleCBkNjQ1Mzc1Li41M2NhNzE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX2NvbnRleHQuY3BwCkBAIC0yMzEsMyArMjMxLDEwIEBAIHZvaWQgZXdr X2NvbnRleHRfdmlicmF0aW9uX2NsaWVudF9jYWxsYmFja3Nfc2V0KEV3a19Db250ZXh0KiBld2tD b250ZXh0LCBFd2tfVmliCiAgICAgZXdrQ29udGV4dC0+dmlicmF0aW9uUHJvdmlkZXItPnNldFZp YnJhdGlvbkNsaWVudENhbGxiYWNrcyh2aWJyYXRlLCBjYW5jZWwsIGRhdGEpOwogI2VuZGlmCiB9 CisKK3ZvaWQgZXdrX2NvbnRleHRfZnJlZShFd2tfQ29udGV4dCogZXdrQ29udGV4dCkKK3sKKyAg ICBFSU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTihld2tDb250ZXh0KTsKKworICAgIGRlbGV0ZSBl d2tDb250ZXh0OworfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX2NvbnRleHRfcHJpdmF0ZS5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9l ZmwvZXdrX2NvbnRleHRfcHJpdmF0ZS5oCmluZGV4IGQxYjY5NWUuLjRiMWNjOGEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0X3ByaXZhdGUu aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dF9wcml2 YXRlLmgKQEAgLTM0LDUgKzM0LDYgQEAgdm9pZCBld2tfY29udGV4dF91cmxfc2NoZW1lX3JlcXVl c3RfcmVjZWl2ZWQoRXdrX0NvbnRleHQqLCBFd2tfVXJsX1NjaGVtZV9SZXF1ZXMKIHZvaWQgZXdr X2NvbnRleHRfZG93bmxvYWRfam9iX2FkZChFd2tfQ29udGV4dCosIEV3a19Eb3dubG9hZF9Kb2Iq KTsKIEV3a19Eb3dubG9hZF9Kb2IqIGV3a19jb250ZXh0X2Rvd25sb2FkX2pvYl9nZXQoY29uc3Qg RXdrX0NvbnRleHQqLCB1aW50NjRfdCBkb3dubG9hZElkKTsKIHZvaWQgZXdrX2NvbnRleHRfZG93 bmxvYWRfam9iX3JlbW92ZShFd2tfQ29udGV4dCosIHVpbnQ2NF90IGRvd25sb2FkSWQpOwordm9p ZCBld2tfY29udGV4dF9mcmVlKEV3a19Db250ZXh0Kik7CiAKICNlbmRpZiAvLyBld2tfY29udGV4 dF9wcml2YXRlX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZs L2V3a192aWV3LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a192aWV3 LmNwcAppbmRleCBjZTdmN2I0Li5hMWYwYzAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9ld2tfdmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX3ZpZXcuY3BwCkBAIC04Miw2ICs4Miw3IEBAIHN0cnVjdCBfRXdrX1Zp ZXdfUHJpdmF0ZV9EYXRhIHsKICAgICBFdmFzX09iamVjdCogY3Vyc29yT2JqZWN0OwogICAgIExv YWRpbmdSZXNvdXJjZXNNYXAgbG9hZGluZ1Jlc291cmNlc01hcDsKICAgICBFd2tfQmFja19Gb3J3 YXJkX0xpc3QqIGJhY2tGb3J3YXJkTGlzdDsKKyAgICBFd2tfQ29udGV4dCogY29udGV4dDsKIAog I2lmZGVmIEhBVkVfRUNPUkVfWAogICAgIGJvb2wgaXNVc2luZ0Vjb3JlWDsKQEAgLTExNCw2ICsx MTUsNyBAQCBzdHJ1Y3QgX0V3a19WaWV3X1ByaXZhdGVfRGF0YSB7CiAgICAgICAgICAgICBldmFz X29iamVjdF9kZWwoY3Vyc29yT2JqZWN0KTsKIAogICAgICAgICBld2tfYmFja19mb3J3YXJkX2xp c3RfZnJlZShiYWNrRm9yd2FyZExpc3QpOworICAgICAgICBld2tfY29udGV4dF9mcmVlKGNvbnRl eHQpOwogICAgIH0KIH07CiAKQEAgLTY2Niw2ICs2NjgsNyBAQCBzdGF0aWMgdm9pZCBfZXdrX3Zp ZXdfaW5pdGlhbGl6ZShFdmFzX09iamVjdCogZXdrVmlldywgRXdrX0NvbnRleHQqIGNvbnRleHQs IFdLUAogCiAgICAgcHJpdi0+cGFnZUNsaWVudCA9IFBhZ2VDbGllbnRJbXBsOjpjcmVhdGUodG9J bXBsKGV3a19jb250ZXh0X1dLQ29udGV4dF9nZXQoY29udGV4dCkpLCB0b0ltcGwocGFnZUdyb3Vw UmVmKSwgZXdrVmlldyk7CiAgICAgcHJpdi0+YmFja0ZvcndhcmRMaXN0ID0gZXdrX2JhY2tfZm9y d2FyZF9saXN0X25ldyh0b0FQSShwcml2LT5wYWdlQ2xpZW50LT5wYWdlKCktPmJhY2tGb3J3YXJk TGlzdCgpKSk7CisgICAgcHJpdi0+Y29udGV4dCA9IGNvbnRleHQ7CiAKICNpZiBVU0UoQ09PUkRJ TkFURURfR1JBUEhJQ1MpCiAgICAgcHJpdi0+dmlld3BvcnRIYW5kbGVyID0gRWZsVmlld3BvcnRI YW5kbGVyOjpjcmVhdGUocHJpdi0+cGFnZUNsaWVudC5nZXQoKSk7Cg== 160179 2012-08-23 09:03:43 -0700 2012-08-23 09:41:23 -0700 Patch 94808_ewk_context_default_free.patch text/plain 4520 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNWYwMDhkLi5iMzAzNmRiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjYg QEAKKzIwMTItMDgtMjMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEZyZWUgZXdrIGNvbnRleHQgZGF0YSBvbiBwcm9n cmFtIGV4aXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NDgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2Ugc3VyZSB0aGUgZGVmYXVsdCBFd2tfQ29udGV4dCBnZXRzIGZyZWVkCisgICAgICAgIG9u IHByb2dyYW0gZXhpdCBieSBjYWxsaW5nIGl0cyBkZXN0cnVjdG9yCisgICAgICAgIGZyb20gZXdr X3NodXRkb3duKCkuCisKKyAgICAgICAgVGhlIHBhdGNoIGFsc28gZml4ZXMgbGVha2luZyBvZiBX S0NvbnRleHRSZWYKKyAgICAgICAgaW5zaWRlIEV3a19Db250ZXh0IHdoaWNoIHNob3VsZCBoYXZl IGJlZW4KKyAgICAgICAgYWRvcHRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3 a19jb250ZXh0LmNwcDoKKyAgICAgICAgKF9Fd2tfQ29udGV4dDo6X0V3a19Db250ZXh0KToKKyAg ICAgICAgKGV3a19jb250ZXh0X2RlZmF1bHRfZ2V0KToKKyAgICAgICAgKGV3a19jb250ZXh0X2Rl ZmF1bHRfZnJlZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRleHRfcHJp dmF0ZS5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL2V3a19tYWluLmNwcDoKKyAgICAg ICAgKGV3a19zaHV0ZG93bik6CisKIDIwMTItMDgtMjMgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJFR1JFU1NJT04ocjEyNjMwNik6IGl0IGJy b2tlIHRoZSBwbHVnaW4gcHJvY2VzcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvZXdrX2NvbnRleHQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9lZmwvZXdrX2NvbnRleHQuY3BwCmluZGV4IGQ2NDUzNzUuLjk1YzJmNTIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dC5jcHAKQEAgLTM4LDYg KzM4LDggQEAKIAogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKIAorc3RhdGljIEV3a19Db250ZXh0 KiBkZWZhdWx0Q29udGV4dCA9IDA7CisKIHN0cnVjdCBfRXdrX1VybF9TY2hlbWVfSGFuZGxlciB7 CiAgICAgRXdrX1VybF9TY2hlbWVfUmVxdWVzdF9DYiBjYWxsYmFjazsKICAgICB2b2lkKiB1c2Vy RGF0YTsKQEAgLTcwLDE4ICs3MiwxOCBAQCBzdHJ1Y3QgX0V3a19Db250ZXh0IHsKICAgICBXS1Jl dGFpblB0cjxXS1NvdXBSZXF1ZXN0TWFuYWdlclJlZj4gcmVxdWVzdE1hbmFnZXI7CiAgICAgVVJM U2NoZW1lSGFuZGxlck1hcCB1cmxTY2hlbWVIYW5kbGVyczsKIAotICAgIF9Fd2tfQ29udGV4dChX S0NvbnRleHRSZWYgY29udGV4dFJlZikKKyAgICBfRXdrX0NvbnRleHQoV0tSZXRhaW5QdHI8V0tD b250ZXh0UmVmPiBjb250ZXh0UmVmKQogICAgICAgICA6IGNvbnRleHQoY29udGV4dFJlZikKICAg ICAgICAgLCBjb29raWVNYW5hZ2VyKDApCi0gICAgICAgICwgcmVxdWVzdE1hbmFnZXIoV0tDb250 ZXh0R2V0U291cFJlcXVlc3RNYW5hZ2VyKGNvbnRleHRSZWYpKQorICAgICAgICAsIHJlcXVlc3RN YW5hZ2VyKFdLQ29udGV4dEdldFNvdXBSZXF1ZXN0TWFuYWdlcihjb250ZXh0UmVmLmdldCgpKSkK ICAgICB7CiAjaWYgRU5BQkxFKEJBVFRFUllfU1RBVFVTKQotICAgICAgICBXS0JhdHRlcnlNYW5h Z2VyUmVmIHdrQmF0dGVyeU1hbmFnZXIgPSBXS0NvbnRleHRHZXRCYXR0ZXJ5TWFuYWdlcihjb250 ZXh0UmVmKTsKKyAgICAgICAgV0tCYXR0ZXJ5TWFuYWdlclJlZiB3a0JhdHRlcnlNYW5hZ2VyID0g V0tDb250ZXh0R2V0QmF0dGVyeU1hbmFnZXIoY29udGV4dFJlZi5nZXQoKSk7CiAgICAgICAgIGJh dHRlcnlQcm92aWRlciA9IEJhdHRlcnlQcm92aWRlcjo6Y3JlYXRlKHdrQmF0dGVyeU1hbmFnZXIp OwogI2VuZGlmCiAKICNpZiBFTkFCTEUoVklCUkFUSU9OKQotICAgICAgICBXS1ZpYnJhdGlvblJl ZiB3a1ZpYnJhdGlvblJlZiA9IFdLQ29udGV4dEdldFZpYnJhdGlvbihjb250ZXh0UmVmKTsKKyAg ICAgICAgV0tWaWJyYXRpb25SZWYgd2tWaWJyYXRpb25SZWYgPSBXS0NvbnRleHRHZXRWaWJyYXRp b24oY29udGV4dFJlZi5nZXQoKSk7CiAgICAgICAgIHZpYnJhdGlvblByb3ZpZGVyID0gVmlicmF0 aW9uUHJvdmlkZXI6OmNyZWF0ZSh3a1ZpYnJhdGlvblJlZik7CiAjZW5kaWYKIApAQCAtMTk4LDE4 ICsyMDAsMjAgQEAgdm9pZCBld2tfY29udGV4dF91cmxfc2NoZW1lX3JlcXVlc3RfcmVjZWl2ZWQo RXdrX0NvbnRleHQqIGV3a0NvbnRleHQsIEV3a19VcmxfU2MKICAgICBoYW5kbGVyLmNhbGxiYWNr KHNjaGVtZVJlcXVlc3QsIGhhbmRsZXIudXNlckRhdGEpOwogfQogCi1zdGF0aWMgaW5saW5lIEV3 a19Db250ZXh0KiBjcmVhdGVEZWZhdWx0RXdrQ29udGV4dCgpCi17Ci0gICAgcmV0dXJuIG5ldyBF d2tfQ29udGV4dChXS0NvbnRleHRDcmVhdGUoKSk7Ci19Ci0KIEV3a19Db250ZXh0KiBld2tfY29u dGV4dF9kZWZhdWx0X2dldCgpCiB7Ci0gICAgc3RhdGljIEV3a19Db250ZXh0KiBkZWZhdWx0Q29u dGV4dCA9IGNyZWF0ZURlZmF1bHRFd2tDb250ZXh0KCk7CisgICAgaWYgKCFkZWZhdWx0Q29udGV4 dCkKKyAgICAgICAgZGVmYXVsdENvbnRleHQgPSBuZXcgRXdrX0NvbnRleHQoYWRvcHRXSyhXS0Nv bnRleHRDcmVhdGUoKSkpOwogCiAgICAgcmV0dXJuIGRlZmF1bHRDb250ZXh0OwogfQogCit2b2lk IGV3a19jb250ZXh0X2RlZmF1bHRfZnJlZSgpCit7CisgICAgZGVsZXRlIGRlZmF1bHRDb250ZXh0 OworICAgIGRlZmF1bHRDb250ZXh0ID0gMDsKK30KKwogRWluYV9Cb29sIGV3a19jb250ZXh0X3Vy aV9zY2hlbWVfcmVnaXN0ZXIoRXdrX0NvbnRleHQqIGV3a0NvbnRleHQsIGNvbnN0IGNoYXIqIHNj aGVtZSwgRXdrX1VybF9TY2hlbWVfUmVxdWVzdF9DYiBjYWxsYmFjaywgdm9pZCogdXNlckRhdGEp CiB7CiAgICAgRUlOQV9TQUZFVFlfT05fTlVMTF9SRVRVUk5fVkFMKGV3a0NvbnRleHQsIGZhbHNl KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250 ZXh0X3ByaXZhdGUuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250 ZXh0X3ByaXZhdGUuaAppbmRleCBkMWI2OTVlLi4wYTQwNmZhIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29udGV4dF9wcml2YXRlLmgKKysrIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRleHRfcHJpdmF0ZS5oCkBAIC0z NSw0ICszNSw2IEBAIHZvaWQgZXdrX2NvbnRleHRfZG93bmxvYWRfam9iX2FkZChFd2tfQ29udGV4 dCosIEV3a19Eb3dubG9hZF9Kb2IqKTsKIEV3a19Eb3dubG9hZF9Kb2IqIGV3a19jb250ZXh0X2Rv d25sb2FkX2pvYl9nZXQoY29uc3QgRXdrX0NvbnRleHQqLCB1aW50NjRfdCBkb3dubG9hZElkKTsK IHZvaWQgZXdrX2NvbnRleHRfZG93bmxvYWRfam9iX3JlbW92ZShFd2tfQ29udGV4dCosIHVpbnQ2 NF90IGRvd25sb2FkSWQpOwogCit2b2lkIGV3a19jb250ZXh0X2RlZmF1bHRfZnJlZSgpOworCiAj ZW5kaWYgLy8gZXdrX2NvbnRleHRfcHJpdmF0ZV9oCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfbWFpbi5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfbWFpbi5jcHAKaW5kZXggMGQwMTkyNC4uN2JmZWQwZiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX21haW4uY3BwCisrKyBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19tYWluLmNwcApAQCAtMjIsNiArMjIs NyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgImV3a19tYWluLmgiCiAKKyNpbmNs dWRlICJld2tfY29udGV4dF9wcml2YXRlLmgiCiAjaW5jbHVkZSA8RWNvcmUuaD4KICNpbmNsdWRl IDxFY29yZV9FdmFzLmg+CiAjaW5jbHVkZSA8RWRqZS5oPgpAQCAtOTQsNiArOTUsOSBAQCBpbnQg ZXdrX3NodXRkb3duKHZvaWQpCiAgICAgaWYgKC0tX2V3a0luaXRDb3VudCkKICAgICAgICAgcmV0 dXJuIF9ld2tJbml0Q291bnQ7CiAKKworICAgIGV3a19jb250ZXh0X2RlZmF1bHRfZnJlZSgpOwor CiAgICAgZWNvcmVfZXZhc19zaHV0ZG93bigpOwogICAgIGVjb3JlX3NodXRkb3duKCk7CiAgICAg ZXZhc19zaHV0ZG93bigpOwo= 160185 2012-08-23 09:41:23 -0700 2012-08-23 09:46:01 -0700 Patch 94808_ewk_context_default_free.patch text/plain 2749 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNWYwMDhkLi5lMjU5MjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDgtMjMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEZyZWUgZXdrIGNvbnRleHQgZGF0YSBvbiBwcm9n cmFtIGV4aXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NDgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2Ugc3VyZSB0aGUgZGVmYXVsdCBFd2tfQ29udGV4dCBnZXRzIGZyZWVkCisgICAgICAgIG9u IHByb2dyYW0gZXhpdC4KKworICAgICAgICBUaGUgcGF0Y2ggYWxzbyBmaXhlcyBsZWFraW5nIG9m IFdLQ29udGV4dFJlZgorICAgICAgICBpbnNpZGUgRXdrX0NvbnRleHQgd2hpY2ggc2hvdWxkIGhh dmUgYmVlbgorICAgICAgICBhZG9wdGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX2NvbnRleHQuY3BwOgorICAgICAgICAoX0V3a19Db250ZXh0OjpfRXdrX0NvbnRleHQpOgor ICAgICAgICAoZXdrX2NvbnRleHRfZGVmYXVsdF9nZXQpOgorCiAyMDEyLTA4LTIzICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIxMjYzMDYpOiBpdCBicm9rZSB0aGUgcGx1Z2luIHByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0LmNwcAppbmRleCBkNjQ1Mzc1Li40NzM2 MDlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRl eHQuY3BwCkBAIC03MCwxOCArNzAsMTggQEAgc3RydWN0IF9Fd2tfQ29udGV4dCB7CiAgICAgV0tS ZXRhaW5QdHI8V0tTb3VwUmVxdWVzdE1hbmFnZXJSZWY+IHJlcXVlc3RNYW5hZ2VyOwogICAgIFVS TFNjaGVtZUhhbmRsZXJNYXAgdXJsU2NoZW1lSGFuZGxlcnM7CiAKLSAgICBfRXdrX0NvbnRleHQo V0tDb250ZXh0UmVmIGNvbnRleHRSZWYpCisgICAgX0V3a19Db250ZXh0KFdLUmV0YWluUHRyPFdL Q29udGV4dFJlZj4gY29udGV4dFJlZikKICAgICAgICAgOiBjb250ZXh0KGNvbnRleHRSZWYpCiAg ICAgICAgICwgY29va2llTWFuYWdlcigwKQotICAgICAgICAsIHJlcXVlc3RNYW5hZ2VyKFdLQ29u dGV4dEdldFNvdXBSZXF1ZXN0TWFuYWdlcihjb250ZXh0UmVmKSkKKyAgICAgICAgLCByZXF1ZXN0 TWFuYWdlcihXS0NvbnRleHRHZXRTb3VwUmVxdWVzdE1hbmFnZXIoY29udGV4dFJlZi5nZXQoKSkp CiAgICAgewogI2lmIEVOQUJMRShCQVRURVJZX1NUQVRVUykKLSAgICAgICAgV0tCYXR0ZXJ5TWFu YWdlclJlZiB3a0JhdHRlcnlNYW5hZ2VyID0gV0tDb250ZXh0R2V0QmF0dGVyeU1hbmFnZXIoY29u dGV4dFJlZik7CisgICAgICAgIFdLQmF0dGVyeU1hbmFnZXJSZWYgd2tCYXR0ZXJ5TWFuYWdlciA9 IFdLQ29udGV4dEdldEJhdHRlcnlNYW5hZ2VyKGNvbnRleHRSZWYuZ2V0KCkpOwogICAgICAgICBi YXR0ZXJ5UHJvdmlkZXIgPSBCYXR0ZXJ5UHJvdmlkZXI6OmNyZWF0ZSh3a0JhdHRlcnlNYW5hZ2Vy KTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKFZJQlJBVElPTikKLSAgICAgICAgV0tWaWJyYXRpb25S ZWYgd2tWaWJyYXRpb25SZWYgPSBXS0NvbnRleHRHZXRWaWJyYXRpb24oY29udGV4dFJlZik7Cisg ICAgICAgIFdLVmlicmF0aW9uUmVmIHdrVmlicmF0aW9uUmVmID0gV0tDb250ZXh0R2V0VmlicmF0 aW9uKGNvbnRleHRSZWYuZ2V0KCkpOwogICAgICAgICB2aWJyYXRpb25Qcm92aWRlciA9IFZpYnJh dGlvblByb3ZpZGVyOjpjcmVhdGUod2tWaWJyYXRpb25SZWYpOwogI2VuZGlmCiAKQEAgLTE5OCwx NiArMTk4LDExIEBAIHZvaWQgZXdrX2NvbnRleHRfdXJsX3NjaGVtZV9yZXF1ZXN0X3JlY2VpdmVk KEV3a19Db250ZXh0KiBld2tDb250ZXh0LCBFd2tfVXJsX1NjCiAgICAgaGFuZGxlci5jYWxsYmFj ayhzY2hlbWVSZXF1ZXN0LCBoYW5kbGVyLnVzZXJEYXRhKTsKIH0KIAotc3RhdGljIGlubGluZSBF d2tfQ29udGV4dCogY3JlYXRlRGVmYXVsdEV3a0NvbnRleHQoKQotewotICAgIHJldHVybiBuZXcg RXdrX0NvbnRleHQoV0tDb250ZXh0Q3JlYXRlKCkpOwotfQotCiBFd2tfQ29udGV4dCogZXdrX2Nv bnRleHRfZGVmYXVsdF9nZXQoKQogewotICAgIHN0YXRpYyBFd2tfQ29udGV4dCogZGVmYXVsdENv bnRleHQgPSBjcmVhdGVEZWZhdWx0RXdrQ29udGV4dCgpOworICAgIHN0YXRpYyBFd2tfQ29udGV4 dCBkZWZhdWx0Q29udGV4dChXS0NvbnRleHRDcmVhdGUoKSk7CiAKLSAgICByZXR1cm4gZGVmYXVs dENvbnRleHQ7CisgICAgcmV0dXJuICZkZWZhdWx0Q29udGV4dDsKIH0KIAogRWluYV9Cb29sIGV3 a19jb250ZXh0X3VyaV9zY2hlbWVfcmVnaXN0ZXIoRXdrX0NvbnRleHQqIGV3a0NvbnRleHQsIGNv bnN0IGNoYXIqIHNjaGVtZSwgRXdrX1VybF9TY2hlbWVfUmVxdWVzdF9DYiBjYWxsYmFjaywgdm9p ZCogdXNlckRhdGEpCg== 160186 2012-08-23 09:46:01 -0700 2012-08-23 11:02:12 -0700 Patch 94808_ewk_context_default_free.patch text/plain 2758 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmNWYwMDhkLi5lMjU5MjVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTItMDgtMjMgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEZyZWUgZXdrIGNvbnRleHQgZGF0YSBvbiBwcm9n cmFtIGV4aXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NDgwOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2Ugc3VyZSB0aGUgZGVmYXVsdCBFd2tfQ29udGV4dCBnZXRzIGZyZWVkCisgICAgICAgIG9u IHByb2dyYW0gZXhpdC4KKworICAgICAgICBUaGUgcGF0Y2ggYWxzbyBmaXhlcyBsZWFraW5nIG9m IFdLQ29udGV4dFJlZgorICAgICAgICBpbnNpZGUgRXdrX0NvbnRleHQgd2hpY2ggc2hvdWxkIGhh dmUgYmVlbgorICAgICAgICBhZG9wdGVkLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwv ZXdrX2NvbnRleHQuY3BwOgorICAgICAgICAoX0V3a19Db250ZXh0OjpfRXdrX0NvbnRleHQpOgor ICAgICAgICAoZXdrX2NvbnRleHRfZGVmYXVsdF9nZXQpOgorCiAyMDEyLTA4LTIzICBDYXJsb3Mg R2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9O KHIxMjYzMDYpOiBpdCBicm9rZSB0aGUgcGx1Z2luIHByb2Nlc3MKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0LmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19jb250ZXh0LmNwcAppbmRleCBkNjQ1Mzc1Li43MTUw NGY2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9ld2tfY29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvZXdrX2NvbnRl eHQuY3BwCkBAIC03MCwxOCArNzAsMTggQEAgc3RydWN0IF9Fd2tfQ29udGV4dCB7CiAgICAgV0tS ZXRhaW5QdHI8V0tTb3VwUmVxdWVzdE1hbmFnZXJSZWY+IHJlcXVlc3RNYW5hZ2VyOwogICAgIFVS TFNjaGVtZUhhbmRsZXJNYXAgdXJsU2NoZW1lSGFuZGxlcnM7CiAKLSAgICBfRXdrX0NvbnRleHQo V0tDb250ZXh0UmVmIGNvbnRleHRSZWYpCisgICAgX0V3a19Db250ZXh0KFdLUmV0YWluUHRyPFdL Q29udGV4dFJlZj4gY29udGV4dFJlZikKICAgICAgICAgOiBjb250ZXh0KGNvbnRleHRSZWYpCiAg ICAgICAgICwgY29va2llTWFuYWdlcigwKQotICAgICAgICAsIHJlcXVlc3RNYW5hZ2VyKFdLQ29u dGV4dEdldFNvdXBSZXF1ZXN0TWFuYWdlcihjb250ZXh0UmVmKSkKKyAgICAgICAgLCByZXF1ZXN0 TWFuYWdlcihXS0NvbnRleHRHZXRTb3VwUmVxdWVzdE1hbmFnZXIoY29udGV4dFJlZi5nZXQoKSkp CiAgICAgewogI2lmIEVOQUJMRShCQVRURVJZX1NUQVRVUykKLSAgICAgICAgV0tCYXR0ZXJ5TWFu YWdlclJlZiB3a0JhdHRlcnlNYW5hZ2VyID0gV0tDb250ZXh0R2V0QmF0dGVyeU1hbmFnZXIoY29u dGV4dFJlZik7CisgICAgICAgIFdLQmF0dGVyeU1hbmFnZXJSZWYgd2tCYXR0ZXJ5TWFuYWdlciA9 IFdLQ29udGV4dEdldEJhdHRlcnlNYW5hZ2VyKGNvbnRleHRSZWYuZ2V0KCkpOwogICAgICAgICBi YXR0ZXJ5UHJvdmlkZXIgPSBCYXR0ZXJ5UHJvdmlkZXI6OmNyZWF0ZSh3a0JhdHRlcnlNYW5hZ2Vy KTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKFZJQlJBVElPTikKLSAgICAgICAgV0tWaWJyYXRpb25S ZWYgd2tWaWJyYXRpb25SZWYgPSBXS0NvbnRleHRHZXRWaWJyYXRpb24oY29udGV4dFJlZik7Cisg ICAgICAgIFdLVmlicmF0aW9uUmVmIHdrVmlicmF0aW9uUmVmID0gV0tDb250ZXh0R2V0VmlicmF0 aW9uKGNvbnRleHRSZWYuZ2V0KCkpOwogICAgICAgICB2aWJyYXRpb25Qcm92aWRlciA9IFZpYnJh dGlvblByb3ZpZGVyOjpjcmVhdGUod2tWaWJyYXRpb25SZWYpOwogI2VuZGlmCiAKQEAgLTE5OCwx NiArMTk4LDExIEBAIHZvaWQgZXdrX2NvbnRleHRfdXJsX3NjaGVtZV9yZXF1ZXN0X3JlY2VpdmVk KEV3a19Db250ZXh0KiBld2tDb250ZXh0LCBFd2tfVXJsX1NjCiAgICAgaGFuZGxlci5jYWxsYmFj ayhzY2hlbWVSZXF1ZXN0LCBoYW5kbGVyLnVzZXJEYXRhKTsKIH0KIAotc3RhdGljIGlubGluZSBF d2tfQ29udGV4dCogY3JlYXRlRGVmYXVsdEV3a0NvbnRleHQoKQotewotICAgIHJldHVybiBuZXcg RXdrX0NvbnRleHQoV0tDb250ZXh0Q3JlYXRlKCkpOwotfQotCiBFd2tfQ29udGV4dCogZXdrX2Nv bnRleHRfZGVmYXVsdF9nZXQoKQogewotICAgIHN0YXRpYyBFd2tfQ29udGV4dCogZGVmYXVsdENv bnRleHQgPSBjcmVhdGVEZWZhdWx0RXdrQ29udGV4dCgpOworICAgIHN0YXRpYyBFd2tfQ29udGV4 dCBkZWZhdWx0Q29udGV4dChhZG9wdFdLKFdLQ29udGV4dENyZWF0ZSgpKSk7CiAKLSAgICByZXR1 cm4gZGVmYXVsdENvbnRleHQ7CisgICAgcmV0dXJuICZkZWZhdWx0Q29udGV4dDsKIH0KIAogRWlu YV9Cb29sIGV3a19jb250ZXh0X3VyaV9zY2hlbWVfcmVnaXN0ZXIoRXdrX0NvbnRleHQqIGV3a0Nv bnRleHQsIGNvbnN0IGNoYXIqIHNjaGVtZSwgRXdrX1VybF9TY2hlbWVfUmVxdWVzdF9DYiBjYWxs YmFjaywgdm9pZCogdXNlckRhdGEpCg==