9479 2006-06-17 01:37:07 -0700 Disassociate the inspector from the frame when it detaches from its parent 2006-06-18 10:56:32 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 420+ Mac OS X 10.4 RESOLVED FIXED P1 Normal --- 1 mitz webkit-unassigned timothy oldest_to_newest 46022 0 mitz 2006-06-17 01:37:07 -0700 [This is a follow-up to bug 8672] The current way of the Inspector observing NSWindowWillCloseNotification in order to tell when to disassociate from the inspected WebFrame is wrong. Aside from the fact that it doesn't track the WebFrame's WebView's window and hostWindow as they change, a WebFrame can be deallocated while its WebView remains in a window. For example, this crashes Safari (which is why this bug is P1): 1. Open a frameset page. 2. Inspect an element in one of the frames. 3. Navigate to another page in the same tab. 4. Try to select a different node in the inspector. 46023 1 8877 mitz 2006-06-17 01:46:31 -0700 Created attachment 8877 Proposed patch 46027 2 8877 mitz 2006-06-17 01:54:10 -0700 Comment on attachment 8877 Proposed patch The same idea can be implemented with generic notifications, which may be cleaner (since WebFrame wouldn't need to know about inspectors). 46138 3 ggaren 2006-06-17 20:43:59 -0700 Notification sure sounds better to me. TimH? 46140 4 8877 timothy 2006-06-17 21:01:43 -0700 Comment on attachment 8877 Proposed patch r=me. A WebFrame might need to know about it's inspectors in the future, so this is fine. 46175 5 ddkilzer 2006-06-18 10:56:32 -0700 Committed revision 14906. 8877 2006-06-17 01:46:31 -0700 2006-06-17 21:01:43 -0700 Proposed patch 9479_r1.patch text/plain 6511 mitz SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTQ4OTUpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMjUgQEAKKzIwMDYtMDYtIyMgIE1pdHogUGV0dGVsICA8b3BlbmRhcndpbi5vcmdAbWl0 enBldHRlbC5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgLSBodHRwOi8vYnVnemlsbGEub3BlbmRhcndpbi5vcmcvc2hvd19idWcuY2dpP2lkPTk0 NzkKKyAgICAgICAgICBEaXNhc3NvY2lhdGUgdGhlIGluc3BlY3RvciBmcm9tIHRoZSBmcmFtZSB3 aGVuIGl0IGRldGFjaGVzIGZyb20gaXRzIHBhcmVudAorCisgICAgICAgICogV2ViSW5zcGVjdG9y L1dlYkluc3BlY3Rvci5tOgorICAgICAgICAoLVtOU1dpbmRvdyBzZXRXZWJGcmFtZTpdKTogQWRk ZWQgY29kZSB0byAoZGUpcmVnaXN0ZXIgd2l0aCB0aGUgV2ViRnJhbWUKKyAgICAgICAgdGhlIGlu c3BlY3RvciBpcyAobm8gbG9uZ2VyKSB0YXJnZXRpbmcuCisgICAgICAgICgtW1dlYkluc3BlY3Rv ciBfd2ViRnJhbWVEZXRhY2hlZDpdKTogQWRkZWQuIE1vdmVkIHRoZSBjb2RlIHRoYXQgd2FzIHBy ZXZpb3VzbHkKKyAgICAgICAgaW4gLVtpbnNwZWN0ZWRXaW5kb3dXaWxsQ2xvc2U6XSBoZXJlLiBU aGlzIGlzIGNhbGxlZCBieSB0aGUgV2ViRnJhbWUgd2hlbiBpdAorICAgICAgICBpcyBkZXRhY2hl ZCBmcm9tIGl0cyBwYXJlbnQuCisgICAgICAgICogV2ViSW5zcGVjdG9yL1dlYkluc3BlY3Rvcklu dGVybmFsLmg6CisgICAgICAgICogV2ViVmlldy9XZWJGcmFtZS5tOgorICAgICAgICAoLVtXZWJG cmFtZVByaXZhdGUgZGVhbGxvY10pOgorICAgICAgICAoLVtXZWJGcmFtZSBfZGV0YWNoRnJvbVBh cmVudF0pOiBBZGRlZCBjb2RlIHRvIG5vdGlmeSBhbGwgcmVnaXN0ZXJlZCBpbnNwZWN0b3JzCisg ICAgICAgIHRoYXQgdGhlIFdlYkZyYW1lIGlzIGRldGFjaGluZy4KKyAgICAgICAgKC1bV2ViRnJh bWUgX2FkZEluc3BlY3RvcjpdKTogQWRkZWQuCisgICAgICAgICgtW1dlYkZyYW1lIF9yZW1vdmVJ bnNwZWN0b3I6XSk6IEFkZGVkLgorICAgICAgICAqIFdlYlZpZXcvV2ViRnJhbWVJbnRlcm5hbC5o OgorCiAyMDA2LTA2LTE2ICBUaW1vdGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KIAog ICAgICAgICBSZXZpZXdlZCBieSBUaW0gTy4KSW5kZXg6IFdlYktpdC9XZWJJbnNwZWN0b3IvV2Vi SW5zcGVjdG9yLm0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L1dlYkluc3BlY3Rvci9XZWJJbnNwZWN0 b3IubQkocmV2aXNpb24gMTQ4OTUpCisrKyBXZWJLaXQvV2ViSW5zcGVjdG9yL1dlYkluc3BlY3Rv ci5tCSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw3IEBACiAjaW1wb3J0ICJXZWJWaWV3UHJp dmF0ZS5oIgogI2ltcG9ydCAiV2ViSFRNTFZpZXcuaCIKICNpbXBvcnQgIldlYkZyYW1lLmgiCisj aW1wb3J0ICJXZWJGcmFtZUludGVybmFsLmgiCiAjaW1wb3J0ICJXZWJMb2NhbGl6YWJsZVN0cmlu Z3MuaCIKICNpbXBvcnQgIldlYktpdE5TU3RyaW5nRXh0cmFzLmgiCiAjaW1wb3J0ICJXZWJUeXBl c0ludGVybmFsLmgiCkBAIC0xNzMsNyArMTc0LDcgQEAgc3RhdGljIE5TTWFwVGFibGUgKmxhc3RD aGlsZElnbm9yaW5nV2hpdAogCiAgICAgaWYgKF9wcml2YXRlLT53ZWJGcmFtZSkgewogICAgICAg ICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1bHRDZW50ZXJdIHJlbW92ZU9ic2VydmVyOnNl bGYgbmFtZTpXZWJWaWV3UHJvZ3Jlc3NGaW5pc2hlZE5vdGlmaWNhdGlvbiBvYmplY3Q6W19wcml2 YXRlLT53ZWJGcmFtZSB3ZWJWaWV3XV07Ci0gICAgICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIg ZGVmYXVsdENlbnRlcl0gcmVtb3ZlT2JzZXJ2ZXI6c2VsZiBuYW1lOk5TV2luZG93V2lsbENsb3Nl Tm90aWZpY2F0aW9uIG9iamVjdDpbW19wcml2YXRlLT53ZWJGcmFtZSB3ZWJWaWV3XSBob3N0V2lu ZG93XV07CisgICAgICAgIFtfcHJpdmF0ZS0+d2ViRnJhbWUgX3JlbW92ZUluc3BlY3RvcjpzZWxm XTsKICAgICB9CiAgICAgCiAgICAgW3dlYkZyYW1lIHJldGFpbl07CkBAIC0xODIsNyArMTgzLDcg QEAgc3RhdGljIE5TTWFwVGFibGUgKmxhc3RDaGlsZElnbm9yaW5nV2hpdAogCiAgICAgaWYgKF9w cml2YXRlLT53ZWJGcmFtZSkgewogICAgICAgICBbW05TTm90aWZpY2F0aW9uQ2VudGVyIGRlZmF1 bHRDZW50ZXJdIGFkZE9ic2VydmVyOnNlbGYgc2VsZWN0b3I6QHNlbGVjdG9yKGluc3BlY3RlZFdl YlZpZXdQcm9ncmVzc0ZpbmlzaGVkOikgbmFtZTpXZWJWaWV3UHJvZ3Jlc3NGaW5pc2hlZE5vdGlm aWNhdGlvbiBvYmplY3Q6W19wcml2YXRlLT53ZWJGcmFtZSB3ZWJWaWV3XV07Ci0gICAgICAgIFtb TlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENlbnRlcl0gYWRkT2JzZXJ2ZXI6c2VsZiBzZWxl Y3RvcjpAc2VsZWN0b3IoaW5zcGVjdGVkV2luZG93V2lsbENsb3NlOikgbmFtZTpOU1dpbmRvd1dp bGxDbG9zZU5vdGlmaWNhdGlvbiBvYmplY3Q6W1tfcHJpdmF0ZS0+d2ViRnJhbWUgd2ViVmlld10g aG9zdFdpbmRvd11dOworICAgICAgICBbX3ByaXZhdGUtPndlYkZyYW1lIF9hZGRJbnNwZWN0b3I6 c2VsZl07CiAgICAgfQogCiAgICAgW19wcml2YXRlLT50cmVlT3V0bGluZVZpZXcgc2V0QWxsb3dz RW1wdHlTZWxlY3Rpb246Tk9dOwpAQCAtNzg2LDYgKzc4NywxNiBAQCBzdGF0aWMgTlNNYXBUYWJs ZSAqbGFzdENoaWxkSWdub3JpbmdXaGl0CiAgICAgWyhOU1BhbmVsICopW3NlbGYgd2luZG93XSBz ZXRGbG9hdGluZ1BhbmVsOllFU107CiB9CiAKKy0gKHZvaWQpX3dlYkZyYW1lRGV0YWNoZWQ6KFdl YkZyYW1lICopZnJhbWUKK3sKKyAgICBbc2VsZiBzZXRGb2N1c2VkRE9NTm9kZTpuaWxdOworICAg IFtzZWxmIHNldFdlYkZyYW1lOm5pbF07CisgICAgW19wcml2YXRlLT50cmVlT3V0bGluZVZpZXcg c2V0QWxsb3dzRW1wdHlTZWxlY3Rpb246WUVTXTsKKyAgICBbX3ByaXZhdGUtPnRyZWVPdXRsaW5l VmlldyBkZXNlbGVjdEFsbDpzZWxmXTsKKyAgICBbc2VsZiBfdXBkYXRlXTsKKyAgICBbc2VsZiBf dXBkYXRlUm9vdF07Cit9CisKICNwcmFnbWEgbWFyayAtCiAKICsgKEJPT0wpaXNTZWxlY3RvckV4 Y2x1ZGVkRnJvbVdlYlNjcmlwdDooU0VMKWFTZWxlY3RvcgpAQCAtODE4LDE2ICs4MjksNiBAQCBz dGF0aWMgTlNNYXBUYWJsZSAqbGFzdENoaWxkSWdub3JpbmdXaGl0CiAgICAgfQogfQogCi0tICh2 b2lkKWluc3BlY3RlZFdpbmRvd1dpbGxDbG9zZTooTlNOb3RpZmljYXRpb24gKilub3RpZmljYXRp b24KLXsKLSAgICBbc2VsZiBzZXRGb2N1c2VkRE9NTm9kZTpuaWxdOwotICAgIFtzZWxmIHNldFdl YkZyYW1lOm5pbF07Ci0gICAgW19wcml2YXRlLT50cmVlT3V0bGluZVZpZXcgc2V0QWxsb3dzRW1w dHlTZWxlY3Rpb246WUVTXTsKLSAgICBbX3ByaXZhdGUtPnRyZWVPdXRsaW5lVmlldyBkZXNlbGVj dEFsbDpzZWxmXTsKLSAgICBbc2VsZiBfdXBkYXRlXTsKLSAgICBbc2VsZiBfdXBkYXRlUm9vdF07 Ci19Ci0KICNwcmFnbWEgbWFyayAtCiAKIC0gKHZvaWQpd2ViVmlldzooV2ViVmlldyAqKXNlbmRl ciBkaWRGaW5pc2hMb2FkRm9yRnJhbWU6KFdlYkZyYW1lICopZnJhbWUKSW5kZXg6IFdlYktpdC9X ZWJJbnNwZWN0b3IvV2ViSW5zcGVjdG9ySW50ZXJuYWwuaAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv V2ViSW5zcGVjdG9yL1dlYkluc3BlY3RvckludGVybmFsLmgJKHJldmlzaW9uIDE0ODk1KQorKysg V2ViS2l0L1dlYkluc3BlY3Rvci9XZWJJbnNwZWN0b3JJbnRlcm5hbC5oCSh3b3JraW5nIGNvcHkp CkBAIC03Myw2ICs3Myw3IEBACiAtICh2b2lkKV91cGRhdGVUcmVlU2Nyb2xsYmFyOwogLSAodm9p ZClfdXBkYXRlVHJhdmVyc2FsQnV0dG9uczsKIC0gKHZvaWQpX3JlZnJlc2hTZWFyY2g7CistICh2 b2lkKV93ZWJGcmFtZURldGFjaGVkOihXZWJGcmFtZSAqKWZyYW1lOwogQGVuZAogCiBAaW50ZXJm YWNlIERPTU5vZGUgKERPTU5vZGVJbnNwZWN0b3JBZGRpdGlvbnMpCkluZGV4OiBXZWJLaXQvV2Vi Vmlldy9XZWJGcmFtZS5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9XZWJWaWV3L1dlYkZyYW1lLm0J KHJldmlzaW9uIDE0ODk1KQorKysgV2ViS2l0L1dlYlZpZXcvV2ViRnJhbWUubQkod29ya2luZyBj b3B5KQpAQCAtMjA2LDYgKzIwNiw3IEBAIE5TU3RyaW5nICpXZWJQYWdlQ2FjaGVEb2N1bWVudFZp ZXdLZXkgPSAKICAgICBOU1N0cmluZyAqZnJhbWVOYW1lc3BhY2U7CiAgICAgCiAgICAgTlNNdXRh YmxlU2V0ICpwbHVnSW5WaWV3czsKKyAgICBOU011dGFibGVTZXQgKmluc3BlY3RvcnM7CiB9CiAK IC0gKHZvaWQpc2V0V2ViRnJhbWVWaWV3OihXZWJGcmFtZVZpZXcgKil2OwpAQCAtMjUzLDYgKzI1 NCw4IEBAIE5TU3RyaW5nICpXZWJQYWdlQ2FjaGVEb2N1bWVudFZpZXdLZXkgPSAKICAgICAKICAg ICBbc2NyaXB0RGVidWdnZXIgcmVsZWFzZV07CiAgICAgCisgICAgW2luc3BlY3RvcnMgcmVsZWFz ZV07CisKICAgICBBU1NFUlQobGlzdGVuZXIgPT0gbmlsKTsKICAgICBBU1NFUlQocG9saWN5UmVx dWVzdCA9PSBuaWwpOwogICAgIEFTU0VSVChwb2xpY3lGcmFtZU5hbWUgPT0gbmlsKTsKQEAgLTU2 Miw2ICs1NjUsNyBAQCBzdGF0aWMgaW5saW5lIFdlYkZyYW1lICpGcmFtZShXZWJDb3JlRnJhCiAK ICAgICBbc2VsZiBfc2F2ZVNjcm9sbFBvc2l0aW9uQW5kVmlld1N0YXRlVG9JdGVtOltfcHJpdmF0 ZSBjdXJyZW50SXRlbV1dOwogICAgIFtzZWxmIF9kZXRhY2hDaGlsZHJlbl07CisgICAgW19wcml2 YXRlLT5pbnNwZWN0b3JzIG1ha2VPYmplY3RzUGVyZm9ybVNlbGVjdG9yOkBzZWxlY3Rvcihfd2Vi RnJhbWVEZXRhY2hlZDopIHdpdGhPYmplY3Q6c2VsZl07CiAKICAgICBbX3ByaXZhdGUtPndlYkZy YW1lVmlldyBfc2V0V2ViRnJhbWU6bmlsXTsgLy8gbmVlZGVkIGZvciBub3cgdG8gYmUgY29tcGF0 aWJsZSB3LyBvbGQgYmVoYXZpb3IKIApAQCAtMjc2MSw2ICsyNzY1LDIwIEBAIHN0YXRpYyBDRkFi c29sdXRlVGltZSBfdGltZU9mTGFzdENvbXBsZXQKICAgICByZXR1cm4gc2VsZiA9PSBbW3NlbGYg d2ViVmlld10gbWFpbkZyYW1lXTsKIH0KIAorLSAodm9pZClfYWRkSW5zcGVjdG9yOihXZWJJbnNw ZWN0b3IgKilpbnNwZWN0b3IKK3sKKyAgICBpZiAoIV9wcml2YXRlLT5pbnNwZWN0b3JzKQorICAg ICAgICBfcHJpdmF0ZS0+aW5zcGVjdG9ycyA9IFtbTlNNdXRhYmxlU2V0IGFsbG9jXSBpbml0XTsK KyAgICBBU1NFUlQoIVtfcHJpdmF0ZS0+aW5zcGVjdG9ycyBjb250YWluc09iamVjdDppbnNwZWN0 b3JdKTsKKyAgICBbX3ByaXZhdGUtPmluc3BlY3RvcnMgYWRkT2JqZWN0Omluc3BlY3Rvcl07Cit9 CisKKy0gKHZvaWQpX3JlbW92ZUluc3BlY3RvcjooV2ViSW5zcGVjdG9yICopaW5zcGVjdG9yCit7 CisgICAgQVNTRVJUKFtfcHJpdmF0ZS0+aW5zcGVjdG9ycyBjb250YWluc09iamVjdDppbnNwZWN0 b3JdKTsKKyAgICBbX3ByaXZhdGUtPmluc3BlY3RvcnMgcmVtb3ZlT2JqZWN0Omluc3BlY3Rvcl07 Cit9CisKIEBlbmQKIAogQGltcGxlbWVudGF0aW9uIFdlYkZvcm1TdGF0ZSA6IE5TT2JqZWN0Cklu ZGV4OiBXZWJLaXQvV2ViVmlldy9XZWJGcmFtZUludGVybmFsLmgKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L1dlYlZpZXcvV2ViRnJhbWVJbnRlcm5hbC5oCShyZXZpc2lvbiAxNDg5NSkKKysrIFdlYktp dC9XZWJWaWV3L1dlYkZyYW1lSW50ZXJuYWwuaAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAs OCBAQAogCiAjaW1wb3J0IDxXZWJLaXQvV2ViRnJhbWVQcml2YXRlLmg+CiAKK0BjbGFzcyBXZWJJ bnNwZWN0b3I7CisKIEBpbnRlcmZhY2UgV2ViRnJhbWUgKFdlYkludGVybmFsKQogCiAtICh2b2lk KV91cGRhdGVEcmF3c0JhY2tncm91bmQ7CkBAIC02MSw2ICs2Myw4IEBACiAtICh2b2lkKV9hZGRF eHRyYUZpZWxkc1RvUmVxdWVzdDooTlNNdXRhYmxlVVJMUmVxdWVzdCAqKXJlcXVlc3QgbWFpblJl c291cmNlOihCT09MKW1haW5SZXNvdXJjZSBhbHdheXNGcm9tUmVxdWVzdDooQk9PTClmOwogLSAo Qk9PTClfaXNNYWluRnJhbWU7CiAKKy0gKHZvaWQpX2FkZEluc3BlY3RvcjooV2ViSW5zcGVjdG9y ICopaW5zcGVjdG9yOworLSAodm9pZClfcmVtb3ZlSW5zcGVjdG9yOihXZWJJbnNwZWN0b3IgKilp bnNwZWN0b3I7CiBAZW5kCiAKIEBpbnRlcmZhY2UgTlNPYmplY3QgKFdlYkludGVybmFsRnJhbWVM b2FkRGVsZWdhdGUpCg==