94770 2012-08-22 19:46:19 -0700 [V8] Move m_isolatedWorlds and m_isolatedWorldSecurityOrigins from V8Proxy to ScriptController 2012-08-22 20:46:34 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 702645 0 haraken 2012-08-22 19:46:19 -0700 Now m_isolatedWorlds and m_isolatedWorldSecurityOrigins of V8Proxy are used by ScriptController only. We can move them to ScriptController. 702646 1 160072 haraken 2012-08-22 19:47:36 -0700 Created attachment 160072 Patch 702666 2 160072 webkit.review.bot 2012-08-22 20:46:30 -0700 Comment on attachment 160072 Patch Clearing flags on attachment: 160072 Committed r126389: <http://trac.webkit.org/changeset/126389> 702667 3 webkit.review.bot 2012-08-22 20:46:34 -0700 All reviewed patches have been landed. Closing bug. 160072 2012-08-22 19:47:36 -0700 2012-08-22 20:46:30 -0700 Patch bug-94770-20120823114733.patch text/plain 7209 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2UxYjk0MmEwMWU3MDg3 ZjNkMGMwMDA0YWNjNjI2MzY4ZWU4NGY5Mi4uMjM4ZTI0N2U2NTEzYjA5MzBlMTVmZDg2N2NjZGIx OTcxMWFiMTBlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTA4LTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIE1vdmUgbV9p c29sYXRlZFdvcmxkcyBhbmQgbV9pc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5zIGZyb20gVjhQ cm94eSB0byBTY3JpcHRDb250cm9sbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05NDc3MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE5vdyBtX2lzb2xhdGVkV29ybGRzIGFuZCBtX2lzb2xhdGVkV29ybGRT ZWN1cml0eU9yaWdpbnMgb2YgVjhQcm94eQorICAgICAgICBhcmUgdXNlZCBieSBTY3JpcHRDb250 cm9sbGVyIG9ubHkuIFdlIGNhbiBtb3ZlIHRoZW0gdG8gU2NyaXB0Q29udHJvbGxlci4KKworICAg ICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGlu Z3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRDb250 cm9sbGVyOjpyZXNldElzb2xhdGVkV29ybGRzKToKKyAgICAgICAgKFdlYkNvcmU6OlNjcmlwdENv bnRyb2xsZXI6OmV2YWx1YXRlSW5Jc29sYXRlZFdvcmxkKToKKyAgICAgICAgKFdlYkNvcmU6OlNj cmlwdENvbnRyb2xsZXI6OnNldElzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbik6CisgICAgICAg IChXZWJDb3JlOjpTY3JpcHRDb250cm9sbGVyOjpjb2xsZWN0SXNvbGF0ZWRDb250ZXh0cyk6Cisg ICAgICAgICogYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oOgorICAgICAgICAoU2NyaXB0 Q29udHJvbGxlcik6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhQcm94eS5oOgorICAgICAgICAo VjhQcm94eSk6CisKIDIwMTItMDgtMjIgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBbY2hyb21pdW1dIENoYW5nZSBXZWJMYXllciBmcm9tIGEgY29uY3Jl dGUgdHlwZSB0byBhIHB1cmUgdmlydHVhbCBpbnRlcmZhY2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5jcHAKaW5kZXggYWY1YWQ2OTJkMDI2OTkwZTY1 N2ZkOWQ0YWVmZDI1NGRiNDlmZWZiMy4uOGU3NGQyZjI0ODBjMWJjYjU0Nzc3NTFjMWE0MjNjODBj ZDVkODIzYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29u dHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJv bGxlci5jcHAKQEAgLTE1NCwxMiArMTU0LDEyIEBAIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6Y2xl YXJTY3JpcHRPYmplY3RzKCkKIAogdm9pZCBTY3JpcHRDb250cm9sbGVyOjpyZXNldElzb2xhdGVk V29ybGRzKCkKIHsKLSAgICBmb3IgKElzb2xhdGVkV29ybGRNYXA6Oml0ZXJhdG9yIGl0ZXIgPSBt X3Byb3h5LT5pc29sYXRlZFdvcmxkcygpLmJlZ2luKCk7Ci0gICAgICAgICBpdGVyICE9IG1fcHJv eHktPmlzb2xhdGVkV29ybGRzKCkuZW5kKCk7ICsraXRlcikgeworICAgIGZvciAoSXNvbGF0ZWRX b3JsZE1hcDo6aXRlcmF0b3IgaXRlciA9IG1faXNvbGF0ZWRXb3JsZHMuYmVnaW4oKTsKKyAgICAg ICAgIGl0ZXIgIT0gbV9pc29sYXRlZFdvcmxkcy5lbmQoKTsgKytpdGVyKSB7CiAgICAgICAgIGl0 ZXItPnNlY29uZC0+ZGVzdHJveSgpOwogICAgIH0KLSAgICBtX3Byb3h5LT5pc29sYXRlZFdvcmxk cygpLmNsZWFyKCk7Ci0gICAgbV9wcm94eS0+aXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2lucygp LmNsZWFyKCk7CisgICAgbV9pc29sYXRlZFdvcmxkcy5jbGVhcigpOworICAgIG1faXNvbGF0ZWRX b3JsZFNlY3VyaXR5T3JpZ2lucy5jbGVhcigpOwogfQogCiB2b2lkIFNjcmlwdENvbnRyb2xsZXI6 OmNsZWFyRm9yQ2xvc2UoKQpAQCAtMjc0LDggKzI3NCw4IEBAIHZvaWQgU2NyaXB0Q29udHJvbGxl cjo6ZXZhbHVhdGVJbklzb2xhdGVkV29ybGQodW5zaWduZWQgd29ybGRJRCwgY29uc3QgVmVjdG9y PFNjCiAgICAgICAgIHY4OjpIYW5kbGVTY29wZSBldmFsdWF0ZUhhbmRsZVNjb3BlOwogICAgICAg ICBWOElzb2xhdGVkQ29udGV4dCogaXNvbGF0ZWRDb250ZXh0ID0gMDsKICAgICAgICAgaWYgKHdv cmxkSUQgPiAwKSB7Ci0gICAgICAgICAgICBJc29sYXRlZFdvcmxkTWFwOjppdGVyYXRvciBpdGVy ID0gbV9wcm94eS0+aXNvbGF0ZWRXb3JsZHMoKS5maW5kKHdvcmxkSUQpOwotICAgICAgICAgICAg aWYgKGl0ZXIgIT0gbV9wcm94eS0+aXNvbGF0ZWRXb3JsZHMoKS5lbmQoKSkKKyAgICAgICAgICAg IElzb2xhdGVkV29ybGRNYXA6Oml0ZXJhdG9yIGl0ZXIgPSBtX2lzb2xhdGVkV29ybGRzLmZpbmQo d29ybGRJRCk7CisgICAgICAgICAgICBpZiAoaXRlciAhPSBtX2lzb2xhdGVkV29ybGRzLmVuZCgp KQogICAgICAgICAgICAgICAgIGlzb2xhdGVkQ29udGV4dCA9IGl0ZXItPnNlY29uZDsKICAgICAg ICAgICAgIGVsc2UgewogICAgICAgICAgICAgICAgIGlzb2xhdGVkQ29udGV4dCA9IG5ldyBWOElz b2xhdGVkQ29udGV4dChtX2ZyYW1lLCBleHRlbnNpb25Hcm91cCwgd29ybGRJRCk7CkBAIC0yODUs MTEgKzI4NSwxMSBAQCB2b2lkIFNjcmlwdENvbnRyb2xsZXI6OmV2YWx1YXRlSW5Jc29sYXRlZFdv cmxkKHVuc2lnbmVkIHdvcmxkSUQsIGNvbnN0IFZlY3RvcjxTYwogICAgICAgICAgICAgICAgIH0K IAogICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgY2hhbmdlIHRoaXMgdG8gdXNp bmcgd2luZG93IHNoZWxscyB0byBtYXRjaCBKU0MuCi0gICAgICAgICAgICAgICAgbV9wcm94eS0+ aXNvbGF0ZWRXb3JsZHMoKS5zZXQod29ybGRJRCwgaXNvbGF0ZWRDb250ZXh0KTsKKyAgICAgICAg ICAgICAgICBtX2lzb2xhdGVkV29ybGRzLnNldCh3b3JsZElELCBpc29sYXRlZENvbnRleHQpOwog ICAgICAgICAgICAgfQogCi0gICAgICAgICAgICBJc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5N YXA6Oml0ZXJhdG9yIHNlY3VyaXR5T3JpZ2luSXRlciA9IG1fcHJveHktPmlzb2xhdGVkV29ybGRT ZWN1cml0eU9yaWdpbnMoKS5maW5kKHdvcmxkSUQpOwotICAgICAgICAgICAgaWYgKHNlY3VyaXR5 T3JpZ2luSXRlciAhPSBtX3Byb3h5LT5pc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5zKCkuZW5k KCkpCisgICAgICAgICAgICBJc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5NYXA6Oml0ZXJhdG9y IHNlY3VyaXR5T3JpZ2luSXRlciA9IG1faXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2lucy5maW5k KHdvcmxkSUQpOworICAgICAgICAgICAgaWYgKHNlY3VyaXR5T3JpZ2luSXRlciAhPSBtX2lzb2xh dGVkV29ybGRTZWN1cml0eU9yaWdpbnMuZW5kKCkpCiAgICAgICAgICAgICAgICAgaXNvbGF0ZWRD b250ZXh0LT5zZXRTZWN1cml0eU9yaWdpbihzZWN1cml0eU9yaWdpbkl0ZXItPnNlY29uZCk7CiAg ICAgICAgIH0gZWxzZSB7CiAgICAgICAgICAgICBpc29sYXRlZENvbnRleHQgPSBuZXcgVjhJc29s YXRlZENvbnRleHQobV9mcmFtZSwgZXh0ZW5zaW9uR3JvdXAsIHdvcmxkSUQpOwpAQCAtMzI1LDkg KzMyNSw5IEBAIHZvaWQgU2NyaXB0Q29udHJvbGxlcjo6ZXZhbHVhdGVJbklzb2xhdGVkV29ybGQo dW5zaWduZWQgd29ybGRJRCwgY29uc3QgVmVjdG9yPFNjCiB2b2lkIFNjcmlwdENvbnRyb2xsZXI6 OnNldElzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbihpbnQgd29ybGRJRCwgUGFzc1JlZlB0cjxT ZWN1cml0eU9yaWdpbj4gc2VjdXJpdHlPcmlnaW4pCiB7CiAgICAgQVNTRVJUKHdvcmxkSUQpOwot ICAgIG1fcHJveHktPmlzb2xhdGVkV29ybGRTZWN1cml0eU9yaWdpbnMoKS5zZXQod29ybGRJRCwg c2VjdXJpdHlPcmlnaW4pOwotICAgIElzb2xhdGVkV29ybGRNYXA6Oml0ZXJhdG9yIGl0ZXIgPSBt X3Byb3h5LT5pc29sYXRlZFdvcmxkcygpLmZpbmQod29ybGRJRCk7Ci0gICAgaWYgKGl0ZXIgIT0g bV9wcm94eS0+aXNvbGF0ZWRXb3JsZHMoKS5lbmQoKSkKKyAgICBtX2lzb2xhdGVkV29ybGRTZWN1 cml0eU9yaWdpbnMuc2V0KHdvcmxkSUQsIHNlY3VyaXR5T3JpZ2luKTsKKyAgICBJc29sYXRlZFdv cmxkTWFwOjppdGVyYXRvciBpdGVyID0gbV9pc29sYXRlZFdvcmxkcy5maW5kKHdvcmxkSUQpOwor ICAgIGlmIChpdGVyICE9IG1faXNvbGF0ZWRXb3JsZHMuZW5kKCkpCiAgICAgICAgIGl0ZXItPnNl Y29uZC0+c2V0U2VjdXJpdHlPcmlnaW4oc2VjdXJpdHlPcmlnaW4pOwogfQogCkBAIC02MjAsNyAr NjIwLDcgQEAgdm9pZCBTY3JpcHRDb250cm9sbGVyOjpzZXRDYXB0dXJlQ2FsbFN0YWNrRm9yVW5j YXVnaHRFeGNlcHRpb25zKGJvb2wgdmFsdWUpCiB2b2lkIFNjcmlwdENvbnRyb2xsZXI6OmNvbGxl Y3RJc29sYXRlZENvbnRleHRzKFZlY3RvcjxzdGQ6OnBhaXI8U2NyaXB0U3RhdGUqLCBTZWN1cml0 eU9yaWdpbio+ID4mIHJlc3VsdCkKIHsKICAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxlU2NvcGU7 Ci0gICAgZm9yIChJc29sYXRlZFdvcmxkTWFwOjppdGVyYXRvciBpdCA9IG1fcHJveHktPmlzb2xh dGVkV29ybGRzKCkuYmVnaW4oKTsgaXQgIT0gbV9wcm94eS0+aXNvbGF0ZWRXb3JsZHMoKS5lbmQo KTsgKytpdCkgeworICAgIGZvciAoSXNvbGF0ZWRXb3JsZE1hcDo6aXRlcmF0b3IgaXQgPSBtX2lz b2xhdGVkV29ybGRzLmJlZ2luKCk7IGl0ICE9IG1faXNvbGF0ZWRXb3JsZHMuZW5kKCk7ICsraXQp IHsKICAgICAgICAgVjhJc29sYXRlZENvbnRleHQqIGlzb2xhdGVkQ29udGV4dCA9IGl0LT5zZWNv bmQ7CiAgICAgICAgIGlmICghaXNvbGF0ZWRDb250ZXh0LT5zZWN1cml0eU9yaWdpbigpKQogICAg ICAgICAgICAgY29udGludWU7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92 OC9TY3JpcHRDb250cm9sbGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRD b250cm9sbGVyLmgKaW5kZXggMWU0YmJhMzQ0NTMxMmQyNTVhMGYwZjU1MjA5M2U1OWRjYWQ5ZDQy My4uYzQxMWVjYTgzYmVkNDYwNTIwMmIxNmIxM2NlNjcwNTNkNDQ1ZDJkMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0Q29udHJvbGxlci5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdENvbnRyb2xsZXIuaApAQCAtMjE1LDYgKzIxNSwx MyBAQCBwcml2YXRlOgogICAgIC8vIEZvciB0aGUgbW9tZW50LCB3ZSBoYXZlIG9uZSBvZiB0aGVz ZS4gU29vbiB3ZSB3aWxsIGhhdmUgb25lIHBlciBET01XcmFwcGVyV29ybGQuCiAgICAgUmVmUHRy PFY4RE9NV2luZG93U2hlbGw+IG1fd2luZG93U2hlbGw7CiAKKyAgICAvLyBUaGUgaXNvbGF0ZWQg d29ybGRzIHdlIGFyZSB0cmFja2luZyBmb3IgdGhpcyBmcmFtZS4gV2UgaG9sZCB0aGVtIGFsaXZl CisgICAgLy8gaGVyZSBzbyB0aGF0IHRoZXkgY2FuIGJlIHVzZWQgYWdhaW4gYnkgZnV0dXJlIGNh bGxzIHRvCisgICAgLy8gZXZhbHVhdGVJbklzb2xhdGVkV29ybGQoKS4KKyAgICBJc29sYXRlZFdv cmxkTWFwIG1faXNvbGF0ZWRXb3JsZHM7CisKKyAgICBJc29sYXRlZFdvcmxkU2VjdXJpdHlPcmln aW5NYXAgbV9pc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5zOworCiAgICAgYm9vbCBtX3BhdXNl ZDsKIAogICAgIE93blB0cjxWOFByb3h5PiBtX3Byb3h5OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhQcm94eS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhQcm94eS5oCmluZGV4IDYzMDBhMTllNzg5YzE1YWMyNDIwMjAzMjI4NjhjOWQ5ZDBlOTNhYTEu LmQ2M2Q2ZmRmOWVlMjFhOTdhNWM4OWIzMjM5YzI1ZDQ4YTEzNDQwZjEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UHJveHkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9WOFByb3h5LmgKQEAgLTk2LDIyICs5Niw4IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICAgICAgLy8gRklYTUU6IFRoaXMgbWV0aG9kIHdpbGwgYmUgc29vbiByZW1vdmVkLCBh cyBhbGwgbWV0aG9kcyB0aGF0IGFjY2VzcyB3aW5kb3dTaGVsbCgpCiAgICAgICAgIC8vIHdpbGwg YmUgbW92ZWQgdG8gU2NyaXB0Q29udHJvbGxlci4KICAgICAgICAgVjhET01XaW5kb3dTaGVsbCog d2luZG93U2hlbGwoKSBjb25zdDsKLQotICAgICAgICAvLyBGSVhNRTogTW92ZSBtX2lzb2xhdGVk V29ybGRzIHRvIFNjcmlwdENvbnRyb2xsZXIgYW5kIHJlbW92ZSB0aGlzIGdldHRlci4KLSAgICAg ICAgSXNvbGF0ZWRXb3JsZE1hcCYgaXNvbGF0ZWRXb3JsZHMoKSB7IHJldHVybiBtX2lzb2xhdGVk V29ybGRzOyB9Ci0KLSAgICAgICAgLy8gRklYTUU6IE1vdmUgbV9pc29sYXRlZFdvcmxkU2VjdXJp dHlPcmlnaW5zIHRvIFNjcmlwdENvbnRyb2xsZXIgYW5kIHJlbW92ZSB0aGlzIGdldHRlci4KLSAg ICAgICAgSXNvbGF0ZWRXb3JsZFNlY3VyaXR5T3JpZ2luTWFwJiBpc29sYXRlZFdvcmxkU2VjdXJp dHlPcmlnaW5zKCkgeyByZXR1cm4gbV9pc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5zOyB9Ci0K ICAgICBwcml2YXRlOgogICAgICAgICBGcmFtZSogbV9mcmFtZTsKLQotICAgICAgICAvLyBUaGUg aXNvbGF0ZWQgd29ybGRzIHdlIGFyZSB0cmFja2luZyBmb3IgdGhpcyBmcmFtZS4gV2UgaG9sZCB0 aGVtIGFsaXZlCi0gICAgICAgIC8vIGhlcmUgc28gdGhhdCB0aGV5IGNhbiBiZSB1c2VkIGFnYWlu IGJ5IGZ1dHVyZSBjYWxscyB0bwotICAgICAgICAvLyBldmFsdWF0ZUluSXNvbGF0ZWRXb3JsZCgp LgotICAgICAgICBJc29sYXRlZFdvcmxkTWFwIG1faXNvbGF0ZWRXb3JsZHM7Ci0gICAgICAgIAot ICAgICAgICBJc29sYXRlZFdvcmxkU2VjdXJpdHlPcmlnaW5NYXAgbV9pc29sYXRlZFdvcmxkU2Vj dXJpdHlPcmlnaW5zOwogICAgIH07CiB9CiAK