94760 2012-08-22 17:24:08 -0700 [V8] OwnHandle doesn't need to support weak handles 2012-08-22 18:22:40 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 702543 0 abarth 2012-08-22 17:24:08 -0700 [V8] OwnHandle doesn't need to support weak handles 702545 1 160044 abarth 2012-08-22 17:24:41 -0700 Created attachment 160044 Patch 702547 2 160044 haraken 2012-08-22 17:26:30 -0700 Comment on attachment 160044 Patch Looks reasonable. 702603 3 abarth 2012-08-22 18:22:40 -0700 Committed r126376: <http://trac.webkit.org/changeset/126376> 160044 2012-08-22 17:24:41 -0700 2012-08-22 17:26:30 -0700 Patch bug-94760-20120822172439.patch text/plain 3273 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MzY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjg1YTg5MTg5MTM3MzJh OTU2ODg3N2RlNjVkODQ5Y2I3ZGU4OTZhNS4uZTJmOGE2MGZhZjFlN2FjMmRhOTY3ZDJhZTMxNGVk Y2YyNjNlZTU4ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTA4LTIyICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1Y4XSBPd25IYW5kbGUgZG9l c24ndCBuZWVkIHRvIHN1cHBvcnQgd2VhayBoYW5kbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDc2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNvZGUgdXNlcyBtYWtlV2VhaygpLiBXZSBjYW4g ZHJvcCBzdXBwb3J0IGZvciBpdCBhbmQgc2ltcGxpZnkgdGhpcworICAgICAgICBjbGFzcy4KKwor ICAgICAgICAqIGJpbmRpbmdzL3Y4L093bkhhbmRsZS5oOgorICAgICAgICAoV2ViQ29yZSk6Cisg ICAgICAgIChPd25IYW5kbGUpOgorICAgICAgICAoV2ViQ29yZTo6T3duSGFuZGxlOjpPd25IYW5k bGUpOgorICAgICAgICAoV2ViQ29yZTo6T3duSGFuZGxlOjp+T3duSGFuZGxlKToKKyAgICAgICAg KFdlYkNvcmU6Ok93bkhhbmRsZTo6Z2V0KToKKyAgICAgICAgKFdlYkNvcmU6Ok93bkhhbmRsZTo6 c2V0KToKKyAgICAgICAgKFdlYkNvcmU6Ok93bkhhbmRsZTo6Y2xlYXIpOgorCiAyMDEyLTA4LTIy ICBEYXZpZCBHcm9nYW4gIDxkZ3JvZ2FuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBJbmRleGVk REI6IHJldmVydCBpbnQgdmVyc2lvbiB3aGVuIHZlcnNpb24gY2hhbmdlIHRyYW5zYWN0aW9uIGFi b3J0cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvT3duSGFuZGxlLmgg Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Pd25IYW5kbGUuaAppbmRleCAxN2M1NTFjZDZl NzFlZmFkZDRjNTUwZTU4ZjBjZjQ3ZTM0NDViMTZkLi42NjhmNWQ0MTRkNGM3OGQ4M2ZkNTI4YjBh MzU4NzY1MWI0ZmZiMWE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9P d25IYW5kbGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9Pd25IYW5kbGUuaApA QCAtMzUsNDUgKzM1LDQxIEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAotICAgIHRlbXBsYXRl PHR5cGVuYW1lIFQ+Ci0gICAgY2xhc3MgT3duSGFuZGxlIHsKLSAgICBwdWJsaWM6Ci0gICAgICAg IE93bkhhbmRsZSgpIHsgfQotICAgICAgICBleHBsaWNpdCBPd25IYW5kbGUodjg6OkhhbmRsZTxU PiBoYW5kbGUpIDogbV9oYW5kbGUodjg6OlBlcnNpc3RlbnQ8VD46Ok5ldyhoYW5kbGUpKSB7IH0K LSAgICAgICAgfk93bkhhbmRsZSgpIHsgY2xlYXIoKTsgfQordGVtcGxhdGU8dHlwZW5hbWUgVD4K K2NsYXNzIE93bkhhbmRsZSB7CitwdWJsaWM6CisgICAgT3duSGFuZGxlKCkgeyB9CiAKLSAgICAg ICAgdjg6OkhhbmRsZTxUPiBnZXQoKSBjb25zdCB7IHJldHVybiBtX2hhbmRsZTsgfQotICAgICAg ICB2b2lkIHNldCh2ODo6SGFuZGxlPFQ+IGhhbmRsZSkgeyBjbGVhcigpOyBtX2hhbmRsZSA9IHY4 OjpQZXJzaXN0ZW50PFQ+OjpOZXcoaGFuZGxlKTsgfQorICAgIGV4cGxpY2l0IE93bkhhbmRsZSh2 ODo6SGFuZGxlPFQ+IGhhbmRsZSkKKyAgICAgICAgOiBtX2hhbmRsZSh2ODo6UGVyc2lzdGVudDxU Pjo6TmV3KGhhbmRsZSkpCisgICAgeworICAgIH0KIAotICAgICAgICAvLyBOb3RlOiBUaGlzIGlz IGNsZWFyIGluIHRoZSBPd25QdHIgc2Vuc2UsIG5vdCB0aGUgdjg6OkhhbmRsZSBzZW5zZS4KLSAg ICAgICAgdm9pZCBjbGVhcigpCi0gICAgICAgIHsKLSAgICAgICAgICAgIGlmIChtX2hhbmRsZS5J c0VtcHR5KCkpCi0gICAgICAgICAgICAgICAgcmV0dXJuOwotICAgICAgICAgICAgaWYgKG1faGFu ZGxlLklzV2VhaygpKQotICAgICAgICAgICAgICAgIG1faGFuZGxlLkNsZWFyV2VhaygpOwotICAg ICAgICAgICAgbV9oYW5kbGUuRGlzcG9zZSgpOwotICAgICAgICAgICAgbV9oYW5kbGUuQ2xlYXIo KTsKLSAgICAgICAgfQorICAgIH5Pd25IYW5kbGUoKQorICAgIHsKKyAgICAgICAgY2xlYXIoKTsK KyAgICB9CiAKLSAgICAgICAgLy8gTWFrZSB0aGUgdW5kZXJseWluZyBoYW5kbGUgd2Vhay4gIFRo ZSBjbGllbnQgZG9lc24ndCBnZXQgYSBjYWxsYmFjaywKLSAgICAgICAgLy8gd2UganVzdCBtYWtl IHRoZSBoYW5kbGUgZW1wdHkuCi0gICAgICAgIHZvaWQgbWFrZVdlYWsoKQotICAgICAgICB7Ci0g ICAgICAgICAgICBpZiAobV9oYW5kbGUuSXNFbXB0eSgpKQotICAgICAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgICAgIG1faGFuZGxlLk1ha2VXZWFrKHRoaXMsICZPd25IYW5kbGU8VD46Ondl YWtDYWxsYmFjayk7Ci0gICAgICAgIH0KKyAgICB2ODo6SGFuZGxlPFQ+IGdldCgpIGNvbnN0IHsg cmV0dXJuIG1faGFuZGxlOyB9CiAKLSAgICBwcml2YXRlOgotICAgICAgICBzdGF0aWMgdm9pZCB3 ZWFrQ2FsbGJhY2sodjg6OlBlcnNpc3RlbnQ8djg6OlZhbHVlPiBvYmplY3QsIHZvaWQqIG93bkhh bmRsZSkKLSAgICAgICAgewotICAgICAgICAgICAgT3duSGFuZGxlPFQ+KiBoYW5kbGUgPSBzdGF0 aWNfY2FzdDxPd25IYW5kbGU8VD4qPihvd25IYW5kbGUpOwotICAgICAgICAgICAgaGFuZGxlLT5j bGVhcigpOwotICAgICAgICB9CisgICAgdm9pZCBzZXQodjg6OkhhbmRsZTxUPiBoYW5kbGUpCisg ICAgeworICAgICAgICBjbGVhcigpOworICAgICAgICBtX2hhbmRsZSA9IHY4OjpQZXJzaXN0ZW50 PFQ+OjpOZXcoaGFuZGxlKTsKKyAgICB9CiAKLSAgICAgICAgdjg6OlBlcnNpc3RlbnQ8VD4gbV9o YW5kbGU7Ci0gICAgfTsKKyAgICAvLyBOb3RlOiBUaGlzIGlzIGNsZWFyIGluIHRoZSBPd25QdHIg c2Vuc2UsIG5vdCB0aGUgdjg6OkhhbmRsZSBzZW5zZS4KKyAgICB2b2lkIGNsZWFyKCkKKyAgICB7 CisgICAgICAgIGlmIChtX2hhbmRsZS5Jc0VtcHR5KCkpCisgICAgICAgICAgICByZXR1cm47Cisg ICAgICAgIG1faGFuZGxlLkRpc3Bvc2UoKTsKKyAgICAgICAgbV9oYW5kbGUuQ2xlYXIoKTsKKyAg ICB9CisKK3ByaXZhdGU6CisgICAgdjg6OlBlcnNpc3RlbnQ8VD4gbV9oYW5kbGU7Cit9OwogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAK