94756 2012-08-22 16:33:48 -0700 Fix a operator ordering bug in SVGSMILElement::calculateAnimationPercentAndRepeat 2012-10-26 18:20:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 thakis thakis dglazkov d-r eric fmalita hans inferno jamesr koivisto krit pdr peter+ews rwlbuis schenney webkit.review.bot zimmermann oldest_to_newest 702508 0 thakis 2012-08-22 16:33:48 -0700 Fix a operator ordering bug in SVGSMILElement::calculateAnimationPercentAndRepeat 702512 1 160032 thakis 2012-08-22 16:35:53 -0700 Created attachment 160032 Patch 703164 2 eric 2012-08-23 11:08:00 -0700 Can we test this? 703186 3 160032 schenney 2012-08-23 11:33:05 -0700 Comment on attachment 160032 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=160032&action=review > Source/WebCore/svg/animation/SVGSMILElement.cpp:969 > repeat = static_cast<unsigned>(repeatingDuration.value() / simpleDuration.value()); I would propose avoiding the fmod entirely. It apparently is being used to determine if the fractional amount of repeatingDuration.value() / simpleDuration.value() is zero. Instead: float repeatFloat = repeatingDuration.value() / simpleDuration.value(); repeat = static_cast<unsigned>(repeatFloat); if (!(repeatFloat - repeat)) repeat--; No idea how to test it. 705650 4 thakis 2012-08-27 14:04:55 -0700 (In reply to comment #3) > (From update of attachment 160032 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=160032&action=review > > > Source/WebCore/svg/animation/SVGSMILElement.cpp:969 > > repeat = static_cast<unsigned>(repeatingDuration.value() / simpleDuration.value()); > > I would propose avoiding the fmod entirely. It apparently is being used to determine if the fractional amount of repeatingDuration.value() / simpleDuration.value() is zero. Instead: > float repeatFloat = repeatingDuration.value() / simpleDuration.value(); > repeat = static_cast<unsigned>(repeatFloat); > if (!(repeatFloat - repeat)) > repeat--; How is that simpler than what's currently there? 705654 5 schenney 2012-08-27 14:10:15 -0700 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 160032 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=160032&action=review > > > > > Source/WebCore/svg/animation/SVGSMILElement.cpp:969 > > > repeat = static_cast<unsigned>(repeatingDuration.value() / simpleDuration.value()); > > > > I would propose avoiding the fmod entirely. It apparently is being used to determine if the fractional amount of repeatingDuration.value() / simpleDuration.value() is zero. Instead: > > float repeatFloat = repeatingDuration.value() / simpleDuration.value(); > > repeat = static_cast<unsigned>(repeatFloat); > > if (!(repeatFloat - repeat)) > > repeat--; > > How is that simpler than what's currently there? It's not really simpler, but it does less work, I think, and does not have numerical accuracy issues. Actually, this is probably better: float repeatFloat = repeatingDuration.value() / simpleDuration.value(); repeat = static_cast<unsigned>(repeatFloat); if (repeatFloat == repeat) repeat--; 705667 6 thakis 2012-08-27 14:19:23 -0700 > > How is that simpler than what's currently there? > > It's not really simpler, but it does less work, I think, and does not have > numerical accuracy issues. Actually, this is probably better: > > float repeatFloat = repeatingDuration.value() / simpleDuration.value(); > repeat = static_cast<unsigned>(repeatFloat); > if (repeatFloat == repeat) > repeat--; I don't think this is performance-sensitive code. I would assume that fmod is at least as smart as any reimplementation we attempt to do. 714485 7 hans 2012-09-07 07:06:52 -0700 *** Bug 96093 has been marked as a duplicate of this bug. *** 714603 8 thakis 2012-09-07 09:35:56 -0700 This is blocking our next clang roll. Can this go in? The alternative is to disable this new warning for webkit. 714614 9 pdr 2012-09-07 09:41:28 -0700 (In reply to comment #8) > This is blocking our next clang roll. Can this go in? The alternative is to disable this new warning for webkit. I think it's fine to go in, but you'll have to find an r+ somewhere else. 715401 10 160032 krit 2012-09-08 19:46:53 -0700 Comment on attachment 160032 Patch I would be in favor of doing it better from the beginning. 715455 11 162986 thakis 2012-09-09 01:46:05 -0700 Created attachment 162986 Patch 715456 12 162986 webkit-ews 2012-09-09 01:52:34 -0700 Comment on attachment 162986 Patch Attachment 162986 did not pass qt-ews (qt): Output: http://queues.webkit.org/results/13794495 715457 13 162986 peter+ews 2012-09-09 01:54:11 -0700 Comment on attachment 162986 Patch Attachment 162986 did not pass cr-android-ews (chromium-android): Output: http://queues.webkit.org/results/13788812 715458 14 162986 webkit-ews 2012-09-09 01:54:26 -0700 Comment on attachment 162986 Patch Attachment 162986 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13794496 715460 15 162986 webkit.review.bot 2012-09-09 02:00:44 -0700 Comment on attachment 162986 Patch Attachment 162986 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13797410 715465 16 162988 thakis 2012-09-09 02:59:28 -0700 Created attachment 162988 Patch 715494 17 162988 krit 2012-09-09 07:04:59 -0700 Comment on attachment 162988 Patch Well, wait. Instead of fixing the bug you surround it with a flag? Don't think that this is a good idea. 715658 18 thakis 2012-09-09 18:38:16 -0700 (In reply to comment #17) > (From update of attachment 162988 [details]) > Well, wait. Instead of fixing the bug you surround it with a flag? Don't think that this is a good idea. The fix was in the first patch, which was rejected as far as I understand due to lack of test (which is reasonable). So, here's the background: We update clang in chromium every 1-2 weeks. Every now and then, clang has a new warning, and we need to make sure all our code compiles with that new warning (we build with -Werror). If the warning is noisy, we just disable it globally, but since the clang people have a very reasonable warning policy, this happens rarely. This specific warning warns when someone writes `if (f(a, b, c > 0))` if they meant to write `if (f(a, b, c) > 0)` (see http://permalink.gmane.org/gmane.comp.compilers.clang.scm/55995 for more information if you're curious). This is exactly what happened here, see the ChangeLog entry in the first patch for more information, where I looked at the history of this file. I had hoped that the original author of this code (anttik) would chime in. Maybe he's on vacation, or busy with other things. I'm not familiar with the svg code, and I currently don't have time to work on a test. (Someone familiar with the svg code mentioned earlier on this bug that it's not obvious how to test this.) I do want to update clang in chromium though, so I need some way forward. I could disable this new warning for all of chrome, but then it won't catch new bugs that it could prevent. I could disable it just for webkit's svg gyp target, but then it won't prevent new bugs it could've prevented in the svg code (also, if someone who didn't use gyp used a new clang, they'd get this warning, and they might even fix this the wrong way -- see e.g. bug 96093). So suppressing the warning just locally in this file seems like the best way forward to me. Let me know if you still disagree, then I'll disable it somewhere further up the stack. 716712 19 162988 krit 2012-09-10 17:16:41 -0700 Comment on attachment 162988 Patch (In reply to comment #18) > Let me know if you still disagree, then I'll disable it somewhere further up the stack. I just asked you to address the code suggestions from stephen. Adding ifdef's is not a good solution at all, especially when you can easily fix it. r- because of ifdef instead of fixing the problem. It is ok not to add a test, since it is build system related IMO. 716754 20 163260 thakis 2012-09-10 18:24:16 -0700 Created attachment 163260 Patch 716758 21 thakis 2012-09-10 18:25:48 -0700 Back to patch set 1 then. As mentioned above, I don't think Stephen's suggestion make the code better. I'm happy to do the changes he's asking for in a follow-up patch if he really likes to see them. In this patch, I just want to fix a compiler warning and put the code in the form the original author intended. (See the ChangeLog entry.) 716829 22 krit 2012-09-10 21:46:49 -0700 Our project goal is to clean up code that we touch. The second code suggestion from Stephen looks good to me. 716830 23 thakis 2012-09-10 21:48:03 -0700 It looks worse to me. I'm happy to discuss this on irc (thakis). I'm about to globally disable the warning instead: http://codereview.chromium.org/10917180/ 716870 24 163260 jamesr 2012-09-10 23:03:38 -0700 Comment on attachment 163260 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163260&action=review > Source/WebCore/svg/animation/SVGSMILElement.cpp:969 > repeat = static_cast<unsigned>(repeatingDuration.value() / simpleDuration.value()); Due to this line it's fairly safe to assume simpleDuration.value() is not zero... > Source/WebCore/svg/animation/SVGSMILElement.cpp:-970 > - if (fmod(repeatingDuration.value(), !simpleDuration.value())) so !simpleDuration.value() simplifies to false which means this can be simplified to: if (fmodf(repeatingDuration.value(), 0)) which according to man fmodf raises a floating point exception and returns NaN so I'm guessing this code is somehow not reachable at all in practice. perhaps we can just nuke this whole if 717142 25 schenney 2012-09-11 07:31:05 -0700 (In reply to comment #24) > (From update of attachment 163260 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163260&action=review > > > Source/WebCore/svg/animation/SVGSMILElement.cpp:969 > > repeat = static_cast<unsigned>(repeatingDuration.value() / simpleDuration.value()); > > Due to this line it's fairly safe to assume simpleDuration.value() is not zero... simpleDuration.value() is not zero. That is checked for at the beginning of the method. > > Source/WebCore/svg/animation/SVGSMILElement.cpp:-970 > > - if (fmod(repeatingDuration.value(), !simpleDuration.value())) > > so !simpleDuration.value() simplifies to false which means this can be simplified to: > > if (fmodf(repeatingDuration.value(), 0)) > > which according to man fmodf raises a floating point exception and returns NaN > > so I'm guessing this code is somehow not reachable at all in practice. perhaps we can just nuke this whole if I believe that the code is intended to catch the case where the repeatingDuration is an exact multiple of the simpleDuration, in which case we need to add one to the repeat count. It might be possible to hit it with a test - I can try in my quiet moments today. 752521 26 171036 thakis 2012-10-26 15:59:11 -0700 Created attachment 171036 Patch 752523 27 171036 jamesr 2012-10-26 16:02:41 -0700 Comment on attachment 171036 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=171036&action=review > Source/WebCore/svg/animation/SVGSMILElement.cpp:1006 > repeat = static_cast<unsigned>(repeatingDuration.value() / simpleDuration.value()); > - if (fmod(repeatingDuration.value(), !simpleDuration.value())) > - repeat--; > + repeat--; fold into the line above? 752526 28 thakis 2012-10-26 16:05:15 -0700 (In reply to comment #27) > (From update of attachment 171036 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=171036&action=review > > > Source/WebCore/svg/animation/SVGSMILElement.cpp:1006 > > repeat = static_cast<unsigned>(repeatingDuration.value() / simpleDuration.value()); > > - if (fmod(repeatingDuration.value(), !simpleDuration.value())) > > - repeat--; > > + repeat--; > > fold into the line above? Done. (Didn't do it for somewhat nicer blame output, but meh) 752528 29 171037 thakis 2012-10-26 16:05:29 -0700 Created attachment 171037 Patch 752544 30 171037 krit 2012-10-26 16:15:45 -0700 Comment on attachment 171037 Patch r=me 752546 31 171037 thakis 2012-10-26 16:18:24 -0700 Comment on attachment 171037 Patch Thanks! 752634 32 171037 webkit.review.bot 2012-10-26 18:20:45 -0700 Comment on attachment 171037 Patch Clearing flags on attachment: 171037 Committed r132715: <http://trac.webkit.org/changeset/132715> 752636 33 webkit.review.bot 2012-10-26 18:20:52 -0700 All reviewed patches have been landed. Closing bug. 160032 2012-08-22 16:35:53 -0700 2012-09-09 01:46:01 -0700 Patch bug-94756-20120822163551.patch text/plain 2285 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MjgzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2MzZDY3MTAzYzJhZDkx ZWMxMTQ1M2IxOWRiM2QyOGJhYWFiMWZiZi4uOGQzZmJhM2MwN2ExNmFkOWNhOWVjMDU5OGFmZDhj YTVmNTk3M2ZhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTIyICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYSBvcGVyYXRvciBv cmRlcmluZyBidWcgaW4gU1ZHU01JTEVsZW1lbnQ6OmNhbGN1bGF0ZUFuaW1hdGlvblBlcmNlbnRB bmRSZXBlYXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk0NzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyBjb2RlIHdhcyBvcmlnaW5hbGx5IGFkZGVkIGluIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcv YnJvd3Nlci90cnVuay9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwP3Jl dj0zMTgwMSBhcworCisgICAgICAgICAgaWYgKGZtb2QocmVwZWF0aW5nRHVyYXRpb24udmFsdWUo KSwgc2ltcGxlRHVyYXRpb24udmFsdWUoKSA9PSAwLikpCisKKyAgICAgICAgSXQgbG9va3MgbGlr ZSB0aGF0IHdhcyBzdXBwb3NlZCB0byByZWFkIGBpZiAoZm1vZCguLi4pID09IDApYCwgYnV0IHRo ZSA9PSBzbGlwcGVkIGludG8gdGhlIGZtb2QgY2FsbC4KKworICAgICAgICBodHRwOi8vdHJhYy53 ZWJraXQub3JnL2NoYW5nZXNldC83NDc4MiBtaW5kbGVzc2x5IHJlZmFjdG9yZWQgdGhpcyB0byB0 aGUgY3VycmVudCBmb3JtLiBJbnN0ZWFkLAorICAgICAgICBkbyB3aGF0IHRoZSBjb2RlIHByb2Jh Ymx5IGludGVuZGVkIGluIHRoZSBmaXJzdCBwbGFjZS4KKworICAgICAgICBGb3VuZCBieSAtV2lt cGxpY2l0LWNvbnZlcnNpb24tZmxvYXRpbmctcG9pbnQtdG8tYm9vbCwgYSB3YXJuaW5nIGN1cnJl bnRseSBiZWluZyBwcm90b3R5cGVkIGluIGNsYW5nLgorCisgICAgICAgICogc3ZnL2FuaW1hdGlv bi9TVkdTTUlMRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdTTUlMRWxlbWVudDo6 Y2FsY3VsYXRlQW5pbWF0aW9uUGVyY2VudEFuZFJlcGVhdCk6CisKIDIwMTItMDgtMjIgIEFuZHJl eSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogW1dlYkdMXSBHZW5lcmljIGZyYW1ld29yayBkcmFmdCBmb3IgdHJhY2tpbmcgV2ViR0wgcmVz b3VyY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQu Y3BwCmluZGV4IDQzZTg0YjFiMzViZDA1ZWM3MjFmMjM4Zjc1NTZlNzhlMTgwZTk4MzcuLjkwMTMy ZTY2M2UwNDI3NDFhMDA2MzQ3ZThjYjBkMzE1MjljMTY2ZjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCkBAIC05NjcsNyArOTY3LDcgQEAg ZmxvYXQgU1ZHU01JTEVsZW1lbnQ6OmNhbGN1bGF0ZUFuaW1hdGlvblBlcmNlbnRBbmRSZXBlYXQo U01JTFRpbWUgZWxhcHNlZCwgdW5zaWcKICAgICBTTUlMVGltZSByZXBlYXRpbmdEdXJhdGlvbiA9 IHRoaXMtPnJlcGVhdGluZ0R1cmF0aW9uKCk7CiAgICAgaWYgKGVsYXBzZWQgPj0gbV9pbnRlcnZh bEVuZCB8fCBhY3RpdmVUaW1lID4gcmVwZWF0aW5nRHVyYXRpb24pIHsKICAgICAgICAgcmVwZWF0 ID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHJlcGVhdGluZ0R1cmF0aW9uLnZhbHVlKCkgLyBzaW1w bGVEdXJhdGlvbi52YWx1ZSgpKTsKLSAgICAgICAgaWYgKGZtb2QocmVwZWF0aW5nRHVyYXRpb24u dmFsdWUoKSwgIXNpbXBsZUR1cmF0aW9uLnZhbHVlKCkpKQorICAgICAgICBpZiAoIWZtb2QocmVw ZWF0aW5nRHVyYXRpb24udmFsdWUoKSwgc2ltcGxlRHVyYXRpb24udmFsdWUoKSkpCiAgICAgICAg ICAgICByZXBlYXQtLTsKIAogICAgICAgICBkb3VibGUgcGVyY2VudCA9IChtX2ludGVydmFsRW5k LnZhbHVlKCkgLSBtX2ludGVydmFsQmVnaW4udmFsdWUoKSkgLyBzaW1wbGVEdXJhdGlvbi52YWx1 ZSgpOwo= 162986 2012-09-09 01:46:05 -0700 2012-09-09 02:59:23 -0700 Patch bug-94756-20120909174542.patch text/plain 2183 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWY2NGExNWYwODM4NWFk YjM5OGE5OGZmMDBjNTJjYTFjZmZkN2EzNS4uNDhmY2NjNjUzMjJiMzM3ZmVkMDRkYjIwZjczNzVj OGQyZDAxY2FmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTA5ICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBTdXBwcmVzcyBhIHdhcm5p bmcgYWJvdXQgYW4gb3BlcmF0b3Igb3JkZXJpbmcgYnVnIGluIFNWR1NNSUxFbGVtZW50OjpjYWxj dWxhdGVBbmltYXRpb25QZXJjZW50QW5kUmVwZWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDc1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBhbHRlcm5hdGl2ZSBpcyB0byBkaXNhYmxlIHRoZSB3 YXJuaW5nIGdsb2JhbGx5IGV2ZXJ5d2hlcmUgaW4KKyAgICAgICAgV2ViS2l0LiBCdXQgc2luY2Ug aXQgZmluZHMgcmVhbCBidWdzIGluIHByYWN0aWNlIChzZWUgdGhpcyBvbmUpLAorICAgICAgICBp dCdzIGJldHRlciB0byBqdXN0IHN1cHByZXNzIGl0IGhlcmUuCisKKyAgICAgICAgKiBzdmcvYW5p bWF0aW9uL1NWR1NNSUxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1NNSUxFbGVt ZW50OjpjYWxjdWxhdGVBbmltYXRpb25QZXJjZW50QW5kUmVwZWF0KToKKwogMjAxMi0wOS0wNSAg VGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkOyByZXZlcnQgYSBjaGFuZ2UgdG8gU2Nyb2xsaW5nVHJlZU5vZGVNYWMgd2hpY2ggYWNjaWRl bnRhbGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQu Y3BwCmluZGV4IGE1MTMyYTA1ZmVmYzZlNTY2MzFkNzUwNjAzYjU4MDE3YjgxNjI5ZDQuLjI1Nzk5 NjhiZmZiMTBiMTQwNzU2NDFkN2Q5MWE3ZjY4YmZhOTVjNmQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCkBAIC05NjcsOCArOTY3LDE0IEBA IGZsb2F0IFNWR1NNSUxFbGVtZW50OjpjYWxjdWxhdGVBbmltYXRpb25QZXJjZW50QW5kUmVwZWF0 KFNNSUxUaW1lIGVsYXBzZWQsIHVuc2lnCiAgICAgU01JTFRpbWUgcmVwZWF0aW5nRHVyYXRpb24g PSB0aGlzLT5yZXBlYXRpbmdEdXJhdGlvbigpOwogICAgIGlmIChlbGFwc2VkID49IG1faW50ZXJ2 YWxFbmQgfHwgYWN0aXZlVGltZSA+IHJlcGVhdGluZ0R1cmF0aW9uKSB7CiAgICAgICAgIHJlcGVh dCA9IHN0YXRpY19jYXN0PHVuc2lnbmVkPihyZXBlYXRpbmdEdXJhdGlvbi52YWx1ZSgpIC8gc2lt cGxlRHVyYXRpb24udmFsdWUoKSk7CisjcHJhZ21hIGNsYW5nIGRpYWdub3N0aWMgcHVzaAorI3By YWdtYSBjbGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XaW1wbGljaXQtY29udmVyc2lvbi1mbG9h dGluZy1wb2ludC10by1ib29sIgorICAgICAgICAvLyBGSVhNRTogVGhpcyBzaG91bGQgYmUgaWYg KCFmbW9kKC4uLiwgc2ltcGxlRHVyYXRpb24udmFsdWUoKSkpLCBzZWUKKyAgICAgICAgLy8gdGhl IGZpcnN0IGJhdGNoIGF0IGh0dHA6Ly93a2IudWcvOTQ3NTYuIEJ1dCBtYWtpbmcgdGhhdCBjaGFu Z2UgbmVlZHMKKyAgICAgICAgLy8gYSB0ZXN0LgogICAgICAgICBpZiAoZm1vZChyZXBlYXRpbmdE dXJhdGlvbi52YWx1ZSgpLCAhc2ltcGxlRHVyYXRpb24udmFsdWUoKSkpCiAgICAgICAgICAgICBy ZXBlYXQtLTsKKyNwcmFnbWEgY2xhbmcgZGlhZ25vc3RpYyBwb3AKIAogICAgICAgICBkb3VibGUg cGVyY2VudCA9IChtX2ludGVydmFsRW5kLnZhbHVlKCkgLSBtX2ludGVydmFsQmVnaW4udmFsdWUo KSkgLyBzaW1wbGVEdXJhdGlvbi52YWx1ZSgpOwogICAgICAgICBwZXJjZW50ID0gcGVyY2VudCAt IGZsb29yKHBlcmNlbnQpOwo= 162988 2012-09-09 02:59:28 -0700 2012-09-10 18:24:11 -0700 Patch bug-94756-20120909185905.patch text/plain 2235 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Njk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWY2NGExNWYwODM4NWFk YjM5OGE5OGZmMDBjNTJjYTFjZmZkN2EzNS4uNDhmY2NjNjUzMjJiMzM3ZmVkMDRkYjIwZjczNzVj OGQyZDAxY2FmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTA5ICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBTdXBwcmVzcyBhIHdhcm5p bmcgYWJvdXQgYW4gb3BlcmF0b3Igb3JkZXJpbmcgYnVnIGluIFNWR1NNSUxFbGVtZW50OjpjYWxj dWxhdGVBbmltYXRpb25QZXJjZW50QW5kUmVwZWF0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDc1NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBhbHRlcm5hdGl2ZSBpcyB0byBkaXNhYmxlIHRoZSB3 YXJuaW5nIGdsb2JhbGx5IGV2ZXJ5d2hlcmUgaW4KKyAgICAgICAgV2ViS2l0LiBCdXQgc2luY2Ug aXQgZmluZHMgcmVhbCBidWdzIGluIHByYWN0aWNlIChzZWUgdGhpcyBvbmUpLAorICAgICAgICBp dCdzIGJldHRlciB0byBqdXN0IHN1cHByZXNzIGl0IGhlcmUuCisKKyAgICAgICAgKiBzdmcvYW5p bWF0aW9uL1NWR1NNSUxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNWR1NNSUxFbGVt ZW50OjpjYWxjdWxhdGVBbmltYXRpb25QZXJjZW50QW5kUmVwZWF0KToKKwogMjAxMi0wOS0wNSAg VGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmll d2VkOyByZXZlcnQgYSBjaGFuZ2UgdG8gU2Nyb2xsaW5nVHJlZU5vZGVNYWMgd2hpY2ggYWNjaWRl bnRhbGx5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxF bGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQu Y3BwCmluZGV4IGE1MTMyYTA1ZmVmYzZlNTY2MzFkNzUwNjAzYjU4MDE3YjgxNjI5ZDQuLjIyMjU0 ZWQ1MTlhYjNiZDY0OGIwODdiYTMxNzdmZDRjNGQ0OGI5ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCkBAIC05NjcsOCArOTY3LDE4IEBA IGZsb2F0IFNWR1NNSUxFbGVtZW50OjpjYWxjdWxhdGVBbmltYXRpb25QZXJjZW50QW5kUmVwZWF0 KFNNSUxUaW1lIGVsYXBzZWQsIHVuc2lnCiAgICAgU01JTFRpbWUgcmVwZWF0aW5nRHVyYXRpb24g PSB0aGlzLT5yZXBlYXRpbmdEdXJhdGlvbigpOwogICAgIGlmIChlbGFwc2VkID49IG1faW50ZXJ2 YWxFbmQgfHwgYWN0aXZlVGltZSA+IHJlcGVhdGluZ0R1cmF0aW9uKSB7CiAgICAgICAgIHJlcGVh dCA9IHN0YXRpY19jYXN0PHVuc2lnbmVkPihyZXBlYXRpbmdEdXJhdGlvbi52YWx1ZSgpIC8gc2lt cGxlRHVyYXRpb24udmFsdWUoKSk7CisjaWZkZWYgX19jbGFuZ19fCisjcHJhZ21hIGNsYW5nIGRp YWdub3N0aWMgcHVzaAorI3ByYWdtYSBjbGFuZyBkaWFnbm9zdGljIGlnbm9yZWQgIi1XaW1wbGlj aXQtY29udmVyc2lvbi1mbG9hdGluZy1wb2ludC10by1ib29sIgorI2VuZGlmCisgICAgICAgIC8v IEZJWE1FOiBUaGlzIHNob3VsZCBiZSBpZiAoIWZtb2QoLi4uLCBzaW1wbGVEdXJhdGlvbi52YWx1 ZSgpKSksIHNlZQorICAgICAgICAvLyB0aGUgZmlyc3QgYmF0Y2ggYXQgaHR0cDovL3drYi51Zy85 NDc1Ni4gQnV0IG1ha2luZyB0aGF0IGNoYW5nZSBuZWVkcworICAgICAgICAvLyBhIHRlc3QuCiAg ICAgICAgIGlmIChmbW9kKHJlcGVhdGluZ0R1cmF0aW9uLnZhbHVlKCksICFzaW1wbGVEdXJhdGlv bi52YWx1ZSgpKSkKICAgICAgICAgICAgIHJlcGVhdC0tOworI2lmZGVmIF9fY2xhbmdfXworI3By YWdtYSBjbGFuZyBkaWFnbm9zdGljIHBvcAorI2VuZGlmCiAKICAgICAgICAgZG91YmxlIHBlcmNl bnQgPSAobV9pbnRlcnZhbEVuZC52YWx1ZSgpIC0gbV9pbnRlcnZhbEJlZ2luLnZhbHVlKCkpIC8g c2ltcGxlRHVyYXRpb24udmFsdWUoKTsKICAgICAgICAgcGVyY2VudCA9IHBlcmNlbnQgLSBmbG9v cihwZXJjZW50KTsK 163260 2012-09-10 18:24:16 -0700 2012-10-26 15:59:08 -0700 Patch bug-94756-20120911102352.patch text/plain 2254 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWNhZTY2ZjExM2ExZjk5 NWQxY2NiMDY4YzY2YjViOTQwMTY5NjI4OC4uNzM2ZmM1MmRjNDIyNTNjZmEzMThmNzM5NjdiMmZj ZDBlY2MwMjBiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA4LTIyICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYSBvcGVyYXRvciBv cmRlcmluZyBidWcgaW4gU1ZHU01JTEVsZW1lbnQ6OmNhbGN1bGF0ZUFuaW1hdGlvblBlcmNlbnRB bmRSZXBlYXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk0NzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhpcyBjb2RlIHdhcyBvcmlnaW5hbGx5IGFkZGVkIGluIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcv YnJvd3Nlci90cnVuay9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwP3Jl dj0zMTgwMSBhcworCisgICAgICAgICAgaWYgKGZtb2QocmVwZWF0aW5nRHVyYXRpb24udmFsdWUo KSwgc2ltcGxlRHVyYXRpb24udmFsdWUoKSA9PSAwLikpCisKKyAgICAgICAgSXQgbG9va3MgbGlr ZSB0aGF0IHdhcyBzdXBwb3NlZCB0byByZWFkIGBpZiAoZm1vZCguLi4pID09IDApYCwgYnV0IHRo ZSA9PSBzbGlwcGVkIGludG8gdGhlIGZtb2QgY2FsbC4KKworICAgICAgICBodHRwOi8vdHJhYy53 ZWJraXQub3JnL2NoYW5nZXNldC83NDc4MiBtaW5kbGVzc2x5IHJlZmFjdG9yZWQgdGhpcyB0byB0 aGUgY3VycmVudCBmb3JtLiBJbnN0ZWFkLAorICAgICAgICBkbyB3aGF0IHRoZSBjb2RlIHByb2Jh Ymx5IGludGVuZGVkIGluIHRoZSBmaXJzdCBwbGFjZS4KKworICAgICAgICBGb3VuZCBieSAtV2lt cGxpY2l0LWNvbnZlcnNpb24tZmxvYXRpbmctcG9pbnQtdG8tYm9vbCwgYSB3YXJuaW5nIGN1cnJl bnRseSBiZWluZyBwcm90b3R5cGVkIGluIGNsYW5nLgorCisgICAgICAgICogc3ZnL2FuaW1hdGlv bi9TVkdTTUlMRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdTTUlMRWxlbWVudDo6 Y2FsY3VsYXRlQW5pbWF0aW9uUGVyY2VudEFuZFJlcGVhdCk6CisKIDIwMTItMDktMDkgIFBhdHJp Y2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFN0cmluZ0J1 aWxkZXI6OmFwcGVuZE51bWJlcigpIGFuZCB1c2UgaXQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvc3Zn L2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5jcHAKaW5kZXggYTUxMzJhMDVmZWZjNmU1NjYzMWQ3 NTA2MDNiNTgwMTdiODE2MjlkNC4uNzQwMTk0NTQyNWFhMTU4MjQyNWI3MDY0YzQxNGVmOTI0NDg4 MDM0OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxl bWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVu dC5jcHAKQEAgLTk2Nyw3ICs5NjcsNyBAQCBmbG9hdCBTVkdTTUlMRWxlbWVudDo6Y2FsY3VsYXRl QW5pbWF0aW9uUGVyY2VudEFuZFJlcGVhdChTTUlMVGltZSBlbGFwc2VkLCB1bnNpZwogICAgIFNN SUxUaW1lIHJlcGVhdGluZ0R1cmF0aW9uID0gdGhpcy0+cmVwZWF0aW5nRHVyYXRpb24oKTsKICAg ICBpZiAoZWxhcHNlZCA+PSBtX2ludGVydmFsRW5kIHx8IGFjdGl2ZVRpbWUgPiByZXBlYXRpbmdE dXJhdGlvbikgewogICAgICAgICByZXBlYXQgPSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmVwZWF0 aW5nRHVyYXRpb24udmFsdWUoKSAvIHNpbXBsZUR1cmF0aW9uLnZhbHVlKCkpOwotICAgICAgICBp ZiAoZm1vZChyZXBlYXRpbmdEdXJhdGlvbi52YWx1ZSgpLCAhc2ltcGxlRHVyYXRpb24udmFsdWUo KSkpCisgICAgICAgIGlmICghZm1vZChyZXBlYXRpbmdEdXJhdGlvbi52YWx1ZSgpLCBzaW1wbGVE dXJhdGlvbi52YWx1ZSgpKSkKICAgICAgICAgICAgIHJlcGVhdC0tOwogCiAgICAgICAgIGRvdWJs ZSBwZXJjZW50ID0gKG1faW50ZXJ2YWxFbmQudmFsdWUoKSAtIG1faW50ZXJ2YWxCZWdpbi52YWx1 ZSgpKSAvIHNpbXBsZUR1cmF0aW9uLnZhbHVlKCk7Cg== 171036 2012-10-26 15:59:11 -0700 2012-10-26 16:05:24 -0700 Patch bug-94756-20121026155742.patch text/plain 2049 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI1ZGMyN2YzYjg5ODIz ODI5ODRkNDJjYmYwZTA2YjRiMTI3YWFhMi4uZjc5YWE4MGY0ODgxMzM0ZmE2NzExYjIxMjVmNjY3 MmY5ODBhNTFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTI2ICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYSBvcGVyYXRvciBv cmRlcmluZyBidWcgaW4gU1ZHU01JTEVsZW1lbnQ6OmNhbGN1bGF0ZUFuaW1hdGlvblBlcmNlbnRB bmRSZXBlYXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk0NzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIGZ1bmN0aW9uIGhhcyBhbiBlYXJseSBleGl0IGZvciAhc2ltcGxlRHVyYXRpb24udmFsdWUo KSwgc28KKyAgICAgICAgIXNpbXBsZUR1cmF0aW9uLnZhbHVlKCkgYWx3YXlzIGlzIDAgd2hlbiBw YXNzZWQgYXMgc2Vjb25kIHBhcmFtZXRlciB0bworICAgICAgICBmbW9kKCksIHdoaWNoIG1lYW5z IGZtb2QoKSBhbHdheXMgcmV0dXJucyBOYU4sIHdoaWNoIGFsd2F5cyBldmFsdWF0ZXMKKyAgICAg ICAgdG8gdHJ1ZS4gU2ltcGxpZnkgdGhlIGNvZGUgYnkgcmVtb3ZpbmcgdGhhdCBleHBsaWNpdCBj aGVjay4KKworICAgICAgICBObyBvYnNlcnZhYmxlIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHN2ZyB0ZXN0cy4KKworICAgICAgICAqIHN2Zy9hbmltYXRp b24vU1ZHU01JTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHU01JTEVsZW1lbnQ6 OmNhbGN1bGF0ZUFuaW1hdGlvblBlcmNlbnRBbmRSZXBlYXQpOgorCiAyMDEyLTEwLTI2ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBQ cmludGluZyBzaG91bGQgdXNlIHVzZSBoaWdoIHJlc29sdXRpb24gaW1hZ2VzIHdoZW4gYXZhaWxh YmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3Bw CmluZGV4IGY0ZGVmZjU0MDljYjIyY2IxNzVhZWI4N2RjMjA4YjdmZGJjMmFkMmMuLmUyMmM0YjE3 ZjAwZDZkNGRhYTVkZDE0MDM0YjI3YzA4ZWQxNmEyN2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCkBAIC0xMDAzLDggKzEwMDMsNyBAQCBm bG9hdCBTVkdTTUlMRWxlbWVudDo6Y2FsY3VsYXRlQW5pbWF0aW9uUGVyY2VudEFuZFJlcGVhdChT TUlMVGltZSBlbGFwc2VkLCB1bnNpZwogICAgIFNNSUxUaW1lIHJlcGVhdGluZ0R1cmF0aW9uID0g dGhpcy0+cmVwZWF0aW5nRHVyYXRpb24oKTsKICAgICBpZiAoZWxhcHNlZCA+PSBtX2ludGVydmFs RW5kIHx8IGFjdGl2ZVRpbWUgPiByZXBlYXRpbmdEdXJhdGlvbikgewogICAgICAgICByZXBlYXQg PSBzdGF0aWNfY2FzdDx1bnNpZ25lZD4ocmVwZWF0aW5nRHVyYXRpb24udmFsdWUoKSAvIHNpbXBs ZUR1cmF0aW9uLnZhbHVlKCkpOwotICAgICAgICBpZiAoZm1vZChyZXBlYXRpbmdEdXJhdGlvbi52 YWx1ZSgpLCAhc2ltcGxlRHVyYXRpb24udmFsdWUoKSkpCi0gICAgICAgICAgICByZXBlYXQtLTsK KyAgICAgICAgcmVwZWF0LS07CiAKICAgICAgICAgZG91YmxlIHBlcmNlbnQgPSAobV9pbnRlcnZh bEVuZC52YWx1ZSgpIC0gbV9pbnRlcnZhbEJlZ2luLnZhbHVlKCkpIC8gc2ltcGxlRHVyYXRpb24u dmFsdWUoKTsKICAgICAgICAgcGVyY2VudCA9IHBlcmNlbnQgLSBmbG9vcihwZXJjZW50KTsK 171037 2012-10-26 16:05:29 -0700 2012-10-26 18:20:45 -0700 Patch bug-94756-20121026160400.patch text/plain 2181 thakis U3VidmVyc2lvbiBSZXZpc2lvbjogMTMyNjMzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjI1ZGMyN2YzYjg5ODIz ODI5ODRkNDJjYmYwZTA2YjRiMTI3YWFhMi4uZjc5YWE4MGY0ODgxMzM0ZmE2NzExYjIxMjVmNjY3 MmY5ODBhNTFiMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEwLTI2ICBOaWNv IFdlYmVyICA8dGhha2lzQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggYSBvcGVyYXRvciBv cmRlcmluZyBidWcgaW4gU1ZHU01JTEVsZW1lbnQ6OmNhbGN1bGF0ZUFuaW1hdGlvblBlcmNlbnRB bmRSZXBlYXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk0NzU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg VGhlIGZ1bmN0aW9uIGhhcyBhbiBlYXJseSBleGl0IGZvciAhc2ltcGxlRHVyYXRpb24udmFsdWUo KSwgc28KKyAgICAgICAgIXNpbXBsZUR1cmF0aW9uLnZhbHVlKCkgYWx3YXlzIGlzIDAgd2hlbiBw YXNzZWQgYXMgc2Vjb25kIHBhcmFtZXRlciB0bworICAgICAgICBmbW9kKCksIHdoaWNoIG1lYW5z IGZtb2QoKSBhbHdheXMgcmV0dXJucyBOYU4sIHdoaWNoIGFsd2F5cyBldmFsdWF0ZXMKKyAgICAg ICAgdG8gdHJ1ZS4gU2ltcGxpZnkgdGhlIGNvZGUgYnkgcmVtb3ZpbmcgdGhhdCBleHBsaWNpdCBj aGVjay4KKworICAgICAgICBObyBvYnNlcnZhYmxlIGJlaGF2aW9yIGNoYW5nZS4KKworICAgICAg ICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHN2ZyB0ZXN0cy4KKworICAgICAgICAqIHN2Zy9hbmltYXRp b24vU1ZHU01JTEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U1ZHU01JTEVsZW1lbnQ6 OmNhbGN1bGF0ZUFuaW1hdGlvblBlcmNlbnRBbmRSZXBlYXQpOgorCiAyMDEyLTEwLTI2ICBLZW5u ZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBQ cmludGluZyBzaG91bGQgdXNlIHVzZSBoaWdoIHJlc29sdXRpb24gaW1hZ2VzIHdoZW4gYXZhaWxh YmxlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVt ZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3Bw CmluZGV4IGY0ZGVmZjU0MDljYjIyY2IxNzVhZWI4N2RjMjA4YjdmZGJjMmFkMmMuLjg3ODE3M2I5 OWNlNWVlMTBmY2Y1YWU1ODIyNjRmOGYxMGNjMjMwMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwCkBAIC0xMDAyLDkgKzEwMDIsNyBAQCBm bG9hdCBTVkdTTUlMRWxlbWVudDo6Y2FsY3VsYXRlQW5pbWF0aW9uUGVyY2VudEFuZFJlcGVhdChT TUlMVGltZSBlbGFwc2VkLCB1bnNpZwogICAgIFNNSUxUaW1lIGFjdGl2ZVRpbWUgPSBlbGFwc2Vk IC0gbV9pbnRlcnZhbEJlZ2luOwogICAgIFNNSUxUaW1lIHJlcGVhdGluZ0R1cmF0aW9uID0gdGhp cy0+cmVwZWF0aW5nRHVyYXRpb24oKTsKICAgICBpZiAoZWxhcHNlZCA+PSBtX2ludGVydmFsRW5k IHx8IGFjdGl2ZVRpbWUgPiByZXBlYXRpbmdEdXJhdGlvbikgewotICAgICAgICByZXBlYXQgPSBz dGF0aWNfY2FzdDx1bnNpZ25lZD4ocmVwZWF0aW5nRHVyYXRpb24udmFsdWUoKSAvIHNpbXBsZUR1 cmF0aW9uLnZhbHVlKCkpOwotICAgICAgICBpZiAoZm1vZChyZXBlYXRpbmdEdXJhdGlvbi52YWx1 ZSgpLCAhc2ltcGxlRHVyYXRpb24udmFsdWUoKSkpCi0gICAgICAgICAgICByZXBlYXQtLTsKKyAg ICAgICAgcmVwZWF0ID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHJlcGVhdGluZ0R1cmF0aW9uLnZh bHVlKCkgLyBzaW1wbGVEdXJhdGlvbi52YWx1ZSgpKSAtIDE7CiAKICAgICAgICAgZG91YmxlIHBl cmNlbnQgPSAobV9pbnRlcnZhbEVuZC52YWx1ZSgpIC0gbV9pbnRlcnZhbEJlZ2luLnZhbHVlKCkp IC8gc2ltcGxlRHVyYXRpb24udmFsdWUoKTsKICAgICAgICAgcGVyY2VudCA9IHBlcmNlbnQgLSBm bG9vcihwZXJjZW50KTsK