94744 2012-08-22 13:22:23 -0700 [EFL][GTK] Use WTF_USE_SOUP instead BUILDING_SOUP__ 2012-08-23 11:29:02 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jesus jesus cgarcia gustavo gyuyoung.kim lucas.de.marchi mrobinson rakuco tonikitoo webkit.review.bot xan.lopez oldest_to_newest 702259 0 jesus 2012-08-22 13:22:23 -0700 There is still one usage of #if defined(BUILDING_SOUP__) in WebKit2/Shared/API/c/WKBase.h and currently this only defined by the efl port in cmake/OptionsEfl.cmake . I believe #if USE(SOUP) could be used instead. 702273 1 160001 jesus 2012-08-22 13:29:21 -0700 Created attachment 160001 Patch 702318 2 160001 buildbot 2012-08-22 14:02:25 -0700 Comment on attachment 160001 Patch Attachment 160001 did not pass win-ews (win): Output: http://queues.webkit.org/results/13573004 702322 3 160001 webkit-ews 2012-08-22 14:08:19 -0700 Comment on attachment 160001 Patch Attachment 160001 did not pass qt-wk2-ews (qt): Output: http://queues.webkit.org/results/13559432 702333 4 mrobinson 2012-08-22 14:15:39 -0700 Is WebKit2/Shared/API/c/WKBase.h is a public header? If so we probably shouldn't use WTF macros there. 702339 5 160001 gyuyoung.kim 2012-08-22 14:19:13 -0700 Comment on attachment 160001 Patch Attachment 160001 did not pass efl-ews (efl): Output: http://queues.webkit.org/results/13569376 702388 6 160001 buildbot 2012-08-22 14:59:20 -0700 Comment on attachment 160001 Patch Attachment 160001 did not pass mac-ews (mac): Output: http://queues.webkit.org/results/13567394 702518 7 160001 gustavo 2012-08-22 16:46:59 -0700 Comment on attachment 160001 Patch Attachment 160001 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/13565473 702988 8 jesus 2012-08-23 07:57:05 -0700 (In reply to comment #4) > Is WebKit2/Shared/API/c/WKBase.h is a public header? If so we probably shouldn't use WTF macros there. Yep, you are right, we can't use the macros but we can use #if defined(WTF_USE_SOUP) I guess. I've tested it locally and it worked with efl, I'm trying Qt and Gtk now. 703015 9 160169 jesus 2012-08-23 08:27:52 -0700 Created attachment 160169 Patch 703160 10 160169 gustavo 2012-08-23 11:06:21 -0700 Comment on attachment 160169 Patch This looks no worse than what we already have, go ahead =) 703184 11 jesus 2012-08-23 11:28:28 -0700 Committed r126453: <http://trac.webkit.org/changeset/126453> 160001 2012-08-22 13:29:21 -0700 2012-08-23 08:27:46 -0700 Patch bug-94744-20120822172831.patch text/plain 2673 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MzQxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggODZlM2NlMmViNWJmOTdk ZjJmZDI2YmMxOTMxNzNmOWMyNjgwMjA3MS4uNDVhY2I2NzgxYWVkMWYyOGQ2MGM2ZGIxYzgyZmIy ZjU5NWRjYmM3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTIyICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbRUZMXSBVc2UgV1RGX1VTRV9TT1VQIGluc3RlYWQgQlVJTERJTkdfU09VUF9fCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDc0NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSAjaWYgVVNFKFNP VVApIGluc3RlYWQgb2YgI2lmIGRlZmluZWQoQlVJTERJTkdfU09VUF9fKQorICAgICAgICBzaW5j ZSB0aGUgZm9ybWVyIGlzIHVzZWQgZXZlcnl3aGVyZS4KKworICAgICAgICAqIFNoYXJlZC9BUEkv Yy9XS0Jhc2UuaDoKKwogMjAxMi0wOC0yMiAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNv bT4KIAogICAgICAgICBCcm93c2VyIG1lbnUgdmlzaWJsZSB3aGVuIGNhbGxpbmcgd2Via2l0UmVx dWVzdEZ1bGxzY3JlZW4gYWZ0ZXIgdXNlciBtYW51YWxseSBlbnRlcnMgZnVsbCBzY3JlZW4gbW9k ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLQmFzZS5oIGIvU291 cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLQmFzZS5oCmluZGV4IGE2YThiZDY2ZjMyNWM2MmFm YjFjMWFmMzZkNzNiMWRhZDBhYjcxZTEuLjkzNDg1ZTAzZTUwYWZlYjZhYTA1ZDY3NjI1N2RlNWE2 NWEwMjA5NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9XS0Jhc2Uu aAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tCYXNlLmgKQEAgLTM3LDcgKzM3 LDcgQEAKICNpbmNsdWRlIDxXZWJLaXQyL1dLQmFzZUd0ay5oPgogI2VuZGlmCiAKLSNpZiBkZWZp bmVkKEJVSUxESU5HX1NPVVBfXykKKyNpZiBVU0UoU09VUCkKICNpbmNsdWRlIDxXZWJLaXQyL1dL QmFzZVNvdXAuaD4KICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0Vm bC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IDU4MWY0YWI4OWVh ZjMwYmUxODFiZWU5M2E1YzJkMmExOThlMTliMWIuLjI1YmY1OTdkOTNkYmY4NTllMzU4YTU0ZjQ0 NzlmYTZhOTE0NGU1NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtl CisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0zMyw3ICszMyw2IEBAIFNF VChFTkFCTEVfR0xJQl9TVVBQT1JUIE9OKQogCiBTRVQoV1RGX1VTRV9TT1VQIDEpCiBBRERfREVG SU5JVElPTlMoLURXVEZfVVNFX1NPVVA9MSkKLUFERF9ERUZJTklUSU9OUygtREJVSUxESU5HX1NP VVBfXz0xKQogCiBBRERfREVGSU5JVElPTlMoLURFTkFCTEVfQ09OVEVYVF9NRU5VUz0wKQogCmRp ZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMzhkM2JiMmU0MTNmZjdhMmFk NzlhYzQzY2Y4YzdjMmNjYTYyZTc4NC4uMjZlMTgwYjdiN2EwMjFkMDJiNDQwOTc1MjAyOTI0NmI4 YzM4ODkzMiAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE2IEBACisyMDEyLTA4LTIyICBKZXN1cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5j aWFAb3BlbmJvc3NhLm9yZz4KKworICAgICAgICBbRUZMXSBVc2UgV1RGX1VTRV9TT1VQIGluc3Rl YWQgQlVJTERJTkdfU09VUF9fCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NDc0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFRoZXJlIGlzIG5vIG5lZWQgdG8gZGVmaW5lIEJVSUxESU5HX1NPVVBfXyBpZiBv bmx5IFdURl9VU0VfU09VUAorICAgICAgICBpcyB1c2VkLgorCisgICAgICAgICogR05VbWFrZWZp bGUuYW06CisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2U6CisKIDIwMTIt MDgtMjIgIEd1c3Rhdm8gTm9yb25oYSBTaWx2YSAgPGduc0Bnbm9tZS5vcmc+CiAKICAgICAgICAg W0dUS10gU3BsaXQgV2ViQ29yZS9wbGF0Zm9ybSBpbnRvIGEgc2VwYXJhdGUgbGlicmFyeQpkaWZm IC0tZ2l0IGEvR05VbWFrZWZpbGUuYW0gYi9HTlVtYWtlZmlsZS5hbQppbmRleCBmZjc0OGVjOGEy NmFmMDEzNTJkMjlmOWQ1ODEzYjkxZmM3YWM0ZjAzLi41NmFlZWM4NDY1NmUyOTRmZWQ4OGU3NDEz ZDMwNzg3OGE3MTdjY2EzIDEwMDY0NAotLS0gYS9HTlVtYWtlZmlsZS5hbQorKysgYi9HTlVtYWtl ZmlsZS5hbQpAQCAtMTU0LDcgKzE1NCw2IEBAIGVuZGlmCiBnbG9iYWxfY3BwZmxhZ3MgKz0gXAog CS1EQlVJTERJTkdfQ0FJUk9fXz0xIFwKIAktREJVSUxESU5HX0dUS19fPTEgXAotCS1EQlVJTERJ TkdfU09VUF9fPTEgXAogCS1EV1RGX0NIQU5HRVMKIAogaWYgRU5BQkxFX1dFQktJVDIK 160169 2012-08-23 08:27:52 -0700 2012-08-23 11:29:02 -0700 Patch bug-94744-20120823122701.patch text/plain 2654 jesus U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2NDI1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjVmMDA4ZDgwYTVkNDU4 NWY1NTE3NWE4MDc5NTBmY2JiNmEzOTQ1MC4uMGY3ZjhkNTk3OGQwYjEzYjdkNzIzZTM2NDA4M2Fh YmQxMjY3YzJkYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA4LTIyICBKZXN1 cyBTYW5jaGV6LVBhbGVuY2lhICA8amVzdXMucGFsZW5jaWFAb3BlbmJvc3NhLm9yZz4KKworICAg ICAgICBbRUZMXSBVc2UgV1RGX1VTRV9TT1VQIGluc3RlYWQgQlVJTERJTkdfU09VUF9fCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NDc0NAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSAjaWYgZGVmaW5l ZChXVEZfVVNFX1NPVVApIGluc3RlYWQgb2YgI2lmIGRlZmluZWQoQlVJTERJTkdfU09VUF9fKQor ICAgICAgICBzaW5jZSB0aGUgZm9ybWVyIGlzIHVzZWQgZXZlcnl3aGVyZS4KKworICAgICAgICAq IFNoYXJlZC9BUEkvYy9XS0Jhc2UuaDoKKwogMjAxMi0wOC0yMyAgQ2FybG9zIEdhcmNpYSBDYW1w b3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTI2MzA2KTog aXQgYnJva2UgdGhlIHBsdWdpbiBwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9T aGFyZWQvQVBJL2MvV0tCYXNlLmggYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tCYXNl LmgKaW5kZXggYTZhOGJkNjZmMzI1YzYyYWZiMWMxYWYzNmQ3M2IxZGFkMGFiNzFlMS4uMDZhYTI4 NmFiNWVjMzhjZDk0NzUwZjU3OWM0ZDE3OTNlNTQ3Mjc2ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdDIvU2hhcmVkL0FQSS9jL1dLQmFzZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9B UEkvYy9XS0Jhc2UuaApAQCAtMzcsNyArMzcsNyBAQAogI2luY2x1ZGUgPFdlYktpdDIvV0tCYXNl R3RrLmg+CiAjZW5kaWYKIAotI2lmIGRlZmluZWQoQlVJTERJTkdfU09VUF9fKQorI2lmIGRlZmlu ZWQoV1RGX1VTRV9TT1VQKQogI2luY2x1ZGUgPFdlYktpdDIvV0tCYXNlU291cC5oPgogI2VuZGlm CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlIGIvU291cmNlL2Nt YWtlL09wdGlvbnNFZmwuY21ha2UKaW5kZXggNTgxZjRhYjg5ZWFmMzBiZTE4MWJlZTkzYTVjMmQy YTE5OGUxOWIxYi4uMjViZjU5N2Q5M2RiZjg1OWUzNThhNTRmNDQ3OWZhNmE5MTQ0ZTU2OCAxMDA2 NDQKLS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKKysrIGIvU291cmNlL2NtYWtl L09wdGlvbnNFZmwuY21ha2UKQEAgLTMzLDcgKzMzLDYgQEAgU0VUKEVOQUJMRV9HTElCX1NVUFBP UlQgT04pCiAKIFNFVChXVEZfVVNFX1NPVVAgMSkKIEFERF9ERUZJTklUSU9OUygtRFdURl9VU0Vf U09VUD0xKQotQUREX0RFRklOSVRJT05TKC1EQlVJTERJTkdfU09VUF9fPTEpCiAKIEFERF9ERUZJ TklUSU9OUygtREVOQUJMRV9DT05URVhUX01FTlVTPTApCiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxv ZyBiL0NoYW5nZUxvZwppbmRleCA5ZjA0Zjg3OTFkZWVmOGQwZDZhYWIwNjI5MzVmM2U4YmRkYzQ0 YTI0Li4wNTdmYjExYzBkNDA4Njk2ZGM3NzcxY2U5ZjU1NjY1NWRhMWYzYmE3IDEwMDY0NAotLS0g YS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMDgtMjIg IEplc3VzIFNhbmNoZXotUGFsZW5jaWEgIDxqZXN1cy5wYWxlbmNpYUBvcGVuYm9zc2Eub3JnPgor CisgICAgICAgIFtFRkxdIFVzZSBXVEZfVVNFX1NPVVAgaW5zdGVhZCBCVUlMRElOR19TT1VQX18K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NzQ0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMg bm8gbmVlZCB0byBkZWZpbmUgQlVJTERJTkdfU09VUF9fIGlmIG9ubHkgV1RGX1VTRV9TT1VQCisg ICAgICAgIGlzIHVzZWQuCisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKyAgICAgICAgKiBT b3VyY2UvY21ha2UvT3B0aW9uc0VmbC5jbWFrZToKKwogMjAxMi0wOC0yMyAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTI2 MzA2KTogaXQgYnJva2UgdGhlIHBsdWdpbiBwcm9jZXNzCmRpZmYgLS1naXQgYS9HTlVtYWtlZmls ZS5hbSBiL0dOVW1ha2VmaWxlLmFtCmluZGV4IDhlZWI5ZmZlOTkyNDBkZGQ4YmQ2MzAzODc1YWRm MzhkNTA1NjJlNTguLmZjNWNhMDk5NGY0ODE4MGQ2OGIzOTBiMWE2YTBhNTczN2QxNzlkZWEgMTAw NjQ0Ci0tLSBhL0dOVW1ha2VmaWxlLmFtCisrKyBiL0dOVW1ha2VmaWxlLmFtCkBAIC0xNTIsNyAr MTUyLDYgQEAgZW5kaWYKIGdsb2JhbF9jcHBmbGFncyArPSBcCiAJLURCVUlMRElOR19DQUlST19f PTEgXAogCS1EQlVJTERJTkdfR1RLX189MSBcCi0JLURCVUlMRElOR19TT1VQX189MSBcCiAJLURX VEZfQ0hBTkdFUwogCiBpZiBFTkFCTEVfV0VCS0lUMgo=