<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>94742</bug_id>
          
          <creation_ts>2012-08-22 12:20:57 -0700</creation_ts>
          <short_desc>Don&apos;t unconditionally define NOMINMAX on Windows</short_desc>
          <delta_ts>2012-08-22 14:55:08 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Scott Graham">scottmg</reporter>
          <assigned_to name="Scott Graham">scottmg</assigned_to>
          <cc>enne</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>702180</commentid>
    <comment_count>0</comment_count>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-08-22 12:20:57 -0700</bug_when>
    <thetext>Don&apos;t unconditionally define NOMINMAX on Windows</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702183</commentid>
    <comment_count>1</comment_count>
      <attachid>159988</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-08-22 12:22:12 -0700</bug_when>
    <thetext>Created attachment 159988
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702186</commentid>
    <comment_count>2</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-22 12:24:44 -0700</bug_when>
    <thetext>Attachment 159988 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Tools/ChangeLog&apos;, u&apos;Tools/TestWebKitAPI/co...&quot; exit_code: 1
Tools/TestWebKitAPI/config.h:46:  #ifndef header guard has wrong style, please use: config_h  [build/header_guard] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702189</commentid>
    <comment_count>3</comment_count>
      <attachid>159988</attachid>
    <who name="Adrienne Walker">enne</who>
    <bug_when>2012-08-22 12:25:47 -0700</bug_when>
    <thetext>Comment on attachment 159988
Patch

R=me.  Silly style bot.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702258</commentid>
    <comment_count>4</comment_count>
      <attachid>159988</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-22 13:21:50 -0700</bug_when>
    <thetext>Comment on attachment 159988
Patch

Rejecting attachment 159988 from commit-queue.

Failed to run &quot;[&apos;/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch&apos;, &apos;--status-host=queues.webkit.org&apos;, &apos;-...&quot; exit_code: 2

Last 500 characters of output:
ource/WebCore/ChangeLog
CONFLICT (content): Merge conflict in Source/WebCore/ChangeLog
Failed to merge in the changes.
Patch failed at 0001 Skipping css3/flexbox/flexitem.html.

When you have resolved this problem run &quot;git rebase --continue&quot;.
If you would prefer to skip this patch, instead run &quot;git rebase --skip&quot;.
To restore the original branch and stop rebasing run &quot;git rebase --abort&quot;.

rebase refs/remotes/origin/master: command returned error: 1

Died at Tools/Scripts/update-webkit line 164.

Full output: http://queues.webkit.org/results/13560388</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702285</commentid>
    <comment_count>5</comment_count>
      <attachid>160002</attachid>
    <who name="Scott Graham">scottmg</who>
    <bug_when>2012-08-22 13:41:59 -0700</bug_when>
    <thetext>Created attachment 160002
rebase</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702288</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-22 13:44:20 -0700</bug_when>
    <thetext>Attachment 160002 did not pass style-queue:

Failed to run &quot;[&apos;Tools/Scripts/check-webkit-style&apos;, &apos;--diff-files&apos;, u&apos;Tools/ChangeLog&apos;, u&apos;Tools/TestWebKitAPI/co...&quot; exit_code: 1
Tools/TestWebKitAPI/config.h:46:  #ifndef header guard has wrong style, please use: config_h  [build/header_guard] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702384</commentid>
    <comment_count>7</comment_count>
      <attachid>160002</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-22 14:55:05 -0700</bug_when>
    <thetext>Comment on attachment 160002
rebase

Clearing flags on attachment: 160002

Committed r126356: &lt;http://trac.webkit.org/changeset/126356&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>702385</commentid>
    <comment_count>8</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-22 14:55:08 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>159988</attachid>
            <date>2012-08-22 12:22:12 -0700</date>
            <delta_ts>2012-08-22 13:41:57 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-94742-20120822122210.patch</filename>
            <type>text/plain</type>
            <size>1071</size>
            <attacher name="Scott Graham">scottmg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MzI3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZWM4MTQ0ZWFmODAzZjBjMWZjNTYyMWIzYWYxMDc5MmY1
MzJiNmZjNS4uNjAwZTk5Y2MwOTU0ZWFkMDNjMDk0ZGIxMTk1ODYwYWE2NGQ0YThhMCAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDEyLTA4LTIyICBTY290dCBHcmFoYW0gIDxzY290dG1nQGNocm9taXVtLm9yZz4KKwor
ICAgICAgICBEb24ndCB1bmNvbmRpdGlvbmFsbHkgZGVmaW5lIE5PTUlOTUFYIG9uIFdpbmRvd3MK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NzQyCisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWRzIGEg
d2FybmluZyB3aGVuIGJ1aWxkaW5nIG9uIFdpbmRvd3Mgd2hlbiBOT01JTk1BWCBpcyBkZWZpbmVk
CisgICAgICAgIGVsc2V3aGVyZSBvciBvbiB0aGUgY29tbWFuZCBsaW5lLgorCisgICAgICAgICog
VGVzdFdlYktpdEFQSS9jb25maWcuaDoKKwogMjAxMi0wOC0yMiAgQWxleGV5IFByb3NrdXJ5YWtv
diAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXSBTdXBwb3J0IHBvc3RpbmcgaW5qZWN0
ZWQgYnVuZGxlIG1lc3NhZ2VzIHRvIGEgcGFnZQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVzdFdlYktp
dEFQSS9jb25maWcuaCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvY29uZmlnLmgKaW5kZXggOTdiYjk1
OGVmODE3OTFkMzk3NjcxZDk2MDdlYzNhYjRlNzhhMDMxNC4uZTc5NmViYzk4NDMzZWNjYzBjZDBk
MWNlNWI2ZTk4YTE3ZWMwZDE2ZiAxMDA2NDQKLS0tIGEvVG9vbHMvVGVzdFdlYktpdEFQSS9jb25m
aWcuaAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL2NvbmZpZy5oCkBAIC00Myw3ICs0Myw5IEBA
CiAKICNlbGlmIGRlZmluZWQoV0lOMzIpIHx8IGRlZmluZWQoX1dJTjMyKQogCisjaWZuZGVmIE5P
TUlOTUFYCiAjZGVmaW5lIE5PTUlOTUFYCisjZW5kaWYKIAogI2VuZGlmCiAK
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>160002</attachid>
            <date>2012-08-22 13:41:59 -0700</date>
            <delta_ts>2012-08-22 14:55:05 -0700</delta_ts>
            <desc>rebase</desc>
            <filename>bug-94742-20120822134157.patch</filename>
            <type>text/plain</type>
            <size>1081</size>
            <attacher name="Scott Graham">scottmg</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2MzQ0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTU5N2JhOWY3YTI0MjRmOWZiM2VhMDQwNjBiOTk0MGM2
MTZjYzE4NC4uMWMxMzVmY2IxZWRhNzZmYmMwMjUxODBmOWY1NzU0OThmMjFjNDc1MyAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1
IEBACisyMDEyLTA4LTIyICBTY290dCBHcmFoYW0gIDxzY290dG1nQGNocm9taXVtLm9yZz4KKwor
ICAgICAgICBEb24ndCB1bmNvbmRpdGlvbmFsbHkgZGVmaW5lIE5PTUlOTUFYIG9uIFdpbmRvd3MK
KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NzQyCisK
KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQXZvaWRzIGEg
d2FybmluZyB3aGVuIGJ1aWxkaW5nIG9uIFdpbmRvd3Mgd2hlbiBOT01JTk1BWCBpcyBkZWZpbmVk
CisgICAgICAgIGVsc2V3aGVyZSBvciBvbiB0aGUgY29tbWFuZCBsaW5lLgorCisgICAgICAgICog
VGVzdFdlYktpdEFQSS9jb25maWcuaDoKKwogMjAxMi0wOC0yMiAgVG9tbXkgV2lkZW5mbHljaHQg
IDx0b21teXdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBbY2hyb21pdW1dIE1lZGlhU3RyZWFtIEFQ
STogQWRkIE1vY2tXZWJSVENQZWVyQ29ubmVjdGlvbkhhbmRsZXIKZGlmZiAtLWdpdCBhL1Rvb2xz
L1Rlc3RXZWJLaXRBUEkvY29uZmlnLmggYi9Ub29scy9UZXN0V2ViS2l0QVBJL2NvbmZpZy5oCmlu
ZGV4IDk3YmI5NThlZjgxNzkxZDM5NzY3MWQ5NjA3ZWMzYWI0ZTc4YTAzMTQuLmU3OTZlYmM5ODQz
M2VjY2MwY2QwZDFjZTViNmU5OGExN2VjMGQxNmYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJL
aXRBUEkvY29uZmlnLmgKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9jb25maWcuaApAQCAtNDMs
NyArNDMsOSBAQAogCiAjZWxpZiBkZWZpbmVkKFdJTjMyKSB8fCBkZWZpbmVkKF9XSU4zMikKIAor
I2lmbmRlZiBOT01JTk1BWAogI2RlZmluZSBOT01JTk1BWAorI2VuZGlmCiAKICNlbmRpZgogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>