94715 2012-08-22 08:34:31 -0700 [V8] Remove V8Proxy from getXPathNSResolver() 2012-08-22 18:12:34 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 85330 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 701947 0 haraken 2012-08-22 08:34:31 -0700 - The V8Proxy* argument of getXPathNSResolver(..., V8Proxy* = 0) is not used. We can remove it. - We can rename getXPathNSResolver() to toXPathNSResolver(). - We can move toXPathNSResolver() from V8DOMWrapper to V8Binding, since other toXXX() methods are written in V8Binding. 701956 1 159947 haraken 2012-08-22 08:38:39 -0700 Created attachment 159947 Patch 702201 2 159947 abarth 2012-08-22 12:30:34 -0700 Comment on attachment 159947 Patch It seems odd that XPathNSResolver needs this special-case code. How do we do this in the general case? 702563 3 haraken 2012-08-22 17:43:42 -0700 (In reply to comment #2) > (From update of attachment 159947 [details]) > It seems odd that XPathNSResolver needs this special-case code. How do we do this in the general case? Generated code by default: if (V8XPathNSResolver::HasInstance(value)) return V8XPathNSResolver::toNative(value) return 0; What XPathNSResolver expects: if (V8XPathNSResolver::HasInstance(value)) return V8XPathNSResolver::toNative(value); else if (value->IsObject()) return V8CustomXPathNSResolver::create(value->ToObject()); return 0; It looks like that XPathNSResolver wants to fall back to V8CustomXPathNSResolver. (I don't know why though.) 702594 4 159947 webkit.review.bot 2012-08-22 18:12:31 -0700 Comment on attachment 159947 Patch Clearing flags on attachment: 159947 Committed r126375: <http://trac.webkit.org/changeset/126375> 702595 5 webkit.review.bot 2012-08-22 18:12:34 -0700 All reviewed patches have been landed. Closing bug. 159947 2012-08-22 08:38:39 -0700 2012-08-22 18:12:31 -0700 Patch bug-94715-20120823003837.patch text/plain 6772 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Mjk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDk5MmU0N2FlZjJlNTQ3 NmM2YTRlMTY3OWZkMGMzZGYwYTE0ODE1Zi4uYzFmZjAxZWY3MmU2MjFjZDZmYzNiMjg5MGQyZGUz YjgxOTU3OTdmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM1IEBACisyMDEyLTA4LTIyICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBW OFByb3h5IGZyb20gZ2V0WFBhdGhOU1Jlc29sdmVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NzE1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgLSBUaGUgVjhQcm94eSogYXJndW1lbnQgb2YgZ2V0WFBh dGhOU1Jlc29sdmVyKC4uLiwgVjhQcm94eSogPSAwKSBpcyBub3QgdXNlZC4KKyAgICAgICAgICBX ZSBjYW4gcmVtb3ZlIGl0LgorCisgICAgICAgIC0gV2UgY2FuIHJlbmFtZSBnZXRYUGF0aE5TUmVz b2x2ZXIoKSB0byB0b1hQYXRoTlNSZXNvbHZlcigpLgorCisgICAgICAgIC0gV2UgY2FuIG1vdmUg dG9YUGF0aE5TUmVzb2x2ZXIoKSBmcm9tIFY4RE9NV3JhcHBlciB0byBWOEJpbmRpbmcsCisgICAg ICAgICAgc2luY2Ugb3RoZXIgdG9YWFgoKSBtZXRob2RzIGFyZSB3cml0dGVuIGluIFY4QmluZGlu Zy4KKworICAgICAgICAtIENoYW5nZSB0aGUgcmV0dXJuIHZhbHVlIG9mIHRvWFBhdGhOU1Jlc29s dmVyKCkgZnJvbSBSZWZQdHIgdG8gUGFzc1JlZlB0ci4KKworICAgICAgICBObyB0ZXN0cy4gTm8g Y2hhbmdlIGluIGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG06CisgICAgICAgIChKU1ZhbHVlVG9OYXRpdmUpOgorICAgICAgICAqIGJpbmRp bmdzL3Y4L1Y4QmluZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjp0b1hQYXRoTlNSZXNvbHZl cik6CisgICAgICAgIChXZWJDb3JlKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOEJpbmRpbmcu aDoKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBl ci5jcHA6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmg6CisgICAgICAgIChW OERPTVdyYXBwZXIpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOERvY3VtZW50Q3Vz dG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RG9jdW1lbnQ6OmV2YWx1YXRlQ2FsbGJhY2sp OgorCiAyMDEyLTA4LTIyICBLd2FuZ1lvbmcgQ2hvaSAgPGt5MC5jaG9pQHNhbXN1bmcuY29tPgog CiAgICAgICAgIFtFRkxdIFN1cHBvcnQgc2xpZGVyIHRpY2sgbWFyayBzbmFwcGluZwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0g Yi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRl eCAzMDBhMzY1YmUzN2ZjY2EzMjA1ZjQyMDEwOTZhMDU2YjE1MDFjZTQ0Li5lMTNlMWI4MDZhMzg2 ZThjYzliMzJkYmFmYjBhYTI2NzMxZDNkNmYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMzgxNSw3ICszODE1LDcgQEAg c3ViIEpTVmFsdWVUb05hdGl2ZQogICAgIH0KIAogICAgIGlmICgkdHlwZSBlcSAiWFBhdGhOU1Jl c29sdmVyIikgewotICAgICAgICByZXR1cm4gIlY4RE9NV3JhcHBlcjo6Z2V0WFBhdGhOU1Jlc29s dmVyKCR2YWx1ZSkiOworICAgICAgICByZXR1cm4gInRvWFBhdGhOU1Jlc29sdmVyKCR2YWx1ZSki OwogICAgIH0KIAogICAgIG15ICRhcnJheVR5cGUgPSAkY29kZUdlbmVyYXRvci0+R2V0QXJyYXlU eXBlKCR0eXBlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Qmlu ZGluZy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEJpbmRpbmcuY3BwCmluZGV4 IDgzZjEyNmNiOWNiZTJkZmI4ODAyMDExYzJjNWRlZjdhNGYzYzM4MWQuLjkxNWFiNzEyYmIxZmUw NjEwMDBjMGJmNTAzNWI4OTJhZDFjNzQ2N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4QmluZGluZy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhCaW5kaW5nLmNwcApAQCAtNDMsOCArNDMsMTAgQEAKICNpbmNsdWRlICJWOERPTVdpbmRvdy5o IgogI2luY2x1ZGUgIlY4RWxlbWVudC5oIgogI2luY2x1ZGUgIlY4T2JqZWN0Q29uc3RydWN0b3Iu aCIKKyNpbmNsdWRlICJWOFhQYXRoTlNSZXNvbHZlci5oIgogI2luY2x1ZGUgIldvcmtlckNvbnRl eHQuaCIKICNpbmNsdWRlICJXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHkuaCIKKyNpbmNsdWRl ICJYUGF0aE5TUmVzb2x2ZXIuaCIKIAogI2luY2x1ZGUgPHd0Zi9NYXRoRXh0cmFzLmg+CiAjaW5j bHVkZSA8d3RmL01haW5UaHJlYWQuaD4KQEAgLTI0MCw2ICsyNDIsMTYgQEAgUGFzc1JlZlB0cjxE T01TdHJpbmdMaXN0PiB0b0RPTVN0cmluZ0xpc3Qodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVl KQogICAgIHJldHVybiByZXQucmVsZWFzZSgpOwogfQogCitQYXNzUmVmUHRyPFhQYXRoTlNSZXNv bHZlcj4gdG9YUGF0aE5TUmVzb2x2ZXIodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlKQorewor ICAgIFJlZlB0cjxYUGF0aE5TUmVzb2x2ZXI+IHJlc29sdmVyOworICAgIGlmIChWOFhQYXRoTlNS ZXNvbHZlcjo6SGFzSW5zdGFuY2UodmFsdWUpKQorICAgICAgICByZXNvbHZlciA9IFY4WFBhdGhO U1Jlc29sdmVyOjp0b05hdGl2ZSh2ODo6SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KHZhbHVlKSk7 CisgICAgZWxzZSBpZiAodmFsdWUtPklzT2JqZWN0KCkpCisgICAgICAgIHJlc29sdmVyID0gVjhD dXN0b21YUGF0aE5TUmVzb2x2ZXI6OmNyZWF0ZSh2YWx1ZS0+VG9PYmplY3QoKSk7CisgICAgcmV0 dXJuIHJlc29sdmVyOworfQorCiBET01XaW5kb3cqIHRvRE9NV2luZG93KHY4OjpIYW5kbGU8djg6 OkNvbnRleHQ+IGNvbnRleHQpCiB7CiAgICAgdjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBnbG9iYWwg PSBjb250ZXh0LT5HbG9iYWwoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4QmluZGluZy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgK aW5kZXggNWJiNGMwMTU0YzM4ZDE2ZTZlNzE3M2M3MDMyMWEzMzY2MjA4M2NjNy4uYjY0YjMzZDlh MDcyZjQxMTdlZTRhYjMyODE3OTUyY2ZjNmQ5OTkxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhCaW5kaW5nLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv djgvVjhCaW5kaW5nLmgKQEAgLTM0OCw2ICszNDgsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgdjg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uVGVtcGxhdGU+IGNyZWF0ZVJhd1RlbXBsYXRl KCk7CiAKICAgICBQYXNzUmVmUHRyPERPTVN0cmluZ0xpc3Q+IHRvRE9NU3RyaW5nTGlzdCh2ODo6 SGFuZGxlPHY4OjpWYWx1ZT4pOworICAgIFBhc3NSZWZQdHI8WFBhdGhOU1Jlc29sdmVyPiB0b1hQ YXRoTlNSZXNvbHZlcih2ODo6SGFuZGxlPHY4OjpWYWx1ZT4pOwogCiAgICAgLy8gUmV0dXJucyB0 aGUgd2luZG93IG9iamVjdCBhc3NvY2lhdGVkIHdpdGggYSBjb250ZXh0LgogICAgIERPTVdpbmRv dyogdG9ET01XaW5kb3codjg6OkhhbmRsZTx2ODo6Q29udGV4dD4pOwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKaW5kZXggMzFmZjMxZGEzZDA4MjhhMjZhOTRj N2RkOGEyNmUzZDdhZTMxYzBmNC4uYjRiYzU3OGFjNDI2OGJhOTAxY2UxMGRhODhkZWEzMTEyNmRi ODMxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCkBA IC01NSwxMiArNTUsMTAgQEAKICNpbmNsdWRlICJWOFByb3h5LmgiCiAjaW5jbHVkZSAiVjhTdHls ZVNoZWV0LmgiCiAjaW5jbHVkZSAiVjhXb3JrZXJDb250ZXh0RXZlbnRMaXN0ZW5lci5oIgotI2lu Y2x1ZGUgIlY4WFBhdGhOU1Jlc29sdmVyLmgiCiAjaW5jbHVkZSAiV2ViR0xDb250ZXh0QXR0cmli dXRlcy5oIgogI2luY2x1ZGUgIldlYkdMVW5pZm9ybUxvY2F0aW9uLmgiCiAjaW5jbHVkZSAiV29y a2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmgiCiAjaW5jbHVkZSAiV3JhcHBlclR5cGVJbmZvLmgi Ci0jaW5jbHVkZSAiWFBhdGhOU1Jlc29sdmVyLmgiCiAjaW5jbHVkZSA8YWxnb3JpdGhtPgogI2lu Y2x1ZGUgPHV0aWxpdHk+CiAjaW5jbHVkZSA8djgtZGVidWcuaD4KQEAgLTI5MywxNiArMjkxLDQg QEAgUGFzc1JlZlB0cjxFdmVudExpc3RlbmVyPiBWOERPTVdyYXBwZXI6OmdldEV2ZW50TGlzdGVu ZXIodjg6OkxvY2FsPHY4OjpWYWx1ZT4gdmEKICNlbmRpZgogfQogCi0vLyBYUGF0aC1yZWxhdGVk IHV0aWxpdGllcwotUmVmUHRyPFhQYXRoTlNSZXNvbHZlcj4gVjhET01XcmFwcGVyOjpnZXRYUGF0 aE5TUmVzb2x2ZXIodjg6OkhhbmRsZTx2ODo6VmFsdWU+IHZhbHVlLCBWOFByb3h5KiBwcm94eSkK LXsKLSAgICBSZWZQdHI8WFBhdGhOU1Jlc29sdmVyPiByZXNvbHZlcjsKLSAgICBpZiAoVjhYUGF0 aE5TUmVzb2x2ZXI6Okhhc0luc3RhbmNlKHZhbHVlKSkKLSAgICAgICAgcmVzb2x2ZXIgPSBWOFhQ YXRoTlNSZXNvbHZlcjo6dG9OYXRpdmUodjg6OkhhbmRsZTx2ODo6T2JqZWN0Pjo6Q2FzdCh2YWx1 ZSkpOwotICAgIGVsc2UgaWYgKHZhbHVlLT5Jc09iamVjdCgpKQotICAgICAgICByZXNvbHZlciA9 IFY4Q3VzdG9tWFBhdGhOU1Jlc29sdmVyOjpjcmVhdGUodmFsdWUtPlRvT2JqZWN0KCkpOwotICAg IHJldHVybiByZXNvbHZlcjsKLX0KLQotCiB9ICAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmggYi9Tb3VyY2Uv V2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaAppbmRleCBkOWU4MDU5ZTQyMGM2ZjNh YTg1ZjI2MDk5MzFjM2YyYTA2ZWM3ZGFjLi5lYzgzYmNjMmQ3Njg0MmQ3OTc1OWRiNjkwMDlkNzY5 MDBlNDg2YzFhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdy YXBwZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaApA QCAtOTMsOSArOTMsNiBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgc3RhdGljIFBh c3NSZWZQdHI8RXZlbnRMaXN0ZW5lcj4gZ2V0RXZlbnRMaXN0ZW5lcih2ODo6TG9jYWw8djg6OlZh bHVlPiB2YWx1ZSwgYm9vbCBpc0F0dHJpYnV0ZSwgTGlzdGVuZXJMb29rdXBUeXBlIGxvb2t1cCk7 CiAKLSAgICAgICAgLy8gWFBhdGgtcmVsYXRlZCB1dGlsaXRpZXMKLSAgICAgICAgc3RhdGljIFJl ZlB0cjxYUGF0aE5TUmVzb2x2ZXI+IGdldFhQYXRoTlNSZXNvbHZlcih2ODo6SGFuZGxlPHY4OjpW YWx1ZT4gdmFsdWUsIFY4UHJveHkqIHByb3h5ID0gMCk7Ci0KICAgICAgICAgLy8gV3JhcCBKUyBu b2RlIGZpbHRlciBpbiBDKysuCiAgICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPE5vZGVGaWx0ZXI+ IHdyYXBOYXRpdmVOb2RlRmlsdGVyKHY4OjpIYW5kbGU8djg6OlZhbHVlPik7CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERvY3VtZW50Q3VzdG9tLmNw cCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOERvY3VtZW50Q3VzdG9tLmNw cAppbmRleCBjZTcyYjYwMmFmYjZiODFiYjgzOTQyNzQzOWNmYjg4NjU2YjVmMWQwLi5mZDM4MzMy OTQ1NDBkN2MwYjZmYjM3MDhlMmM3OTExMmI1Y2I1ODYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhEb2N1bWVudEN1c3RvbS5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4RG9jdW1lbnRDdXN0b20uY3BwCkBAIC03Niw3 ICs3Niw3IEBAIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOERvY3VtZW50OjpldmFsdWF0ZUNhbGxi YWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCiAgICAgaWYgKFY4Tm9kZTo6SGFzSW5zdGFu Y2UoYXJnc1sxXSkpCiAgICAgICAgIGNvbnRleHROb2RlID0gVjhOb2RlOjp0b05hdGl2ZSh2ODo6 SGFuZGxlPHY4OjpPYmplY3Q+OjpDYXN0KGFyZ3NbMV0pKTsKIAotICAgIFJlZlB0cjxYUGF0aE5T UmVzb2x2ZXI+IHJlc29sdmVyID0gVjhET01XcmFwcGVyOjpnZXRYUGF0aE5TUmVzb2x2ZXIoYXJn c1syXSk7CisgICAgUmVmUHRyPFhQYXRoTlNSZXNvbHZlcj4gcmVzb2x2ZXIgPSB0b1hQYXRoTlNS ZXNvbHZlcihhcmdzWzJdKTsKICAgICBpZiAoIXJlc29sdmVyICYmICFhcmdzWzJdLT5Jc051bGwo KSAmJiAhYXJnc1syXS0+SXNVbmRlZmluZWQoKSkKICAgICAgICAgcmV0dXJuIHNldERPTUV4Y2Vw dGlvbihUWVBFX01JU01BVENIX0VSUiwgYXJncy5HZXRJc29sYXRlKCkpOwogCg==