94704 2012-08-22 06:36:09 -0700 REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance 2012-08-22 14:42:19 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zan zan abarth beidson dpranke eric ojan simon.fraser thorton webkit.review.bot oldest_to_newest 701850 0 zan 2012-08-22 06:36:09 -0700 REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance 701851 1 159923 zan 2012-08-22 06:37:06 -0700 Created attachment 159923 Patch 701853 2 zan 2012-08-22 06:38:25 -0700 Perhaps a reincarnation of bug #92847, this caused some tests to pop up as passing. Too bad. 701998 3 dpranke 2012-08-22 09:19:12 -0700 Oh, that's my fault. Will look into it in a bit ... 702264 4 eric 2012-08-22 13:24:49 -0700 How do we test this so it doesn't happen again? 702287 5 dpranke 2012-08-22 13:44:14 -0700 Actually, to clarify ... this is not a regression of bug #92847. This was caused by the fix I landed for bug 94540 (r126189). At some point, we stopped calling diff_image() for reftests and were just comparing checksums. This seemed to be bad (at least for the Apple Mac port) and so I added the diff_image as a sanity check. It wasn't clear to me at the time (and still isn't) whether we should use the default tolerance for the port, or use 0 (and thus ref tests and pixel tests would potentially be compared with different tolerances). I can see arguments for either way, and perhaps this should be a separate default setting. In the absence of agreeing over what we want to do here, it's not obvious what the test should be testing ;). That said, I'll R+ this as I *think* the Apple Mac port doesn't actually need fuzzy diffs and so this shouldn't break things. I guess we can find out. 702289 6 159923 dpranke 2012-08-22 13:44:46 -0700 Comment on attachment 159923 Patch Also, we should add some sort of a test for this (per eric's comment), but I don't want to hold up this fix for that. I'll file a separate bug. 702365 7 159923 webkit.review.bot 2012-08-22 14:42:15 -0700 Comment on attachment 159923 Patch Clearing flags on attachment: 159923 Committed r126353: <http://trac.webkit.org/changeset/126353> 702366 8 webkit.review.bot 2012-08-22 14:42:19 -0700 All reviewed patches have been landed. Closing bug. 159923 2012-08-22 06:37:06 -0700 2012-08-22 14:42:15 -0700 Patch bug-94704-20120822063704.patch text/plain 2442 zan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Mjg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGJhNTY0NWNmMzQxMTBjYWE0OTAyNGM3MWFhMDMxZmYx YWIyZmViZC4uMTNhNTE3OGEzNjg4ZDMwYzZiNjc0YTA4ZmE4ODU3NGY0ZmM5ODlmOCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA4LTIyICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMTI2MTg5KTogUmVmdGVzdCBtaXNtYXRjaGVzIGFyZSAoYWdh aW4pIHJ1biB0aHJvdWdoIEltYWdlRGlmZiB3aXRoIDAuMSB0b2xlcmFuY2UKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NzA0CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXNlIHRvbGVyYW5jZT0wIHdoZW4g YWNxdWlyaW5nIGRpZmYgaW1hZ2Ugb2YgcmVmdGVzdCBvdXRwdXQuCisKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIu cHk6CisgICAgICAgIChTaW5nbGVUZXN0UnVubmVyLl9jb21wYXJlX291dHB1dF93aXRoX3JlZmVy ZW5jZSk6CisKIDIwMTItMDgtMjIgIERvbWluaWsgUsO2dHRzY2hlcyAgPGRvbWluaWsucm90dHNj aGVzQGludGVsLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBhZGRpbmcgbXlzZWxmIHRvIGNv bW1pdHRlcnMucHkuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90 ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHkgYi9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9zaW5nbGVfdGVzdF9ydW5uZXIucHkKaW5k ZXggYWUzNDcwYTVkYWI3Y2YzYjExNWQ0YTlkNDA1YzY1ZjZiNWU5OWJhZi4uZWRhYzhlYmIzMjgy NjRhOTMxNDE1YTJiZjlmZjdjNDZkZWJhNDI4ZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvc2luZ2xlX3Rlc3RfcnVubmVyLnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL3Npbmds ZV90ZXN0X3J1bm5lci5weQpAQCAtMzIxLDE0ICszMjEsMTQgQEAgY2xhc3MgU2luZ2xlVGVzdFJ1 bm5lcihvYmplY3QpOgogICAgICAgICAgICAgZmFpbHVyZXMuYXBwZW5kKHRlc3RfZmFpbHVyZXMu RmFpbHVyZVJlZnRlc3ROb0ltYWdlc0dlbmVyYXRlZChyZWZlcmVuY2VfZmlsZW5hbWUpKQogICAg ICAgICBlbGlmIG1pc21hdGNoOgogICAgICAgICAgICAgaWYgcmVmZXJlbmNlX2RyaXZlcl9vdXRw dXQuaW1hZ2VfaGFzaCA9PSBhY3R1YWxfZHJpdmVyX291dHB1dC5pbWFnZV9oYXNoOgotICAgICAg ICAgICAgICAgIGRpZmZfcmVzdWx0ID0gc2VsZi5fcG9ydC5kaWZmX2ltYWdlKHJlZmVyZW5jZV9k cml2ZXJfb3V0cHV0LmltYWdlLCBhY3R1YWxfZHJpdmVyX291dHB1dC5pbWFnZSkKKyAgICAgICAg ICAgICAgICBkaWZmX3Jlc3VsdCA9IHNlbGYuX3BvcnQuZGlmZl9pbWFnZShyZWZlcmVuY2VfZHJp dmVyX291dHB1dC5pbWFnZSwgYWN0dWFsX2RyaXZlcl9vdXRwdXQuaW1hZ2UsIHRvbGVyYW5jZT0w KQogICAgICAgICAgICAgICAgIGlmIG5vdCBkaWZmX3Jlc3VsdFswXToKICAgICAgICAgICAgICAg ICAgICAgZmFpbHVyZXMuYXBwZW5kKHRlc3RfZmFpbHVyZXMuRmFpbHVyZVJlZnRlc3RNaXNtYXRj aERpZE5vdE9jY3VyKHJlZmVyZW5jZV9maWxlbmFtZSkpCiAgICAgICAgICAgICAgICAgZWxzZToK ICAgICAgICAgICAgICAgICAgICAgX2xvZy53YXJuaW5nKCIgICVzIC0+IHJlZiB0ZXN0IGhhc2hl cyBtYXRjaGVkIGJ1dCBkaWZmIGZhaWxlZCIgJSBzZWxmLl90ZXN0X25hbWUpCiAKICAgICAgICAg ZWxpZiByZWZlcmVuY2VfZHJpdmVyX291dHB1dC5pbWFnZV9oYXNoICE9IGFjdHVhbF9kcml2ZXJf b3V0cHV0LmltYWdlX2hhc2g6Ci0gICAgICAgICAgICBkaWZmX3Jlc3VsdCA9IHNlbGYuX3BvcnQu ZGlmZl9pbWFnZShyZWZlcmVuY2VfZHJpdmVyX291dHB1dC5pbWFnZSwgYWN0dWFsX2RyaXZlcl9v dXRwdXQuaW1hZ2UpCisgICAgICAgICAgICBkaWZmX3Jlc3VsdCA9IHNlbGYuX3BvcnQuZGlmZl9p bWFnZShyZWZlcmVuY2VfZHJpdmVyX291dHB1dC5pbWFnZSwgYWN0dWFsX2RyaXZlcl9vdXRwdXQu aW1hZ2UsIHRvbGVyYW5jZT0wKQogICAgICAgICAgICAgaWYgZGlmZl9yZXN1bHRbMF06CiAgICAg ICAgICAgICAgICAgZmFpbHVyZXMuYXBwZW5kKHRlc3RfZmFpbHVyZXMuRmFpbHVyZVJlZnRlc3RN aXNtYXRjaChyZWZlcmVuY2VfZmlsZW5hbWUpKQogICAgICAgICAgICAgZWxzZToK