<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>94700</bug_id>
          
          <creation_ts>2012-08-22 06:29:49 -0700</creation_ts>
          <short_desc>webkit-patch gets stuck into an infinite loop if bugzilla doesn&apos;t respond in time.</short_desc>
          <delta_ts>2012-08-28 11:36:22 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Szilard Ledan">szledan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>eric</cc>
    
    <cc>galpeter</cc>
    
    <cc>kadam</cc>
    
    <cc>kkristof</cc>
    
    <cc>ojan</cc>
    
    <cc>ossy</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>701841</commentid>
    <comment_count>0</comment_count>
    <who name="Szilard Ledan">szledan</who>
    <bug_when>2012-08-22 06:29:49 -0700</bug_when>
    <thetext>webkit-patch gets stuck into an infinite loop if bugzilla dosen&apos;t respond in time.
Interrupting download with a timeout would be a possible solution.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>701845</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-08-22 06:31:58 -0700</bug_when>
    <thetext>Fixing it is important, because I have to restart EWS bots 
regularly because of this bug. It would be better if EWS
can handle this situation automatically.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706394</commentid>
    <comment_count>2</comment_count>
      <attachid>160994</attachid>
    <who name="Szilard Ledan">szledan</who>
    <bug_when>2012-08-28 08:51:46 -0700</bug_when>
    <thetext>Created attachment 160994
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706404</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2012-08-28 08:58:11 -0700</bug_when>
    <thetext>Thanks for working on this bug!  Eric, would you be willing to review this patch?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706528</commentid>
    <comment_count>4</comment_count>
      <attachid>160994</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2012-08-28 11:06:29 -0700</bug_when>
    <thetext>Comment on attachment 160994
patch

SGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706570</commentid>
    <comment_count>5</comment_count>
      <attachid>160994</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-28 11:36:18 -0700</bug_when>
    <thetext>Comment on attachment 160994
patch

Clearing flags on attachment: 160994

Committed r126905: &lt;http://trac.webkit.org/changeset/126905&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>706571</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-08-28 11:36:22 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>160994</attachid>
            <date>2012-08-28 08:51:46 -0700</date>
            <delta_ts>2012-08-28 11:36:18 -0700</delta_ts>
            <desc>patch</desc>
            <filename>120828-webkit-patch</filename>
            <type>text/plain</type>
            <size>2049</size>
            <attacher name="Szilard Ledan">szledan</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA4MWIw
YTNkLi41YmVjOTZkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh
bmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTItMDgtMjggIFN6aWxhcmQgTGVkYW4gIDxzemxl
ZGFuQGluZi51LXN6ZWdlZC5odT4KKworICAgICAgICBbd2Via2l0LXBhdGNoXSBnZXRzIHN0dWNr
IGludG8gYW4gaW5maW5pdGUgbG9vcCBpZiBidWd6aWxsYSBkb2Vzbid0IHJlc3BvbmQgaW4gdGlt
ZS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk0NzAw
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW50ZXJy
dXB0aW5nIGRvd25sb2FkIHdpdGggYSB0aW1lb3V0IHdvdWxkIGJlIGEgcG9zc2libGUgc29sdXRp
b24uCisgICAgICAgIEkgaW1wb3J0ZWQgdGhlIHNvY2tldCBtb2R1bGUgYW5kIHVzZWQgdGhlIHNl
dGRlZmF1bHR0aW1lb3V0KCkgbWV0aG9kLgorICAgICAgICBGaXhpbmcgaXQgaXMgaW1wb3J0YW50
LCBiZWNhdXNlIEVXUyBib3RzIG5lZWQgdG8gYmUgcmVzdGFydGVkIHJlZ3VsYXJseQorICAgICAg
ICBiZWNhdXNlIG9mIHRoaXMgYnVnLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21t
b24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5OgorICAgICAgICAoQnVnemlsbGEuX2dldF9icm93
c2VyKToKKyAgICAgICAgKEJ1Z3ppbGxhLnNldGRlZmF1bHR0aW1lb3V0KToKKwogMjAxMi0wOC0y
NyAgR2F2aW4gUGV0ZXJzICA8Z2F2aW5wQGNocm9taXVtLm9yZz4KIAogICAgICAgICBbd2Via2l0
LXBhdGNoXSBEb24ndCBjcmFzaCBjaHJvbWUtY2hhbm5lbHMgY29tbWFuZCB3aGVuIGEgcHJldmlv
dXNseSB1bmtub3duIHBsYXRmb3JtIHNob3dzIHVwLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0
cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5IGIvVG9vbHMvU2NyaXB0
cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CmluZGV4IGVlY2FkZjIu
LjY1MWUxYjMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9i
dWd6aWxsYS9idWd6aWxsYS5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9u
ZXQvYnVnemlsbGEvYnVnemlsbGEucHkKQEAgLTMzLDYgKzMzLDcgQEAKIGltcG9ydCBtaW1ldHlw
ZXMKIGltcG9ydCByZQogaW1wb3J0IFN0cmluZ0lPCitpbXBvcnQgc29ja2V0CiBpbXBvcnQgdXJs
bGliCiAKIGZyb20gZGF0ZXRpbWUgaW1wb3J0IGRhdGV0aW1lICMgdXNlZCBpbiB0aW1lc3RhbXAo
KQpAQCAtMjc5LDYgKzI4MCw3IEBAIGNsYXNzIEJ1Z3ppbGxhKG9iamVjdCk6CiAKICAgICBkZWYg
X2dldF9icm93c2VyKHNlbGYpOgogICAgICAgICBpZiBub3Qgc2VsZi5fYnJvd3NlcjoKKyAgICAg
ICAgICAgIHNlbGYuc2V0ZGVmYXVsdHRpbWVvdXQoNjAwKQogICAgICAgICAgICAgZnJvbSB3ZWJr
aXRweS50aGlyZHBhcnR5LmF1dG9pbnN0YWxsZWQubWVjaGFuaXplIGltcG9ydCBCcm93c2VyCiAg
ICAgICAgICAgICBzZWxmLl9icm93c2VyID0gQnJvd3NlcigpCiAgICAgICAgICAgICAjIElnbm9y
ZSBidWdzLndlYmtpdC5vcmcvcm9ib3RzLnR4dCB1bnRpbCB3ZSBmaXggaXQgdG8gYWxsb3cgdGhp
cyBzY3JpcHQuCkBAIC0yOTAsNiArMjkyLDkgQEAgY2xhc3MgQnVnemlsbGEob2JqZWN0KToKIAog
ICAgIGJyb3dzZXIgPSBwcm9wZXJ0eShfZ2V0X2Jyb3dzZXIsIF9zZXRfYnJvd3NlcikKIAorICAg
IGRlZiBzZXRkZWZhdWx0dGltZW91dChzZWxmLCB2YWx1ZSk6CisgICAgICAgIHNvY2tldC5zZXRk
ZWZhdWx0dGltZW91dCh2YWx1ZSkKKwogICAgIGRlZiBmZXRjaF91c2VyKHNlbGYsIHVzZXJfaWQp
OgogICAgICAgICBzZWxmLmF1dGhlbnRpY2F0ZSgpCiAgICAgICAgIGVkaXRfdXNlcl9wYWdlID0g
c2VsZi5icm93c2VyLm9wZW4oc2VsZi5lZGl0X3VzZXJfdXJsX2Zvcl9pZCh1c2VyX2lkKSkK
</data>

          </attachment>
      

    </bug>

</bugzilla>