94692 2012-08-22 04:50:02 -0700 [Qt][WK2] Enable runtime enabled features: DeviceMotion and DeviceOrientation 2012-08-22 06:21:39 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P2 Normal --- 1 ossy ossy cmarcelo hausmann kbalazs menard ossy webkit.review.bot zoltan oldest_to_newest 701773 0 ossy 2012-08-22 04:50:02 -0700 After https://trac.webkit.org/changeset/126057/trunk/Source/WebCore/page/DOMWindow.cpp the following tests started to fail: (because DeviceMotion and DeviceOrientation runtime enabled features are disabled on Qt WK2 and it wasn't checked before.) - fast/dom/DeviceMotion/no-page-cache.html - fast/dom/DeviceOrientation/no-page-cache.html I tried to enable them and then these tests pass. Now there are 4-4 non-skipped DeviceMotion and DeviceOrientation tests on Qt-WK2 and all of them pass. 701795 1 159909 ossy 2012-08-22 05:27:03 -0700 Created attachment 159909 Patch 701796 2 ossy 2012-08-22 05:27:36 -0700 They were disabled by https://trac.webkit.org/changeset/73876 (two years before) because of crashes. But now they work fine. 701816 3 hausmann 2012-08-22 06:06:21 -0700 Awesome, thanks Ossy! :) 701832 4 159909 webkit.review.bot 2012-08-22 06:21:36 -0700 Comment on attachment 159909 Patch Clearing flags on attachment: 159909 Committed r126296: <http://trac.webkit.org/changeset/126296> 701833 5 webkit.review.bot 2012-08-22 06:21:39 -0700 All reviewed patches have been landed. Closing bug. 159909 2012-08-22 05:27:03 -0700 2012-08-22 06:21:36 -0700 Patch bug-94692-20120822052701.patch text/plain 1518 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTI2Mjg5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZDE0N2EwNDYxMGU3N2M2 MzFhZmJjMTUyODhjNDJmNDAwZjNlM2M3ZS4uODU3MzMzYjFmYjJmY2NlMjNiYTcwNDE2ZDcwOThk MzE5NTU3YWU2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEyLTA4LTIyICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgW1F0XVtXSzJdIEVu YWJsZSBydW50aW1lIGVuYWJsZWQgZmVhdHVyZXM6IERldmljZU1vdGlvbiBhbmQgRGV2aWNlT3Jp ZW50YXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk0NjkyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NRdC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBy b2Nlc3M6OnBsYXRmb3JtSW5pdGlhbGl6ZVdlYlByb2Nlc3MpOgorCiAyMDEyLTA4LTIyICBMdWl6 IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBBdm9p ZCB1c2luZyBXZWJLaXQgbWFjcm9zIGluIHFyYXd3ZWJ2aWV3X3AuaApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9xdC9XZWJQcm9jZXNzUXQuY3BwCmluZGV4IDI2OGM0YjA5MzRlMjM4ZjEw NDAwNTEzYTQxNTgzZjU3M2QwZmRjNDMuLjAyYTkwZWM0M2MzYTY1ZWIyYjQ0MGY5YzAzMzVjZTgy MzNlNjNiZmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvcXQvV2ViUHJv Y2Vzc1F0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL3F0L1dlYlByb2Nlc3NR dC5jcHAKQEAgLTE2MCwxMSArMTYwLDYgQEAgdm9pZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRp YWxpemVXZWJQcm9jZXNzKGNvbnN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMKICAgICB9 CiAjZW5kaWYKIAotICAgIC8vIERpc2FibGUgcnVudGltZSBlbmFibGVkIGZlYXR1cmVzIHRoYXQg aGF2ZSBubyBXZWJLaXQyIGltcGxlbWVudGF0aW9uIHlldC4KLSNpZiBFTkFCTEUoREVWSUNFX09S SUVOVEFUSU9OKQotICAgIFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNldERldmlj ZU1vdGlvbkVuYWJsZWQoZmFsc2UpOwotICAgIFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVy ZXM6OnNldERldmljZU9yaWVudGF0aW9uRW5hYmxlZChmYWxzZSk7Ci0jZW5kaWYKICNpZiBFTkFC TEUoU1BFRUNIX0lOUFVUKQogICAgIFdlYkNvcmU6OlJ1bnRpbWVFbmFibGVkRmVhdHVyZXM6OnNl dFNwZWVjaElucHV0RW5hYmxlZChmYWxzZSk7CiAjZW5kaWYK